233837 2021-12-03 12:49:48 -0800 [ANGLE] clang with -Wunknown-warning-option will fail on -Wweak-template-vtables 2021-12-15 10:09:17 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 220896 1 dino dino dino ews-watchlist graouts kbr kkinnunen kondapallykalyan kpiddington mjs webkit-bug-importer oldest_to_newest 1820274 0 dino 2021-12-03 12:49:48 -0800 [ANGLE] clang with -Wunknown-warning-option will fail on -Wweak-template-vtables 1820277 1 445891 dino 2021-12-03 12:52:45 -0800 Created attachment 445891 Patch 1820278 2 ews-watchlist 2021-12-03 12:53:44 -0800 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1820279 3 445891 kbr 2021-12-03 12:56:51 -0800 Comment on attachment 445891 Patch Looks fine, though please keep in mind this will collide with the big ANGLE upgrade Kyle's in the middle of in Bug 220896. Unless this is really pressing it might be better to wait for that to complete, but not sure how many blockers there are on that. r+ 1820281 4 dino 2021-12-03 13:00:15 -0800 Agreed. This can wait until Kyle's roll lands, and maybe even come in the next roll if we can fix it upstream. 1821228 5 kbr 2021-12-07 14:52:37 -0800 Kyle's mega-roll landed in Bug 220896 - would it be feasible to upload this patch to ANGLE's code review tool instead, and pick it up by rolling forward ANGLE again? 1822905 6 webkit-bug-importer 2021-12-10 12:50:19 -0800 <rdar://problem/86335819> 1824076 7 mjs 2021-12-14 12:27:20 -0800 This is breaking a build internally so I'm not sure it can wait? 1824189 8 kbr 2021-12-14 17:27:16 -0800 Landing this now would be fine if it can't quickly/easily be uploaded to ANGLE's issue tracker. Kyle's landing a follow-on roll right now in Bug 234317 - but it doesn't include this fix. 1824388 9 dino 2021-12-15 09:32:43 -0800 An update on this. It seems I can't use __has_warning everywhere, so I'll try to add a new CFLAG for -Wno-unknown-warning-option 1824408 10 447250 dino 2021-12-15 10:05:30 -0800 Created attachment 447250 Patch 1824414 11 dino 2021-12-15 10:09:17 -0800 Committed r287082 (245277@trunk): <https://commits.webkit.org/245277@trunk> 445891 2021-12-03 12:52:45 -0800 2021-12-15 10:05:26 -0800 Patch bug-233837-20211204075244.patch text/plain 1836 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NDQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggOGU2YTU4NjVkNmMxMTcwYWRiNGJjM2RkMmY1ZTM1NTEzNmI0MWI4MS4uNzkzNjkxMTUwNTcx NjI3N2FlYmIyYWM5ZTMwNGE1Mjk5ZGZjNWQ1NSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTEyLTAzICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxl LmNvbT4KKworICAgICAgICBbQU5HTEVdIGNsYW5nIHdpdGggLVd1bmtub3duLXdhcm5pbmctb3B0 aW9uIHdpbGwgZmFpbCBvbiAtV3dlYWstdGVtcGxhdGUtdnRhYmxlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzODM3CisgICAgICAgIHJkYXI6Ly84 NTM3OTI5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5ld2VyIHZlcnNpb25zIG9mIGNsYW5nIGNhbiBmYWlsIGlmIC1XdW5rbm93bi13YXJuaW5nLW9w dGlvbiBpcyBzZXQgd2hpbGUgdHJ5aW5nCisgICAgICAgIHRvIHVzZSAtV3dlYWstdGVtcGxhdGUt dnRhYmxlcy4gQWRkIGEgZ3VhcmQgZm9yIHRoZSBsYXR0ZXIgYmVmb3JlIHRyeWluZyB0bworICAg ICAgICBkaXNhYmxlIGl0LiAoWWVzLCB0aGlzIGlzIGFuIGVycm9yIHNheWluZyBpdCBkb2Vzbid0 IHVuZGVyc3RhbmQgdGhlIHR5cGUgb2YKKyAgICAgICAgd2FybmluZyB0aGF0IHlvdSdyZSB0cnlp bmcgdG8gZGlzYWJsZSwgd2hpY2ggcHJvYmFibHkgd2Fzbid0IGVuYWJsZWQgaW4gdGhlIGZpcnN0 CisgICAgICAgIHBsYWNlIHNpbmNlIGl0IGlzbid0IHVuZGVyc3Rvb2QpCisKKyAgICAgICAgKiBz cmMvY29tbW9uL2RlYnVnLmg6CisKIDIwMjEtMTEtMzAgIEt5bGUgUGlkZGluZ3RvbiAgPGtwaWRk aW5ndG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBIYXJkd2FyZSBQQ0YgZmlsdGVyaW5nIGRvZXMg bm90IHdvcmsgb24gaU9TIDE1IHdoZW4gdXNpbmcgV2ViR0wyCmRpZmYgLS1naXQgYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tbW9uL2RlYnVnLmggYi9Tb3VyY2UvVGhpcmRQYXJ0eS9B TkdMRS9zcmMvY29tbW9uL2RlYnVnLmgKaW5kZXggZTAwMzdhNGUyY2I4NmI4NTczMzdiNzVhZjNl ZGY3ZTdlNDczZTYzMi4uZmExMzE0MmRjMWMxZjk2MjgxZDA5OGYzNDRhZTE4Y2MwOTg0Zjk5MCAx MDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbW1vbi9kZWJ1Zy5oCisr KyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21tb24vZGVidWcuaApAQCAtNDM1LDcg KzQzNSw3IEBAIHN0ZDo6b3N0cmVhbSAmRm10SGV4KHN0ZDo6b3N0cmVhbSAmb3MsIFQgdmFsdWUp CiAjICAgIGRlZmluZSBBTkdMRV9SRUVOQUJMRV9ERVNUUlVDVE9SX09WRVJSSURFX1dBUk5JTkcK ICNlbmRpZgogCi0jaWYgZGVmaW5lZChfX2NsYW5nX18pCisjaWYgZGVmaW5lZChfX2NsYW5nX18p ICYmIF9faGFzX3dhcm5pbmcoIi1Xd2Vhay10ZW1wbGF0ZS12dGFibGVzIikKICMgICAgZGVmaW5l IEFOR0xFX0RJU0FCTEVfV0VBS19URU1QTEFURV9WVEFCTEVTX1dBUk5JTkcgXAogICAgICAgICBf UHJhZ21hKCJjbGFuZyBkaWFnbm9zdGljIHB1c2giKSAgICAgICAgICAgICAgICBcCiAgICAgICAg ICAgICBfUHJhZ21hKCJjbGFuZyBkaWFnbm9zdGljIGlnbm9yZWQgXCItV3dlYWstdGVtcGxhdGUt dnRhYmxlc1wiIikK 447250 2021-12-15 10:05:30 -0800 2021-12-15 10:06:09 -0800 Patch bug-233837-20211216050529.patch text/plain 1648 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNmY3ZTdiOWI1ZmMxNTQwMDUzODA1NGYwMWIxODRiYjYzM2NjZjJhYi4uMmQ5YmIzNjE3ZWM0 ODRhZDhhMTQxZTE1MTVlNzUwMWY2MzMyZjg2NCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEyLTE1ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxl LmNvbT4KKworICAgICAgICBbQU5HTEVdIGNsYW5nIHdpdGggLVd1bmtub3duLXdhcm5pbmctb3B0 aW9uIHdpbGwgZmFpbCBvbiAtV3dlYWstdGVtcGxhdGUtdnRhYmxlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzODM3CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS84NjMzNTgxOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUdXJuIG9mZiB1bmtub3duLXdhcm5pbmctb3B0aW9uIG9uIEFwcGxlIGJ1aWxk cy4gVGhpcyBzaG91bGRuJ3QgbmVlZCB0byBiZQorICAgICAgICB1cHN0cmVhbWVkIC0gdGhlIFhj b2RlIGNvbmZpZ3VyYXRpb25zIGZvciBBTkdMRSBhcmUgc3BlY2lmaWMgdG8gV2ViS2l0LgorCisg ICAgICAgICogQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZzoKKwogMjAyMS0xMi0xNSAgQ2hy aXMgTG9yZCAgPGNsb3JkQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gVXNlIGxpYmdibSBh bmQgdGhlIEFOR0xFIGdibSBiYWNrZW5kIHRvIGZpeCBpbml0aWFsaXNhdGlvbgpkaWZmIC0tZ2l0 IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZyBi L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKaW5k ZXggMTFkMWIxNTVlOTUwMGYwMWIzYjEzZGUxODM0Zjc4YmM4ZDQyZmIyNS4uMDExN2EyY2E4ZWQ0 NjA0MDhmZTNkZmE5ODdjN2NmODQ2NjQ1MWEzYiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZworKysgYi9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCkBAIC02MSw3ICs2MSw3IEBA IEdDQ19XQVJOX1VOVVNFRF9WQVJJQUJMRSA9IFlFUzsKIAogUFJFQklORElORyA9IE5POwogCi1X QVJOSU5HX0NGTEFHUyA9IC1XZm9ybWF0PTIgLVdnbG9iYWwtY29uc3RydWN0b3JzIC1Xbm8taW5j b25zaXN0ZW50LW1pc3Npbmctb3ZlcnJpZGU7CitXQVJOSU5HX0NGTEFHUyA9IC1XZm9ybWF0PTIg LVdnbG9iYWwtY29uc3RydWN0b3JzIC1Xbm8taW5jb25zaXN0ZW50LW1pc3Npbmctb3ZlcnJpZGUg LVduby11bmtub3duLXdhcm5pbmctb3B0aW9uOwogCiBTVVBQT1JURURfUExBVEZPUk1TID0gaXBo b25lb3MgaXBob25lc2ltdWxhdG9yIG1hY29zeCBhcHBsZXR2b3MgYXBwbGV0dnNpbXVsYXRvciB3 YXRjaG9zIHdhdGNoc2ltdWxhdG9yOwogU1VQUE9SVFNfTUFDQ0FUQUxZU1QgPSBZRVM7Cg==