233832 2021-12-03 11:27:38 -0800 Make WebLockRegistryProxy::processDidExit() return early if process never registered any locks 2021-12-07 12:12:48 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 232436 1 cdumez cdumez achristensen darin ggaren kkinnunen sam webkit-bug-importer youennf oldest_to_newest 1820242 0 cdumez 2021-12-03 11:27:38 -0800 Make WebLockRegistryProxy::processDidExit() return early if process never registered any locks. This avoids calling LocalWebLockRegistry::clientsAreGoingAway() (which can be expensive) in the case we know for sure no locks were registered by this process. 1820243 1 445882 cdumez 2021-12-03 11:28:52 -0800 Created attachment 445882 Patch 1820244 2 achristensen 2021-12-03 11:32:08 -0800 Wouldn't m_perOriginRegistries be empty? I'm not convinced this does anything. 1820245 3 cdumez 2021-12-03 11:33:35 -0800 (In reply to Alex Christensen from comment #2) > Wouldn't m_perOriginRegistries be empty? I'm not convinced this does > anything. Huh? The LocalWebLockRegistry is on the WebsiteDataStore and is thus potentially shared by many WebProcesses. Each WebProcessProxy has its own WebLockRegistryProxy though so I believe this is useful. 1821120 4 cdumez 2021-12-07 11:19:22 -0800 Ping review? 1821157 5 ews-feeder 2021-12-07 12:11:15 -0800 Committed r286604 (244929@trunk): <https://commits.webkit.org/244929@trunk> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445882. 1821160 6 webkit-bug-importer 2021-12-07 12:12:48 -0800 <rdar://problem/86169856> 445882 2021-12-03 11:28:52 -0800 2021-12-07 12:11:17 -0800 Patch bug-233832-20211203112851.patch text/plain 3030 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNmNmMyZmIyZjg5MWU4NmRl MjFlNGMyNGFkZTk3MGMzNjUyMGMyNmYuLjJhY2VkNmYzNTUxY2E4ZDVmZTFiNmY4OTI0NDE0NjVj MzU4MGM3ZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMTItMDMgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFdlYkxvY2tSZWdpc3RyeVBy b3h5Ojpwcm9jZXNzRGlkRXhpdCgpIHJldHVybiBlYXJseSBpZiBwcm9jZXNzIG5ldmVyIHJlZ2lz dGVyZWQgYW55IGxvY2tzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzM4MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBNYWtlIFdlYkxvY2tSZWdpc3RyeVByb3h5Ojpwcm9jZXNzRGlkRXhpdCgpIHJldHVy biBlYXJseSBpZiBwcm9jZXNzIG5ldmVyIHJlZ2lzdGVyZWQgYW55IGxvY2tzLgorICAgICAgICBU aGlzIGF2b2lkcyBjYWxsaW5nIExvY2FsV2ViTG9ja1JlZ2lzdHJ5OjpjbGllbnRzQXJlR29pbmdB d2F5KCkgKHdoaWNoIGNhbiBiZSBleHBlbnNpdmUpIGluIHRoZQorICAgICAgICBjYXNlIHdlIGtu b3cgZm9yIHN1cmUgbm8gbG9ja3Mgd2VyZSByZWdpc3RlcmVkIGJ5IHRoaXMgcHJvY2Vzcy4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9XZWJMb2NrUmVnaXN0cnlQcm94eS5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYkxvY2tSZWdpc3RyeVByb3h5OjpyZXF1ZXN0TG9jayk6CisgICAgICAgIChXZWJL aXQ6OldlYkxvY2tSZWdpc3RyeVByb3h5Ojpwcm9jZXNzRGlkRXhpdCk6CisgICAgICAgICogVUlQ cm9jZXNzL1dlYkxvY2tSZWdpc3RyeVByb3h5Lmg6CisKIDIwMjEtMTItMDMgIFdlbnNvbiBIc2ll aCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgWyBNb250ZXJleSB3azIgXSBo dHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXdlYm0tc3RhbGwuaHRtbCAobGF5b3V0LXRlc3QpIGlzIGEg Y29uc3RhbnQgdGV4dCBmYWlsdXJlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9XZWJMb2NrUmVnaXN0cnlQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJM b2NrUmVnaXN0cnlQcm94eS5jcHAKaW5kZXggNjU1NWJmN2NhOTUxN2NkMjMxNjlkNzExMTFhYmVk MWU2N2E5MzRiZS4uZGU4NzkwZWMxZjIwMGRmNTE0YjY0ZDU0NTkyNTY0OGUzMTgyMmMyNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViTG9ja1JlZ2lzdHJ5UHJveHkuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkxvY2tSZWdpc3RyeVByb3h5LmNwcApA QCAtNTMsNiArNTMsNyBAQCB2b2lkIFdlYkxvY2tSZWdpc3RyeVByb3h5OjpyZXF1ZXN0TG9jayhX ZWJDb3JlOjpDbGllbnRPcmlnaW4mJiBjbGllbnRPcmlnaW4sIFdlYgogewogICAgIE1FU1NBR0Vf Q0hFQ0sobG9ja0lkZW50aWZpZXIucHJvY2Vzc0lkZW50aWZpZXIoKSA9PSBtX3Byb2Nlc3MuY29y ZVByb2Nlc3NJZGVudGlmaWVyKCkpOwogICAgIE1FU1NBR0VfQ0hFQ0soY2xpZW50SUQucHJvY2Vz c0lkZW50aWZpZXIoKSA9PSBtX3Byb2Nlc3MuY29yZVByb2Nlc3NJZGVudGlmaWVyKCkpOworICAg IG1faGFzRXZlclJlcXVlc3RlZExvY2tzID0gdHJ1ZTsKIAogICAgIG1fcHJvY2Vzcy53ZWJzaXRl RGF0YVN0b3JlKCkud2ViTG9ja1JlZ2lzdHJ5KCkucmVxdWVzdExvY2soV1RGTW92ZShjbGllbnRP cmlnaW4pLCBsb2NrSWRlbnRpZmllciwgY2xpZW50SUQsIFdURk1vdmUobmFtZSksIGxvY2tNb2Rl LCBzdGVhbCwgaWZBdmFpbGFibGUsIFt3ZWFrVGhpcyA9IFdlYWtQdHIgeyAqdGhpcyB9LCBsb2Nr SWRlbnRpZmllciwgY2xpZW50SURdKGJvb2wgc3VjY2VzcykgewogICAgICAgICBpZiAod2Vha1Ro aXMpCkBAIC05MCw3ICs5MSw4IEBAIHZvaWQgV2ViTG9ja1JlZ2lzdHJ5UHJveHk6OmNsaWVudElz R29pbmdBd2F5KFdlYkNvcmU6OkNsaWVudE9yaWdpbiYmIGNsaWVudE9yaWdpCiAKIHZvaWQgV2Vi TG9ja1JlZ2lzdHJ5UHJveHk6OnByb2Nlc3NEaWRFeGl0KCkKIHsKLSAgICBtX3Byb2Nlc3Mud2Vi c2l0ZURhdGFTdG9yZSgpLndlYkxvY2tSZWdpc3RyeSgpLmNsaWVudHNBcmVHb2luZ0F3YXkobV9w cm9jZXNzLmNvcmVQcm9jZXNzSWRlbnRpZmllcigpKTsKKyAgICBpZiAobV9oYXNFdmVyUmVxdWVz dGVkTG9ja3MpCisgICAgICAgIG1fcHJvY2Vzcy53ZWJzaXRlRGF0YVN0b3JlKCkud2ViTG9ja1Jl Z2lzdHJ5KCkuY2xpZW50c0FyZUdvaW5nQXdheShtX3Byb2Nlc3MuY29yZVByb2Nlc3NJZGVudGlm aWVyKCkpOwogfQogCiAjdW5kZWYgTUVTU0FHRV9DSEVDSwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2ViTG9ja1JlZ2lzdHJ5UHJveHkuaCBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYkxvY2tSZWdpc3RyeVByb3h5LmgKaW5kZXggMGJhMzFhOWI5MmI3MTYxYzdjYWQ2 MDJiZmJhMWI4MzY5OTczMzI3Yy4uOGFhZjM5ZWIzMjhmNzZjM2M0MGY3ZWI1M2QzNDZiMGUwZGMy NGU4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViTG9ja1JlZ2lzdHJ5 UHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJMb2NrUmVnaXN0cnlQcm94 eS5oCkBAIC01Nyw2ICs1Nyw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBjbGllbnRJc0dvaW5nQXdh eShXZWJDb3JlOjpDbGllbnRPcmlnaW4mJiwgV2ViQ29yZTo6U2NyaXB0RXhlY3V0aW9uQ29udGV4 dElkZW50aWZpZXIpOwogCiAgICAgV2ViUHJvY2Vzc1Byb3h5JiBtX3Byb2Nlc3M7CisgICAgYm9v bCBtX2hhc0V2ZXJSZXF1ZXN0ZWRMb2NrcyB7IGZhbHNlIH07CiB9OwogCiB9IC8vIG5hbWVzcGFj ZSBXZWJLaXQK