<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>233821</bug_id>
          
          <creation_ts>2021-12-03 09:37:12 -0800</creation_ts>
          <short_desc>[libpas] make build.sh, test.sh, build_and_test.sh, and clean.sh work on Linux</short_desc>
          <delta_ts>2021-12-14 01:03:12 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>bmalloc</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Zan Dobersek">zan</assigned_to>
          <cc>ggaren</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1820181</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2021-12-03 09:37:12 -0800</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1820489</commentid>
    <comment_count>1</comment_count>
      <attachid>445984</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2021-12-05 01:37:47 -0800</bug_when>
    <thetext>Created attachment 445984
WIP patch

This integrates CMake invocation into the build.sh script. The patch just needs some minor refinements before it&apos;s reviewable. Test invocation works fine as it&apos;s currently done.

This covers invoking the build. There&apos;s still different build problems like missing includes or Darwin-specific code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1820549</commentid>
    <comment_count>2</comment_count>
      <attachid>446008</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2021-12-06 00:37:41 -0800</bug_when>
    <thetext>Created attachment 446008
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1820867</commentid>
    <comment_count>3</comment_count>
      <attachid>446008</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2021-12-06 19:36:39 -0800</bug_when>
    <thetext>Comment on attachment 446008
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446008&amp;action=review

Thank you for doing this!  I just think that build_variant, in its current form, would break us.

&gt; Source/bmalloc/libpas/build.sh:98
&gt; +    case $sdk in
&gt; +        macosx.internal)
&gt; +            build_variant_xcodebuild $@
&gt; +            ;;
&gt; +    esac

This isn&apos;t adequate for us - we can have $sdk be:

- macosx
- macosx.internal
- iphoneos
- iphoneos.internal
- maybe other things too, but definitely not Linux ;-)

Also, the build_variant_linux seems like it would probably work on other non-Xcode systems, so &quot;Linux&quot; might be a bad name.

What if you set $sdk to &quot;cmake&quot; instead of &quot;linux&quot; and this was just &quot;case $sdk in cmake) build_variant_cmake ;; *) build_variant_xcodebuild esac&quot; or something like that?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1820902</commentid>
    <comment_count>4</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2021-12-06 22:48:36 -0800</bug_when>
    <thetext>I see. &quot;cmake&quot; as an SDK makes sense, and other variants can default to build_variant_xcodebuild.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1820908</commentid>
    <comment_count>5</comment_count>
      <attachid>446128</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2021-12-06 23:24:03 -0800</bug_when>
    <thetext>Created attachment 446128
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1822765</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-12-10 09:38:20 -0800</bug_when>
    <thetext>&lt;rdar://problem/86325940&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1823397</commentid>
    <comment_count>7</comment_count>
      <attachid>446128</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-12-12 23:11:43 -0800</bug_when>
    <thetext>Comment on attachment 446128
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1823400</commentid>
    <comment_count>8</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-12-12 23:17:13 -0800</bug_when>
    <thetext>Committed r286934 (245160@main): &lt;https://commits.webkit.org/245160@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446128.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1823928</commentid>
    <comment_count>9</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-12-14 01:03:12 -0800</bug_when>
    <thetext>Committed r287016 (245221@trunk): &lt;https://commits.webkit.org/245221@trunk&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>445984</attachid>
            <date>2021-12-05 01:37:47 -0800</date>
            <delta_ts>2021-12-06 00:37:33 -0800</delta_ts>
            <desc>WIP patch</desc>
            <filename>libpas_build.patch</filename>
            <type>text/plain</type>
            <size>2158</size>
            <attacher name="Zan Dobersek">zan</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9idWlsZC5zaCBiL1NvdXJjZS9ibWFs
bG9jL2xpYnBhcy9idWlsZC5zaAppbmRleCA2OGJkNjUwY2Y0NmMuLmE5MTVkZTMwZTI2NCAxMDA3
NTUKLS0tIGEvU291cmNlL2JtYWxsb2MvbGlicGFzL2J1aWxkLnNoCisrKyBiL1NvdXJjZS9ibWFs
bG9jL2xpYnBhcy9idWlsZC5zaApAQCAtMjQsMTAgKzI0LDEwIEBACiAKIC4gY29tbW9uLnNoCiAK
LWZ1bmN0aW9uIGJ1aWxkX3ZhcmlhbnQgeworZnVuY3Rpb24gYnVpbGRfdmFyaWFudF94Y29kZWJ1
aWxkIHsKICAgICB2YXJpYW50PSQxCi0gICAgZXh0cmFfeGNvZGVidWlsZF9vcHRpb25zPSIkMiIK
LSAgICB0YXJnZXQ9JDMKKyAgICB0YXJnZXQ9JDIKKyAgICBleHRyYV94Y29kZWJ1aWxkX29wdGlv
bnM9IkVYVFJBX0RFRklORVM9JDMiCiAgICAgCiAgICAgYnVpbGRfZGlyPWJ1aWxkLSRzZGstJHZh
cmlhbnQKICAgICBta2RpciAtcCAkYnVpbGRfZGlyCkBAIC02MCwxNyArNjAsNjYgQEAgZnVuY3Rp
b24gYnVpbGRfdmFyaWFudCB7CiAgICAgZXNhYwogfQogCitmdW5jdGlvbiBidWlsZF92YXJpYW50
X2xpbnV4IHsKKyAgICB2YXJpYW50PSQxCisgICAgdGFyZ2V0PSQyCisgICAgZXh0cmFfb3B0aW9u
cz0kMworCisgICAgYnVpbGRfZGlyPWJ1aWxkLSRzZGstJHZhcmlhbnQvJGNvbmZpZ2RpcgorICAg
IG1rZGlyIC1wICRidWlsZF9kaXIKKworICAgIGNhc2UgJGNvbmZpZyBpbgorICAgICAgICBSZWxl
YXNlKQorICAgICAgICAgICAgOzsKKyAgICAgICAgRGVidWcpCisgICAgICAgICAgICA7OworICAg
ICAgICAqKQorICAgICAgICAgICAgZWNobyAiQmFkIHZhbHVlIG9mIGNvbmZpZyIKKyAgICAgICAg
ICAgIGV4aXQgMQorICAgIGVzYWMKKworICAgIGV4dHJhX2NtYWtlX2NfZmxhZ3M9IiIKKyAgICBl
eHRyYV9jbWFrZV9jeHhfZmxhZ3M9IiIKKyAgICBpZiBbICJ4JGV4dHJhX29wdGlvbnMiICE9ICJ4
IiBdCisgICAgdGhlbgorICAgICAgICBvcHRpb25zX2xpc3Q9IiIKKyAgICAgICAgZm9yIG9wdGlv
biBpbiAkZXh0cmFfb3B0aW9uczsgZG8KKyAgICAgICAgICAgIG9wdGlvbnNfbGlzdD0iJHtvcHRp
b25zX2xpc3R9IC1EJHtvcHRpb259IgorICAgICAgICBkb25lCisgICAgICAgIGVjaG8gJG9wdGlv
bnNfbGlzdAorICAgICAgICBleHRyYV9jbWFrZV9jX2ZsYWdzPSItRENNQUtFX0NfRkxBR1M9XCIk
e29wdGlvbnNfbGlzdCMqIH1cIiIKKyAgICAgICAgZXh0cmFfY21ha2VfY3h4X2ZsYWdzPSItRENN
QUtFX0NYWF9GTEFHUz1cIiR7b3B0aW9uc19saXN0IyogfVwiIgorICAgIGZpCisgICAgZWNobyAk
ZXh0cmFfY21ha2VfY19mbGFncworCisgICAgY21ha2UgLURDTUFLRV9CVUlMRF9UWVBFPSRjb25m
aWcgIiRleHRyYV9jbWFrZV9jX2ZsYWdzIiAiJGV4dHJhX2NtYWtlX2N4eF9mbGFncyIgLUIgJGJ1
aWxkX2RpcgorICAgIGNtYWtlIC0tYnVpbGQgJGJ1aWxkX2RpciAtLXBhcmFsbGVsCit9CisKK2Z1
bmN0aW9uIGJ1aWxkX3ZhcmlhbnQgeworICAgIGNhc2UgJHNkayBpbgorICAgICAgICBtYWNvc3gu
aW50ZXJuYWwpCisgICAgICAgICAgICBidWlsZF92YXJpYW50X3hjb2RlYnVpbGQgJEAKKyAgICAg
ICAgICAgIDs7CisgICAgZXNhYworICAgIGNhc2UgJHNkayBpbgorICAgICAgICBsaW51eCkKKyAg
ICAgICAgICAgIGJ1aWxkX3ZhcmlhbnRfbGludXggJEAKKyAgICAgICAgICAgIDs7CisgICAgZXNh
YworfQorCiBmdW5jdGlvbiBidWlsZF92YXJpYW50cyB7CiAgICAgdGFyZ2V0PSQxCiAgICAgCiAg
ICAgY2FzZSAkdmFyaWFudHMgaW4KICAgICAgICAgYWxsfHRlc3RpbmcpCi0gICAgICAgICAgICBi
dWlsZF92YXJpYW50IHRlc3RpbmcgIkVYVFJBX0RFRklORVM9RU5BQkxFX1BBU19URVNUSU5HIiAk
dGFyZ2V0CisgICAgICAgICAgICBidWlsZF92YXJpYW50IHRlc3RpbmcgJHRhcmdldCAiRU5BQkxF
X1BBU19URVNUSU5HIgogICAgICAgICAgICAgOzsKICAgICBlc2FjCiAgICAgY2FzZSAkdmFyaWFu
dHMgaW4KICAgICAgICAgYWxsfGRlZmF1bHQpCi0gICAgICAgICAgICBidWlsZF92YXJpYW50IGRl
ZmF1bHQgIkVYVFJBX0RFRklORVM9IiAkdGFyZ2V0CisgICAgICAgICAgICBidWlsZF92YXJpYW50
IGRlZmF1bHQgJHRhcmdldCAiIgogICAgICAgICAgICAgOzsKICAgICBlc2FjCiB9Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>446008</attachid>
            <date>2021-12-06 00:37:41 -0800</date>
            <delta_ts>2021-12-06 23:23:58 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-233821-20211206093739.patch</filename>
            <type>text/plain</type>
            <size>4736</size>
            <attacher name="Zan Dobersek">zan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D
aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggZTg2Yjg0MGI2NGVhZGFk
ODUxY2IwYTUzNjUxNzEyN2UxMzg3YzZlMy4uODkxN2RjNGJkN2JhMDIyNTk2ZTA5NjhhMzVkMTk0
YzI0YTUzZTAwYiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIxLTEyLTA2ICBaYW4g
RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbbGlicGFzXSBtYWtl
IGJ1aWxkLnNoLCB0ZXN0LnNoLCBidWlsZF9hbmRfdGVzdC5zaCwgYW5kIGNsZWFuLnNoIHdvcmsg
b24gTGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTIzMzgyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEFkanVzdCBhbmQgZW5oYW5jZSB0aGUgc2hlbGwgc2NyaXB0cyBmb3IgYnVpbGRpbmcgYW5kIHRl
c3RpbmcgQ01ha2UKKyAgICAgICAgYnVpbGRzIG9mIGxpYnBhcy4gSW4gYnVpbGQuc2gsIHRoZSAn
bGludXgnIFNESyBvcHRpb24gaGFuZGxpbmcgaXMgYWRkZWQsCisgICAgICAgIGludm9raW5nIENN
YWtlIHRvIHByb2R1Y2UgYSBsaWJwYXMgYnVpbGQgb2YgdGhlIGRlc2lyZWQgdmFyaWFudCBhbmQK
KyAgICAgICAgY29uZmlndXJhdGlvbi4gVGhlIERlYnVnIGFuZCBSZWxlYXNlIGNvbmZpZ3VyYXRp
b24gcG9zc2liaWxpdGllcyBtYXAKKyAgICAgICAgZXhhY3RseSB0byB0aGUgQ01BS0VfQlVJTERf
VFlQRSBvcHRpb24uIFRoZSBFTkFCTEVfUEFTX1RFU1RJTkcgb3B0aW9uCisgICAgICAgIHVzZWQg
Zm9yIHRoZSB0ZXN0aW5nIHZhcmlhbnQgaXMgY29udmVydGVkIGludG8gYSBtYWNybyBkZWZpbml0
aW9uIHRoYXQncworICAgICAgICBwYXNzZWQgdG8gYm90aCBDTUFLRV9DX0ZMQUdTIGFuZCBDTUFL
RV9DWFhfRkxBR1MuCisKKyAgICAgICAgVGhlIGZ1bmN0aW9uIGRlY2xhcmF0aW9ucyBhcmUgYWRq
dXN0ZWQgdG8gdXNlIHRoZSAiZm5hbWUoKSIgZm9ybSwgbWFraW5nCisgICAgICAgIHRoaW5ncyBy
dW5uYWJsZSBvbiBzaGVsbHMgdGhhdCBkb24ndCBzdXBwb3J0IHRoZSAiZnVuY3Rpb24iIGtleXdv
cmQuCisKKyAgICAgICAgKiBsaWJwYXMvYnVpbGQuc2g6CisgICAgICAgICogbGlicGFzL2NvbW1v
bi5zaDoKKyAgICAgICAgKiBsaWJwYXMvdGVzdC5zaDoKKwogMjAyMS0xMi0wMyAgRmlsaXAgUGl6
bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFtsaWJwYXNdIEJpdGZpdCBhbGxvY2F0
b3IgaGFzIGEgd3JvbmcgYXNzZXJ0aW9uIHdoZW4gYSBwYWdlJ3MgbWF4X2ZyZWUgaXMgZW5vdWdo
IGZvciB0aGUgc2l6ZSBvZiBhbiBhbGxvY2F0aW9uLCBub3QgZW5vdWdoIGZvciB0aGF0IGFsbG9j
YXRpb24ncyBzaXplIGNsYXNzLCBhbmQgdGhlIG9iamVjdCBvZiB0aGF0IHNpemUgaXMgbm90IGFs
aWduZWQgdG8gdGhlIGN1cnJlbnRseSByZXF1ZXN0ZWQgYWxpZ25tZW50CmRpZmYgLS1naXQgYS9T
b3VyY2UvYm1hbGxvYy9saWJwYXMvYnVpbGQuc2ggYi9Tb3VyY2UvYm1hbGxvYy9saWJwYXMvYnVp
bGQuc2gKaW5kZXggNjhiZDY1MGNmNDZjODU3MWJmOGRlM2ZkNmMyMTFkMmMxODY1ODQ1Zi4uM2Rj
ZWExMmMyNzUzOTkzYzYxN2IxNTgxYzZkYWUyYjU3ZGM4ODhkZiAxMDA3NTUKLS0tIGEvU291cmNl
L2JtYWxsb2MvbGlicGFzL2J1aWxkLnNoCisrKyBiL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9idWls
ZC5zaApAQCAtMjQsMTAgKzI0LDEwIEBACiAKIC4gY29tbW9uLnNoCiAKLWZ1bmN0aW9uIGJ1aWxk
X3ZhcmlhbnQgeworYnVpbGRfdmFyaWFudF94Y29kZWJ1aWxkKCkgewogICAgIHZhcmlhbnQ9JDEK
LSAgICBleHRyYV94Y29kZWJ1aWxkX29wdGlvbnM9IiQyIgotICAgIHRhcmdldD0kMworICAgIHRh
cmdldD0kMgorICAgIGV4dHJhX3hjb2RlYnVpbGRfb3B0aW9ucz0iRVhUUkFfREVGSU5FUz0kMyIK
ICAgICAKICAgICBidWlsZF9kaXI9YnVpbGQtJHNkay0kdmFyaWFudAogICAgIG1rZGlyIC1wICRi
dWlsZF9kaXIKQEAgLTQzLDcgKzQzLDcgQEAgZnVuY3Rpb24gYnVpbGRfdmFyaWFudCB7CiAgICAg
ICAgICAgICAKICAgICBjYXNlICR0YXJnZXQgaW4KICAgICAgICAgbWJtYWxsb2N8YWxsKQotICAg
ICAgICAgICAgZnVuY3Rpb24gbGlua19tYm1hbGxvY19wZXJzb25hbGl0eSB7CisgICAgICAgICAg
ICBsaW5rX21ibWFsbG9jX3BlcnNvbmFsaXR5KCkgewogICAgICAgICAgICAgICAgIHBlcnNvbmFs
aXR5PSQxCiAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgbWtkaXIgLXAgJGJ1aWxk
X2Rpci8kY29uZmlnZGlyL21ibWFsbG9jXyRwZXJzb25hbGl0eQpAQCAtNjAsMTcgKzYwLDYwIEBA
IGZ1bmN0aW9uIGJ1aWxkX3ZhcmlhbnQgewogICAgIGVzYWMKIH0KIAotZnVuY3Rpb24gYnVpbGRf
dmFyaWFudHMgeworYnVpbGRfdmFyaWFudF9saW51eCgpIHsKKyAgICB2YXJpYW50PSQxCisgICAg
dGFyZ2V0PSQyCisgICAgZXh0cmFfb3B0aW9ucz0kMworCisgICAgY2FzZSAkY29uZmlnIGluCisg
ICAgICAgIFJlbGVhc2UpCisgICAgICAgICAgICA7OworICAgICAgICBEZWJ1ZykKKyAgICAgICAg
ICAgIDs7CisgICAgICAgICopCisgICAgICAgICAgICBlY2hvICJCYWQgdmFsdWUgb2YgY29uZmln
IgorICAgICAgICAgICAgZXhpdCAxCisgICAgZXNhYworCisgICAgYnVpbGRfZGlyPWJ1aWxkLSRz
ZGstJHZhcmlhbnQvJGNvbmZpZ2RpcgorICAgIG1rZGlyIC1wICRidWlsZF9kaXIKKworICAgIGV4
dHJhX2NtYWtlX29wdGlvbnM9IiIKKyAgICBmb3Igb3B0aW9uIGluICRleHRyYV9vcHRpb25zOyBk
bworICAgICAgICBleHRyYV9jbWFrZV9vcHRpb25zPSIke2V4dHJhX2NtYWtlX29wdGlvbnN9IC1E
JHtvcHRpb259IgorICAgIGRvbmUKKyAgICBleHRyYV9jbWFrZV9vcHRpb25zPVwiJHtleHRyYV9j
bWFrZV9vcHRpb25zIyogfVwiCisKKyAgICBlY2hvICRleHRyYV9jbWFrZV9vcHRpb25zCisKKyAg
ICBjbWFrZSAtRENNQUtFX0JVSUxEX1RZUEU9JGNvbmZpZyAtRENNQUtFX0NfRkxBR1M9JGV4dHJh
X2NtYWtlX29wdGlvbnMgLURDTUFLRV9DWFhfRkxBR1M9JGV4dHJhX2NtYWtlX29wdGlvbnMgLUIg
JGJ1aWxkX2RpcgorICAgIGNtYWtlIC0tYnVpbGQgJGJ1aWxkX2RpciAtLXBhcmFsbGVsCit9CisK
K2J1aWxkX3ZhcmlhbnQoKSB7CisgICAgY2FzZSAkc2RrIGluCisgICAgICAgIG1hY29zeC5pbnRl
cm5hbCkKKyAgICAgICAgICAgIGJ1aWxkX3ZhcmlhbnRfeGNvZGVidWlsZCAkQAorICAgICAgICAg
ICAgOzsKKyAgICBlc2FjCisgICAgY2FzZSAkc2RrIGluCisgICAgICAgIGxpbnV4KQorICAgICAg
ICAgICAgYnVpbGRfdmFyaWFudF9saW51eCAkQAorICAgICAgICAgICAgOzsKKyAgICBlc2FjCit9
CisKK2J1aWxkX3ZhcmlhbnRzKCkgewogICAgIHRhcmdldD0kMQogICAgIAogICAgIGNhc2UgJHZh
cmlhbnRzIGluCiAgICAgICAgIGFsbHx0ZXN0aW5nKQotICAgICAgICAgICAgYnVpbGRfdmFyaWFu
dCB0ZXN0aW5nICJFWFRSQV9ERUZJTkVTPUVOQUJMRV9QQVNfVEVTVElORyIgJHRhcmdldAorICAg
ICAgICAgICAgYnVpbGRfdmFyaWFudCB0ZXN0aW5nICR0YXJnZXQgIkVOQUJMRV9QQVNfVEVTVElO
RyIKICAgICAgICAgICAgIDs7CiAgICAgZXNhYwogICAgIGNhc2UgJHZhcmlhbnRzIGluCiAgICAg
ICAgIGFsbHxkZWZhdWx0KQotICAgICAgICAgICAgYnVpbGRfdmFyaWFudCBkZWZhdWx0ICJFWFRS
QV9ERUZJTkVTPSIgJHRhcmdldAorICAgICAgICAgICAgYnVpbGRfdmFyaWFudCBkZWZhdWx0ICR0
YXJnZXQgIiIKICAgICAgICAgICAgIDs7CiAgICAgZXNhYwogfQpkaWZmIC0tZ2l0IGEvU291cmNl
L2JtYWxsb2MvbGlicGFzL2NvbW1vbi5zaCBiL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9jb21tb24u
c2gKaW5kZXggOWE5NzkwMWY0N2MxMDQzYWU1ZTQ0NzNlODBlZDQ4OGEzZWZiODMxZS4uZWM0ZDMx
YjVkZjM0M2MyNDkxMzg2YjAwMGJlYTliZWRjOGMyOTllOSAxMDA2NDQKLS0tIGEvU291cmNlL2Jt
YWxsb2MvbGlicGFzL2NvbW1vbi5zaAorKysgYi9Tb3VyY2UvYm1hbGxvYy9saWJwYXMvY29tbW9u
LnNoCkBAIC0zMSw3ICszMSw3IEBAIHZhcmlhbnRzPWFsbAogdGFyZ2V0PWFsbAogcG9ydD0xMDAy
MgogCi1mdW5jdGlvbiBzaG93X2hlbHAgeworc2hvd19oZWxwKCkgewogICAgIHNldCAreAogICAg
IGVjaG8gIiQwIFstaGNzYXZ0cGJdIgogICAgIGVjaG8KZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFs
bG9jL2xpYnBhcy90ZXN0LnNoIGIvU291cmNlL2JtYWxsb2MvbGlicGFzL3Rlc3Quc2gKaW5kZXgg
YTQ5Y2IwYTM0ZDAwYzZjMDgxOWJjYzliODRkMzAzYmNkNTNlM2RiMS4uOTkzNmUxMGJkMWU1Mzg0
YjUxNDBjOWVkN2FmOWExOTEzNDlmNWE5MSAxMDA3NTUKLS0tIGEvU291cmNlL2JtYWxsb2MvbGli
cGFzL3Rlc3Quc2gKKysrIGIvU291cmNlL2JtYWxsb2MvbGlicGFzL3Rlc3Quc2gKQEAgLTI0LDcg
KzI0LDcgQEAKIAogLiBjb21tb24uc2gKIAotZnVuY3Rpb24gY29weV92YXJpYW50IHsKK2NvcHlf
dmFyaWFudCgpIHsKICAgICB2YXJpYW50PSQxCiAgICAgCiAgICAgdGFyIC1jenZmIC9kZXYvc3Rk
b3V0IGJ1aWxkLSRzZGstJHZhcmlhbnQvJGNvbmZpZ2RpciB0ZXN0LWltcGwuc2ggY29tbW9uLnNo
IHwgXAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>446128</attachid>
            <date>2021-12-06 23:24:03 -0800</date>
            <delta_ts>2021-12-12 23:17:15 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-233821-20211207082402.patch</filename>
            <type>text/plain</type>
            <size>4691</size>
            <attacher name="Zan Dobersek">zan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D
aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggZTg2Yjg0MGI2NGVhZGFk
ODUxY2IwYTUzNjUxNzEyN2UxMzg3YzZlMy4uMTAyNTdiM2VjOTFlNmVhODI4OWQyMWQxNWE4Y2Vh
NzVkOTUzNzM1MiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIxLTEyLTA2ICBaYW4g
RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbbGlicGFzXSBtYWtl
IGJ1aWxkLnNoLCB0ZXN0LnNoLCBidWlsZF9hbmRfdGVzdC5zaCwgYW5kIGNsZWFuLnNoIHdvcmsg
b24gTGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTIzMzgyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEFkanVzdCBhbmQgZW5oYW5jZSB0aGUgc2hlbGwgc2NyaXB0cyBmb3IgYnVpbGRpbmcgYW5kIHRl
c3RpbmcgQ01ha2UKKyAgICAgICAgYnVpbGRzIG9mIGxpYnBhcy4gSW4gYnVpbGQuc2gsIHRoZSAn
Y21ha2UnIFNESyBvcHRpb24gaGFuZGxpbmcgaXMgYWRkZWQsCisgICAgICAgIGludm9raW5nIENN
YWtlIHRvIHByb2R1Y2UgYSBsaWJwYXMgYnVpbGQgb2YgdGhlIGRlc2lyZWQgdmFyaWFudCBhbmQK
KyAgICAgICAgY29uZmlndXJhdGlvbi4gVGhlIERlYnVnIGFuZCBSZWxlYXNlIGNvbmZpZ3VyYXRp
b24gcG9zc2liaWxpdGllcyBtYXAKKyAgICAgICAgZXhhY3RseSB0byB0aGUgQ01BS0VfQlVJTERf
VFlQRSBvcHRpb24uIFRoZSBFTkFCTEVfUEFTX1RFU1RJTkcgb3B0aW9uCisgICAgICAgIHVzZWQg
Zm9yIHRoZSB0ZXN0aW5nIHZhcmlhbnQgaXMgY29udmVydGVkIGludG8gYSBtYWNybyBkZWZpbml0
aW9uIHRoYXQncworICAgICAgICBwYXNzZWQgdG8gYm90aCBDTUFLRV9DX0ZMQUdTIGFuZCBDTUFL
RV9DWFhfRkxBR1MuCisKKyAgICAgICAgVGhlIGZ1bmN0aW9uIGRlY2xhcmF0aW9ucyBhcmUgYWRq
dXN0ZWQgdG8gdXNlIHRoZSAiZm5hbWUoKSIgZm9ybSwgbWFraW5nCisgICAgICAgIHRoaW5ncyBy
dW5uYWJsZSBvbiBzaGVsbHMgdGhhdCBkb24ndCBzdXBwb3J0IHRoZSAiZnVuY3Rpb24iIGtleXdv
cmQuCisKKyAgICAgICAgKiBsaWJwYXMvYnVpbGQuc2g6CisgICAgICAgICogbGlicGFzL2NvbW1v
bi5zaDoKKyAgICAgICAgKiBsaWJwYXMvdGVzdC5zaDoKKwogMjAyMS0xMi0wMyAgRmlsaXAgUGl6
bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFtsaWJwYXNdIEJpdGZpdCBhbGxvY2F0
b3IgaGFzIGEgd3JvbmcgYXNzZXJ0aW9uIHdoZW4gYSBwYWdlJ3MgbWF4X2ZyZWUgaXMgZW5vdWdo
IGZvciB0aGUgc2l6ZSBvZiBhbiBhbGxvY2F0aW9uLCBub3QgZW5vdWdoIGZvciB0aGF0IGFsbG9j
YXRpb24ncyBzaXplIGNsYXNzLCBhbmQgdGhlIG9iamVjdCBvZiB0aGF0IHNpemUgaXMgbm90IGFs
aWduZWQgdG8gdGhlIGN1cnJlbnRseSByZXF1ZXN0ZWQgYWxpZ25tZW50CmRpZmYgLS1naXQgYS9T
b3VyY2UvYm1hbGxvYy9saWJwYXMvYnVpbGQuc2ggYi9Tb3VyY2UvYm1hbGxvYy9saWJwYXMvYnVp
bGQuc2gKaW5kZXggNjhiZDY1MGNmNDZjODU3MWJmOGRlM2ZkNmMyMTFkMmMxODY1ODQ1Zi4uMWZj
MmZkMDdkOWMzMGFlZjExMjg1ODI5OGNjMjVjZjZlNWFjMjdlMyAxMDA3NTUKLS0tIGEvU291cmNl
L2JtYWxsb2MvbGlicGFzL2J1aWxkLnNoCisrKyBiL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9idWls
ZC5zaApAQCAtMjQsMTAgKzI0LDEwIEBACiAKIC4gY29tbW9uLnNoCiAKLWZ1bmN0aW9uIGJ1aWxk
X3ZhcmlhbnQgeworYnVpbGRfdmFyaWFudF94Y29kZWJ1aWxkKCkgewogICAgIHZhcmlhbnQ9JDEK
LSAgICBleHRyYV94Y29kZWJ1aWxkX29wdGlvbnM9IiQyIgotICAgIHRhcmdldD0kMworICAgIHRh
cmdldD0kMgorICAgIGV4dHJhX3hjb2RlYnVpbGRfb3B0aW9ucz0iRVhUUkFfREVGSU5FUz0kMyIK
ICAgICAKICAgICBidWlsZF9kaXI9YnVpbGQtJHNkay0kdmFyaWFudAogICAgIG1rZGlyIC1wICRi
dWlsZF9kaXIKQEAgLTQzLDcgKzQzLDcgQEAgZnVuY3Rpb24gYnVpbGRfdmFyaWFudCB7CiAgICAg
ICAgICAgICAKICAgICBjYXNlICR0YXJnZXQgaW4KICAgICAgICAgbWJtYWxsb2N8YWxsKQotICAg
ICAgICAgICAgZnVuY3Rpb24gbGlua19tYm1hbGxvY19wZXJzb25hbGl0eSB7CisgICAgICAgICAg
ICBsaW5rX21ibWFsbG9jX3BlcnNvbmFsaXR5KCkgewogICAgICAgICAgICAgICAgIHBlcnNvbmFs
aXR5PSQxCiAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgbWtkaXIgLXAgJGJ1aWxk
X2Rpci8kY29uZmlnZGlyL21ibWFsbG9jXyRwZXJzb25hbGl0eQpAQCAtNjAsMTcgKzYwLDU4IEBA
IGZ1bmN0aW9uIGJ1aWxkX3ZhcmlhbnQgewogICAgIGVzYWMKIH0KIAotZnVuY3Rpb24gYnVpbGRf
dmFyaWFudHMgeworYnVpbGRfdmFyaWFudF9jbWFrZSgpIHsKKyAgICB2YXJpYW50PSQxCisgICAg
dGFyZ2V0PSQyCisgICAgZXh0cmFfb3B0aW9ucz0kMworCisgICAgY2FzZSAkY29uZmlnIGluCisg
ICAgICAgIFJlbGVhc2UpCisgICAgICAgICAgICA7OworICAgICAgICBEZWJ1ZykKKyAgICAgICAg
ICAgIDs7CisgICAgICAgICopCisgICAgICAgICAgICBlY2hvICJCYWQgdmFsdWUgb2YgY29uZmln
IgorICAgICAgICAgICAgZXhpdCAxCisgICAgZXNhYworCisgICAgYnVpbGRfZGlyPWJ1aWxkLSRz
ZGstJHZhcmlhbnQvJGNvbmZpZ2RpcgorICAgIG1rZGlyIC1wICRidWlsZF9kaXIKKworICAgIGV4
dHJhX2NtYWtlX29wdGlvbnM9IiIKKyAgICBmb3Igb3B0aW9uIGluICRleHRyYV9vcHRpb25zOyBk
bworICAgICAgICBleHRyYV9jbWFrZV9vcHRpb25zPSIke2V4dHJhX2NtYWtlX29wdGlvbnN9IC1E
JHtvcHRpb259IgorICAgIGRvbmUKKyAgICBleHRyYV9jbWFrZV9vcHRpb25zPVwiJHtleHRyYV9j
bWFrZV9vcHRpb25zIyogfVwiCisKKyAgICBlY2hvICRleHRyYV9jbWFrZV9vcHRpb25zCisKKyAg
ICBjbWFrZSAtRENNQUtFX0JVSUxEX1RZUEU9JGNvbmZpZyAtRENNQUtFX0NfRkxBR1M9JGV4dHJh
X2NtYWtlX29wdGlvbnMgLURDTUFLRV9DWFhfRkxBR1M9JGV4dHJhX2NtYWtlX29wdGlvbnMgLUIg
JGJ1aWxkX2RpcgorICAgIGNtYWtlIC0tYnVpbGQgJGJ1aWxkX2RpciAtLXBhcmFsbGVsCit9CisK
K2J1aWxkX3ZhcmlhbnQoKSB7CisgICAgY2FzZSAkc2RrIGluCisgICAgICAgIGNtYWtlKQorICAg
ICAgICAgICAgYnVpbGRfdmFyaWFudF9jbWFrZSAkQAorICAgICAgICAgICAgOzsKKyAgICAgICAg
KikKKyAgICAgICAgICAgIGJ1aWxkX3ZhcmlhbnRfeGNvZGVidWlsZAorICAgICAgICAgICAgOzsK
KyAgICBlc2FjCit9CisKK2J1aWxkX3ZhcmlhbnRzKCkgewogICAgIHRhcmdldD0kMQogICAgIAog
ICAgIGNhc2UgJHZhcmlhbnRzIGluCiAgICAgICAgIGFsbHx0ZXN0aW5nKQotICAgICAgICAgICAg
YnVpbGRfdmFyaWFudCB0ZXN0aW5nICJFWFRSQV9ERUZJTkVTPUVOQUJMRV9QQVNfVEVTVElORyIg
JHRhcmdldAorICAgICAgICAgICAgYnVpbGRfdmFyaWFudCB0ZXN0aW5nICR0YXJnZXQgIkVOQUJM
RV9QQVNfVEVTVElORyIKICAgICAgICAgICAgIDs7CiAgICAgZXNhYwogICAgIGNhc2UgJHZhcmlh
bnRzIGluCiAgICAgICAgIGFsbHxkZWZhdWx0KQotICAgICAgICAgICAgYnVpbGRfdmFyaWFudCBk
ZWZhdWx0ICJFWFRSQV9ERUZJTkVTPSIgJHRhcmdldAorICAgICAgICAgICAgYnVpbGRfdmFyaWFu
dCBkZWZhdWx0ICR0YXJnZXQgIiIKICAgICAgICAgICAgIDs7CiAgICAgZXNhYwogfQpkaWZmIC0t
Z2l0IGEvU291cmNlL2JtYWxsb2MvbGlicGFzL2NvbW1vbi5zaCBiL1NvdXJjZS9ibWFsbG9jL2xp
YnBhcy9jb21tb24uc2gKaW5kZXggOWE5NzkwMWY0N2MxMDQzYWU1ZTQ0NzNlODBlZDQ4OGEzZWZi
ODMxZS4uZWM0ZDMxYjVkZjM0M2MyNDkxMzg2YjAwMGJlYTliZWRjOGMyOTllOSAxMDA2NDQKLS0t
IGEvU291cmNlL2JtYWxsb2MvbGlicGFzL2NvbW1vbi5zaAorKysgYi9Tb3VyY2UvYm1hbGxvYy9s
aWJwYXMvY29tbW9uLnNoCkBAIC0zMSw3ICszMSw3IEBAIHZhcmlhbnRzPWFsbAogdGFyZ2V0PWFs
bAogcG9ydD0xMDAyMgogCi1mdW5jdGlvbiBzaG93X2hlbHAgeworc2hvd19oZWxwKCkgewogICAg
IHNldCAreAogICAgIGVjaG8gIiQwIFstaGNzYXZ0cGJdIgogICAgIGVjaG8KZGlmZiAtLWdpdCBh
L1NvdXJjZS9ibWFsbG9jL2xpYnBhcy90ZXN0LnNoIGIvU291cmNlL2JtYWxsb2MvbGlicGFzL3Rl
c3Quc2gKaW5kZXggYTQ5Y2IwYTM0ZDAwYzZjMDgxOWJjYzliODRkMzAzYmNkNTNlM2RiMS4uOTkz
NmUxMGJkMWU1Mzg0YjUxNDBjOWVkN2FmOWExOTEzNDlmNWE5MSAxMDA3NTUKLS0tIGEvU291cmNl
L2JtYWxsb2MvbGlicGFzL3Rlc3Quc2gKKysrIGIvU291cmNlL2JtYWxsb2MvbGlicGFzL3Rlc3Qu
c2gKQEAgLTI0LDcgKzI0LDcgQEAKIAogLiBjb21tb24uc2gKIAotZnVuY3Rpb24gY29weV92YXJp
YW50IHsKK2NvcHlfdmFyaWFudCgpIHsKICAgICB2YXJpYW50PSQxCiAgICAgCiAgICAgdGFyIC1j
enZmIC9kZXYvc3Rkb3V0IGJ1aWxkLSRzZGstJHZhcmlhbnQvJGNvbmZpZ2RpciB0ZXN0LWltcGwu
c2ggY29tbW9uLnNoIHwgXAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>