233792 2021-12-02 16:47:54 -0800 [Cocoa] Web Inspector: fix completion handler type signature for _WKInspectorExtension methods 2021-12-03 09:36:15 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1819943 0 bburg 2021-12-02 16:47:54 -0800 A dictionary is not necessarily returned here, the implementation deserializes a SerializedScriptValue. While the frontend does return a dictionary payload, this is unpacked on the WebProcess-side before being sent back out via the _WKInspectorExtension APi. 1819944 1 webkit-bug-importer 2021-12-02 16:48:16 -0800 <rdar://problem/85995314> 1819961 2 445796 bburg 2021-12-02 17:06:12 -0800 Created attachment 445796 Patch v1.0 1819964 3 445796 hi 2021-12-02 17:09:23 -0800 Comment on attachment 445796 Patch v1.0 rs=me 1820177 4 ews-feeder 2021-12-03 09:36:14 -0800 Committed r286497 (244836@main): <https://commits.webkit.org/244836@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445796. 445796 2021-12-02 17:06:12 -0800 2021-12-03 09:36:14 -0800 Patch v1.0 bug-233792-20211202170611.patch text/plain 5451 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE5YWIxMTM0NTgxZDhiZDhk NjA5NTdlYmNkZDc3ZTkwNjgzMzFmOGUuLmIxMTcxZjM1YmE3Y2I2MDRjZTE2MDA1MzA3NDNhNTMy OTVlNjEwN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjEtMTItMDIgIEJKIEJ1cmcg IDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBXZWIgSW5zcGVjdG9yOiBmaXgg Y29tcGxldGlvbiBoYW5kbGVyIHR5cGUgc2lnbmF0dXJlIGZvciBfV0tJbnNwZWN0b3JFeHRlbnNp b24gbWV0aG9kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMzNzkyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NTk5NTMxND4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29j b2EvX1dLSW5zcGVjdG9yRXh0ZW5zaW9uLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2Nv YS9fV0tJbnNwZWN0b3JFeHRlbnNpb24ubW06CisgICAgICAgICgtW19XS0luc3BlY3RvckV4dGVu c2lvbiBldmFsdWF0ZVNjcmlwdDpmcmFtZVVSTDpjb250ZXh0U2VjdXJpdHlPcmlnaW46dXNlQ29u dGVudFNjcmlwdENvbnRleHQ6Y29tcGxldGlvbkhhbmRsZXI6XSk6CisgICAgICAgICgtW19XS0lu c3BlY3RvckV4dGVuc2lvbiBldmFsdWF0ZVNjcmlwdDppblRhYldpdGhJZGVudGlmaWVyOmNvbXBs ZXRpb25IYW5kbGVyOl0pOgorICAgICAgICBSZXBsYWNlIHRoZSBjb21wbGV0aW9uSGFuZGxlcidz IE5TRGljdGlvbmFyeSBhcmd1bWVudCB0eXBlIHdpdGggYGlkYC4KKworICAgICAgICBBIGRpY3Rp b25hcnkgaXMgbm90IG5lY2Vzc2FyaWx5IHJldHVybmVkIGhlcmUgYmVjYXVzZSB0aGUgaW1wbGVt ZW50YXRpb24gZGVzZXJpYWxpemVzIGEgU2VyaWFsaXplZFNjcmlwdFZhbHVlLgorICAgICAgICBU aGlzIGNvdWxkIGJlIGEgc3RyaW5nLCBudW1iZXIsIGFycmF5LCBkaWN0aW9uYXJ5LCBvciBvdGhl ciBzZXJpYWxpemFibGUgdmFsdWVzLgorCisgICAgICAgIFdoaWxlIHRoZSBmcm9udGVuZCBkb2Vz IHJldHVybiBhIGRpY3Rpb25hcnkgcGF5bG9hZCwgdGhpcyBpcyB1bnBhY2tlZCBvbiB0aGUgV2Vi UHJvY2Vzcy1zaWRlCisgICAgICAgIGJlZm9yZSBiZWluZyBzZW50IGJhY2sgb3V0IHZpYSB0aGUg X1dLSW5zcGVjdG9yRXh0ZW5zaW9uIEFQaS4KKwogMjAyMS0xMi0wMiAgUGVyIEFybmUgVm9sbGFu ICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dQXSBTdHJlbmd0aGVuIHNhbmRib3gg d2hlbiBBcHBDYWNoZSBpcyBkaXNhYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL0NvY29hL19XS0luc3BlY3RvckV4dGVuc2lvbi5oIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQVBJL0NvY29hL19XS0luc3BlY3RvckV4dGVuc2lvbi5oCmluZGV4IDMzYThhYTlj NzkyNDUwYjg3MzY3NzRlZTQ2MDJjMzZiYjBlNWY2YTAuLmE1YzQ1N2Q4MmE4ZjdmMTFkOTQ4NDNh OTdlNDIxMmIyZTNhNWViMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9Db2NvYS9fV0tJbnNwZWN0b3JFeHRlbnNpb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvQ29jb2EvX1dLSW5zcGVjdG9yRXh0ZW5zaW9uLmgKQEAgLTYzLDcgKzYzLDcgQEAg V0tfQ0xBU1NfQVZBSUxBQkxFKG1hY29zKDEyLjApKQogICogc2NyaXB0U291cmNlIGlzIHRyZWF0 ZWQgYXMgYSB0b3AtbGV2ZWwgZXZhbHVhdGlvbi4gQnkgZGVmYXVsdCwgdGhlIHNjcmlwdCBpcyBl dmFsdWF0ZWQgaW4gdGhlIGluc3BlY3RlZCBwYWdlJ3Mgc2NyaXB0IGNvbnRleHQuCiAgKiBUaGUg aW5zcGVjdGVkIHBhZ2UgdWx0aW1hdGVseSBjb250cm9scyBpdHMgZXhlY3V0aW9uIGNvbnRleHQg YW5kIHRoZSByZXN1bHQgb2YgdGhpcyBldmFsdWF0aW9uLiBUaHVzLCB0aGUgcmVzdWx0IHNoYWxs IGJlIHRyZWF0ZWQgYXMgdW50cnVzdGVkIGlucHV0LgogICovCi0tICh2b2lkKWV2YWx1YXRlU2Ny aXB0OihOU1N0cmluZyAqKXNjcmlwdFNvdXJjZSBmcmFtZVVSTDooTlNVUkwgKilmcmFtZVVSTCBj b250ZXh0U2VjdXJpdHlPcmlnaW46KE5TVVJMICopY29udGV4dFNlY3VyaXR5T3JpZ2luIHVzZUNv bnRlbnRTY3JpcHRDb250ZXh0OihCT09MKXVzZUNvbnRlbnRTY3JpcHRDb250ZXh0IGNvbXBsZXRp b25IYW5kbGVyOih2b2lkKF4pKE5TRXJyb3IgKiBfTnVsbGFibGUsIE5TRGljdGlvbmFyeSAqIF9O dWxsYWJsZSByZXN1bHQpKWNvbXBsZXRpb25IYW5kbGVyOworLSAodm9pZClldmFsdWF0ZVNjcmlw dDooTlNTdHJpbmcgKilzY3JpcHRTb3VyY2UgZnJhbWVVUkw6KE5TVVJMICopZnJhbWVVUkwgY29u dGV4dFNlY3VyaXR5T3JpZ2luOihOU1VSTCAqKWNvbnRleHRTZWN1cml0eU9yaWdpbiB1c2VDb250 ZW50U2NyaXB0Q29udGV4dDooQk9PTCl1c2VDb250ZW50U2NyaXB0Q29udGV4dCBjb21wbGV0aW9u SGFuZGxlcjoodm9pZCheKShOU0Vycm9yICogX051bGxhYmxlLCBpZCByZXN1bHQpKWNvbXBsZXRp b25IYW5kbGVyOwogCiAvKioKICAqIEBhYnN0cmFjdCBFdmFsdWF0ZXMgSmF2YVNjcmlwdCBpbiB0 aGUgY29udGV4dCBvZiBhIFdlYiBJbnNwZWN0b3IgdGFiIGNyZWF0ZWQgYnkgdGhpcyBfV0tJbnNw ZWN0b3JFeHRlbnNpb24uCkBAIC03Myw3ICs3Myw3IEBAIFdLX0NMQVNTX0FWQUlMQUJMRShtYWNv cygxMi4wKSkKICAqIEBkaXNjdXNzaW9uIFRoZSBjb21wbGV0aW9uSGFuZGxlciBpcyBwYXNzZWQg YW4gTlNKU09OU2VyaWFsaXphdGlvbi1jb21wYXRpYmxlIE5TT2JqZWN0IHJlcHJlc2VudGluZyB0 aGUgZXZhbHVhdGlvbiByZXN1bHQsIG9yIGFuIGVycm9yLgogICogc2NyaXB0U291cmNlIGlzIHRy ZWF0ZWQgYXMgYSB0b3AtbGV2ZWwgZXZhbHVhdGlvbi4KICAqLwotLSAodm9pZClldmFsdWF0ZVNj cmlwdDooTlNTdHJpbmcgKilzY3JpcHRTb3VyY2UgaW5UYWJXaXRoSWRlbnRpZmllcjooTlNTdHJp bmcgKil0YWJJZGVudGlmaWVyIGNvbXBsZXRpb25IYW5kbGVyOih2b2lkKF4pKE5TRXJyb3IgKiBf TnVsbGFibGUsIE5TRGljdGlvbmFyeSAqIF9OdWxsYWJsZSByZXN1bHQpKWNvbXBsZXRpb25IYW5k bGVyOworLSAodm9pZClldmFsdWF0ZVNjcmlwdDooTlNTdHJpbmcgKilzY3JpcHRTb3VyY2UgaW5U YWJXaXRoSWRlbnRpZmllcjooTlNTdHJpbmcgKil0YWJJZGVudGlmaWVyIGNvbXBsZXRpb25IYW5k bGVyOih2b2lkKF4pKE5TRXJyb3IgKiBfTnVsbGFibGUsIGlkIHJlc3VsdCkpY29tcGxldGlvbkhh bmRsZXI7CiAKIC8qKgogICogQGFic3RyYWN0IFJlbG9hZHMgdGhlIGluc3BlY3RlZCBwYWdlIG9u IGJlaGFsZiBvZiB0aGUgX1dLSW5zcGVjdG9yRXh0ZW5zaW9uLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0luc3BlY3RvckV4dGVuc2lvbi5tbSBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tJbnNwZWN0b3JFeHRlbnNpb24ubW0K aW5kZXggNjZiYjc3NTdiODg0ZDM2MjExZWMzYjI5ZGRlOWVhYjIyNmIyYTBjZS4uNTgwZTcxOGRk MTY4YTAxOTUwMjQ4NTJkNDBjYzQ1YzJjMTgyNjcxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0luc3BlY3RvckV4dGVuc2lvbi5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLSW5zcGVjdG9yRXh0ZW5zaW9uLm1tCkBA IC04Miw3ICs4Miw3IEBAIC0gKHZvaWQpY3JlYXRlVGFiV2l0aE5hbWU6KE5TU3RyaW5nICopdGFi TmFtZSB0YWJJY29uVVJMOihOU1VSTCAqKXRhYkljb25VUkwgc291CiAgICAgfSk7CiB9CiAKLS0g KHZvaWQpZXZhbHVhdGVTY3JpcHQ6KE5TU3RyaW5nICopc2NyaXB0U291cmNlIGZyYW1lVVJMOihO U1VSTCAqKWZyYW1lVVJMIGNvbnRleHRTZWN1cml0eU9yaWdpbjooTlNVUkwgKiljb250ZXh0U2Vj dXJpdHlPcmlnaW4gdXNlQ29udGVudFNjcmlwdENvbnRleHQ6KEJPT0wpdXNlQ29udGVudFNjcmlw dENvbnRleHQgY29tcGxldGlvbkhhbmRsZXI6KHZvaWQoXikoTlNFcnJvciAqLCBOU0RpY3Rpb25h cnkgKikpY29tcGxldGlvbkhhbmRsZXIKKy0gKHZvaWQpZXZhbHVhdGVTY3JpcHQ6KE5TU3RyaW5n ICopc2NyaXB0U291cmNlIGZyYW1lVVJMOihOU1VSTCAqKWZyYW1lVVJMIGNvbnRleHRTZWN1cml0 eU9yaWdpbjooTlNVUkwgKiljb250ZXh0U2VjdXJpdHlPcmlnaW4gdXNlQ29udGVudFNjcmlwdENv bnRleHQ6KEJPT0wpdXNlQ29udGVudFNjcmlwdENvbnRleHQgY29tcGxldGlvbkhhbmRsZXI6KHZv aWQoXikoTlNFcnJvciAqLCBpZCkpY29tcGxldGlvbkhhbmRsZXIKIHsKICAgICBzdGQ6Om9wdGlv bmFsPFVSTD4gb3B0aW9uYWxGcmFtZVVSTCA9IGZyYW1lVVJMID8gc3RkOjptYWtlX29wdGlvbmFs KFVSTChmcmFtZVVSTCkpIDogc3RkOjpudWxsb3B0OwogICAgIHN0ZDo6b3B0aW9uYWw8VVJMPiBv cHRpb25hbENvbnRleHRTZWN1cml0eU9yaWdpbiA9IGNvbnRleHRTZWN1cml0eU9yaWdpbiA/IHN0 ZDo6bWFrZV9vcHRpb25hbChVUkwoY29udGV4dFNlY3VyaXR5T3JpZ2luKSkgOiBzdGQ6Om51bGxv cHQ7CkBAIC0xMDMsNyArMTAzLDcgQEAgLSAodm9pZClldmFsdWF0ZVNjcmlwdDooTlNTdHJpbmcg KilzY3JpcHRTb3VyY2UgZnJhbWVVUkw6KE5TVVJMICopZnJhbWVVUkwgY29udGUKICAgICB9KTsK IH0KIAotLSAodm9pZClldmFsdWF0ZVNjcmlwdDooTlNTdHJpbmcgKilzY3JpcHRTb3VyY2UgaW5U YWJXaXRoSWRlbnRpZmllcjooTlNTdHJpbmcgKilleHRlbnNpb25UYWJJZGVudGlmaWVyIGNvbXBs ZXRpb25IYW5kbGVyOih2b2lkKF4pKE5TRXJyb3IgKiwgTlNEaWN0aW9uYXJ5ICopKWNvbXBsZXRp b25IYW5kbGVyCistICh2b2lkKWV2YWx1YXRlU2NyaXB0OihOU1N0cmluZyAqKXNjcmlwdFNvdXJj ZSBpblRhYldpdGhJZGVudGlmaWVyOihOU1N0cmluZyAqKWV4dGVuc2lvblRhYklkZW50aWZpZXIg Y29tcGxldGlvbkhhbmRsZXI6KHZvaWQoXikoTlNFcnJvciAqLCBpZCkpY29tcGxldGlvbkhhbmRs ZXIKIHsKICAgICBfZXh0ZW5zaW9uLT5ldmFsdWF0ZVNjcmlwdEluRXh0ZW5zaW9uVGFiKGV4dGVu c2lvblRhYklkZW50aWZpZXIsIHNjcmlwdFNvdXJjZSwgW3Byb3RlY3RlZFNlbGYgPSByZXRhaW5Q dHIoc2VsZiksIGNhcHR1cmVkQmxvY2sgPSBtYWtlQmxvY2tQdHIoV1RGTW92ZShjb21wbGV0aW9u SGFuZGxlcikpXSAoSW5zcGVjdG9yOjpFeHRlbnNpb25FdmFsdWF0aW9uUmVzdWx0JiYgcmVzdWx0 KSBtdXRhYmxlIHsKICAgICAgICAgaWYgKCFyZXN1bHQpIHsK