233737 2021-12-01 16:59:43 -0800 [Gstreamer] test http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html fails 2021-12-03 00:51:21 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Minor --- 1 crzwdjk crzwdjk eocanha eric.carlson ews-watchlist glenn jer.noble philipj pnormand sergio webkit-bug-importer oldest_to_newest 1819483 0 crzwdjk 2021-12-01 16:59:43 -0800 In r284365 the test http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html was fixed to give some more time to the frequency analyzer to detect activity. The same fix needs to be applied to http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html 1819485 1 445637 crzwdjk 2021-12-01 17:03:09 -0800 Created attachment 445637 Patch 1819608 2 pnormand 2021-12-02 00:45:08 -0800 I'm not sure adding a new timer is the solution here, it might just make the test flaky :( 1819738 3 eocanha 2021-12-02 09:49:24 -0800 In a 40 cores machine loaded with "stress -c 400" (10 times more than what the machine can process, showing a load of 395 when running top) the loop that samples the frequency data every 30 ms usually doesn't need extra iterations to get non-silence values. I ran the test (modified to end one second later on purpose) several times and I think only once or twice I got the need of one or two extra iterations at most. 100 ms would allow 3 extra iterations of the frequency sampler. I think that's enough, even on a loaded machine. If I was a reviewer (I'm not), I would accept the patch as is and increase the timeout if the test ever fails (flakes) again. 1819758 4 445637 pnormand 2021-12-02 10:21:16 -0800 Comment on attachment 445637 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445637&action=review > LayoutTests/http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html:46 > + }, 100); ok then please fix indentation here and you'll get the r+ you deserve 1819797 5 445749 crzwdjk 2021-12-02 11:15:29 -0800 Created attachment 445749 Patch 1820050 6 ews-feeder 2021-12-03 00:50:33 -0800 Committed r286486 (244825@main): <https://commits.webkit.org/244825@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445749. 1820051 7 webkit-bug-importer 2021-12-03 00:51:21 -0800 <rdar://problem/86008091> 445637 2021-12-01 17:03:09 -0800 2021-12-02 11:15:26 -0800 Patch bug-233737-20211201200308.patch text/plain 1927 crzwdjk U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MzQ1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOWIwNjNkNDYxMDhiZWVjYjc5YTIy ZGM4ZTFhODNkMzlhYzczZTIyYi4uM2YwOGQ5N2E4MTU1MzViZGJlZDM5YzE4ZjdlYmQ0ZDI0ZDMz NGUxZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTEyLTAxICBBcmNhZHkgR29sZG1pbnRz LU9ybG92ICA8YWdvbGRtaW50c0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHc3RyZWFtZXJdIHRl c3QgaHR0cC90ZXN0cy9zZWN1cml0eS93ZWJhdWRpby1yZW5kZXItcmVtb3RlLWF1ZGlvLWFsbG93 ZWQtY3Jvc3NvcmlnaW4uaHRtbCBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjMzNzM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgR2l2ZSBzb21lIG1vcmUgdGltZSB0byB0aGUgZnJlcXVlbmN5IGFu YWx5emVyIHRvIGRldGVjdCBhY3Rpdml0eS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvc2VjdXJp dHkvd2ViYXVkaW8tcmVuZGVyLXJlbW90ZS1hdWRpby1hbGxvd2VkLWNyb3Nzb3JpZ2luLmh0bWw6 CisKIDIwMjEtMTEtMzAgIFJvYmVydCBKZW5uZXIgIDxKZW5uZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIFJFQkFTRUxJTkUgWyBNb250ZXJleSBdZmFzdC9jc3MvY29udGludWF0aW9uQ3Jhc2guaHRt bCAobGF5b3V0LXRlc3QpIGlzIGEgY29uc3RhbnQgdGV4dCBmYWlsdXJlCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3dlYmF1ZGlvLXJlbmRlci1yZW1vdGUtYXVk aW8tYWxsb3dlZC1jcm9zc29yaWdpbi5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1 cml0eS93ZWJhdWRpby1yZW5kZXItcmVtb3RlLWF1ZGlvLWFsbG93ZWQtY3Jvc3NvcmlnaW4uaHRt bAppbmRleCA0NjcyODBjMmI1YjBiOTUzNDEzNTBiZjY2NjFiN2NmNTNmZDgzNGQxLi4yYWI4ODcw NGI4YmYwMDhmNTZjOTVjMmZhMzVmYzdhNjM0OGVhZDJhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3dlYmF1ZGlvLXJlbmRlci1yZW1vdGUtYXVkaW8tYWxsb3dl ZC1jcm9zc29yaWdpbi5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkv d2ViYXVkaW8tcmVuZGVyLXJlbW90ZS1hdWRpby1hbGxvd2VkLWNyb3Nzb3JpZ2luLmh0bWwKQEAg LTM3LDExICszNywxMyBAQAogICAgICAgICB9LCAzMCk7CiAKICAgICAgICAgYXVkaW8uYWRkRXZl bnRMaXN0ZW5lcigiZW5kZWQiLCBldmVudCA9PiB7Ci0gICAgICAgICAgICBjbGVhckludGVydmFs KGludGVydmFsVG9rZW4pOwotICAgICAgICAgICAgY29udGV4dC5zdXNwZW5kKCkudGhlbigoKSA9 PiB7Ci0gICAgICAgICAgICAgICAgc2hvdWxkTm90QmUoIm91dHB1dEFycmF5IiwgInNpbGVudEFy cmF5Iik7Ci0gICAgICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7Ci0gICAgICAgICAgICB9KTsK KyAgICAgICAgICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAgICAgY2xl YXJJbnRlcnZhbChpbnRlcnZhbFRva2VuKTsKKyAgICAgICAgICAgICAgICBjb250ZXh0LnN1c3Bl bmQoKS50aGVuKCgpID0+IHsKKyAgICAgICAgICAgICAgICAgICAgc2hvdWxkTm90QmUoIm91dHB1 dEFycmF5IiwgInNpbGVudEFycmF5Iik7CisgICAgICAgICAgICAgICAgICAgIGZpbmlzaEpTVGVz dCgpOworICAgICAgICAgICAgICAgIH0pOworCSAgICB9LCAxMDApOwogICAgICAgICB9KTsKICAg ICB9CiAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBnbyk7Cg== 445749 2021-12-02 11:15:29 -0800 2021-12-03 00:50:34 -0800 Patch bug-233737-20211202141528.patch text/plain 1915 crzwdjk U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NDM0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTA2ZTYxNjNmZGZlNTZhMWY0OGEy MWNmOWFhZGQ2NDhkZjQ2NmRhYS4uMzc5NjA5YjZlNTRmY2NmZTMwMDlkNzNiNzYxNzRiMDljNmE5 ZWJlZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTEyLTAyICBBcmNhZHkgR29sZG1pbnRz LU9ybG92ICA8YWdvbGRtaW50c0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHU3RyZWFtZXJdIHRl c3QgaHR0cC90ZXN0cy9zZWN1cml0eS93ZWJhdWRpby1yZW5kZXItcmVtb3RlLWF1ZGlvLWFsbG93 ZWQtY3Jvc3NvcmlnaW4uaHRtbCBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjMzNzM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgR2l2ZSBzb21lIG1vcmUgdGltZSB0byB0aGUgZnJlcXVlbmN5IGFu YWx5emVyIHRvIGRldGVjdCBhY3Rpdml0eS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvc2VjdXJp dHkvd2ViYXVkaW8tcmVuZGVyLXJlbW90ZS1hdWRpby1hbGxvd2VkLWNyb3Nzb3JpZ2luLmh0bWw6 CisKIDIwMjEtMTItMDIgIFR5bGVyIFdpbGNvY2sgIDx0eWxlcl93QGFwcGxlLmNvbT4KIAogICAg ICAgICBBWCBJc29sYXRlZCBUcmVlOiBEb2N1bWVudCBsaW5rcyBzaG91bGQgYmUgc3RvcmVkIGlu IHdlYiBhcmVhcywgbm90IHRoZSByb290CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL3NlY3VyaXR5L3dlYmF1ZGlvLXJlbmRlci1yZW1vdGUtYXVkaW8tYWxsb3dlZC1jcm9zc29y aWdpbi5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS93ZWJhdWRpby1yZW5k ZXItcmVtb3RlLWF1ZGlvLWFsbG93ZWQtY3Jvc3NvcmlnaW4uaHRtbAppbmRleCA0NjcyODBjMmI1 YjBiOTUzNDEzNTBiZjY2NjFiN2NmNTNmZDgzNGQxLi5lOGIyYjkzZTg5ZGE1MTAxMmQ2MTFhODA2 MDRhOGNkZGZlYjc3NDg3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3Vy aXR5L3dlYmF1ZGlvLXJlbmRlci1yZW1vdGUtYXVkaW8tYWxsb3dlZC1jcm9zc29yaWdpbi5odG1s CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvd2ViYXVkaW8tcmVuZGVyLXJl bW90ZS1hdWRpby1hbGxvd2VkLWNyb3Nzb3JpZ2luLmh0bWwKQEAgLTM3LDExICszNywxMyBAQAog ICAgICAgICB9LCAzMCk7CiAKICAgICAgICAgYXVkaW8uYWRkRXZlbnRMaXN0ZW5lcigiZW5kZWQi LCBldmVudCA9PiB7Ci0gICAgICAgICAgICBjbGVhckludGVydmFsKGludGVydmFsVG9rZW4pOwot ICAgICAgICAgICAgY29udGV4dC5zdXNwZW5kKCkudGhlbigoKSA9PiB7Ci0gICAgICAgICAgICAg ICAgc2hvdWxkTm90QmUoIm91dHB1dEFycmF5IiwgInNpbGVudEFycmF5Iik7Ci0gICAgICAgICAg ICAgICAgZmluaXNoSlNUZXN0KCk7Ci0gICAgICAgICAgICB9KTsKKyAgICAgICAgICAgIHNldFRp bWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAgICAgY2xlYXJJbnRlcnZhbChpbnRlcnZh bFRva2VuKTsKKyAgICAgICAgICAgICAgICBjb250ZXh0LnN1c3BlbmQoKS50aGVuKCgpID0+IHsK KyAgICAgICAgICAgICAgICAgICAgc2hvdWxkTm90QmUoIm91dHB1dEFycmF5IiwgInNpbGVudEFy cmF5Iik7CisgICAgICAgICAgICAgICAgICAgIGZpbmlzaEpTVGVzdCgpOworICAgICAgICAgICAg ICAgIH0pCisgICAgICAgICAgICB9LCAxMDApOwogICAgICAgICB9KTsKICAgICB9CiAgICAgd2lu ZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBnbyk7Cg==