233720 2021-12-01 13:23:23 -0800 Add static_assert the value we use to initialize a StructureID buffer should be 0. 2021-12-01 14:25:24 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=233379 InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam mcatanzaro msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1819381 0 keith_miller 2021-12-01 13:23:23 -0800 Fix GCC warning about memcpy into a StructureID* buffer 1819383 1 445606 keith_miller 2021-12-01 13:24:00 -0800 Created attachment 445606 Patch 1819385 2 445606 ysuzuki 2021-12-01 13:26:16 -0800 Comment on attachment 445606 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445606&action=review > Source/JavaScriptCore/runtime/StructureChain.cpp:52 > + static_assert(!StructureID().bits(), "Make sure the value we're going to memcpy below matches the default StructureID"); This part looks good. > Source/JavaScriptCore/runtime/StructureID.h:55 > + constexpr uint32_t bits() const { return m_bits; } Nice. 1819390 3 445607 keith_miller 2021-12-01 13:32:47 -0800 Created attachment 445607 Patch for landing 1819396 4 445607 mcatanzaro 2021-12-01 13:45:21 -0800 Comment on attachment 445607 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=445607&action=review > Source/JavaScriptCore/runtime/StructureChain.cpp:53 > memset(vector, 0, bytes); I'm skeptical that would be enough to suppress this warning. We'll probably need to do: memset(static_cast<void*>(vector), 0, bytes); If your patch alone isn't enough, I'll just commit this as a follow-up. 1819398 5 keith_miller 2021-12-01 13:46:17 -0800 (In reply to Michael Catanzaro from comment #4) > Comment on attachment 445607 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445607&action=review > > > Source/JavaScriptCore/runtime/StructureChain.cpp:53 > > memset(vector, 0, bytes); > > I'm skeptical that would be enough to suppress this warning. We'll probably > need to do: > > memset(static_cast<void*>(vector), 0, bytes); > > If your patch alone isn't enough, I'll just commit this as a follow-up. Oh, this is just the static_assert now since Yusuke already landed a cast change. 1819399 6 mcatanzaro 2021-12-01 13:47:12 -0800 Ack, see: bug #233379 for the warning fix. 1819415 7 ews-feeder 2021-12-01 14:24:50 -0800 Committed r286387 (244744@main): <https://commits.webkit.org/244744@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445607. 1819416 8 webkit-bug-importer 2021-12-01 14:25:24 -0800 <rdar://problem/85939821> 445606 2021-12-01 13:24:00 -0800 2021-12-01 13:32:44 -0800 Patch bug-233720-20211201162359.patch text/plain 2807 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2Mzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 MDJiNGI3ZWYwYmQxNTBlNjVhYTRlMzYwZDcwMGZmNWM2MTAxOTg4Li45OWMxZDMyM2RiMTgxYmIx ZjA2MmVkZTdhYTU2YjU4ZDNmY2E4MDIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMS0xMi0wMSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGaXggR0NDIHdhcm5pbmcgYWJvdXQgbWVtY3B5IGludG8gYSBTdHJ1 Y3R1cmVJRCogYnVmZmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzM3MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBbHNvLCBhZGQgc3RhdGljIGFzc2VydCB0aGF0IHRoZSB6ZXJvIHdlIGFyZSBwdXR0 aW5nIGludG8gdGhlIGJ1ZmZlcgorICAgICAgICBtYXRjaGVzIHRoZSBkZWZhdWx0IFN0cnVjdHVy ZUlEIGNvbnN0cnVjdG9yLgorCisgICAgICAgICogcnVudGltZS9TdHJ1Y3R1cmVDaGFpbi5jcHA6 CisgICAgICAgIChKU0M6OlN0cnVjdHVyZUNoYWluOjpjcmVhdGUpOgorICAgICAgICAqIHJ1bnRp bWUvU3RydWN0dXJlSUQuaDoKKyAgICAgICAgKEpTQzo6U3RydWN0dXJlSUQ6OmJpdHMgY29uc3Qp OgorCiAyMDIxLTEyLTAxICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgZml4IENMb29wIGJ1aWxkCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmVDaGFpbi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9TdHJ1Y3R1cmVDaGFpbi5jcHAKaW5kZXggYTk3YmM3MmNlMmQxOWJiYjE5 OWJmYzE0NDYxY2JkMzc2YTA4ZGE1MS4uZWI1ZmEzMTE1MWIzNjUyNDQ1NmJjMzVmOGU4ZGNmYzM4 MWM1MGRkMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0 dXJlQ2hhaW4uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVy ZUNoYWluLmNwcApAQCAtNDksNyArNDksOCBAQCBTdHJ1Y3R1cmVDaGFpbiogU3RydWN0dXJlQ2hh aW46OmNyZWF0ZShWTSYgdm0sIEpTT2JqZWN0KiBoZWFkKQogICAgICsrc2l6ZTsgLy8gU2VudGlu ZWwgbnVsbHB0ci4KICAgICBzaXplX3QgYnl0ZXMgPSBDaGVja2VkPHNpemVfdD4oc2l6ZSkgKiBz aXplb2YoU3RydWN0dXJlSUQpOwogICAgIFN0cnVjdHVyZUlEKiB2ZWN0b3IgPSBzdGF0aWNfY2Fz dDxTdHJ1Y3R1cmVJRCo+KHZtLmpzVmFsdWVHaWdhY2FnZUF1eGlsaWFyeVNwYWNlKCkuYWxsb2Nh dGVOb25WaXJ0dWFsKHZtLCBieXRlcywgbnVsbHB0ciwgQWxsb2NhdGlvbkZhaWx1cmVNb2RlOjpB c3NlcnQpKTsKLSAgICBtZW1zZXQodmVjdG9yLCAwLCBieXRlcyk7CisgICAgc3RhdGljX2Fzc2Vy dCghU3RydWN0dXJlSUQoKS5iaXRzKCksICJNYWtlIHN1cmUgdGhlIHZhbHVlIHdlJ3JlIGdvaW5n IHRvIG1lbWNweSBiZWxvdyBtYXRjaGVzIHRoZSBkZWZhdWx0IFN0cnVjdHVyZUlEIik7CisgICAg bWVtc2V0KHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KHZlY3RvciksIDAsIGJ5dGVzKTsKICAgICBT dHJ1Y3R1cmVDaGFpbiogY2hhaW4gPSBuZXcgKE5vdE51bGwsIGFsbG9jYXRlQ2VsbDxTdHJ1Y3R1 cmVDaGFpbj4odm0pKSBTdHJ1Y3R1cmVDaGFpbih2bSwgdm0uc3RydWN0dXJlQ2hhaW5TdHJ1Y3R1 cmUuZ2V0KCksIHZlY3Rvcik7CiAgICAgY2hhaW4tPmZpbmlzaENyZWF0aW9uKHZtLCBoZWFkKTsK ICAgICByZXR1cm4gY2hhaW47CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9TdHJ1Y3R1cmVJRC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0 dXJlSUQuaAppbmRleCBiOWFmZjY3YzAwNGY5YTY3MzY1MTk0YTFiNjYwZGU1YzJiOGI0MWYyLi4w OWJlMGJlODc0NDEzYTdmYTI5MDAyZTBiYmIwMTIzZDg5ZjEwYmFjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmVJRC5oCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZUlELmgKQEAgLTUyLDcgKzUyLDcgQEAgcHVibGlj OgogICAgIGV4cGxpY2l0IG9wZXJhdG9yIGJvb2woKSBjb25zdCB7IHJldHVybiAhIW1fYml0czsg fQogICAgIGJvb2wgb3BlcmF0b3I9PShTdHJ1Y3R1cmVJRCBjb25zdCYgb3RoZXIpIGNvbnN0ICB7 IHJldHVybiBtX2JpdHMgPT0gb3RoZXIubV9iaXRzOyB9CiAgICAgYm9vbCBvcGVyYXRvciE9KFN0 cnVjdHVyZUlEIGNvbnN0JiBvdGhlcikgY29uc3QgIHsgcmV0dXJuIG1fYml0cyAhPSBvdGhlci5t X2JpdHM7IH0KLSAgICB1aW50MzJfdCBiaXRzKCkgY29uc3QgeyByZXR1cm4gbV9iaXRzOyB9Cisg ICAgY29uc3RleHByIHVpbnQzMl90IGJpdHMoKSBjb25zdCB7IHJldHVybiBtX2JpdHM7IH0KIAog ICAgIFN0cnVjdHVyZUlEKFdURjo6SGFzaFRhYmxlRGVsZXRlZFZhbHVlVHlwZSkgOiBtX2JpdHMo bnVrZWRTdHJ1Y3R1cmVJREJpdCkgeyB9CiAgICAgYm9vbCBpc0hhc2hUYWJsZURlbGV0ZWRWYWx1 ZSgpIGNvbnN0IHsgcmV0dXJuICp0aGlzID09IFN0cnVjdHVyZUlEKFdURjo6SGFzaFRhYmxlRGVs ZXRlZFZhbHVlKTsgfQo= 445607 2021-12-01 13:32:47 -0800 2021-12-01 14:24:51 -0800 Patch for landing bug-233720-20211201163246.patch text/plain 2769 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MzgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 Y2UwZGViNGM2NDEzYjg5NmJkZmM2OTBlYzBkMTAyYmEwMmEzNDFiLi5iMzgyYmIxNWFkMGQ0Yzc1 MGUxNDZiZWVjODMzZGIxZGQxNjdhZTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMS0xMi0wMSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBBZGQgc3RhdGljX2Fzc2VydCB0aGUgdmFsdWUgd2UgdXNlIHRvIGlu aXRpYWxpemUgYSBTdHJ1Y3R1cmVJRCBidWZmZXIgc2hvdWxkIGJlIDAuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzM3MjAKKworICAgICAgICBSZXZp ZXdlZCBieSBZdXN1a2UgU3V6dWtpLgorCisgICAgICAgIEFsc28sIGFkZCBzdGF0aWMgYXNzZXJ0 IHRoYXQgdGhlIHplcm8gd2UgYXJlIHB1dHRpbmcgaW50byB0aGUgYnVmZmVyCisgICAgICAgIG1h dGNoZXMgdGhlIGRlZmF1bHQgU3RydWN0dXJlSUQgY29uc3RydWN0b3IuCisKKyAgICAgICAgKiBy dW50aW1lL1N0cnVjdHVyZUNoYWluLmNwcDoKKyAgICAgICAgKEpTQzo6U3RydWN0dXJlQ2hhaW46 OmNyZWF0ZSk6CisgICAgICAgICogcnVudGltZS9TdHJ1Y3R1cmVJRC5oOgorICAgICAgICAoSlND OjpTdHJ1Y3R1cmVJRDo6Yml0cyBjb25zdCk6CisKIDIwMjEtMTItMDEgIFl1c3VrZSBTdXp1a2kg IDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCB1c2Ugdm9pZCogdG8g c3VwcHJlc3MgR0NDIHdhcm5pbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1N0cnVjdHVyZUNoYWluLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1N0cnVjdHVyZUNoYWluLmNwcAppbmRleCAxYWQ4MmYzMjM4YmI1NGU1ZDg1NTIxZjU0ZWQ5MGM3 MDZkZjZjOTdjLi42OWM3N2Q1OTRjODBhYTBiNDFiYTE3YjE3YjQ2NGE2N2M3MzRlYjExIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmVDaGFpbi5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlQ2hhaW4uY3BwCkBA IC00OSw2ICs0OSw3IEBAIFN0cnVjdHVyZUNoYWluKiBTdHJ1Y3R1cmVDaGFpbjo6Y3JlYXRlKFZN JiB2bSwgSlNPYmplY3QqIGhlYWQpCiAgICAgKytzaXplOyAvLyBTZW50aW5lbCBudWxscHRyLgog ICAgIHNpemVfdCBieXRlcyA9IENoZWNrZWQ8c2l6ZV90PihzaXplKSAqIHNpemVvZihTdHJ1Y3R1 cmVJRCk7CiAgICAgdm9pZCogdmVjdG9yID0gdm0uanNWYWx1ZUdpZ2FjYWdlQXV4aWxpYXJ5U3Bh Y2UoKS5hbGxvY2F0ZU5vblZpcnR1YWwodm0sIGJ5dGVzLCBudWxscHRyLCBBbGxvY2F0aW9uRmFp bHVyZU1vZGU6OkFzc2VydCk7CisgICAgc3RhdGljX2Fzc2VydCghU3RydWN0dXJlSUQoKS5iaXRz KCksICJNYWtlIHN1cmUgdGhlIHZhbHVlIHdlJ3JlIGdvaW5nIHRvIG1lbWNweSBiZWxvdyBtYXRj aGVzIHRoZSBkZWZhdWx0IFN0cnVjdHVyZUlEIik7CiAgICAgbWVtc2V0KHZlY3RvciwgMCwgYnl0 ZXMpOwogICAgIFN0cnVjdHVyZUNoYWluKiBjaGFpbiA9IG5ldyAoTm90TnVsbCwgYWxsb2NhdGVD ZWxsPFN0cnVjdHVyZUNoYWluPih2bSkpIFN0cnVjdHVyZUNoYWluKHZtLCB2bS5zdHJ1Y3R1cmVD aGFpblN0cnVjdHVyZS5nZXQoKSwgc3RhdGljX2Nhc3Q8U3RydWN0dXJlSUQqPih2ZWN0b3IpKTsK ICAgICBjaGFpbi0+ZmluaXNoQ3JlYXRpb24odm0sIGhlYWQpOwpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlSUQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1N0cnVjdHVyZUlELmgKaW5kZXggYjlhZmY2N2MwMDRmOWE2NzM2NTE5NGEx YjY2MGRlNWMyYjhiNDFmMi4uMDliZTBiZTg3NDQxM2E3ZmEyOTAwMmUwYmJiMDEyM2Q4OWYxMGJh YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlSUQu aAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmVJRC5oCkBAIC01 Miw3ICs1Miw3IEBAIHB1YmxpYzoKICAgICBleHBsaWNpdCBvcGVyYXRvciBib29sKCkgY29uc3Qg eyByZXR1cm4gISFtX2JpdHM7IH0KICAgICBib29sIG9wZXJhdG9yPT0oU3RydWN0dXJlSUQgY29u c3QmIG90aGVyKSBjb25zdCAgeyByZXR1cm4gbV9iaXRzID09IG90aGVyLm1fYml0czsgfQogICAg IGJvb2wgb3BlcmF0b3IhPShTdHJ1Y3R1cmVJRCBjb25zdCYgb3RoZXIpIGNvbnN0ICB7IHJldHVy biBtX2JpdHMgIT0gb3RoZXIubV9iaXRzOyB9Ci0gICAgdWludDMyX3QgYml0cygpIGNvbnN0IHsg cmV0dXJuIG1fYml0czsgfQorICAgIGNvbnN0ZXhwciB1aW50MzJfdCBiaXRzKCkgY29uc3QgeyBy ZXR1cm4gbV9iaXRzOyB9CiAKICAgICBTdHJ1Y3R1cmVJRChXVEY6Okhhc2hUYWJsZURlbGV0ZWRW YWx1ZVR5cGUpIDogbV9iaXRzKG51a2VkU3RydWN0dXJlSURCaXQpIHsgfQogICAgIGJvb2wgaXNI YXNoVGFibGVEZWxldGVkVmFsdWUoKSBjb25zdCB7IHJldHVybiAqdGhpcyA9PSBTdHJ1Y3R1cmVJ RChXVEY6Okhhc2hUYWJsZURlbGV0ZWRWYWx1ZSk7IH0K