233712 2021-12-01 10:40:55 -0800 REGRESSION(r286209) [GTK][WPE] crashes in offscreen canvas tests that try to create a GL context 2021-12-02 06:13:23 -0800 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=233517 InRadar P2 Major --- 1 crzwdjk kkinnunen bugs-noreply cdumez changseok clord dino esprehn+autocc ews-watchlist gyuyoung.kim kkinnunen koivisto kondapallykalyan lmoura webkit-bug-importer oldest_to_newest 1819316 0 crzwdjk 2021-12-01 10:40:55 -0800 The change in r286209 has caused a number of crashes in offscreen canvas tests on GTK and WPE (which only run on GTK and WPE): http/wpt/offscreen-canvas/getContext-webgl.html [ Crash ] http/wpt/offscreen-canvas/transferToImageBitmap-webgl.html [ Crash ] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.getcontext.html [ Crash ] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.getcontext.worker.html [ Crash ] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.resize.html [ Crash ] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transfer.to.imagebitmap.html [ Crash ] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transfer.to.imagebitmap.w.html [ Crash ] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transferrable.html [ Crash ] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transferrable.w.html [ Crash ] With a backtrace like the following: #0 0x00007f806d263347 in WebCore::WebGLRenderingContextBase::create(WebCore::CanvasBase&, WebCore::GraphicsContextGLAttributes&, WebCore::GraphicsContextGLWebGLVersion) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0 #1 0x00007f806d1e9ccc in WebCore::OffscreenCanvas::createContextWebGL(WebCore::OffscreenCanvas::RenderingContextType, WebCore::GraphicsContextGLAttributes&&) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0 #2 0x00007f806d1ea02e in WebCore::OffscreenCanvas::getContext(JSC::JSGlobalObject&, WebCore::OffscreenCanvas::RenderingContextType, WTF::Vector<JSC::Strong<JSC::Unknown, (JSC::ShouldStrongDestructorGrabLock)0>, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0 #3 0x00007f806c2e0447 in WebCore::jsOffscreenCanvasPrototypeFunction_getContext(JSC::JSGlobalObject*, JSC::CallFrame*) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0 #4 0x00007f8021cff1d8 in () #5 0x00007fff5faf3cb0 in () #6 0x00007f80682dc20d in op_call_slow_return_location () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.1.so.0 #7 0x0000000000000000 in () Not having debugged this in depth, my suspicion is that this change is not taking into account the offscreen case where hostWindow is null. 1819660 1 445712 kkinnunen 2021-12-02 05:02:59 -0800 Created attachment 445712 Patch 1819670 2 ews-feeder 2021-12-02 06:11:58 -0800 Committed r286422 (244768@main): <https://commits.webkit.org/244768@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445712. 1819671 3 webkit-bug-importer 2021-12-02 06:13:23 -0800 <rdar://problem/85968413> 445712 2021-12-02 05:02:59 -0800 2021-12-02 06:12:00 -0800 Patch bug-233712-20211202150257.patch text/plain 2146 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzMzYTA3NDllZDhiZDYy ODdhY2E1NzVlNmE1ZmQyYzhlNDVlZTYzZC4uODI0ZGVkZWFlNDQ1ODI2MzAzMzViODAyNGI1ZWFj NjE4NDcyYTAwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTEyLTAyICBLaW1t byBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihy Mjg2MjA5KSBbR1RLXVtXUEVdIGNyYXNoZXMgaW4gb2Zmc2NyZWVuIGNhbnZhcyB0ZXN0cyB0aGF0 IHRyeSB0byBjcmVhdGUgYSBHTCBjb250ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzM3MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXggYSBjcmFzaCBmb3IgcG9ydHMgdGhhdCB1c2Ugb2Zmc2Ny ZWVuIGNhbnZhcyBXZWJHTC4KKyAgICAgICAgQ3VycmVudGx5IHdlIGRvIG5vdCBoYXZlIGNvZGUg dG8gbmF2aWdhdGUgZnJvbSBvZmZzY3JlZW4gY2FudmFzCisgICAgICAgIENhbnZhc0Jhc2UgdG8g Q2hyb21lQ2xpZW50LiBGb3IgdGhpcyBjYXNlIGl0IGRvZXNuJ3QgbWF0dGVyLCBhcworICAgICAg ICBHUFVQIGRvZXMgbm90IHN1cHBvcnQgb2Zmc2NyZWVuIGNhbnZhcyBpbiBtZWFuaW5nZnVsIHdh eQorICAgICAgICBhbnl3YXkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0ZXN0ZWQgYnkgZXhp c3RpbmcgdGVzdC4KKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4 dEJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZTo6 Y3JlYXRlKToKKwogMjAyMS0xMi0wMiAgS2ltbW8gS2lubnVuZW4gIDxra2lubnVuZW5AYXBwbGUu Y29tPgogCiAgICAgICAgIE5ldHdvcmsgcHJvY2VzcyBkb2VzIG5vdCBzZWVtIHRvIGluaXRpYWxp emUgbG9nZ2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xS ZW5kZXJpbmdDb250ZXh0QmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJH TFJlbmRlcmluZ0NvbnRleHRCYXNlLmNwcAppbmRleCBmZWQxZjIyODdhNzMzNjIwZTg2ZGE0Zjkx MWZmYWFlYTZiMjNhOTJlLi5hYzgxZDhjOTMyNDQ0N2NlYjdmYTM4ZTMzYTk2OWFmYzFhMDM4NGEw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0Nv bnRleHRCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRl cmluZ0NvbnRleHRCYXNlLmNwcApAQCAtODYwLDcgKzg2MCwxMyBAQCBzdGQ6OnVuaXF1ZV9wdHI8 V2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZT4gV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZTo6Y3Jl YXRlKENhbgogICAgICAgICByZW5kZXJpbmdDb250ZXh0LT5zdXNwZW5kSWZOZWVkZWQoKTsKICAg ICAgICAgcmV0dXJuIHJlbmRlcmluZ0NvbnRleHQ7CiAgICAgfQotICAgIGF1dG8gY29udGV4dCA9 IGhvc3RXaW5kb3ctPmNyZWF0ZUdyYXBoaWNzQ29udGV4dEdMKGF0dHJpYnV0ZXMpOworICAgIFJl ZlB0cjxHcmFwaGljc0NvbnRleHRHTD4gY29udGV4dDsKKyAgICBpZiAoaG9zdFdpbmRvdykKKyAg ICAgICAgY29udGV4dCA9IGhvc3RXaW5kb3ctPmNyZWF0ZUdyYXBoaWNzQ29udGV4dEdMKGF0dHJp YnV0ZXMpOworICAgIGVsc2UgeworICAgICAgICAvLyBGSVhNRTogT2Zmc2NyZWVuQ2FudmFzIGRv ZXMgbm90IHN1cHBvcnQgR1BVIHByb2Nlc3MuCisgICAgICAgIGNvbnRleHQgPSBjcmVhdGVXZWJQ cm9jZXNzR3JhcGhpY3NDb250ZXh0R0woYXR0cmlidXRlcyk7CisgICAgfQogICAgIGlmICghY29u dGV4dCkgewogICAgICAgICBpZiAoY2FudmFzRWxlbWVudCkgewogICAgICAgICAgICAgY2FudmFz RWxlbWVudC0+ZGlzcGF0Y2hFdmVudChXZWJHTENvbnRleHRFdmVudDo6Y3JlYXRlKGV2ZW50TmFt ZXMoKS53ZWJnbGNvbnRleHRjcmVhdGlvbmVycm9yRXZlbnQsCg==