233701 2021-12-01 07:27:40 -0800 Regression(r283912) Broke backward compatibility for Swift bindings 2021-12-01 09:45:43 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 231496 1 cdumez cdumez achristensen darin ddkilzer ggaren sam webkit-bug-importer oldest_to_newest 1819224 0 cdumez 2021-12-01 07:27:40 -0800 r283912 broke backward compatibility for Swift bindings. 1819225 1 cdumez 2021-12-01 07:27:51 -0800 <rdar://85627701> 1819226 2 445573 cdumez 2021-12-01 07:29:55 -0800 Created attachment 445573 Patch 1819274 3 darin 2021-12-01 09:18:30 -0800 How do we *eventually* make this change? Is there any way to deprecate the old name and move to the new one over time? 1819281 4 cdumez 2021-12-01 09:30:14 -0800 (In reply to Darin Adler from comment #3) > How do we *eventually* make this change? Is there any way to deprecate the > old name and move to the new one over time? This is WebKitLegacy, do we really have to worry about updating it? 1819282 5 darin 2021-12-01 09:32:02 -0800 (In reply to Chris Dumez from comment #4) > This is WebKitLegacy, do we really have to worry about updating it? I see your point. I agree that we don’t. 1819291 6 ews-feeder 2021-12-01 09:45:40 -0800 Committed r286367 (244726@main): <https://commits.webkit.org/244726@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445573. 445573 2021-12-01 07:29:55 -0800 2021-12-01 09:45:41 -0800 Patch bug-233701-20211201072954.patch text/plain 2743 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggNTAxZDUwMWFiMzgwMTdmMWQ4ZjllODFjOWJlZmRjMmQ3ZjZmMTZmZS4uMmRlNzg5MWQ0NzQw ODA1NmVlOGQ4NzUwNWQxNGMxNGJhYzI5NjE1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTEyLTAxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMjgzOTEyKSBCcm9rZSBiYWNrd2FyZCBjb21w YXRpYmlsaXR5IGZvciBTd2lmdCBiaW5kaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzNzAxCisgICAgICAgIDxyZGFyOi8vODU2Mjc3MDE+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVuYW1lIEVw b2NoVGltZVN0YW1wIGJhY2sgdG8gRE9NVGltZVN0YW1wIGluIERPTU9iamVjdC5oICYgRE9NRXZl bnQuaAorICAgICAgICBzaW5jZSB0aG9zZSBhcmUgQVBJIGhlYWRlcnMgYW5kIHdlIG5lZWQgdG8g bWFpbnRhaW4gYmFja3dhcmQgY29tcGF0aWJpbGl0eS4KKworICAgICAgICAqIERPTS9ET01FdmVu dC5oOgorICAgICAgICAqIERPTS9ET01FdmVudC5tbToKKyAgICAgICAgKC1bRE9NRXZlbnQgdGlt ZVN0YW1wXSk6CisgICAgICAgICogRE9NL0RPTU9iamVjdC5oOgorCiAyMDIxLTExLTI0ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgQ29tcGlsZXIgc2hvdWxk IGJlIGFibGUgdG8gY2hlY2sgbG9jYWxpemVkIGZvcm1hdCBzdHJpbmdzIGZvciBjb25zaXN0ZW5j eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvRE9NL0RPTUV2ZW50LmggYi9T b3VyY2UvV2ViS2l0TGVnYWN5L21hYy9ET00vRE9NRXZlbnQuaAppbmRleCBjZDQwMjQ3ZGYzNWJi ZWY3YTNiY2ZhZmE3YzQyYzc3ZTc3YjNkZTA4Li44OWQzMmIzMTljMjg0ZDU3M2NmZGRjMGY4Yjhj YWRjYjA0NmYwZWZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9ET00vRE9N RXZlbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9ET00vRE9NRXZlbnQuaApAQCAt NDMsNyArNDMsNyBAQCBXRUJLSVRfQ0xBU1NfREVQUkVDQVRFRF9NQUMoMTBfNCwgMTBfMTQpCiBA cHJvcGVydHkgKHJlYWRvbmx5KSB1bnNpZ25lZCBzaG9ydCBldmVudFBoYXNlOwogQHByb3BlcnR5 IChyZWFkb25seSkgQk9PTCBidWJibGVzOwogQHByb3BlcnR5IChyZWFkb25seSkgQk9PTCBjYW5j ZWxhYmxlOwotQHByb3BlcnR5IChyZWFkb25seSkgRXBvY2hUaW1lU3RhbXAgdGltZVN0YW1wOwor QHByb3BlcnR5IChyZWFkb25seSkgRE9NVGltZVN0YW1wIHRpbWVTdGFtcDsKIEBwcm9wZXJ0eSAo cmVhZG9ubHksIHN0cm9uZykgaWQgPERPTUV2ZW50VGFyZ2V0PiBzcmNFbGVtZW50IFdFQktJVF9B VkFJTEFCTEVfTUFDKDEwXzYpOwogQHByb3BlcnR5IEJPT0wgcmV0dXJuVmFsdWUgV0VCS0lUX0FW QUlMQUJMRV9NQUMoMTBfNik7CiBAcHJvcGVydHkgQk9PTCBjYW5jZWxCdWJibGUgV0VCS0lUX0FW QUlMQUJMRV9NQUMoMTBfNik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9E T00vRE9NRXZlbnQubW0gYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9ET00vRE9NRXZlbnQubW0K aW5kZXggYjA2MDEwNjA2NzgxZDgyYzYxZjFhMmZmMGU3ZTIwN2ZhZmQwMTg4NS4uZGZhMzViNDFi ZTYyY2RkYzc4ZDFmZDA3YTA5NjE2MTliNWJjZGIwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dExlZ2FjeS9tYWMvRE9NL0RPTUV2ZW50Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFj L0RPTS9ET01FdmVudC5tbQpAQCAtOTQsNyArOTQsNyBAQCAtIChCT09MKWNvbXBvc2VkCiAgICAg cmV0dXJuIElNUEwtPmNvbXBvc2VkKCk7CiB9CiAKLS0gKEVwb2NoVGltZVN0YW1wKXRpbWVTdGFt cAorLSAoRE9NVGltZVN0YW1wKXRpbWVTdGFtcAogewogICAgIFdlYkNvcmU6OkpTTWFpblRocmVh ZE51bGxTdGF0ZSBzdGF0ZTsKICAgICByZXR1cm4gSU1QTC0+dGltZVN0YW1wKCkuYXBwcm94aW1h dGVXYWxsVGltZSgpLnNlY29uZHNTaW5jZUVwb2NoKCkubWlsbGlzZWNvbmRzKCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9ET00vRE9NT2JqZWN0LmggYi9Tb3VyY2UvV2Vi S2l0TGVnYWN5L21hYy9ET00vRE9NT2JqZWN0LmgKaW5kZXggZWI0MTIzNDI5YzRlZTY1ODEwYzNj N2E0MDcyMjcwNzIyNTMzZjViMC4uNzI1MmQ4YTRjNzg0NzY0ZDQwYmM0YTEwOWNiYWIxOWExMjRk NTgwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvRE9NL0RPTU9iamVjdC5o CisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0RPTS9ET01PYmplY3QuaApAQCAtMjksNyAr MjksNyBAQAogCiBAY2xhc3MgRE9NU3R5bGVTaGVldDsKIAotdHlwZWRlZiB1bnNpZ25lZCBsb25n IGxvbmcgRXBvY2hUaW1lU3RhbXA7Cit0eXBlZGVmIHVuc2lnbmVkIGxvbmcgbG9uZyBET01UaW1l U3RhbXA7CiAKIHR5cGVkZWYgc3RydWN0IERPTU9iamVjdEludGVybmFsIERPTU9iamVjdEludGVy bmFsOwogCg==