233689 2021-11-30 23:58:13 -0800 REGRESSION (r286346): ResourceLoadDelegate.LoadInfo fails 2021-12-01 11:38:20 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton achristensen darin simon.fraser webkit-bug-importer oldest_to_newest 1819130 0 thorton 2021-11-30 23:58:13 -0800 REGRESSION (r286346): ResourceLoadDelegate.LoadInfo fails 1819131 1 445533 thorton 2021-11-30 23:58:50 -0800 Created attachment 445533 Patch 1819294 2 ews-feeder 2021-12-01 09:50:38 -0800 Committed r286368 (244727@main): <https://commits.webkit.org/244727@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445533. 1819298 3 webkit-bug-importer 2021-12-01 09:51:35 -0800 <rdar://problem/85926760> 1819301 4 445533 darin 2021-12-01 09:59:11 -0800 Comment on attachment 445533 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445533&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:-382 > - EXPECT_EQ(archiveData.length, 607ull); Another comment from my new crusade, on this deleted code, so that observers will learn what I have recently learned: This is backwards, the actual value first and then the expected. The GTest macros take the expected value first and the actual value second. Getting this right helps the clarity of the message when the expectation is not met. 1819342 5 darin 2021-12-01 11:38:20 -0800 (In reply to Darin Adler from comment #4) > Another comment from my new crusade, on this deleted code, so that observers > will learn what I have recently learned: This is backwards, the actual value > first and then the expected. The GTest macros take the expected value first > and the actual value second. Getting this right helps the clarity of the > message when the expectation is not met. Now I am not sure; the error message someone mentioned in a Slack discussion seems to be more even-handed than I thought, so my comment may be out of date. 445533 2021-11-30 23:58:50 -0800 2021-12-01 09:50:40 -0800 Patch bug-233689-20211130235849.patch text/plain 2771 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MzQ4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmU0ODQ3MTdkNGFiNDM3YmVlNjg2N2YzMzgwODc0YTdi N2NhZmU3NC4uMWFmMDMxMzIwZDM4OTM5YjFkYTdlYjlmYTdmOWNhODY2YjdiOGRmNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0 IEBACisyMDIxLTExLTMwICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgor CisgICAgICAgIFJFR1JFU1NJT04gKHIyODYzNDYpOiBSZXNvdXJjZUxvYWREZWxlZ2F0ZS5Mb2Fk SW5mbyBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMzNjg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Jlc291cmNlTG9hZERlbGVnYXRl Lm1tOgorICAgICAgICBUaGlzIHRlc3QgYXNzZXJ0cyB0aGF0IGFyY2hpdmluZyBhIF9XS1Jlc291 cmNlTG9hZEluZm8gdmlhIE5TS2V5ZWRBcmNoaXZlcgorICAgICAgICBlbmNvZGVzIHRvIGEgcGFy dGljdWxhciBzaXplICg2MDcgYnl0ZXMpLgorCisgICAgICAgIElmIHlvdSBsb29rIGF0IHRoZSBy ZXN1bHRhbnQgcGxpc3QgYmVmb3JlIHIyODYzNDYsIHRoZSBlbmNvZGVkIGZyYW1lSUQKKyAgICAg ICAgYW5kIHJlc291cmNlTG9hZElEIGhhdmUgdGhlIHNhbWUgdmFsdWUsIGFuZCBiZWNhdXNlIG9m IE5TS2V5ZWRBcmNoaXZlcgorICAgICAgICBkZWR1cGxpY2F0aW9uLCBzaGFyZSB0aGUgc2FtZSBv YmplY3QuCisKKyAgICAgICAgSWYgeW91IGxvb2sgYXQgdGhlIHJlc3VsdGFudCBwbGlzdCAqYWZ0 ZXIqIHIyODYzNDYsIHRoZSBlbmNvZGVkIGZyYW1lSUQKKyAgICAgICAgaXMgb25lIGxhcmdlciB0 aGFuIHRoZSByZXNvdXJjZUxvYWRJRCwgdGh1cyBjYW5ub3QgYmUgZGVkdXBsaWNhdGVkLCBhbmQK KyAgICAgICAgZW5kIHVwIGVuY29kaW5nIGFzIHNlcGFyYXRlIG9iamVjdHMuIFRoaXMgcmVzdWx0 cyBpbiB0aGUgZW5jb2RlZCBzaXplCisgICAgICAgIGluY3JlYXNpbmcgdG8gNjEyIGJ5dGVzLgor CisgICAgICAgIFRoZSByZWFzb24gdGhhdCB0aGUgZW5jb2RlZCBmcmFtZUlEIGlzIG5vdyBvbmUg dmFsdWUgbGFyZ2VyIGlzIHRoYXQKKyAgICAgICAgT2JqZWN0SWRlbnRpZmllciB1c2VzIGEgZ2xv YmFsIGlkZW50aWZpZXIgcG9vbCwgYW5kIHIyODYzNDYgY3JlYXRlcworICAgICAgICBvbmUgbW9y ZSBPYmplY3RJZGVudGlmaWVyIGR1cmluZyBFdmVudEhhbmRsZXIgY29uc3RydWN0aW9uLCBkZXN0 cm95aW5nCisgICAgICAgIG91ciBlbnRpcmVseSBjb2luY2lkZW50YWwgSUQgb3ZlcmxhcCwgYW5k IGNhdXNpbmcgdGhlIGFmb3JlbWVudGlvbmVkCisgICAgICAgIGVuY29kZWQgc2l6ZSBjaGFuZ2Uu CisKKyAgICAgICAgUmVtb3ZlIHRoaXMgYXNzZXJ0aW9uIGZyb20gdGhlIHRlc3QsIHNpbmNlIGl0 IGlzIHZlcnkgYWdncmVzc2l2ZSBhbmQKKyAgICAgICAgc2VlbXMgdW5uZWNlc3NhcnkuIFdlIGNv dWxkIGluc3RlYWQganVzdCByZWJhc2VsaW5lIHRoZSB0ZXN0LCBidXQgaXQKKyAgICAgICAgc2Vl bXMgaW5zdWZmaWNpZW50bHkgaW1wb3J0YW50IHRvIGJ1cmRlbiBzb21lIGZ1dHVyZSBkZXZlbG9w ZXIgd2l0aAorICAgICAgICBhIHJlcGVhdCBvZiB0aGlzIGV2ZW5pbmcgb2YgZXhwbG9yYXRpb24g YW5kIGRpc2NvdmVyeS4KKwogMjAyMS0xMS0zMCAgQkogQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBhZGQgRXh0ZW5zaW9uVGFiQWN0aXZhdGlvbiBkaWFn bm9zdGljIGV2ZW50CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dENvY29hL1Jlc291cmNlTG9hZERlbGVnYXRlLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRDb2NvYS9SZXNvdXJjZUxvYWREZWxlZ2F0ZS5tbQppbmRleCBhYTVmNWU4ZGE2ZWY2 ZjljMjg5NGVmODY0YzJhMjNhNjZiMThmN2M1Li5jY2EzNWFkZDEzNzlhNDYyOWZhODViNjhjNDRh MTA4YjBiMWZjNzMzIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dENvY29hL1Jlc291cmNlTG9hZERlbGVnYXRlLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Q29jb2EvUmVzb3VyY2VMb2FkRGVsZWdhdGUubW0KQEAgLTM3OSw3ICszNzks NiBAQCBURVNUKFJlc291cmNlTG9hZERlbGVnYXRlLCBMb2FkSW5mbykKICAgICBfV0tSZXNvdXJj ZUxvYWRJbmZvICpvcmlnaW5hbCA9IGxvYWRJbmZvc1swXS5nZXQoKTsKICAgICBOU0Vycm9yICpl cnJvciA9IG5pbDsKICAgICBOU0RhdGEgKmFyY2hpdmVEYXRhID0gW05TS2V5ZWRBcmNoaXZlciBh cmNoaXZlZERhdGFXaXRoUm9vdE9iamVjdDpvcmlnaW5hbCByZXF1aXJpbmdTZWN1cmVDb2Rpbmc6 WUVTIGVycm9yOiZlcnJvcl07Ci0gICAgRVhQRUNUX0VRKGFyY2hpdmVEYXRhLmxlbmd0aCwgNjA3 dWxsKTsKICAgICBFWFBFQ1RfRkFMU0UoZXJyb3IpOwogICAgIF9XS1Jlc291cmNlTG9hZEluZm8g KmRlc2VyaWFsaXplZCA9IFtOU0tleWVkVW5hcmNoaXZlciB1bmFyY2hpdmVkT2JqZWN0T2ZDbGFz czpbX1dLUmVzb3VyY2VMb2FkSW5mbyBjbGFzc10gZnJvbURhdGE6YXJjaGl2ZURhdGEgZXJyb3I6 JmVycm9yXTsKICAgICBFWFBFQ1RfRkFMU0UoZXJyb3IpOwo=