233674 2021-11-30 18:14:30 -0800 [Win] OSAllocator::reserveUncommittedAligned should use aligned allocation 2021-12-01 12:31:25 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii benjamin cdumez cmarcelo don.olmstead ews-watchlist keith_miller ross.kirsling webkit-bug-importer oldest_to_newest 1819041 0 fujii 2021-11-30 18:14:30 -0800 [Win] OSAllocator::reserveUncommittedAligned should use aligned allocation It has a FIXME comment (Added by Bug 233379): > // FIXME: Is there a way to do this where we can either release the excess reservation or not reserve it at all? > void* result = reserveUncommitted(2 * bytes, usage, writable, executable); 1819045 1 fujii 2021-11-30 18:16:46 -0800 The document of VirtualAlloc2 has a sample code. "Scenario 3. Allocate memory in a specific virtual address range (below 4GB, in this example) and with specific alignment." https://docs.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-virtualalloc2 1819066 2 445508 fujii 2021-11-30 20:39:22 -0800 Created attachment 445508 Patch 1819209 3 445508 keith_miller 2021-12-01 05:55:38 -0800 Comment on attachment 445508 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445508&action=review > Source/WTF/wtf/win/OSAllocatorWin.cpp:69 > // FIXME: Is there a way to do this where we can either release the excess reservation or not reserve it at all? Nit: I'd remove this FIXME at this point. 1819362 4 445603 fujii 2021-12-01 12:28:05 -0800 Created attachment 445603 Patch for landing Thank you for the review. 1819366 5 fujii 2021-12-01 12:30:05 -0800 Committed r286377 (244736@main): <https://commits.webkit.org/244736@main> 1819368 6 webkit-bug-importer 2021-12-01 12:31:25 -0800 <rdar://problem/85934857> 445508 2021-11-30 20:39:22 -0800 2021-12-01 12:27:52 -0800 Patch bug-233674-20211201133921.patch text/plain 2506 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZjMzVhZjZlYjBlMThlY2Y0YmQ2YzI2 N2Y0MTY0NTA3ZjljY2EzZGYuLjU4MzNlOTU0MTQ2ZjQxMzg2MTRkODhjYzU1OGM2ZTJhNzQ1NThl ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMTEtMzAgIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gT1NBbGxvY2F0b3I6OnJlc2Vy dmVVbmNvbW1pdHRlZEFsaWduZWQgc2hvdWxkIHVzZSBhbGlnbmVkIGFsbG9jYXRpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMzY3NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9TQWxsb2NhdG9yOjpy ZXNlcnZlVW5jb21taXR0ZWRBbGlnbmVkIGFsbG9jYXRlZCAyR2lCIGZvciAxR2lCCisgICAgICAg IGFsaWduZWQgYWxsb2NhdGlvbiByZXF1ZXN0LgorCisgICAgICAgIFdpbmRvd3MgMTAgKERlc2t0 b3ApIGhhcyBWaXJ0dWFsQWxsb2MyIEFQSSB0byBhbGlnbmVkIGFsbG9jYXRpb24uCisKKyAgICAg ICAgKiB3dGYvd2luL09TQWxsb2NhdG9yV2luLmNwcDoKKyAgICAgICAgKFdURjo6T1NBbGxvY2F0 b3I6OnJlc2VydmVVbmNvbW1pdHRlZEFsaWduZWQpOiBVc2UgVmlydHVhbEFsbG9jMgorICAgICAg ICBBUEkgaWYgYXZhaWxhYmxlLiBVc2UgU09GVF9MSU5LX09QVElPTkFMIGZvciBWaXJ0dWFsQWxs b2MyLgorCiAyMDIxLTExLTMwICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgogCiAgICAgICAgIEFkZCBhIG1vbWVudHVtIGV2ZW50IHN5bnRoZXNpemVyCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi93aW4vT1NBbGxvY2F0b3JXaW4uY3BwIGIvU291cmNlL1dURi93dGYv d2luL09TQWxsb2NhdG9yV2luLmNwcAppbmRleCBlYzY1N2U3MWI1NGRjYTBjYTI0YjViY2Q5MDdl ZjRkZWFmNmM0NDkzLi5hYTM2OGMxNTM0Zjg0MzE1NGEwNmQ1OTZkZjI2MDQ2MDQwOTliNGNlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi93aW4vT1NBbGxvY2F0b3JXaW4uY3BwCisrKyBiL1Nv dXJjZS9XVEYvd3RmL3dpbi9PU0FsbG9jYXRvcldpbi5jcHAKQEAgLTMwLDYgKzMwLDEwIEBACiAj aW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDx3dGYvTWF0aEV4dHJhcy5oPgog I2luY2x1ZGUgPHd0Zi9QYWdlQmxvY2suaD4KKyNpbmNsdWRlIDx3dGYvU29mdExpbmtpbmcuaD4K KworU09GVF9MSU5LX0xJQlJBUlkoa2VybmVsYmFzZSkKK1NPRlRfTElOS19PUFRJT05BTChrZXJu ZWxiYXNlLCBWaXJ0dWFsQWxsb2MyLCB2b2lkKiwgV0lOQVBJLCAoSEFORExFLCBQVk9JRCwgU0la RV9ULCBVTE9ORywgVUxPTkcsIE1FTV9FWFRFTkRFRF9QQVJBTUVURVIgKiwgVUxPTkcpKQogCiBu YW1lc3BhY2UgV1RGIHsKIApAQCAtNTEsNiArNTUsMTcgQEAgdm9pZCogT1NBbGxvY2F0b3I6OnJl c2VydmVVbmNvbW1pdHRlZChzaXplX3QgYnl0ZXMsIFVzYWdlLCBib29sIHdyaXRhYmxlLCBib29s IGUKIHZvaWQqIE9TQWxsb2NhdG9yOjpyZXNlcnZlVW5jb21taXR0ZWRBbGlnbmVkKHNpemVfdCBi eXRlcywgVXNhZ2UgdXNhZ2UsIGJvb2wgd3JpdGFibGUsIGJvb2wgZXhlY3V0YWJsZSwgYm9vbCwg Ym9vbCkKIHsKICAgICBBU1NFUlQoaGFzT25lQml0U2V0KGJ5dGVzKSAmJiBieXRlcyA+PSBwYWdl U2l6ZSgpKTsKKyAgICBpZiAoVmlydHVhbEFsbG9jMlB0cigpKSB7CisgICAgICAgIE1FTV9BRERS RVNTX1JFUVVJUkVNRU5UUyBhZGRyZXNzUmVxcyA9IHsgfTsKKyAgICAgICAgTUVNX0VYVEVOREVE X1BBUkFNRVRFUiBwYXJhbSA9IHsgfTsKKyAgICAgICAgYWRkcmVzc1JlcXMuQWxpZ25tZW50ID0g Ynl0ZXM7CisgICAgICAgIHBhcmFtLlR5cGUgPSBNZW1FeHRlbmRlZFBhcmFtZXRlckFkZHJlc3NS ZXF1aXJlbWVudHM7CisgICAgICAgIHBhcmFtLlBvaW50ZXIgPSAmYWRkcmVzc1JlcXM7CisgICAg ICAgIHZvaWQqIHJlc3VsdCA9IFZpcnR1YWxBbGxvYzJQdHIoKShudWxscHRyLCBudWxscHRyLCBi eXRlcywgTUVNX1JFU0VSVkUsIHByb3RlY3Rpb24od3JpdGFibGUsIGV4ZWN1dGFibGUpLCAmcGFy YW0sIDEpOworICAgICAgICBpZiAoIXJlc3VsdCkKKyAgICAgICAgICAgIENSQVNIKCk7CisgICAg ICAgIHJldHVybiByZXN1bHQ7CisgICAgfQogICAgIC8vIEZJWE1FOiBJcyB0aGVyZSBhIHdheSB0 byBkbyB0aGlzIHdoZXJlIHdlIGNhbiBlaXRoZXIgcmVsZWFzZSB0aGUgZXhjZXNzIHJlc2VydmF0 aW9uIG9yIG5vdCByZXNlcnZlIGl0IGF0IGFsbD8KICAgICB2b2lkKiByZXN1bHQgPSByZXNlcnZl VW5jb21taXR0ZWQoMiAqIGJ5dGVzLCB1c2FnZSwgd3JpdGFibGUsIGV4ZWN1dGFibGUpOwogCg== 445603 2021-12-01 12:28:05 -0800 2021-12-01 12:28:05 -0800 Patch for landing bug-233674-20211202052804.patch text/plain 2640 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2Mzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGUyZDRmNWQwOTgzMDM0YTA2M2M5OTUw MjU4NmYyNGYzNDMyNWFlOWUuLjY1NjE4Yjc3ZWI3MzRlNWYxNzcyMjM5MGQwYWI4YjZhZGFmMjEw MDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMTItMDEgIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gT1NBbGxvY2F0b3I6OnJlc2Vy dmVVbmNvbW1pdHRlZEFsaWduZWQgc2hvdWxkIHVzZSBhbGlnbmVkIGFsbG9jYXRpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMzY3NAorCisgICAg ICAgIFJldmlld2VkIGJ5IEtlaXRoIE1pbGxlci4KKworICAgICAgICBPU0FsbG9jYXRvcjo6cmVz ZXJ2ZVVuY29tbWl0dGVkQWxpZ25lZCByZXNlcnZlZCAyR2lCIGZvciAxR2lCCisgICAgICAgIGFs aWduZWQgYWxsb2NhdGlvbiByZXF1ZXN0LgorCisgICAgICAgIFdpbmRvd3MgMTAgKERlc2t0b3Ap IGhhcyBWaXJ0dWFsQWxsb2MyIEFQSSB0byBhbGlnbmVkIGFsbG9jYXRpb24uCisKKyAgICAgICAg KiB3dGYvd2luL09TQWxsb2NhdG9yV2luLmNwcDoKKyAgICAgICAgKFdURjo6T1NBbGxvY2F0b3I6 OnJlc2VydmVVbmNvbW1pdHRlZEFsaWduZWQpOiBVc2UgVmlydHVhbEFsbG9jMgorICAgICAgICBB UEkgaWYgYXZhaWxhYmxlLiBVc2UgU09GVF9MSU5LX09QVElPTkFMIGZvciBWaXJ0dWFsQWxsb2My LgorCiAyMDIxLTEyLTAxICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQuIEZpeCAtV2Zvcm1hdCB3YXJuaW5nIGFmdGVyIGluIFRocmVhZGluZ1Bv c2l4IGxvZ2dpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3dpbi9PU0FsbG9jYXRvcldp bi5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi93aW4vT1NBbGxvY2F0b3JXaW4uY3BwCmluZGV4IGVjNjU3 ZTcxYjU0ZGNhMGNhMjRiNWJjZDkwN2VmNGRlYWY2YzQ0OTMuLjVhYzZkZThiMmU0NGJlNTFiM2Yw NDMxOGQyYmQ1NWVhY2ZmMzA1OTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3dpbi9PU0Fs bG9jYXRvcldpbi5jcHAKKysrIGIvU291cmNlL1dURi93dGYvd2luL09TQWxsb2NhdG9yV2luLmNw cApAQCAtMzAsNiArMzAsMTAgQEAKICNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgogI2luY2x1 ZGUgPHd0Zi9NYXRoRXh0cmFzLmg+CiAjaW5jbHVkZSA8d3RmL1BhZ2VCbG9jay5oPgorI2luY2x1 ZGUgPHd0Zi9Tb2Z0TGlua2luZy5oPgorCitTT0ZUX0xJTktfTElCUkFSWShrZXJuZWxiYXNlKQor U09GVF9MSU5LX09QVElPTkFMKGtlcm5lbGJhc2UsIFZpcnR1YWxBbGxvYzIsIHZvaWQqLCBXSU5B UEksIChIQU5ETEUsIFBWT0lELCBTSVpFX1QsIFVMT05HLCBVTE9ORywgTUVNX0VYVEVOREVEX1BB UkFNRVRFUiAqLCBVTE9ORykpCiAKIG5hbWVzcGFjZSBXVEYgewogCkBAIC01MSw3ICs1NSwxNyBA QCB2b2lkKiBPU0FsbG9jYXRvcjo6cmVzZXJ2ZVVuY29tbWl0dGVkKHNpemVfdCBieXRlcywgVXNh Z2UsIGJvb2wgd3JpdGFibGUsIGJvb2wgZQogdm9pZCogT1NBbGxvY2F0b3I6OnJlc2VydmVVbmNv bW1pdHRlZEFsaWduZWQoc2l6ZV90IGJ5dGVzLCBVc2FnZSB1c2FnZSwgYm9vbCB3cml0YWJsZSwg Ym9vbCBleGVjdXRhYmxlLCBib29sLCBib29sKQogewogICAgIEFTU0VSVChoYXNPbmVCaXRTZXQo Ynl0ZXMpICYmIGJ5dGVzID49IHBhZ2VTaXplKCkpOwotICAgIC8vIEZJWE1FOiBJcyB0aGVyZSBh IHdheSB0byBkbyB0aGlzIHdoZXJlIHdlIGNhbiBlaXRoZXIgcmVsZWFzZSB0aGUgZXhjZXNzIHJl c2VydmF0aW9uIG9yIG5vdCByZXNlcnZlIGl0IGF0IGFsbD8KKyAgICBpZiAoVmlydHVhbEFsbG9j MlB0cigpKSB7CisgICAgICAgIE1FTV9BRERSRVNTX1JFUVVJUkVNRU5UUyBhZGRyZXNzUmVxcyA9 IHsgfTsKKyAgICAgICAgTUVNX0VYVEVOREVEX1BBUkFNRVRFUiBwYXJhbSA9IHsgfTsKKyAgICAg ICAgYWRkcmVzc1JlcXMuQWxpZ25tZW50ID0gYnl0ZXM7CisgICAgICAgIHBhcmFtLlR5cGUgPSBN ZW1FeHRlbmRlZFBhcmFtZXRlckFkZHJlc3NSZXF1aXJlbWVudHM7CisgICAgICAgIHBhcmFtLlBv aW50ZXIgPSAmYWRkcmVzc1JlcXM7CisgICAgICAgIHZvaWQqIHJlc3VsdCA9IFZpcnR1YWxBbGxv YzJQdHIoKShudWxscHRyLCBudWxscHRyLCBieXRlcywgTUVNX1JFU0VSVkUsIHByb3RlY3Rpb24o d3JpdGFibGUsIGV4ZWN1dGFibGUpLCAmcGFyYW0sIDEpOworICAgICAgICBpZiAoIXJlc3VsdCkK KyAgICAgICAgICAgIENSQVNIKCk7CisgICAgICAgIHJldHVybiByZXN1bHQ7CisgICAgfQogICAg IHZvaWQqIHJlc3VsdCA9IHJlc2VydmVVbmNvbW1pdHRlZCgyICogYnl0ZXMsIHVzYWdlLCB3cml0 YWJsZSwgZXhlY3V0YWJsZSk7CiAKICAgICBjaGFyKiBhbGlnbmVkID0gcmVpbnRlcnByZXRfY2Fz dDxjaGFyKj4ocm91bmRVcFRvTXVsdGlwbGVPZihieXRlcywgcmVpbnRlcnByZXRfY2FzdDx1aW50 cHRyX3Q+KHJlc3VsdCkpKTsK