233670 2021-11-30 16:32:31 -0800 Adjust a Live Text quirk so that it applies to YouTube image thumbnails 2023-04-03 23:02:18 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 254973 1 wenson_hsieh wenson_hsieh akeerthi cdumez esprehn+autocc ews-watchlist hi kangil.han karlcow megan_gardner thorton webkit-bug-importer oldest_to_newest 1819002 0 wenson_hsieh 2021-11-30 16:32:31 -0800 . 1819008 1 445489 wenson_hsieh 2021-11-30 16:45:54 -0800 Created attachment 445489 Patch 1819021 2 445489 hi 2021-11-30 17:20:20 -0800 Comment on attachment 445489 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445489&action=review rs=me > Source/WebCore/page/Quirks.cpp:1461 > + if (host.endsWith(".youtube.com") || host == "youtube.com") I think we normally use `equalLettersIgnoringASCIICase` and `endsWithIgnoringASCIICase` (or `convertToASCIILowercase` beforehand). 1819247 3 445489 wenson_hsieh 2021-12-01 08:20:11 -0800 Comment on attachment 445489 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445489&action=review >> Source/WebCore/page/Quirks.cpp:1461 >> + if (host.endsWith(".youtube.com") || host == "youtube.com") > > I think we normally use `equalLettersIgnoringASCIICase` and `endsWithIgnoringASCIICase` (or `convertToASCIILowercase` beforehand). Fixed — thanks for the review! 1819250 4 445575 wenson_hsieh 2021-12-01 08:21:12 -0800 Created attachment 445575 Patch for landing 1819270 5 ews-feeder 2021-12-01 09:09:50 -0800 Committed r286366 (244725@main): <https://commits.webkit.org/244725@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445575. 1819271 6 webkit-bug-importer 2021-12-01 09:10:26 -0800 <rdar://problem/85924733> 1944485 7 karlcow 2023-03-27 21:19:10 -0700 Wenson Hsieh, do you remember the steps to reproduce here? 1944618 8 wenson_hsieh 2023-03-28 08:02:21 -0700 (In reply to Karl Dubost from comment #7) > Wenson Hsieh, do you remember the steps to reproduce here? The steps to reproduce, as I previously recalled, are: 1. Navigate to a YouTube video. 2. Hover over related video thumbnails that have recognizable text. 3. Drag to select the text. At some point, (3) wouldn't work and you would end up not selecting text. That said, I just tried this out on YouTube with site-specific hacks disabled, and it now appears to work. Perhaps we don't need this quirk anymore.. 445489 2021-11-30 16:45:54 -0800 2021-12-01 08:21:09 -0800 Patch bug-233670-20211130164552.patch text/plain 3468 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2U4OTE0YzFmZjIwNTA5 ZGEyZjhlOTY4YTNlMzNkMDRlYzgwYTYwMC4uNzY5ZmE3NjRiM2IxYmU5YWE3ZTVjNWMyMmQzNzdl ZTUwZTVjODljMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTExLTMwICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEFkanVzdCBhIExp dmUgVGV4dCBxdWlyayBzbyB0aGF0IGl0IGFwcGxpZXMgdG8gWW91VHViZSBpbWFnZSB0aHVtYm5h aWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzM2 NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBdWdt ZW50IHRoaXMgZXhpc3RpbmcgcXVpcmsgc28gdGhhdCBpdCAoMSkgYXBwbGllcyB0byBZb3VUdWJl IGFzIHdlbGwsIGFuZCAoMikgYWxzbyBmb3JjZXMgYC13ZWJraXQtdXNlci1kcmFnYAorICAgICAg ICB0byBiZSBgYXV0b2AuCisKKyAgICAgICAgKiBkb20vSW1hZ2VPdmVybGF5LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkltYWdlT3ZlcmxheTo6dXBkYXRlU3VidHJlZSk6CisgICAgICAgICogcGFn ZS9RdWlya3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UXVpcmtzOjpuZWVkc1RvRm9yY2VVc2Vy U2VsZWN0QW5kVXNlckRyYWdXaGVuSW5zdGFsbGluZ0ltYWdlT3ZlcmxheSBjb25zdCk6CisgICAg ICAgIChXZWJDb3JlOjpRdWlya3M6Om5lZWRzVG9Gb3JjZVVzZXJTZWxlY3RXaGVuSW5zdGFsbGlu Z0ltYWdlT3ZlcmxheSBjb25zdCk6IERlbGV0ZWQuCisgICAgICAgICogcGFnZS9RdWlya3MuaDoK KwogMjAyMS0xMS0zMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAg IFtIYXJkZW5pbmddIEVhcmx5IHJldHVybiBpbiBKU0xhenlFdmVudExpc3RlbmVyOjppbml0aWFs aXplSlNGdW5jdGlvbigpIGlmICFzZXR0aW5ncygpLnNjcmlwdE1hcmt1cEVuYWJsZWQoKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0ltYWdlT3ZlcmxheS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vSW1hZ2VPdmVybGF5LmNwcAppbmRleCAxOGNkYjhkNDkwMThkYzliMGMwNjA1MTM0 MzE0ZjY3NTY0MzY2ZjY5Li45ZGI1ZWEwZjRkNjdjMDM4OTRhOGE0Y2QyMjY3Y2EzZDU2Njg5YWI4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vSW1hZ2VPdmVybGF5LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vSW1hZ2VPdmVybGF5LmNwcApAQCAtMzUxLDggKzM1MSwxMCBAQCBz dGF0aWMgRWxlbWVudHMgdXBkYXRlU3VidHJlZShIVE1MRWxlbWVudCYgZWxlbWVudCwgY29uc3Qg VGV4dFJlY29nbml0aW9uUmVzdWx0JgogICAgICAgICAgICAgZWxlbWVudHMuYmxvY2tzLnVuY2hl Y2tlZEFwcGVuZChXVEZNb3ZlKGJsb2NrQ29udGFpbmVyKSk7CiAgICAgICAgIH0KIAotICAgICAg ICBpZiAoZG9jdW1lbnQtPnF1aXJrcygpLm5lZWRzVG9Gb3JjZVVzZXJTZWxlY3RXaGVuSW5zdGFs bGluZ0ltYWdlT3ZlcmxheSgpKQorICAgICAgICBpZiAoZG9jdW1lbnQtPnF1aXJrcygpLm5lZWRz VG9Gb3JjZVVzZXJTZWxlY3RBbmRVc2VyRHJhZ1doZW5JbnN0YWxsaW5nSW1hZ2VPdmVybGF5KCkp IHsKICAgICAgICAgICAgIGVsZW1lbnQuc2V0SW5saW5lU3R5bGVQcm9wZXJ0eShDU1NQcm9wZXJ0 eVdlYmtpdFVzZXJTZWxlY3QsIENTU1ZhbHVlVGV4dCk7CisgICAgICAgICAgICBlbGVtZW50LnNl dElubGluZVN0eWxlUHJvcGVydHkoQ1NTUHJvcGVydHlXZWJraXRVc2VyRHJhZywgQ1NTVmFsdWVB dXRvKTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIGlmICghaGFkRXhpc3RpbmdFbGVtZW50cykg ewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwIGIvU291cmNlL1dl YkNvcmUvcGFnZS9RdWlya3MuY3BwCmluZGV4IDRmMjJhZWFiNDU1OGMzOWZkNDhlMjEyZGJmN2Zh NDYxYTcxYjNjZTQuLmQzZTFjMjE5ZDE5MjdmZDZiMGE4ZjU0YmExNzNkZTA3NGY0NTUxMDcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1F1aXJrcy5jcHAKQEAgLTE0NDgsNyArMTQ0OCw3IEBAIGJvb2wgUXVpcmtzOjpz aG91bGRCeXBhc3NVc2VyR2VzdHVyZVJlcXVpcmVtZW50Rm9yV2ViQXV0aG4oKSBjb25zdAogCiAj aWYgRU5BQkxFKElNQUdFX0FOQUxZU0lTKQogCi1ib29sIFF1aXJrczo6bmVlZHNUb0ZvcmNlVXNl clNlbGVjdFdoZW5JbnN0YWxsaW5nSW1hZ2VPdmVybGF5KCkgY29uc3QKK2Jvb2wgUXVpcmtzOjpu ZWVkc1RvRm9yY2VVc2VyU2VsZWN0QW5kVXNlckRyYWdXaGVuSW5zdGFsbGluZ0ltYWdlT3Zlcmxh eSgpIGNvbnN0CiB7CiAgICAgaWYgKCFuZWVkc1F1aXJrcygpKQogICAgICAgICByZXR1cm4gZmFs c2U7CkBAIC0xNDU3LDYgKzE0NTcsMTAgQEAgYm9vbCBRdWlya3M6Om5lZWRzVG9Gb3JjZVVzZXJT ZWxlY3RXaGVuSW5zdGFsbGluZ0ltYWdlT3ZlcmxheSgpIGNvbnN0CiAgICAgaWYgKHRvcFByaXZh dGVseUNvbnRyb2xsZWREb21haW4odXJsLmhvc3QoKS50b1N0cmluZygpKS5zdGFydHNXaXRoKCJn b29nbGUuIikgJiYgdXJsLnBhdGgoKSA9PSAiL3NlYXJjaCIpCiAgICAgICAgIHJldHVybiB0cnVl OwogCisgICAgYXV0byBob3N0ID0gdXJsLmhvc3QoKTsKKyAgICBpZiAoaG9zdC5lbmRzV2l0aCgi LnlvdXR1YmUuY29tIikgfHwgaG9zdCA9PSAieW91dHViZS5jb20iKQorICAgICAgICByZXR1cm4g dHJ1ZTsKKwogICAgIHJldHVybiBmYWxzZTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9RdWlya3MuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmgKaW5kZXggZDA5 YjYxNWEzMDNjOTIzMTI1MjkyNTQ0ZGU3YTQ3MTA4MjNmODg2MS4uMDFhZjU5YTE1YmU2MzIwODdj YjY3YzlmZTg0MjY0MjVlYTFkOTcyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9R dWlya3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5oCkBAIC0xNTQsNyArMTU0 LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBib29sIHNob3VsZE9taXRIVE1MRG9jdW1lbnRTdXBw b3J0ZWRQcm9wZXJ0eU5hbWVzKCk7CiAKICNpZiBFTkFCTEUoSU1BR0VfQU5BTFlTSVMpCi0gICAg Ym9vbCBuZWVkc1RvRm9yY2VVc2VyU2VsZWN0V2hlbkluc3RhbGxpbmdJbWFnZU92ZXJsYXkoKSBj b25zdDsKKyAgICBib29sIG5lZWRzVG9Gb3JjZVVzZXJTZWxlY3RBbmRVc2VyRHJhZ1doZW5JbnN0 YWxsaW5nSW1hZ2VPdmVybGF5KCkgY29uc3Q7CiAjZW5kaWYKIAogcHJpdmF0ZToK 445575 2021-12-01 08:21:12 -0800 2021-12-01 09:09:52 -0800 Patch for landing bug-233670-20211201082111.patch text/plain 3512 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2U4OTE0YzFmZjIwNTA5 ZGEyZjhlOTY4YTNlMzNkMDRlYzgwYTYwMC4uNGZlOWMwZjZlN2VjODU0OTMwMmQ1MThhMGI2OGQ5 ODQ0YTg4NGQ5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTExLTMwICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEFkanVzdCBhIExp dmUgVGV4dCBxdWlyayBzbyB0aGF0IGl0IGFwcGxpZXMgdG8gWW91VHViZSBpbWFnZSB0aHVtYm5h aWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzM2 NzAKKworICAgICAgICBSZXZpZXdlZCBieSBEZXZpbiBSb3Vzc28uCisKKyAgICAgICAgQXVnbWVu dCB0aGlzIGV4aXN0aW5nIHF1aXJrIHNvIHRoYXQgaXQgKDEpIGFwcGxpZXMgdG8gWW91VHViZSBh cyB3ZWxsLCBhbmQgKDIpIGFsc28gZm9yY2VzIGAtd2Via2l0LXVzZXItZHJhZ2AKKyAgICAgICAg dG8gYmUgYGF1dG9gLgorCisgICAgICAgICogZG9tL0ltYWdlT3ZlcmxheS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpJbWFnZU92ZXJsYXk6OnVwZGF0ZVN1YnRyZWUpOgorICAgICAgICAqIHBhZ2Uv UXVpcmtzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlF1aXJrczo6bmVlZHNUb0ZvcmNlVXNlclNl bGVjdEFuZFVzZXJEcmFnV2hlbkluc3RhbGxpbmdJbWFnZU92ZXJsYXkgY29uc3QpOgorICAgICAg ICAoV2ViQ29yZTo6UXVpcmtzOjpuZWVkc1RvRm9yY2VVc2VyU2VsZWN0V2hlbkluc3RhbGxpbmdJ bWFnZU92ZXJsYXkgY29uc3QpOiBEZWxldGVkLgorICAgICAgICAqIHBhZ2UvUXVpcmtzLmg6CisK IDIwMjEtMTEtMzAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBb SGFyZGVuaW5nXSBFYXJseSByZXR1cm4gaW4gSlNMYXp5RXZlbnRMaXN0ZW5lcjo6aW5pdGlhbGl6 ZUpTRnVuY3Rpb24oKSBpZiAhc2V0dGluZ3MoKS5zY3JpcHRNYXJrdXBFbmFibGVkKCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9JbWFnZU92ZXJsYXkuY3BwIGIvU291cmNlL1dlYkNv cmUvZG9tL0ltYWdlT3ZlcmxheS5jcHAKaW5kZXggMThjZGI4ZDQ5MDE4ZGM5YjBjMDYwNTEzNDMx NGY2NzU2NDM2NmY2OS4uOWRiNWVhMGY0ZDY3YzAzODk0YThhNGNkMjI2N2NhM2Q1NjY4OWFiOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0ltYWdlT3ZlcmxheS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL0ltYWdlT3ZlcmxheS5jcHAKQEAgLTM1MSw4ICszNTEsMTAgQEAgc3Rh dGljIEVsZW1lbnRzIHVwZGF0ZVN1YnRyZWUoSFRNTEVsZW1lbnQmIGVsZW1lbnQsIGNvbnN0IFRl eHRSZWNvZ25pdGlvblJlc3VsdCYKICAgICAgICAgICAgIGVsZW1lbnRzLmJsb2Nrcy51bmNoZWNr ZWRBcHBlbmQoV1RGTW92ZShibG9ja0NvbnRhaW5lcikpOwogICAgICAgICB9CiAKLSAgICAgICAg aWYgKGRvY3VtZW50LT5xdWlya3MoKS5uZWVkc1RvRm9yY2VVc2VyU2VsZWN0V2hlbkluc3RhbGxp bmdJbWFnZU92ZXJsYXkoKSkKKyAgICAgICAgaWYgKGRvY3VtZW50LT5xdWlya3MoKS5uZWVkc1Rv Rm9yY2VVc2VyU2VsZWN0QW5kVXNlckRyYWdXaGVuSW5zdGFsbGluZ0ltYWdlT3ZlcmxheSgpKSB7 CiAgICAgICAgICAgICBlbGVtZW50LnNldElubGluZVN0eWxlUHJvcGVydHkoQ1NTUHJvcGVydHlX ZWJraXRVc2VyU2VsZWN0LCBDU1NWYWx1ZVRleHQpOworICAgICAgICAgICAgZWxlbWVudC5zZXRJ bmxpbmVTdHlsZVByb3BlcnR5KENTU1Byb3BlcnR5V2Via2l0VXNlckRyYWcsIENTU1ZhbHVlQXV0 byk7CisgICAgICAgIH0KICAgICB9CiAKICAgICBpZiAoIWhhZEV4aXN0aW5nRWxlbWVudHMpIHsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvUXVpcmtzLmNwcAppbmRleCA0ZjIyYWVhYjQ1NThjMzlmZDQ4ZTIxMmRiZjdmYTQ2 MWE3MWIzY2U0Li5hODE2YjZmNTM4ZmFlMTViYWIwMzM3MDhjMjcyYTYwOTYyZDJmYTQ4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9RdWlya3MuY3BwCkBAIC0xNDQ4LDcgKzE0NDgsNyBAQCBib29sIFF1aXJrczo6c2hv dWxkQnlwYXNzVXNlckdlc3R1cmVSZXF1aXJlbWVudEZvcldlYkF1dGhuKCkgY29uc3QKIAogI2lm IEVOQUJMRShJTUFHRV9BTkFMWVNJUykKIAotYm9vbCBRdWlya3M6Om5lZWRzVG9Gb3JjZVVzZXJT ZWxlY3RXaGVuSW5zdGFsbGluZ0ltYWdlT3ZlcmxheSgpIGNvbnN0Citib29sIFF1aXJrczo6bmVl ZHNUb0ZvcmNlVXNlclNlbGVjdEFuZFVzZXJEcmFnV2hlbkluc3RhbGxpbmdJbWFnZU92ZXJsYXko KSBjb25zdAogewogICAgIGlmICghbmVlZHNRdWlya3MoKSkKICAgICAgICAgcmV0dXJuIGZhbHNl OwpAQCAtMTQ1Nyw2ICsxNDU3LDEwIEBAIGJvb2wgUXVpcmtzOjpuZWVkc1RvRm9yY2VVc2VyU2Vs ZWN0V2hlbkluc3RhbGxpbmdJbWFnZU92ZXJsYXkoKSBjb25zdAogICAgIGlmICh0b3BQcml2YXRl bHlDb250cm9sbGVkRG9tYWluKHVybC5ob3N0KCkudG9TdHJpbmcoKSkuc3RhcnRzV2l0aCgiZ29v Z2xlLiIpICYmIHVybC5wYXRoKCkgPT0gIi9zZWFyY2giKQogICAgICAgICByZXR1cm4gdHJ1ZTsK IAorICAgIGF1dG8gaG9zdCA9IHVybC5ob3N0KCk7CisgICAgaWYgKGVxdWFsTGV0dGVyc0lnbm9y aW5nQVNDSUlDYXNlKGhvc3QsICJ5b3V0dWJlLmNvbSIpIHx8IGhvc3QuZW5kc1dpdGhJZ25vcmlu Z0FTQ0lJQ2FzZSgiLnlvdXR1YmUuY29tIikpCisgICAgICAgIHJldHVybiB0cnVlOworCiAgICAg cmV0dXJuIGZhbHNlOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJr cy5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuaAppbmRleCBkMDliNjE1YTMwM2M5MjMx MjUyOTI1NDRkZTdhNDcxMDgyM2Y4ODYxLi4wMWFmNTlhMTViZTYzMjA4N2NiNjdjOWZlODQyNjQy NWVhMWQ5NzJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmgKQEAgLTE1NCw3ICsxNTQsNyBAQCBwdWJsaWM6 CiAgICAgc3RhdGljIGJvb2wgc2hvdWxkT21pdEhUTUxEb2N1bWVudFN1cHBvcnRlZFByb3BlcnR5 TmFtZXMoKTsKIAogI2lmIEVOQUJMRShJTUFHRV9BTkFMWVNJUykKLSAgICBib29sIG5lZWRzVG9G b3JjZVVzZXJTZWxlY3RXaGVuSW5zdGFsbGluZ0ltYWdlT3ZlcmxheSgpIGNvbnN0OworICAgIGJv b2wgbmVlZHNUb0ZvcmNlVXNlclNlbGVjdEFuZFVzZXJEcmFnV2hlbkluc3RhbGxpbmdJbWFnZU92 ZXJsYXkoKSBjb25zdDsKICNlbmRpZgogCiBwcml2YXRlOgo=