233658 2021-11-30 13:42:42 -0800 [ Monterey ] fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html (layout-test) is a constant text failure 2021-12-02 13:33:59 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jenner wenson_hsieh benjamin cdumez cmarcelo ews-watchlist megan_gardner thorton webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1818918 0 jenner 2021-11-30 13:42:42 -0800 fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html is a constant text failure on Monterey. HISTORY: https://results.webkit.org/?suite=layout-tests&test=fast%2Fimages%2Ftext-recognition%2Fmac%2Fimage-overlay-text-disables-app-highlight-menu-items.html DIFF URL: https://build.webkit.org/results/Apple-Monterey-Release-WK2-Tests/r286311%20(292)/fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items-pretty-diff.html TEXT DIFF: -PASS foundTitle1 is true -PASS foundTitle2 is true -PASS Selected image overlay -PASS foundTitle1 is false -PASS foundTitle2 is false -PASS successfullyParsed is true +CONSOLE MESSAGE: TypeError: undefined is not an object (evaluating 'internals.appHighlightContextMenuItemTitles') +FAIL successfullyParsed should be true. Was false. +Some tests failed. TEST COMPLETE - + Hello world this is a test. 1818919 1 webkit-bug-importer 2021-11-30 13:43:12 -0800 <rdar://problem/85886424> 1819498 2 wenson_hsieh 2021-12-01 17:14:56 -0800 > +CONSOLE MESSAGE: TypeError: undefined is not an object (evaluating > 'internals.appHighlightContextMenuItemTitles') > +FAIL successfullyParsed should be true. Was false. This test is passing in configurations where ENABLE_APP_HIGHLIGHTS is defined. I'm guessing we just need to upstream ENABLE_APP_HIGHLIGHTS code. 1819504 3 445642 wenson_hsieh 2021-12-01 17:20:30 -0800 Created attachment 445642 For EWS 1819799 4 445750 wenson_hsieh 2021-12-02 11:15:55 -0800 Created attachment 445750 Fix iOS build 1819828 5 wenson_hsieh 2021-12-02 12:27:30 -0800 (In reply to Wenson Hsieh from comment #2) > > +CONSOLE MESSAGE: TypeError: undefined is not an object (evaluating > > 'internals.appHighlightContextMenuItemTitles') > > +FAIL successfullyParsed should be true. Was false. > > This test is passing in configurations where ENABLE_APP_HIGHLIGHTS is > defined. > > I'm guessing we just need to upstream ENABLE_APP_HIGHLIGHTS code. Verified with a non-internal macOS Monterey WebKit build that this is the only change needed to fix the test. 1819840 6 445750 wenson_hsieh 2021-12-02 12:57:21 -0800 Comment on attachment 445750 Fix iOS build Thanks for the review! 1819855 7 ews-feeder 2021-12-02 13:33:56 -0800 Committed r286450 (244792@main): <https://commits.webkit.org/244792@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445750. 445642 2021-12-01 17:20:30 -0800 2021-12-02 11:15:52 -0800 For EWS bug-233658-20211201172029.patch text/plain 1637 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDY1NjE4Yjc3ZWI3MzRlNWYxNzcyMjM5 MGQwYWI4YjZhZGFmMjEwMDIuLjQwMTYxZDZiMTVlNDk4MWQ0NjJmYWMwMmY4YjFmNjQ0ZTg3ZjVi MTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTItMDEgIFdlbnNvbiBIc2llaCAgPHdlbnNv bl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgWyBNb250ZXJleSBdIGZhc3QvaW1hZ2VzL3Rl eHQtcmVjb2duaXRpb24vbWFjL2ltYWdlLW92ZXJsYXktdGV4dC1kaXNhYmxlcy1hcHAtaGlnaGxp Z2h0LW1lbnUtaXRlbXMuaHRtbCAobGF5b3V0LXRlc3QpIGlzIGEgY29uc3RhbnQgdGV4dCBmYWls dXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzM2 NTgKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vODU4ODY0MjQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWZpbmUgRU5BQkxFX0FQUF9ISUdITElHSFRT IGZvciBpT1MgMTUrIGFuZCBtYWNPUyBNb250ZXJleSsuIFRoaXMgZW5zdXJlcyB0aGF0CisgICAg ICAgIGBpbnRlcm5hbHMuYXBwSGlnaGxpZ2h0Q29udGV4dE1lbnVJdGVtVGl0bGVzYCBpcyBkZWZp bmVkIGluIGxheW91dCB0ZXN0cyBvbiBNb250ZXJleS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9y bUVuYWJsZUNvY29hLmg6CisKIDIwMjEtMTItMDEgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmku RnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW1dpbl0gT1NBbGxvY2F0b3I6OnJlc2VydmVVbmNv bW1pdHRlZEFsaWduZWQgc2hvdWxkIHVzZSBhbGlnbmVkIGFsbG9jYXRpb24KZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtRW5hYmxlQ29jb2EuaCBiL1NvdXJjZS9XVEYvd3RmL1Bs YXRmb3JtRW5hYmxlQ29jb2EuaAppbmRleCBhZTkyYmVlOTg2MDRmNzA5ZjkwMTZiMTNmYzFlMjJj NmZiMzJjYzE1Li4zZjFjZDMzNGE3YWMwODk0YWFkZGQ5MGEwYTRhYjAzMjJiMDEzMzE3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmgKKysrIGIvU291cmNl L1dURi93dGYvUGxhdGZvcm1FbmFibGVDb2NvYS5oCkBAIC03MTYsNiArNzE2LDEyIEBACiAjZGVm aW5lIEVOQUJMRV9BUFBfUFJJVkFDWV9SRVBPUlQgMQogI2VuZGlmCiAKKyNpZiAoIWRlZmluZWQo RU5BQkxFX0FQUF9ISUdITElHSFRTKSAmJiBcCisgICAgKFBMQVRGT1JNKE1BQykgJiYgX19NQUNf T1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMjAwMDAgXAorICAgIHx8IFBMQVRGT1JNKElP UykgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTUwMDAwKSkKKyNkZWZp bmUgRU5BQkxFX0FQUF9ISUdITElHSFRTIDEKKyNlbmRpZgorCiAjaWYgIWRlZmluZWQoRU5BQkxF X0RFU1RJTkFUSU9OX0NPTE9SX1NQQUNFX0RJU1BMQVlfUDMpCiAjZGVmaW5lIEVOQUJMRV9ERVNU SU5BVElPTl9DT0xPUl9TUEFDRV9ESVNQTEFZX1AzIDEKICNlbmRpZgo= 445750 2021-12-02 11:15:55 -0800 2021-12-02 13:33:58 -0800 Fix iOS build bug-233658-20211202111554.patch text/plain 2915 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDliZDFhMmIxM2IwOGRiNmQ4ZTFlNzY4 NGY1ZmVkN2QzYjUzMDk1YjUuLjMzNmRlNTc4M2E4NDc1NWNiZmJkYzEwMWI0OTRmYzI1YWUwZTkz ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTItMDIgIFdlbnNvbiBIc2llaCAgPHdlbnNv bl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgWyBNb250ZXJleSBdIGZhc3QvaW1hZ2VzL3Rl eHQtcmVjb2duaXRpb24vbWFjL2ltYWdlLW92ZXJsYXktdGV4dC1kaXNhYmxlcy1hcHAtaGlnaGxp Z2h0LW1lbnUtaXRlbXMuaHRtbCAobGF5b3V0LXRlc3QpIGlzIGEgY29uc3RhbnQgdGV4dCBmYWls dXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzM2 NTgKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vODU4ODY0MjQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWZpbmUgRU5BQkxFX0FQUF9ISUdITElHSFRT IGZvciBpT1MgMTUrIGFuZCBtYWNPUyBNb250ZXJleSsuIFRoaXMgZW5zdXJlcyB0aGF0CisgICAg ICAgIGBpbnRlcm5hbHMuYXBwSGlnaGxpZ2h0Q29udGV4dE1lbnVJdGVtVGl0bGVzYCBpcyBkZWZp bmVkIGluIGxheW91dCB0ZXN0cyBvbiBNb250ZXJleS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9y bUVuYWJsZUNvY29hLmg6CisKIDIwMjEtMTItMDIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBh cHBsZS5jb20+CiAKICAgICAgICAgbWFjT1MgTW9udGVyZXkgYnVpbGQgZml4IGFmdGVyIHIyODY0 MjAgKHN1Z2dlc3RlZCBieSBCcmFkeSkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0 Zm9ybUVuYWJsZUNvY29hLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmgK aW5kZXggYWU5MmJlZTk4NjA0ZjcwOWY5MDE2YjEzZmMxZTIyYzZmYjMyY2MxNS4uM2YxY2QzMzRh N2FjMDg5NGFhZGRkOTBhMGE0YWIwMzIyYjAxMzMxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93 dGYvUGxhdGZvcm1FbmFibGVDb2NvYS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtRW5h YmxlQ29jb2EuaApAQCAtNzE2LDYgKzcxNiwxMiBAQAogI2RlZmluZSBFTkFCTEVfQVBQX1BSSVZB Q1lfUkVQT1JUIDEKICNlbmRpZgogCisjaWYgKCFkZWZpbmVkKEVOQUJMRV9BUFBfSElHSExJR0hU UykgJiYgXAorICAgIChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVR VUlSRUQgPj0gMTIwMDAwIFwKKyAgICB8fCBQTEFURk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZF UlNJT05fTUlOX1JFUVVJUkVEID49IDE1MDAwMCkpCisjZGVmaW5lIEVOQUJMRV9BUFBfSElHSExJ R0hUUyAxCisjZW5kaWYKKwogI2lmICFkZWZpbmVkKEVOQUJMRV9ERVNUSU5BVElPTl9DT0xPUl9T UEFDRV9ESVNQTEFZX1AzKQogI2RlZmluZSBFTkFCTEVfREVTVElOQVRJT05fQ09MT1JfU1BBQ0Vf RElTUExBWV9QMyAxCiAjZW5kaWYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xz L0NoYW5nZUxvZwppbmRleCA5NDVlYWViODIzMzE5ODg3M2MyNjQwNDE1YTc4MDYxMmE2YmQ4NzQ5 Li5jZGYwNTg4YzJmYmM2ZjJjNmUzM2Q4MzFhYTNjMGQzNjcwMTczMDA3IDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MjEtMTItMDIgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAg ICAgWyBNb250ZXJleSBdIGZhc3QvaW1hZ2VzL3RleHQtcmVjb2duaXRpb24vbWFjL2ltYWdlLW92 ZXJsYXktdGV4dC1kaXNhYmxlcy1hcHAtaGlnaGxpZ2h0LW1lbnUtaXRlbXMuaHRtbCAobGF5b3V0 LXRlc3QpIGlzIGEgY29uc3RhbnQgdGV4dCBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzM2NTgKKyAgICAgICAgcmRhcjovL3Byb2JsZW0v ODU4ODY0MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgYSBmb3J3YXJkIGRlY2xhcmF0aW9uIGZvciBvcGVuIHNvdXJjZSBidWlsZHMuCisKKyAg ICAgICAgKiBUZXN0V2ViS2l0QVBJL2lvcy9VSUtpdFNQSS5oOgorCiAyMDIxLTEyLTAyICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLiBbR1RLXSBVc2UgbnVsbHB0ciBpbnN0ZWFkIG9mIDAgaW4gSlNTdHJpbmdDcmVhdGVXaXRo Q2hhcmFjdGVycygpCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL2lvcy9VSUtpdFNQ SS5oIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9pb3MvVUlLaXRTUEkuaAppbmRleCA0ZGYyYjNlNGU2 MDY5YWRkNjQwOTkwZDhlZGQwZGFlZDc3MGYzMTVkLi4xMmZiNWZjZGM3MWEzNjQ1OTc2YmE3ODc0 NmY4ZmU4ZmQ2NTU5ZTU2IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL2lvcy9VSUtp dFNQSS5oCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvaW9zL1VJS2l0U1BJLmgKQEAgLTE0MCw2 ICsxNDAsNyBAQCBXVEZfRVhURVJOX0NfRU5ECiAKIEBpbnRlcmZhY2UgVUlDYWxsb3V0QmFyIDog VUlWaWV3CiArIChVSUNhbGxvdXRCYXIgKilzaGFyZWRDYWxsb3V0QmFyOworKyAoVUlDYWxsb3V0 QmFyICopYWN0aXZlQ2FsbG91dEJhcjsKIEBlbmQKIAogQGludGVyZmFjZSBfVUlOYXZpZ2F0aW9u SW50ZXJhY3RpdmVUcmFuc2l0aW9uQmFzZSA6IFVJUGVyY2VudERyaXZlbkludGVyYWN0aXZlVHJh bnNpdGlvbgo=