233647 2021-11-30 11:01:15 -0800 Add a fast path for empty string to setInnerHTML() 2021-12-02 07:22:23 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build All All RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/31844 InRadar P2 Normal --- 1 ashvayka ashvayka cdumez clopez cmarcelo esprehn+autocc ews-watchlist ggaren kangil.han webkit-bug-importer youennf ysuzuki oldest_to_newest 1818836 0 ashvayka 2021-11-30 11:01:15 -0800 Add a fast path for empty string to setInnerHTML() 1818838 1 445444 ashvayka 2021-11-30 11:02:49 -0800 Created attachment 445444 Patch 1818839 2 445445 ashvayka 2021-11-30 11:03:50 -0800 Created attachment 445445 Microbenchmark r286261: 393ms patched: 110ms (3.6x faster) 1818853 3 445444 ggaren 2021-11-30 11:36:43 -0800 Comment on attachment 445444 Patch r=me Nice! 1819255 4 445578 ashvayka 2021-12-01 08:43:40 -0800 Created attachment 445578 Patch Special-case <html> container. 1819299 5 ysuzuki 2021-12-01 09:53:16 -0800 NICE! Can we add a test for this HTMLElement thing? 1819300 6 ashvayka 2021-12-01 09:56:44 -0800 (In reply to Yusuke Suzuki from comment #5) > NICE! Can we add a test for this HTMLElement thing? Thanks! You mean for the <html> thing? imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_innerHTML_tests_innerHTML_1.html captures that. 1819304 7 ysuzuki 2021-12-01 10:04:18 -0800 (In reply to Alexey Shvayka from comment #6) > (In reply to Yusuke Suzuki from comment #5) > > NICE! Can we add a test for this HTMLElement thing? > > Thanks! You mean for the <html> thing? > imported/w3c/web-platform-tests/html/syntax/parsing/ > html5lib_innerHTML_tests_innerHTML_1.html captures that. Perfect! 1819333 8 445596 ashvayka 2021-12-01 11:26:25 -0800 Created attachment 445596 Patch Fix <template> contents case and add a test. 1819334 9 ews-watchlist 2021-12-01 11:27:13 -0800 This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess 1819678 10 445596 ashvayka 2021-12-02 06:42:35 -0800 Comment on attachment 445596 Patch Setting r+ on my own patch, which is already reviewed by Geoff, to make GitHub WPT export bot happy. 1819684 11 ews-feeder 2021-12-02 07:21:22 -0800 Committed r286425 (244771@main): <https://commits.webkit.org/244771@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445596. 1819685 12 webkit-bug-importer 2021-12-02 07:22:23 -0800 <rdar://problem/85970175> 445444 2021-11-30 11:02:49 -0800 2021-12-01 08:43:36 -0800 Patch bug-233647-20211130190247.patch text/plain 2915 ashvayka SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NjMwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDIxLTExLTMwICBBbGV4ZXkg U2h2YXlrYSAgPGFzaHZheWthQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYSBmYXN0IHBhdGgg Zm9yIGVtcHR5IHN0cmluZyB0byBzZXRJbm5lckhUTUwoKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzNjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGEgZmFzdCBwYXRoIGZv ciBgY29udGFpbmVyTm9kZS5pbm5lckhUTUwgPSAiImAsIHdoaWNoIGlzIGEgY29tbW9uCisgICAg ICAgIGlkaW9tIHRvIHJlbW92ZSBhbGwgY2hpbGRyZW4gZnJvbSBhIGNvbnRhaW5lciBub2RlLCB3 aGlsZSBlbnN1cmluZyBtdXRhdGlvbiByZWNvcmRzCisgICAgICAgIGFyZSBlbnF1ZXVlZC4KKwor ICAgICAgICBCeXBhc3NpbmcgcGFyc2VyIGluc3RhbnRpYXRpb24gcmVzdWx0cyBpbiBhIDMuNngg cHJvZ3Jlc3Npb24gb2YgYXR0YWNoZWQgbWljcm9iZW5jaG1hcmsuCisgICAgICAgIEJsaW5rIGhh cyB0aGlzIG9wdGltaXphdGlvbiwgd2hpbGUgb3VyIGB0ZXh0Q29udGVudGAgYW5kIGBpbm5lclRl eHRgIHNldHRlcnMgYXJlIGFscmVhZHkKKyAgICAgICAgZW5vdWdoIGZvciBlbXB0eSBzdHJpbmdz LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAg ICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6c2V0SW5uZXJI VE1MKToKKyAgICAgICAgKiBkb20vU2hhZG93Um9vdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT aGFkb3dSb290OjpzZXRJbm5lckhUTUwpOgorCiAyMDIxLTExLTMwICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgcnZmYyB0byBNZWRp YVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5j cHAJKHJldmlzaW9uIDI4NjI2MSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzEsNiArMzEsNyBAQAogI2luY2x1ZGUgIkF0dHJpYnV0ZUNoYW5n ZUludmFsaWRhdGlvbi5oIgogI2luY2x1ZGUgIkNTU1BhcnNlci5oIgogI2luY2x1ZGUgIkNoaWxk Q2hhbmdlSW52YWxpZGF0aW9uLmgiCisjaW5jbHVkZSAiQ2hpbGRMaXN0TXV0YXRpb25TY29wZS5o IgogI2luY2x1ZGUgIkNocm9tZS5oIgogI2luY2x1ZGUgIkNocm9tZUNsaWVudC5oIgogI2luY2x1 ZGUgIkNsYXNzQ2hhbmdlSW52YWxpZGF0aW9uLmgiCkBAIC0zMjY2LDYgKzMyNjcsMTIgQEAgRXhj ZXB0aW9uT3I8dm9pZD4gRWxlbWVudDo6c2V0T3V0ZXJIVE1MKAogCiBFeGNlcHRpb25Pcjx2b2lk PiBFbGVtZW50OjpzZXRJbm5lckhUTUwoY29uc3QgU3RyaW5nJiBodG1sKQogeworICAgIGlmICho dG1sLmlzRW1wdHkoKSkgeworICAgICAgICBDaGlsZExpc3RNdXRhdGlvblNjb3BlIG11dGF0aW9u KCp0aGlzKTsKKyAgICAgICAgcmVtb3ZlQ2hpbGRyZW4oKTsKKyAgICAgICAgcmV0dXJuIHsgfTsK KyAgICB9CisKICAgICBhdXRvIGZyYWdtZW50ID0gY3JlYXRlRnJhZ21lbnRGb3JJbm5lck91dGVy SFRNTCgqdGhpcywgaHRtbCwgQWxsb3dTY3JpcHRpbmdDb250ZW50KTsKICAgICBpZiAoZnJhZ21l bnQuaGFzRXhjZXB0aW9uKCkpCiAgICAgICAgIHJldHVybiBmcmFnbWVudC5yZWxlYXNlRXhjZXB0 aW9uKCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL1NoYWRvd1Jvb3QuY3BwCShyZXZpc2lvbiAyODYyNjEp CisrKyBTb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTI5LDYgKzI5LDcgQEAKICNpbmNsdWRlICJTaGFkb3dSb290LmgiCiAKICNpbmNsdWRlICJDU1NT dHlsZVNoZWV0LmgiCisjaW5jbHVkZSAiQ2hpbGRMaXN0TXV0YXRpb25TY29wZS5oIgogI2luY2x1 ZGUgIkVsZW1lbnRJbmxpbmVzLmgiCiAjaW5jbHVkZSAiRWxlbWVudFRyYXZlcnNhbC5oIgogI2lu Y2x1ZGUgIkhUTUxQYXJzZXJJZGlvbXMuaCIKQEAgLTE4Miw2ICsxODMsMTIgQEAgU3RyaW5nIFNo YWRvd1Jvb3Q6OmlubmVySFRNTCgpIGNvbnN0CiAKIEV4Y2VwdGlvbk9yPHZvaWQ+IFNoYWRvd1Jv b3Q6OnNldElubmVySFRNTChjb25zdCBTdHJpbmcmIG1hcmt1cCkKIHsKKyAgICBpZiAobWFya3Vw LmlzRW1wdHkoKSkgeworICAgICAgICBDaGlsZExpc3RNdXRhdGlvblNjb3BlIG11dGF0aW9uKCp0 aGlzKTsKKyAgICAgICAgcmVtb3ZlQ2hpbGRyZW4oKTsKKyAgICAgICAgcmV0dXJuIHsgfTsKKyAg ICB9CisKICAgICBhdXRvIGZyYWdtZW50ID0gY3JlYXRlRnJhZ21lbnRGb3JJbm5lck91dGVySFRN TCgqaG9zdCgpLCBtYXJrdXAsIEFsbG93U2NyaXB0aW5nQ29udGVudCk7CiAgICAgaWYgKGZyYWdt ZW50Lmhhc0V4Y2VwdGlvbigpKQogICAgICAgICByZXR1cm4gZnJhZ21lbnQucmVsZWFzZUV4Y2Vw dGlvbigpOwo= 445445 2021-11-30 11:03:50 -0800 2021-11-30 11:03:50 -0800 Microbenchmark microbenchmark.html text/html 792 ashvayka PCFET0NUWVBFIGh0bWw+CjxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4KPGJ1dHRvbiBpZD0iJHN0YXJ0 Ij5zdGFydDwvYnV0dG9uPgo8aDMgaWQ9IiRvdXRwdXQiPjwvaDM+CjxkaXYgaWQ9IiR0ZXN0Ij48 L2Rpdj4KPHNjcmlwdD4KdmFyIHJ1bnMgPSAwOwp2YXIgd2FybVVwUnVucyA9IDU7CnZhciBkZWx0 YVN1bSA9IDA7Cgokc3RhcnQub25jbGljayA9ICgpID0+IHsKICAgICRzdGFydC5kaXNhYmxlZCA9 IHRydWU7CiAgICBzZXRJbnRlcnZhbCgoKSA9PiB7CiAgICAgICAgdmFyIHN0YXJ0ID0gRGF0ZS5u b3coKTsKICAgICAgICB2YXIgZDsKCiAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCAxXzAwMF8w MDA7ICsraSkKICAgICAgICAgICAgJHRlc3QuaW5uZXJIVE1MID0gIiI7CgogICAgICAgIHZhciBk ZWx0YSA9IERhdGUubm93KCkgLSBzdGFydDsKICAgICAgICBydW5zKys7CgogICAgICAgIGlmIChy dW5zIDw9IHdhcm1VcFJ1bnMpIHsKICAgICAgICAgICAgJG91dHB1dC50ZXh0Q29udGVudCA9IGB3 YXJtLXVwIHJ1biAke3J1bnN9IC8gJHt3YXJtVXBSdW5zfWA7CiAgICAgICAgfSBlbHNlIHsKICAg ICAgICAgICAgZGVsdGFTdW0gKz0gZGVsdGE7CiAgICAgICAgICAgIHZhciBtZWFzdXJlZFJ1bnMg PSBydW5zIC0gd2FybVVwUnVuczsKICAgICAgICAgICAgJG91dHB1dC50ZXh0Q29udGVudCA9IGBB Vkc6ICR7KGRlbHRhU3VtIC8gbWVhc3VyZWRSdW5zKS50b0ZpeGVkKDIpfW1zICgke21lYXN1cmVk UnVuc30gcnVucylgOwogICAgICAgIH0KICAgIH0sIDEwMDApOwp9Owo8L3NjcmlwdD4K 445578 2021-12-01 08:43:40 -0800 2021-12-01 11:26:21 -0800 Patch bug-233647-20211201164339.patch text/plain 3495 ashvayka SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NjMwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBACisyMDIxLTExLTMwICBBbGV4ZXkg U2h2YXlrYSAgPGFzaHZheWthQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYSBmYXN0IHBhdGgg Zm9yIGVtcHR5IHN0cmluZyB0byBzZXRJbm5lckhUTUwoKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzNjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg R2VvZmYgR2FyZW4uCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGEgZmFzdCBwYXRoIGZvciBg Y29udGFpbmVyTm9kZS5pbm5lckhUTUwgPSAiImAsIHdoaWNoIGlzIGEgY29tbW9uCisgICAgICAg IGlkaW9tIHRvIHJlbW92ZSBhbGwgY2hpbGRyZW4gZnJvbSBhIGNvbnRhaW5lciBub2RlLCB3aGls ZSBlbnN1cmluZyBtdXRhdGlvbiByZWNvcmRzCisgICAgICAgIGFyZSBlbnF1ZXVlZC4KKworICAg ICAgICBBbHRob3VnaCB0aGVyZSBhcmUgcXVpdGUgYSBmZXcgaW5zZXJ0aW9uIG1vZGVzIFsxXSwg cGFyc2luZyBlbXB0eSBzdHJpbmcgY3JlYXRlcworICAgICAgICBhZGRpdGlvbmFsIGVsZW1lbnRz IG9ubHkgZm9yIDxodG1sPiBjb250YWluZXIgKHBsZWFzZSBzZWUgIkFueXRoaW5nIGVsc2UiIGNs YXVzZXMpLgorCisgICAgICAgIEJ5cGFzc2luZyBwYXJzZXIgaW5zdGFudGlhdGlvbiByZXN1bHRz IGluIDMuNnggcHJvZ3Jlc3Npb24gb2YgYXR0YWNoZWQgbWljcm9iZW5jaG1hcmsuCisgICAgICAg IEJvdGggR2Vja28gYW5kIEJsaW5rIGhhcyB0aGlzIG9wdGltaXphdGlvbiwgd2hpY2ggd2FzIHJl cG9ydGVkIHRvIHByb2dyZXNzIFNwZWVkb21ldGVyMgorICAgICAgICBzY29yZSAoZXNwZWNpYWxs eSBWYW5pbGxhIC8galF1ZXJ5IC8gUHJlYWN0IHN1YnRlc3RzKS4KKworICAgICAgICBPdXIgYHRl eHRDb250ZW50YCBhbmQgYGlubmVyVGV4dGAgc2V0dGVycyBhcmUgYWxyZWFkeSBlbm91Z2ggZm9y IGVtcHR5IHN0cmluZ3MuCisKKyAgICAgICAgWzFdIGh0dHBzOi8vaHRtbC5zcGVjLndoYXR3Zy5v cmcvbXVsdGlwYWdlL3BhcnNpbmcuaHRtbCNwYXJzaW5nLW1haW4taW5odG1sCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBkb20vRWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50OjpzZXRJbm5lckhUTUwpOgorICAgICAg ICAqIGRvbS9TaGFkb3dSb290LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYWRvd1Jvb3Q6OnNl dElubmVySFRNTCk6CisKIDIwMjEtMTEtMzAgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUu Y29tPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBydmZjIHRvIE1lZGlhUGxheWVyUHJpdmF0 ZU1lZGlhU291cmNlQVZGT2JqQwpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24g Mjg2MjYxKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSAiQXR0cmlidXRlQ2hhbmdlSW52YWxpZGF0aW9u LmgiCiAjaW5jbHVkZSAiQ1NTUGFyc2VyLmgiCiAjaW5jbHVkZSAiQ2hpbGRDaGFuZ2VJbnZhbGlk YXRpb24uaCIKKyNpbmNsdWRlICJDaGlsZExpc3RNdXRhdGlvblNjb3BlLmgiCiAjaW5jbHVkZSAi Q2hyb21lLmgiCiAjaW5jbHVkZSAiQ2hyb21lQ2xpZW50LmgiCiAjaW5jbHVkZSAiQ2xhc3NDaGFu Z2VJbnZhbGlkYXRpb24uaCIKQEAgLTMyNjYsNiArMzI2NywxNCBAQCBFeGNlcHRpb25Pcjx2b2lk PiBFbGVtZW50OjpzZXRPdXRlckhUTUwoCiAKIEV4Y2VwdGlvbk9yPHZvaWQ+IEVsZW1lbnQ6OnNl dElubmVySFRNTChjb25zdCBTdHJpbmcmIGh0bWwpCiB7CisgICAgLy8gUGFyc2luZyBlbXB0eSBz dHJpbmcgY3JlYXRlcyBhZGRpdGlvbmFsIGVsZW1lbnRzIG9ubHkgZm9yIDxodG1sPiBjb250YWlu ZXIKKyAgICAvLyBodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9wYXJzaW5n Lmh0bWwjcGFyc2luZy1tYWluLWluaHRtbAorICAgIGlmIChodG1sLmlzRW1wdHkoKSAmJiAhaXM8 SFRNTEh0bWxFbGVtZW50PigqdGhpcykpIHsKKyAgICAgICAgQ2hpbGRMaXN0TXV0YXRpb25TY29w ZSBtdXRhdGlvbigqdGhpcyk7CisgICAgICAgIHJlbW92ZUNoaWxkcmVuKCk7CisgICAgICAgIHJl dHVybiB7IH07CisgICAgfQorCiAgICAgYXV0byBmcmFnbWVudCA9IGNyZWF0ZUZyYWdtZW50Rm9y SW5uZXJPdXRlckhUTUwoKnRoaXMsIGh0bWwsIEFsbG93U2NyaXB0aW5nQ29udGVudCk7CiAgICAg aWYgKGZyYWdtZW50Lmhhc0V4Y2VwdGlvbigpKQogICAgICAgICByZXR1cm4gZnJhZ21lbnQucmVs ZWFzZUV4Y2VwdGlvbigpOwpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL1NoYWRvd1Jvb3QuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmNwcAkocmV2aXNp b24gMjg2MjYxKQorKysgU291cmNlL1dlYkNvcmUvZG9tL1NoYWRvd1Jvb3QuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yOSw2ICsyOSw3IEBACiAjaW5jbHVkZSAiU2hhZG93Um9vdC5oIgogCiAjaW5j bHVkZSAiQ1NTU3R5bGVTaGVldC5oIgorI2luY2x1ZGUgIkNoaWxkTGlzdE11dGF0aW9uU2NvcGUu aCIKICNpbmNsdWRlICJFbGVtZW50SW5saW5lcy5oIgogI2luY2x1ZGUgIkVsZW1lbnRUcmF2ZXJz YWwuaCIKICNpbmNsdWRlICJIVE1MUGFyc2VySWRpb21zLmgiCkBAIC0xODIsNiArMTgzLDEyIEBA IFN0cmluZyBTaGFkb3dSb290Ojppbm5lckhUTUwoKSBjb25zdAogCiBFeGNlcHRpb25Pcjx2b2lk PiBTaGFkb3dSb290OjpzZXRJbm5lckhUTUwoY29uc3QgU3RyaW5nJiBtYXJrdXApCiB7CisgICAg aWYgKG1hcmt1cC5pc0VtcHR5KCkpIHsKKyAgICAgICAgQ2hpbGRMaXN0TXV0YXRpb25TY29wZSBt dXRhdGlvbigqdGhpcyk7CisgICAgICAgIHJlbW92ZUNoaWxkcmVuKCk7CisgICAgICAgIHJldHVy biB7IH07CisgICAgfQorCiAgICAgYXV0byBmcmFnbWVudCA9IGNyZWF0ZUZyYWdtZW50Rm9ySW5u ZXJPdXRlckhUTUwoKmhvc3QoKSwgbWFya3VwLCBBbGxvd1NjcmlwdGluZ0NvbnRlbnQpOwogICAg IGlmIChmcmFnbWVudC5oYXNFeGNlcHRpb24oKSkKICAgICAgICAgcmV0dXJuIGZyYWdtZW50LnJl bGVhc2VFeGNlcHRpb24oKTsK 445596 2021-12-01 11:26:25 -0800 2021-12-02 07:21:24 -0800 Patch bug-233647-20211201192624.patch text/plain 7220 ashvayka SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NjMwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBACisyMDIxLTEyLTAxICBBbGV4ZXkg U2h2YXlrYSAgPGFzaHZheWthQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYSBmYXN0IHBhdGgg Zm9yIGVtcHR5IHN0cmluZyB0byBzZXRJbm5lckhUTUwoKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzNjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg R2VvZmYgR2FyZW4uCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGEgZmFzdCBwYXRoIGZvciBg ZWxlbWVudC5pbm5lckhUTUwgPSAiImAsIHdoaWNoIGlzIGEgY29tbW9uIGlkaW9tIGZvcgorICAg ICAgICByZW1vdmluZyBhbGwgY2hpbGRyZW4gZnJvbSBhbiBlbGVtZW50LCB3aGlsZSBlbnN1cmlu ZyA8dGVtcGxhdGU+IGNvbnRlbnRzIGlzIG1vZGlmaWVkCisgICAgICAgIHJhdGhlciB0aGFuIGl0 cyBjaGlsZHJlbiBbMV0sIGFuZCB0aGF0IG11dGF0aW9uIHJlY29yZHMgYXJlIGVucXVldWVkLgor CisgICAgICAgIEFsdGhvdWdoIHRoZXJlIGFyZSBxdWl0ZSBhIGZldyBpbnNlcnRpb24gbW9kZXMg WzFdLCBwYXJzaW5nIGVtcHR5IHN0cmluZyBjcmVhdGVzCisgICAgICAgIGFkZGl0aW9uYWwgZWxl bWVudHMgb25seSBpbnNpZGUgPGh0bWw+IGNvbnRhaW5lciAocGxlYXNlIHNlZSAiQW55dGhpbmcg ZWxzZSIgY2xhdXNlcykuCisKKyAgICAgICAgQnlwYXNzaW5nIHBhcnNlciBpbnN0YW50aWF0aW9u IHJlc3VsdHMgaW4gMy4yeCBwcm9ncmVzc2lvbiBvZiB0aGUgYXR0YWNoZWQgbWljcm9iZW5jaG1h cmsuCisgICAgICAgIEJvdGggR2Vja28gYW5kIEJsaW5rIGhhcyB0aGlzIG9wdGltaXphdGlvbiwg d2hpY2ggd2FzIHJlcG9ydGVkIHRvIHByb2dyZXNzIFNwZWVkb21ldGVyMgorICAgICAgICBzY29y ZSAoZXNwZWNpYWxseSBWYW5pbGxhIC8galF1ZXJ5IC8gUHJlYWN0IHN1YnRlc3RzKS4KKworICAg ICAgICBPdXIgYHRleHRDb250ZW50YCBhbmQgYGlubmVyVGV4dGAgc2V0dGVycyBhcmUgYWxyZWFk eSBmYXN0IGVub3VnaCBmb3IgZW1wdHkgc3RyaW5ncy4KKworICAgICAgICBbMV0gaHR0cHM6Ly93 M2MuZ2l0aHViLmlvL0RPTS1QYXJzaW5nLyNkb20taW5uZXJodG1sLWlubmVyaHRtbCAoc2V0dGlu Zywgc3RlcCAzKQorICAgICAgICBbMl0gaHR0cHM6Ly9odG1sLnNwZWMud2hhdHdnLm9yZy9tdWx0 aXBhZ2UvcGFyc2luZy5odG1sI3BhcnNpbmctbWFpbi1pbmh0bWwKKworICAgICAgICBObyBiZWhh dmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpFbGVtZW50OjpzZXRJbm5lckhUTUwpOgorICAgICAgICAqIGRvbS9TaGFkb3dSb290LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYWRvd1Jvb3Q6OnNldElubmVySFRNTCk6CisKIDIwMjEt MTEtMzAgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBz dXBwb3J0IGZvciBydmZjIHRvIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQwpJ bmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24gMjg2MjYxKQorKysgU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw2ICszMSw3IEBACiAj aW5jbHVkZSAiQXR0cmlidXRlQ2hhbmdlSW52YWxpZGF0aW9uLmgiCiAjaW5jbHVkZSAiQ1NTUGFy c2VyLmgiCiAjaW5jbHVkZSAiQ2hpbGRDaGFuZ2VJbnZhbGlkYXRpb24uaCIKKyNpbmNsdWRlICJD aGlsZExpc3RNdXRhdGlvblNjb3BlLmgiCiAjaW5jbHVkZSAiQ2hyb21lLmgiCiAjaW5jbHVkZSAi Q2hyb21lQ2xpZW50LmgiCiAjaW5jbHVkZSAiQ2xhc3NDaGFuZ2VJbnZhbGlkYXRpb24uaCIKQEAg LTMyNjYsMTYgKzMyNjcsMjQgQEAgRXhjZXB0aW9uT3I8dm9pZD4gRWxlbWVudDo6c2V0T3V0ZXJI VE1MKAogCiBFeGNlcHRpb25Pcjx2b2lkPiBFbGVtZW50OjpzZXRJbm5lckhUTUwoY29uc3QgU3Ry aW5nJiBodG1sKQogewotICAgIGF1dG8gZnJhZ21lbnQgPSBjcmVhdGVGcmFnbWVudEZvcklubmVy T3V0ZXJIVE1MKCp0aGlzLCBodG1sLCBBbGxvd1NjcmlwdGluZ0NvbnRlbnQpOwotICAgIGlmIChm cmFnbWVudC5oYXNFeGNlcHRpb24oKSkKLSAgICAgICAgcmV0dXJuIGZyYWdtZW50LnJlbGVhc2VF eGNlcHRpb24oKTsKLQogICAgIENvbnRhaW5lck5vZGUqIGNvbnRhaW5lcjsKICAgICBpZiAoIWlz PEhUTUxUZW1wbGF0ZUVsZW1lbnQ+KCp0aGlzKSkKICAgICAgICAgY29udGFpbmVyID0gdGhpczsK ICAgICBlbHNlCiAgICAgICAgIGNvbnRhaW5lciA9ICZkb3duY2FzdDxIVE1MVGVtcGxhdGVFbGVt ZW50PigqdGhpcykuY29udGVudCgpOwogCisgICAgLy8gUGFyc2luZyBlbXB0eSBzdHJpbmcgY3Jl YXRlcyBhZGRpdGlvbmFsIGVsZW1lbnRzIG9ubHkgaW5zaWRlIDxodG1sPiBjb250YWluZXIKKyAg ICAvLyBodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9wYXJzaW5nLmh0bWwj cGFyc2luZy1tYWluLWluaHRtbAorICAgIGlmIChodG1sLmlzRW1wdHkoKSAmJiAhaXM8SFRNTEh0 bWxFbGVtZW50PigqY29udGFpbmVyKSkgeworICAgICAgICBDaGlsZExpc3RNdXRhdGlvblNjb3Bl IG11dGF0aW9uKCpjb250YWluZXIpOworICAgICAgICBjb250YWluZXItPnJlbW92ZUNoaWxkcmVu KCk7CisgICAgICAgIHJldHVybiB7IH07CisgICAgfQorCisgICAgYXV0byBmcmFnbWVudCA9IGNy ZWF0ZUZyYWdtZW50Rm9ySW5uZXJPdXRlckhUTUwoKnRoaXMsIGh0bWwsIEFsbG93U2NyaXB0aW5n Q29udGVudCk7CisgICAgaWYgKGZyYWdtZW50Lmhhc0V4Y2VwdGlvbigpKQorICAgICAgICByZXR1 cm4gZnJhZ21lbnQucmVsZWFzZUV4Y2VwdGlvbigpOworCiAgICAgcmV0dXJuIHJlcGxhY2VDaGls ZHJlbldpdGhGcmFnbWVudCgqY29udGFpbmVyLCBmcmFnbWVudC5yZWxlYXNlUmV0dXJuVmFsdWUo KSk7CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5jcHAJKHJldmlzaW9uIDI4NjI2 MSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjksNiArMjksNyBAQAogI2luY2x1ZGUgIlNoYWRvd1Jvb3QuaCIKIAogI2luY2x1ZGUgIkNT U1N0eWxlU2hlZXQuaCIKKyNpbmNsdWRlICJDaGlsZExpc3RNdXRhdGlvblNjb3BlLmgiCiAjaW5j bHVkZSAiRWxlbWVudElubGluZXMuaCIKICNpbmNsdWRlICJFbGVtZW50VHJhdmVyc2FsLmgiCiAj aW5jbHVkZSAiSFRNTFBhcnNlcklkaW9tcy5oIgpAQCAtMTgyLDYgKzE4MywxMiBAQCBTdHJpbmcg U2hhZG93Um9vdDo6aW5uZXJIVE1MKCkgY29uc3QKIAogRXhjZXB0aW9uT3I8dm9pZD4gU2hhZG93 Um9vdDo6c2V0SW5uZXJIVE1MKGNvbnN0IFN0cmluZyYgbWFya3VwKQogeworICAgIGlmIChtYXJr dXAuaXNFbXB0eSgpKSB7CisgICAgICAgIENoaWxkTGlzdE11dGF0aW9uU2NvcGUgbXV0YXRpb24o KnRoaXMpOworICAgICAgICByZW1vdmVDaGlsZHJlbigpOworICAgICAgICByZXR1cm4geyB9Owor ICAgIH0KKwogICAgIGF1dG8gZnJhZ21lbnQgPSBjcmVhdGVGcmFnbWVudEZvcklubmVyT3V0ZXJI VE1MKCpob3N0KCksIG1hcmt1cCwgQWxsb3dTY3JpcHRpbmdDb250ZW50KTsKICAgICBpZiAoZnJh Z21lbnQuaGFzRXhjZXB0aW9uKCkpCiAgICAgICAgIHJldHVybiBmcmFnbWVudC5yZWxlYXNlRXhj ZXB0aW9uKCk7CkluZGV4OiBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4 NjM3NCkKKysrIExheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxMyBAQAorMjAyMS0xMi0wMSAgQWxleGV5IFNodmF5a2EgIDxhc2h2YXlr YUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgZmFzdCBwYXRoIGZvciBlbXB0eSBzdHJpbmcg dG8gc2V0SW5uZXJIVE1MKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIzMzY0NworCisgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmIEdhcmVuLgorCisg ICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL3NjcmlwdGluZy0xL3Ro ZS10ZW1wbGF0ZS1lbGVtZW50L2lubmVyaHRtbC1vbi10ZW1wbGF0ZXMvaW5uZXJodG1sLWV4cGVj dGVkLnR4dDoKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3Mvc2Ny aXB0aW5nLTEvdGhlLXRlbXBsYXRlLWVsZW1lbnQvaW5uZXJodG1sLW9uLXRlbXBsYXRlcy9pbm5l cmh0bWwuaHRtbDoKKwogMjAyMS0xMi0wMSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5j b20+CiAKICAgICAgICAgWzpoYXMoKSBwc2V1ZG8tY2xhc3NdIFNpYmxpbmcgY29tYmluYXRvciBp bnZhbGlkYXRpb24KSW5kZXg6IExheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvaHRtbC9zZW1hbnRpY3Mvc2NyaXB0aW5nLTEvdGhlLXRlbXBsYXRlLWVsZW1lbnQvaW5u ZXJodG1sLW9uLXRlbXBsYXRlcy9pbm5lcmh0bWwtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRp Y3Mvc2NyaXB0aW5nLTEvdGhlLXRlbXBsYXRlLWVsZW1lbnQvaW5uZXJodG1sLW9uLXRlbXBsYXRl cy9pbm5lcmh0bWwtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAyODYyNjEpCisrKyBMYXlvdXRUZXN0 cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL3NjcmlwdGlu Zy0xL3RoZS10ZW1wbGF0ZS1lbGVtZW50L2lubmVyaHRtbC1vbi10ZW1wbGF0ZXMvaW5uZXJodG1s LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDYgQEAKIAogUEFTUyBpbm5l ckhUTUwgb2YgdGVtcGxhdGUgZWxlbWVudCByZXBsYWNlcyBhbGwgcmVmZXJlbmNlZCBieSB0aGUg Y29udGVudCBhdHRyaWJ1dGUKK1BBU1MgaW5uZXJIVE1MIG9mIHRlbXBsYXRlIGVsZW1lbnQgcmVw bGFjZXMgYWxsIHJlZmVyZW5jZWQgYnkgdGhlIGNvbnRlbnQgYXR0cmlidXRlLiBUZXN0IGVtcHR5 IEhUTUwgc3RyaW5nCiBQQVNTIGlubmVySFRNTCBvZiB0ZW1wbGF0ZSBlbGVtZW50IHJlcGxhY2Vz IGFsbCByZWZlcmVuY2VkIGJ5IHRoZSBjb250ZW50IGF0dHJpYnV0ZS4gVGVzdCBuZXN0ZWQgdGVt cGxhdGUKIFBBU1MgaW5uZXJIVE1MIG9mIHRlbXBsYXRlIGVsZW1lbnQgcmVwbGFjZXMgYWxsIHJl ZmVyZW5jZWQgYnkgdGhlIGNvbnRlbnQgYXR0cmlidXRlLiBUZXN0IGxvYWRpbmcgb2YgSFRNTCBk b2N1bWVudCBmcm9tIGEgZmlsZQogCkluZGV4OiBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL3NjcmlwdGluZy0xL3RoZS10ZW1wbGF0ZS1l bGVtZW50L2lubmVyaHRtbC1vbi10ZW1wbGF0ZXMvaW5uZXJodG1sLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFu dGljcy9zY3JpcHRpbmctMS90aGUtdGVtcGxhdGUtZWxlbWVudC9pbm5lcmh0bWwtb24tdGVtcGxh dGVzL2lubmVyaHRtbC5odG1sCShyZXZpc2lvbiAyODYyNjEpCisrKyBMYXlvdXRUZXN0cy9pbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL3NjcmlwdGluZy0xL3Ro ZS10ZW1wbGF0ZS1lbGVtZW50L2lubmVyaHRtbC1vbi10ZW1wbGF0ZXMvaW5uZXJodG1sLmh0bWwJ KHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1LDI1IEBAIHRlc3QoZnVuY3Rpb24gKCkgewogfSwg J2lubmVySFRNTCBvZiB0ZW1wbGF0ZSBlbGVtZW50IHJlcGxhY2VzIGFsbCByZWZlcmVuY2VkIGJ5 IHRoZSBjb250ZW50IGF0dHJpYnV0ZScpOwogCiAKK3Rlc3QoZnVuY3Rpb24gKCkgeworICAgIHZh ciBkb2MgPSBuZXdIVE1MRG9jdW1lbnQoKTsKKyAgICB2YXIgdGVtcGxhdGUgPSBkb2MuY3JlYXRl RWxlbWVudCgndGVtcGxhdGUnKTsKKworICAgIHZhciBkaXYxID0gZG9jLmNyZWF0ZUVsZW1lbnQo J2RpdicpOworICAgIGRpdjEuc2V0QXR0cmlidXRlKCdpZCcsICdkaXYxJyk7CisgICAgdGVtcGxh dGUuY29udGVudC5hcHBlbmRDaGlsZChkaXYxKTsKKworICAgIGFzc2VydF9ub3RfZXF1YWxzKHRl bXBsYXRlLmNvbnRlbnQucXVlcnlTZWxlY3RvcignI2RpdjEnKSwgbnVsbCwKKyAgICAgICAgICAg ICdFbGVtZW50IHNob3VsZCBwcmVzZW50IGluIHRlbXBsYXRlIGNvbnRlbnQnKTsKKworICAgIHRl bXBsYXRlLmlubmVySFRNTCA9ICcnOworCisgICAgYXNzZXJ0X2ZhbHNlKHRlbXBsYXRlLmNvbnRl bnQuaGFzQ2hpbGROb2RlcygpLAorICAgICAgICAgICAgJ1RlbXBsYXRlIGNvbnRlbnQgc2hvdWxk IGJlIHJlbW92ZWQgYnkgaW5uZXJIVE1MJyk7CisKK30sICdpbm5lckhUTUwgb2YgdGVtcGxhdGUg ZWxlbWVudCByZXBsYWNlcyBhbGwgcmVmZXJlbmNlZCBieSB0aGUgY29udGVudCBhdHRyaWJ1dGUu ICcKKyAgICArICdUZXN0IGVtcHR5IEhUTUwgc3RyaW5nJyk7CisKIAogdGVzdChmdW5jdGlvbiAo KSB7CiAgICAgdmFyIGRvYyA9IG5ld0hUTUxEb2N1bWVudCgpOwo=