233615 2021-11-29 19:52:47 -0800 [LFC][IFC] Move inline box geometry (BoxGeometry) update logic to a dedicated function 2021-12-02 12:23:28 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1818582 0 zalan 2021-11-29 19:52:47 -0800 ssia 1818584 1 445373 zalan 2021-11-29 19:56:13 -0800 Created attachment 445373 Patch 1819825 2 ews-feeder 2021-12-02 12:22:47 -0800 Committed r286445 (244787@main): <https://commits.webkit.org/244787@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445373. 1819826 3 webkit-bug-importer 2021-12-02 12:23:28 -0800 <rdar://problem/85983695> 445373 2021-11-29 19:56:13 -0800 2021-12-02 12:22:49 -0800 Patch bug-233615-20211129195612.patch text/plain 6505 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTdkNDE1ZWIwMzlkMjk0 YmE2YmUzOGFlYWM5NGRkNTVjMzYyY2EwYy4uN2M4YTZhNmEzNDJhZmUwZjI1NzI0ODZkNDc2Zjkz Njg3NWJiNmEzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTExLTI5ICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJRkNdIE1vdmUgaW5s aW5lIGJveCBnZW9tZXRyeSAoQm94R2VvbWV0cnkpIHVwZGF0ZSBsb2dpYyB0byBhIGRlZGljYXRl ZCBmdW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMzNjE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyBpcyBhbHNvIGluIHByZXBhcmF0aW9uIGZvciBjb21wdXRpbmcgdGhlIEJveEdlb21l dHJ5IGZvciBiaWRpIGlubGluZSBib3hlcy4KKworICAgICAgICAqIGxheW91dC9mb3JtYXR0aW5n Q29udGV4dHMvaW5saW5lL0lubGluZURpc3BsYXlDb250ZW50QnVpbGRlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpMYXlvdXQ6OklubGluZURpc3BsYXlDb250ZW50QnVpbGRlcjo6c2V0SW5saW5l Qm94R2VvbWV0cnkpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpJbmxpbmVEaXNwbGF5Q29u dGVudEJ1aWxkZXI6OmFwcGVuZElubGluZUJveERpc3BsYXlCb3gpOgorICAgICAgICAoV2ViQ29y ZTo6TGF5b3V0OjpJbmxpbmVEaXNwbGF5Q29udGVudEJ1aWxkZXI6OmFwcGVuZFNwYW5uaW5nSW5s aW5lQm94RGlzcGxheUJveCk6CisgICAgICAgICogbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9p bmxpbmUvSW5saW5lRGlzcGxheUNvbnRlbnRCdWlsZGVyLmg6CisKIDIwMjEtMTEtMjkgIEFsYW4g QnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gSW5jb3JyZWN0 IGJpZGkgZGlzcGxheSBib3ggdmVydGljYWwgcG9zaXRpb25pbmcKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZURpc3BsYXlD b250ZW50QnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRl eHRzL2lubGluZS9JbmxpbmVEaXNwbGF5Q29udGVudEJ1aWxkZXIuY3BwCmluZGV4IGY5N2JiOGVi MjE2MGE0ZTM4YjdkZTc0ZGQzZjIzMDA5MWJjNjliZDMuLmFmOTBkMDU2YmFhYjY3N2E0NWEzMDU4 Mjk0MTc1ZmI3ODEyM2RmYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3Jt YXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZURpc3BsYXlDb250ZW50QnVpbGRlci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5l RGlzcGxheUNvbnRlbnRCdWlsZGVyLmNwcApAQCAtMTkyLDYgKzE5MiwyMyBAQCB2b2lkIElubGlu ZURpc3BsYXlDb250ZW50QnVpbGRlcjo6YXBwZW5kQXRvbWljSW5saW5lTGV2ZWxEaXNwbGF5Qm94 KGNvbnN0IExpbmU6OgogICAgIGFkanVzdFBhcmVudElubGluZUJveElua092ZXJmbG93KCk7CiB9 CiAKK3ZvaWQgSW5saW5lRGlzcGxheUNvbnRlbnRCdWlsZGVyOjpzZXRJbmxpbmVCb3hHZW9tZXRy eShjb25zdCBCb3gmIGxheW91dEJveCwgY29uc3QgSW5saW5lUmVjdCYgcmVjdCwgYm9vbCBpc0Zp cnN0SW5saW5lQm94RnJhZ21lbnQpCit7CisgICAgYXV0byBhZGp1c3RlZFNpemUgPSBMYXlvdXRT aXplIHsgTGF5b3V0VW5pdDo6ZnJvbUZsb2F0Q2VpbChyZWN0LndpZHRoKCkpLCBMYXlvdXRVbml0 Ojpmcm9tRmxvYXRDZWlsKHJlY3QuaGVpZ2h0KCkpIH07CisgICAgYXV0byBhZGp1c3RlZFJlY3Qg PSBSZWN0IHsgTGF5b3V0UG9pbnQgeyByZWN0LnRvcExlZnQoKSB9LCBhZGp1c3RlZFNpemUgfTsK KyAgICBhdXRvJiBib3hHZW9tZXRyeSA9IGZvcm1hdHRpbmdTdGF0ZSgpLmJveEdlb21ldHJ5KGxh eW91dEJveCk7CisgICAgaWYgKCFpc0ZpcnN0SW5saW5lQm94RnJhZ21lbnQpIHsKKyAgICAgICAg YXV0byBlbmNsb3NpbmdCb3JkZXJCb3hSZWN0ID0gQm94R2VvbWV0cnk6OmJvcmRlckJveFJlY3Qo Ym94R2VvbWV0cnkpOworICAgICAgICBlbmNsb3NpbmdCb3JkZXJCb3hSZWN0LmV4cGFuZFRvQ29u dGFpbihhZGp1c3RlZFJlY3QpOworICAgICAgICBhZGp1c3RlZFJlY3QgPSBlbmNsb3NpbmdCb3Jk ZXJCb3hSZWN0OworICAgIH0KKyAgICBib3hHZW9tZXRyeS5zZXRMb2dpY2FsVG9wTGVmdChhZGp1 c3RlZFJlY3QudG9wTGVmdCgpKTsKKyAgICBhdXRvIGNvbnRlbnRCb3hIZWlnaHQgPSBhZGp1c3Rl ZFJlY3QuaGVpZ2h0KCkgLSAoYm94R2VvbWV0cnkudmVydGljYWxCb3JkZXIoKSArIGJveEdlb21l dHJ5LnZlcnRpY2FsUGFkZGluZygpLnZhbHVlX29yKDBfbHUpKTsKKyAgICBhdXRvIGNvbnRlbnRC b3hXaWR0aCA9IGFkanVzdGVkUmVjdC53aWR0aCgpIC0gKGJveEdlb21ldHJ5Lmhvcml6b250YWxC b3JkZXIoKSArIGJveEdlb21ldHJ5Lmhvcml6b250YWxQYWRkaW5nKCkudmFsdWVfb3IoMF9sdSkp OworICAgIGJveEdlb21ldHJ5LnNldENvbnRlbnRCb3hIZWlnaHQoY29udGVudEJveEhlaWdodCk7 CisgICAgYm94R2VvbWV0cnkuc2V0Q29udGVudEJveFdpZHRoKGNvbnRlbnRCb3hXaWR0aCk7Cit9 CisKIHZvaWQgSW5saW5lRGlzcGxheUNvbnRlbnRCdWlsZGVyOjphcHBlbmRJbmxpbmVCb3hEaXNw bGF5Qm94KGNvbnN0IExpbmU6OlJ1biYgbGluZVJ1biwgY29uc3QgSW5saW5lTGV2ZWxCb3gmIGlu bGluZUJveCwgY29uc3QgSW5saW5lUmVjdCYgaW5saW5lQm94Qm9yZGVyQm94LCBib29sIGxpbmVo YXNDb250ZW50LCBEaXNwbGF5Qm94ZXMmIGJveGVzKQogewogICAgIEFTU0VSVChsaW5lUnVuLmxh eW91dEJveCgpLmlzSW5saW5lQm94KCkpOwpAQCAtMjIxLDE0ICsyMzgsNyBAQCB2b2lkIElubGlu ZURpc3BsYXlDb250ZW50QnVpbGRlcjo6YXBwZW5kSW5saW5lQm94RGlzcGxheUJveChjb25zdCBM aW5lOjpSdW4mIGxpbgogICAgIH0KIAogICAgIC8vIFRoaXMgaW5saW5lIGJveCBzaG93ZWQgdXAg Zmlyc3Qgb24gdGhpcyBsaW5lLgotICAgIGF1dG8gaW5saW5lQm94U2l6ZSA9IExheW91dFNpemUg eyBMYXlvdXRVbml0Ojpmcm9tRmxvYXRDZWlsKGlubGluZUJveEJvcmRlckJveC53aWR0aCgpKSwg TGF5b3V0VW5pdDo6ZnJvbUZsb2F0Q2VpbChpbmxpbmVCb3hCb3JkZXJCb3guaGVpZ2h0KCkpIH07 Ci0gICAgYXV0byBsb2dpY2FsUmVjdCA9IFJlY3QgeyBMYXlvdXRQb2ludCB7IGlubGluZUJveEJv cmRlckJveC50b3BMZWZ0KCkgfSwgaW5saW5lQm94U2l6ZSB9OwotICAgIGF1dG8mIGJveEdlb21l dHJ5ID0gZm9ybWF0dGluZ1N0YXRlKCkuYm94R2VvbWV0cnkobGF5b3V0Qm94KTsKLSAgICBib3hH ZW9tZXRyeS5zZXRMb2dpY2FsVG9wTGVmdChsb2dpY2FsUmVjdC50b3BMZWZ0KCkpOwotICAgIGF1 dG8gY29udGVudEJveEhlaWdodCA9IGxvZ2ljYWxSZWN0LmhlaWdodCgpIC0gKGJveEdlb21ldHJ5 LnZlcnRpY2FsQm9yZGVyKCkgKyBib3hHZW9tZXRyeS52ZXJ0aWNhbFBhZGRpbmcoKS52YWx1ZV9v cigwX2x1KSk7Ci0gICAgYm94R2VvbWV0cnkuc2V0Q29udGVudEJveEhlaWdodChjb250ZW50Qm94 SGVpZ2h0KTsKLSAgICBhdXRvIGNvbnRlbnRCb3hXaWR0aCA9IGxvZ2ljYWxSZWN0LndpZHRoKCkg LSAoYm94R2VvbWV0cnkuaG9yaXpvbnRhbEJvcmRlcigpICsgYm94R2VvbWV0cnkuaG9yaXpvbnRh bFBhZGRpbmcoKS52YWx1ZV9vcigwX2x1KSk7Ci0gICAgYm94R2VvbWV0cnkuc2V0Q29udGVudEJv eFdpZHRoKGNvbnRlbnRCb3hXaWR0aCk7CisgICAgc2V0SW5saW5lQm94R2VvbWV0cnkobGF5b3V0 Qm94LCBpbmxpbmVCb3hCb3JkZXJCb3gsIHRydWUpOwogfQogCiB2b2lkIElubGluZURpc3BsYXlD b250ZW50QnVpbGRlcjo6YXBwZW5kU3Bhbm5pbmdJbmxpbmVCb3hEaXNwbGF5Qm94KGNvbnN0IExp bmU6OlJ1biYgbGluZVJ1biwgY29uc3QgSW5saW5lTGV2ZWxCb3gmIGlubGluZUJveCwgY29uc3Qg SW5saW5lUmVjdCYgaW5saW5lQm94Qm9yZGVyQm94LCBEaXNwbGF5Qm94ZXMmIGJveGVzKQpAQCAt MjU1LDE2ICsyNjUsOCBAQCB2b2lkIElubGluZURpc3BsYXlDb250ZW50QnVpbGRlcjo6YXBwZW5k U3Bhbm5pbmdJbmxpbmVCb3hEaXNwbGF5Qm94KGNvbnN0IExpbmU6OgogICAgICAgICAsIGlubGlu ZUJveC5oYXNDb250ZW50KCkKICAgICAgICAgLCBpc0ZpcnN0TGFzdEJveChpbmxpbmVCb3gpIH0p OwogCi0gICAgYXV0byBpbmxpbmVCb3hTaXplID0gTGF5b3V0U2l6ZSB7IExheW91dFVuaXQ6OmZy b21GbG9hdENlaWwoaW5saW5lQm94Qm9yZGVyQm94LndpZHRoKCkpLCBMYXlvdXRVbml0Ojpmcm9t RmxvYXRDZWlsKGlubGluZUJveEJvcmRlckJveC5oZWlnaHQoKSkgfTsKLSAgICBhdXRvIGxvZ2lj YWxSZWN0ID0gUmVjdCB7IExheW91dFBvaW50IHsgaW5saW5lQm94Qm9yZGVyQm94LnRvcExlZnQo KSB9LCBpbmxpbmVCb3hTaXplIH07CiAgICAgLy8gTWlkZGxlIG9yIGVuZCBvZiB0aGUgaW5saW5l IGJveC4gTGV0J3Mgc3RyZXRjaCB0aGUgYm94IGFzIG5lZWRlZC4KLSAgICBhdXRvJiBib3hHZW9t ZXRyeSA9IGZvcm1hdHRpbmdTdGF0ZSgpLmJveEdlb21ldHJ5KGxheW91dEJveCk7Ci0gICAgYXV0 byBlbmNsb3NpbmdCb3JkZXJCb3hSZWN0ID0gQm94R2VvbWV0cnk6OmJvcmRlckJveFJlY3QoYm94 R2VvbWV0cnkpOwotICAgIGVuY2xvc2luZ0JvcmRlckJveFJlY3QuZXhwYW5kVG9Db250YWluKGxv Z2ljYWxSZWN0KTsKLSAgICBib3hHZW9tZXRyeS5zZXRMb2dpY2FsTGVmdChlbmNsb3NpbmdCb3Jk ZXJCb3hSZWN0LmxlZnQoKSk7Ci0KLSAgICBib3hHZW9tZXRyeS5zZXRDb250ZW50Qm94SGVpZ2h0 KGVuY2xvc2luZ0JvcmRlckJveFJlY3QuaGVpZ2h0KCkgLSAoYm94R2VvbWV0cnkudmVydGljYWxC b3JkZXIoKSArIGJveEdlb21ldHJ5LnZlcnRpY2FsUGFkZGluZygpLnZhbHVlX29yKDBfbHUpKSk7 Ci0gICAgYm94R2VvbWV0cnkuc2V0Q29udGVudEJveFdpZHRoKGVuY2xvc2luZ0JvcmRlckJveFJl Y3Qud2lkdGgoKSAtIChib3hHZW9tZXRyeS5ob3Jpem9udGFsQm9yZGVyKCkgKyBib3hHZW9tZXRy eS5ob3Jpem9udGFsUGFkZGluZygpLnZhbHVlX29yKDBfbHUpKSk7CisgICAgc2V0SW5saW5lQm94 R2VvbWV0cnkobGF5b3V0Qm94LCBpbmxpbmVCb3hCb3JkZXJCb3gsIGZhbHNlKTsKIH0KIAogdm9p ZCBJbmxpbmVEaXNwbGF5Q29udGVudEJ1aWxkZXI6OmFwcGVuZElubGluZUJveERpc3BsYXlCb3hG b3JCaWRpQm91bmRhcnkoY29uc3QgQm94JiBsYXlvdXRCb3gsIGNvbnN0IElubGluZVJlY3QmIGlu bGluZUJveFJlY3QsIGJvb2wgaXNGaXJzdElubGluZUJveEZyYWdtZW50LCBEaXNwbGF5Qm94ZXMm IGJveGVzKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250 ZXh0cy9pbmxpbmUvSW5saW5lRGlzcGxheUNvbnRlbnRCdWlsZGVyLmggYi9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVEaXNwbGF5Q29udGVudEJ1 aWxkZXIuaAppbmRleCA0YjVhNGEyMWVmNDFiNjRlZTA1NjMyY2JlMjcyN2Q3MmVkZDM4MjQ2Li41 MGU1MjFmZWI3MGEzYTg5MTkxODE5NjkxZDE0ZjIwMDk3MGQzMjJiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVEaXNwbGF5 Q29udGVudEJ1aWxkZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0Nv bnRleHRzL2lubGluZS9JbmxpbmVEaXNwbGF5Q29udGVudEJ1aWxkZXIuaApAQCAtNTcsNiArNTcs OCBAQCBwcml2YXRlOgogICAgIHZvaWQgYXBwZW5kU3Bhbm5pbmdJbmxpbmVCb3hEaXNwbGF5Qm94 KGNvbnN0IExpbmU6OlJ1biYsIGNvbnN0IElubGluZUxldmVsQm94JiwgY29uc3QgSW5saW5lUmVj dCYsIERpc3BsYXlCb3hlcyYpOwogICAgIHZvaWQgYXBwZW5kSW5saW5lQm94RGlzcGxheUJveEZv ckJpZGlCb3VuZGFyeShjb25zdCBCb3gmLCBjb25zdCBJbmxpbmVSZWN0JiwgYm9vbCBpc0ZpcnN0 SW5saW5lQm94RnJhZ21lbnQsIERpc3BsYXlCb3hlcyYpOwogCisgICAgdm9pZCBzZXRJbmxpbmVC b3hHZW9tZXRyeShjb25zdCBCb3gmLCBjb25zdCBJbmxpbmVSZWN0JiwgYm9vbCBpc0ZpcnN0SW5s aW5lQm94RnJhZ21lbnQpOworCiAgICAgY29uc3QgQ29udGFpbmVyQm94JiByb290KCkgY29uc3Qg eyByZXR1cm4gbV9mb3JtYXR0aW5nQ29udGV4dFJvb3Q7IH0KICAgICBJbmxpbmVGb3JtYXR0aW5n U3RhdGUmIGZvcm1hdHRpbmdTdGF0ZSgpIGNvbnN0IHsgcmV0dXJuIG1fZm9ybWF0dGluZ1N0YXRl OyB9IAogCg==