233593 2021-11-29 13:19:57 -0800 [JSC] slice should be aware of TerminationException 2021-11-29 17:21:04 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1818436 0 ysuzuki 2021-11-29 13:19:57 -0800 [JSC] slice should be aware of terminated excution exception 1818437 1 445332 ysuzuki 2021-11-29 13:20:37 -0800 Created attachment 445332 Patch 1818438 2 ysuzuki 2021-11-29 13:20:42 -0800 <rdar://problem/85823844> 1818442 3 445332 mark.lam 2021-11-29 13:29:31 -0800 Comment on attachment 445332 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445332&action=review r=me > Source/JavaScriptCore/ChangeLog:3 > + [JSC] slice should be aware of terminated excution exception It’s called a TerminationException now. Also, you had a typo in “excution”. > Source/JavaScriptCore/ChangeLog:9 > + Since terminated execution exception can happen at any time, assertNoException is wrong. Ditto. Please use “termination exception” instead. > JSTests/ChangeLog:9 > + * stress/slice-terminated-execution-exception.js: Added. I suggest renaming this to slice-termination-exception.js to match the new naming. 1818549 4 ysuzuki 2021-11-29 17:21:04 -0800 Committed r286275 (244636@main): <https://commits.webkit.org/244636@main> 445332 2021-11-29 13:20:37 -0800 2021-11-29 13:29:31 -0800 Patch bug-233593-20211129162035.patch text/plain 6314 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi NWU4M2MwZDFmYjUzNWFiNDgyMjBjODk4ODg3MWFiOTI0Y2RiYmVhLi4zYWQ4ZTc0NGQ0NWJjNWRh NDliMTIxMjBmODgwNWFhZTcyNzBlMWRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMS0xMS0yOSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIHNsaWNlIHNob3VsZCBiZSBhd2FyZSBvZiB0ZXJtaW5hdGVkIGV4 Y3V0aW9uIGV4Y2VwdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjMzNTkzCisgICAgICAgIHJkYXI6Ly84NTgyMzg0NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHRlcm1pbmF0ZWQgZXhlY3V0 aW9uIGV4Y2VwdGlvbiBjYW4gaGFwcGVuIGF0IGFueSB0aW1lLCBhc3NlcnROb0V4Y2VwdGlvbiBp cyB3cm9uZy4KKworICAgICAgICAqIHJ1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwOgorICAgICAg ICAoSlNDOjpKU0NfREVGSU5FX0hPU1RfRlVOQ1RJT04pOgorCiAyMDIxLTExLTI5ICBZdXN1a2Ug U3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gQWRkIEludGwuTnVt YmVyRm9ybWF0LmZvcm1hdFJhbmdlVG9QYXJ0cwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwCmluZGV4IGRlOTI4NWM5ODM3ZTc0OGU2YzQ0NWY1 YTMxYjkyNjA1YjM0MDQzMDcuLjZlYTZiNjdhMDRmMzNkNDE5MzYyN2FkZmE3MDBkMTE3ZmZjYTM2 ZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90 eXBlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlw ZS5jcHAKQEAgLTIwOCw1MSArMjA4LDQ5IEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIHN0ZDo6cGFp cjxTcGVjaWVzQ29uc3RydWN0UmVzdWx0LCBKU09iamVjdCo+IHNwZWNpZXNDb25zdHJ1CiAgICAg Vk0mIHZtID0gZ2xvYmFsT2JqZWN0LT52bSgpOwogICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX1RI Uk9XX1NDT1BFKHZtKTsKIAotICAgIGF1dG8gZXhjZXB0aW9uUmVzdWx0ID0gW10gKCkgewotICAg ICAgICByZXR1cm4gc3RkOjptYWtlX3BhaXIoU3BlY2llc0NvbnN0cnVjdFJlc3VsdDo6RXhjZXB0 aW9uLCBudWxscHRyKTsKLSAgICB9OworICAgIGNvbnN0ZXhwciBzdGQ6OnBhaXI8U3BlY2llc0Nv bnN0cnVjdFJlc3VsdCwgSlNPYmplY3QqPiBleGNlcHRpb25SZXN1bHQgeyBTcGVjaWVzQ29uc3Ry dWN0UmVzdWx0OjpFeGNlcHRpb24sIG51bGxwdHIgfTsKIAogICAgIC8vIEVDTUEgOS40LjIuMzog aHR0cHM6Ly90YzM5LmdpdGh1Yi5pby9lY21hMjYyLyNzZWMtYXJyYXlzcGVjaWVzY3JlYXRlCiAg ICAgSlNWYWx1ZSBjb25zdHJ1Y3RvciA9IGpzVW5kZWZpbmVkKCk7CiAgICAgYm9vbCB0aGlzSXNB cnJheSA9IGlzQXJyYXkoZ2xvYmFsT2JqZWN0LCB0aGlzT2JqZWN0KTsKLSAgICBSRVRVUk5fSUZf RVhDRVBUSU9OKHNjb3BlLCBleGNlcHRpb25SZXN1bHQoKSk7CisgICAgUkVUVVJOX0lGX0VYQ0VQ VElPTihzY29wZSwgZXhjZXB0aW9uUmVzdWx0KTsKICAgICBpZiAoTElLRUxZKHRoaXNJc0FycmF5 KSkgewogICAgICAgICAvLyBGYXN0IHBhdGggaW4gdGhlIG5vcm1hbCBjYXNlIHdoZXJlIHRoZSB1 c2VyIGhhcyBub3Qgc2V0IGFuIG93biBjb25zdHJ1Y3RvciBhbmQgdGhlIEFycmF5LnByb3RvdHlw ZS5jb25zdHJ1Y3RvciBpcyBub3JtYWwuCiAgICAgICAgIC8vIFdlIG5lZWQgcHJvdG90eXBlIGNo ZWNrIGZvciBzdWJjbGFzc2VzIG9mIEFycmF5LCB3aGljaCBhcmUgQXJyYXkgb2JqZWN0cyBidXQg aGF2ZSBhIGRpZmZlcmVudCBwcm90b3R5cGUgYnkgZGVmYXVsdC4KICAgICAgICAgYm9vbCBpc1Zh bGlkID0gc3BlY2llc1dhdGNocG9pbnRJc1ZhbGlkKHZtLCB0aGlzT2JqZWN0KTsKLSAgICAgICAg c2NvcGUuYXNzZXJ0Tm9FeGNlcHRpb24oKTsKKyAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihz Y29wZSwgZXhjZXB0aW9uUmVzdWx0KTsKICAgICAgICAgaWYgKExJS0VMWShpc1ZhbGlkKSkKLSAg ICAgICAgICAgIHJldHVybiBzdGQ6Om1ha2VfcGFpcihTcGVjaWVzQ29uc3RydWN0UmVzdWx0OjpG YXN0UGF0aCwgbnVsbHB0cik7CisgICAgICAgICAgICByZXR1cm4gc3RkOjpwYWlyIHsgU3BlY2ll c0NvbnN0cnVjdFJlc3VsdDo6RmFzdFBhdGgsIG51bGxwdHIgfTsKIAogICAgICAgICBjb25zdHJ1 Y3RvciA9IHRoaXNPYmplY3QtPmdldChnbG9iYWxPYmplY3QsIHZtLnByb3BlcnR5TmFtZXMtPmNv bnN0cnVjdG9yKTsKLSAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZXhjZXB0aW9u UmVzdWx0KCkpOworICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBleGNlcHRpb25S ZXN1bHQpOwogICAgICAgICBpZiAoY29uc3RydWN0b3IuaXNDb25zdHJ1Y3Rvcih2bSkpIHsKICAg ICAgICAgICAgIEpTT2JqZWN0KiBjb25zdHJ1Y3Rvck9iamVjdCA9IGpzQ2FzdDxKU09iamVjdCo+ KGNvbnN0cnVjdG9yKTsKICAgICAgICAgICAgIGJvb2wgaXNBcnJheUNvbnN0cnVjdG9yRnJvbUFu b3RoZXJSZWFsbSA9IGdsb2JhbE9iamVjdCAhPSBjb25zdHJ1Y3Rvck9iamVjdC0+Z2xvYmFsT2Jq ZWN0KHZtKQogICAgICAgICAgICAgICAgICYmIGNvbnN0cnVjdG9yT2JqZWN0LT5pbmhlcml0czxB cnJheUNvbnN0cnVjdG9yPih2bSk7CiAgICAgICAgICAgICBpZiAoaXNBcnJheUNvbnN0cnVjdG9y RnJvbUFub3RoZXJSZWFsbSkKLSAgICAgICAgICAgICAgICByZXR1cm4gc3RkOjptYWtlX3BhaXIo U3BlY2llc0NvbnN0cnVjdFJlc3VsdDo6RmFzdFBhdGgsIG51bGxwdHIpOworICAgICAgICAgICAg ICAgIHJldHVybiBzdGQ6OnBhaXIgeyBTcGVjaWVzQ29uc3RydWN0UmVzdWx0OjpGYXN0UGF0aCwg bnVsbHB0ciB9OwogICAgICAgICB9CiAgICAgICAgIGlmIChjb25zdHJ1Y3Rvci5pc09iamVjdCgp KSB7CiAgICAgICAgICAgICBjb25zdHJ1Y3RvciA9IGNvbnN0cnVjdG9yLmdldChnbG9iYWxPYmpl Y3QsIHZtLnByb3BlcnR5TmFtZXMtPnNwZWNpZXNTeW1ib2wpOwotICAgICAgICAgICAgUkVUVVJO X0lGX0VYQ0VQVElPTihzY29wZSwgZXhjZXB0aW9uUmVzdWx0KCkpOworICAgICAgICAgICAgUkVU VVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZXhjZXB0aW9uUmVzdWx0KTsKICAgICAgICAgICAgIGlm IChjb25zdHJ1Y3Rvci5pc051bGwoKSkKLSAgICAgICAgICAgICAgICByZXR1cm4gc3RkOjptYWtl X3BhaXIoU3BlY2llc0NvbnN0cnVjdFJlc3VsdDo6RmFzdFBhdGgsIG51bGxwdHIpOworICAgICAg ICAgICAgICAgIHJldHVybiBzdGQ6OnBhaXIgeyBTcGVjaWVzQ29uc3RydWN0UmVzdWx0OjpGYXN0 UGF0aCwgbnVsbHB0ciB9OwogICAgICAgICB9CiAgICAgfSBlbHNlIHsKICAgICAgICAgLy8gSWYg aXNBcnJheSBpcyBmYWxzZSwgcmV0dXJuID8gQXJyYXlDcmVhdGUobGVuZ3RoKS4KLSAgICAgICAg cmV0dXJuIHN0ZDo6bWFrZV9wYWlyKFNwZWNpZXNDb25zdHJ1Y3RSZXN1bHQ6OkZhc3RQYXRoLCBu dWxscHRyKTsKKyAgICAgICAgcmV0dXJuIHN0ZDo6cGFpciB7IFNwZWNpZXNDb25zdHJ1Y3RSZXN1 bHQ6OkZhc3RQYXRoLCBudWxscHRyIH07CiAgICAgfQogCiAgICAgaWYgKGNvbnN0cnVjdG9yLmlz VW5kZWZpbmVkKCkpCi0gICAgICAgIHJldHVybiBzdGQ6Om1ha2VfcGFpcihTcGVjaWVzQ29uc3Ry dWN0UmVzdWx0OjpGYXN0UGF0aCwgbnVsbHB0cik7CisgICAgICAgIHJldHVybiBzdGQ6OnBhaXIg eyBTcGVjaWVzQ29uc3RydWN0UmVzdWx0OjpGYXN0UGF0aCwgbnVsbHB0ciB9OwogCiAgICAgTWFy a2VkQXJndW1lbnRCdWZmZXIgYXJnczsKICAgICBhcmdzLmFwcGVuZChqc051bWJlcihsZW5ndGgp KTsKICAgICBBU1NFUlQoIWFyZ3MuaGFzT3ZlcmZsb3dlZCgpKTsKICAgICBKU09iamVjdCogbmV3 T2JqZWN0ID0gY29uc3RydWN0KGdsb2JhbE9iamVjdCwgY29uc3RydWN0b3IsIGFyZ3MsICJTcGVj aWVzIGNvbnN0cnVjdGlvbiBkaWQgbm90IGdldCBhIHZhbGlkIGNvbnN0cnVjdG9yIik7Ci0gICAg UkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZXhjZXB0aW9uUmVzdWx0KCkpOwotICAgIHJldHVy biBzdGQ6Om1ha2VfcGFpcihTcGVjaWVzQ29uc3RydWN0UmVzdWx0OjpDcmVhdGVkT2JqZWN0LCBu ZXdPYmplY3QpOworICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGV4Y2VwdGlvblJlc3Vs dCk7CisgICAgcmV0dXJuIHN0ZDo6cGFpciB7IFNwZWNpZXNDb25zdHJ1Y3RSZXN1bHQ6OkNyZWF0 ZWRPYmplY3QsIG5ld09iamVjdCB9OwogfQogCiBKU0NfREVGSU5FX0hPU1RfRlVOQ1RJT04oYXJy YXlQcm90b0Z1bmNTcGVjaWVzQ3JlYXRlLCAoSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwg Q2FsbEZyYW1lKiBjYWxsRnJhbWUpKQpAQCAtMTU2Miw3ICsxNTYwLDcgQEAgSlNDX0RFRklORV9I T1NUX0ZVTkNUSU9OKGFycmF5UHJvdG9Qcml2YXRlRnVuY0NvbmNhdE1lbWNweSwgKEpTR2xvYmFs T2JqZWN0KiBnbG8KIAogICAgIC8vIFdlIG5lZWQgdG8gY2hlY2sgdGhlIHNwZWNpZXMgY29uc3Ry dWN0b3IgaGVyZSBzaW5jZSBjaGVja2luZyBpdCBpbiB0aGUgSlMgd3JhcHBlciBpcyB0b28gZXhw ZW5zaXZlIGZvciB0aGUgbm9uLW9wdGltaXppbmcgdGllcnMuCiAgICAgYm9vbCBpc1ZhbGlkID0g c3BlY2llc1dhdGNocG9pbnRJc1ZhbGlkKHZtLCBmaXJzdEFycmF5KTsKLSAgICBzY29wZS5hc3Nl cnROb0V4Y2VwdGlvbigpOworICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIHsgfSk7CiAg ICAgaWYgKFVOTElLRUxZKCFpc1ZhbGlkKSkKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29k ZShqc051bGwoKSk7CiAKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9D aGFuZ2VMb2cKaW5kZXggODNmMGRhODRmNGMxNWEzMzJlYTBlYTdiOWYwZjFlOWI3M2Y1YjlmMS4u YTZmNTU5YjFhNDQ3OTcwYjljZWRmZDJlZWFlYTU2N2E5N2YzOGYwOSAxMDA2NDQKLS0tIGEvSlNU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAyMS0xMS0yOSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgorCisgICAgICAg IFtKU0NdIHNsaWNlIHNob3VsZCBiZSBhd2FyZSBvZiB0ZXJtaW5hdGVkIGV4Y3V0aW9uIGV4Y2Vw dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMz NTkzCisgICAgICAgIHJkYXI6Ly84NTgyMzg0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL3NsaWNlLXRlcm1pbmF0ZWQtZXhlY3V0aW9u LWV4Y2VwdGlvbi5qczogQWRkZWQuCisgICAgICAgIChhc3luYyBpbmZpbml0ZUxvb3ApOgorCiAy MDIxLTExLTI5ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAg W0pTQ10gQWRkIEludGwuTnVtYmVyRm9ybWF0LmZvcm1hdFJhbmdlVG9QYXJ0cwpkaWZmIC0tZ2l0 IGEvSlNUZXN0cy9zdHJlc3Mvc2xpY2UtdGVybWluYXRlZC1leGVjdXRpb24tZXhjZXB0aW9uLmpz IGIvSlNUZXN0cy9zdHJlc3Mvc2xpY2UtdGVybWluYXRlZC1leGVjdXRpb24tZXhjZXB0aW9uLmpz Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjE0ZTE0Y2NiNzM4OWRmZTY4ZWE1NjYxMGMwMDI1MWMwMGIyNDM5YWQKLS0t IC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9zbGljZS10ZXJtaW5hdGVkLWV4ZWN1dGlv bi1leGNlcHRpb24uanMKQEAgLTAsMCArMSw5IEBACisvL0AgcnVuRGVmYXVsdCgiLS13YXRjaGRv Zz0xMDAiLCAiLS13YXRjaGRvZy1leGNlcHRpb24tb2siKQorYXN5bmMgZnVuY3Rpb24gaW5maW5p dGVMb29wKCkgeworICBhd2FpdCB1bmRlZmluZWQ7CisgIHdoaWxlICgxKSA7Cit9CisKK2luZmlu aXRlTG9vcCgpOworZHJhaW5NaWNyb3Rhc2tzKCk7CitbXS5zbGljZSgpOwo=