233577 2021-11-29 10:51:12 -0800 [JSC] private name operation should use RETURN_IF_EXCEPTION 2021-11-29 11:56:12 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1818313 0 ysuzuki 2021-11-29 10:51:12 -0800 [JSC] private name operation should use RETURN_IF_EXCEPTION 1818314 1 445299 ysuzuki 2021-11-29 10:52:19 -0800 Created attachment 445299 Patch 1818315 2 ysuzuki 2021-11-29 10:52:25 -0800 <rdar://problem/85813869> 1818318 3 445299 mark.lam 2021-11-29 11:01:24 -0800 Comment on attachment 445299 Patch r=me 1818372 4 ysuzuki 2021-11-29 11:56:12 -0800 Committed r286249 (244612@main): <https://commits.webkit.org/244612@main> 445299 2021-11-29 10:52:19 -0800 2021-11-29 11:01:24 -0800 Patch bug-233577-20211129135218.patch text/plain 4906 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ZTQxZDliMzc4Y2ZjOTUzZjcyNTYwZTUyYmMyY2VlZjU4YWI4MTg3Li4wZGNiZmVhZjRlOTQzMzBk N2YzMTVkZTZiNTRlZjM3MDAxOTFkOTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMS0xMS0yOSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIHByaXZhdGUgbmFtZSBvcGVyYXRpb24gc2hvdWxkIHVzZSBSRVRV Uk5fSUZfRVhDRVBUSU9OCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzM1NzcKKyAgICAgICAgcmRhcjovLzg1ODEzODY5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmVjYXVzZSBvZiBUZXJtaW5hdGVkRXhl Y3V0aW9uRXJyb3IsIGVycm9yIGNhbiBiZSB0aHJvd24gYXQgYW55IHRpbWUuCisKKyAgICAgICAg KiBqaXQvSklUT3BlcmF0aW9ucy5jcHA6CisgICAgICAgIChKU0M6OkpTQ19ERUZJTkVfSklUX09Q RVJBVElPTik6CisgICAgICAgIChKU0M6OnB1dFByaXZhdGVOYW1lT3B0aW1pemUpOgorICAgICAg ICAoSlNDOjpwdXRQcml2YXRlTmFtZSk6CisgICAgICAgICogbGxpbnQvTExJbnRTbG93UGF0aHMu Y3BwOgorICAgICAgICAoSlNDOjpMTEludDo6TExJTlRfU0xPV19QQVRIX0RFQ0wpOgorCiAyMDIx LTExLTI5ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBb UklTQ1Y2NF0gUG9wdWxhdGUgUklTQ1Y2NEFzc2VtYmxlciB3aXRoIGluc3RydWN0aW9uLWdlbmVy YXRpb24gbWV0aG9kcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRP cGVyYXRpb25zLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5j cHAKaW5kZXggNmJjZTc0YWI4MmM1NTdkMDA4NTE1MDc4NTFhMDRlNGUxNDYzMGMwNC4uMWRkN2I3 M2M2MTY3OTYyN2YzMDJkOTE0MjJmNWJjMzdmMjE0ZTRiMCAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCkBAIC01MjgsNyArNTI4LDcgQEAgSlNDX0RFRklO RV9KSVRfT1BFUkFUSU9OKG9wZXJhdGlvbkhhc1ByaXZhdGVOYW1lT3B0aW1pemUsIEVuY29kZWRK U1ZhbHVlLCAoSlNHbG8KICAgICBKU1ZhbHVlIHByb3BlcnR5VmFsdWUgPSBKU1ZhbHVlOjpkZWNv ZGUoZW5jb2RlZFByb3BlcnR5KTsKICAgICBBU1NFUlQocHJvcGVydHlWYWx1ZS5pc1N5bWJvbCgp KTsKICAgICBhdXRvIHByb3BlcnR5ID0gcHJvcGVydHlWYWx1ZS50b1Byb3BlcnR5S2V5KGdsb2Jh bE9iamVjdCk7Ci0gICAgRVhDRVBUSU9OX0FTU0VSVCghc2NvcGUuZXhjZXB0aW9uKCkpOworICAg IFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIHsgfSk7CiAKICAgICBQcm9wZXJ0eVNsb3Qgc2xv dChiYXNlT2JqZWN0LCBQcm9wZXJ0eVNsb3Q6OkludGVybmFsTWV0aG9kVHlwZTo6SGFzUHJvcGVy dHkpOwogICAgIGJvb2wgZm91bmQgPSBKU09iamVjdDo6Z2V0UHJpdmF0ZUZpZWxkU2xvdChiYXNl T2JqZWN0LCBnbG9iYWxPYmplY3QsIHByb3BlcnR5LCBzbG90KTsKQEAgLTU2Miw3ICs1NjIsNyBA QCBKU0NfREVGSU5FX0pJVF9PUEVSQVRJT04ob3BlcmF0aW9uSGFzUHJpdmF0ZU5hbWVHZW5lcmlj LCBFbmNvZGVkSlNWYWx1ZSwgKEpTR2xvYgogICAgIEpTVmFsdWUgcHJvcGVydHlWYWx1ZSA9IEpT VmFsdWU6OmRlY29kZShlbmNvZGVkUHJvcGVydHkpOwogICAgIEFTU0VSVChwcm9wZXJ0eVZhbHVl LmlzU3ltYm9sKCkpOwogICAgIGF1dG8gcHJvcGVydHkgPSBwcm9wZXJ0eVZhbHVlLnRvUHJvcGVy dHlLZXkoZ2xvYmFsT2JqZWN0KTsKLSAgICBFWENFUFRJT05fQVNTRVJUKCFzY29wZS5leGNlcHRp b24oKSk7CisgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgeyB9KTsKIAogICAgIHJldHVy biBKU1ZhbHVlOjplbmNvZGUoanNCb29sZWFuKGFzT2JqZWN0KGJhc2VWYWx1ZSktPmhhc1ByaXZh dGVGaWVsZChnbG9iYWxPYmplY3QsIHByb3BlcnR5KSkpOwogfQpAQCAtMTMyNCw3ICsxMzI0LDcg QEAgc3RhdGljIEFMV0FZU19JTkxJTkUgdm9pZCBwdXRQcml2YXRlTmFtZU9wdGltaXplKEpTR2xv YmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIEMKICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3Bl LCB2b2lkKCkpOwogCiAgICAgYXV0byBwcm9wZXJ0eU5hbWUgPSBzdWJzY3JpcHQudG9Qcm9wZXJ0 eUtleShnbG9iYWxPYmplY3QpOwotICAgIEVYQ0VQVElPTl9BU1NFUlQoIXNjb3BlLmV4Y2VwdGlv bigpKTsKKyAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCB2b2lkKCkpOwogCiAgICAgLy8g UHJpdmF0ZSBmaWVsZHMgY2FuIG9ubHkgYmUgYWNjZXNzZWQgd2l0aGluIGNsYXNzIGxleGljYWwg c2NvcGUKICAgICAvLyBhbmQgY2xhc3MgbWV0aG9kcyBhcmUgYWx3YXlzIGluIHN0cmljdCBtb2Rl CkBAIC0xMzU4LDcgKzEzNTgsNyBAQCBzdGF0aWMgQUxXQVlTX0lOTElORSB2b2lkIHB1dFByaXZh dGVOYW1lKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIEpTVmFsdWUgYgogICAgIFJFVFVS Tl9JRl9FWENFUFRJT04oc2NvcGUsIHZvaWQoKSk7CiAKICAgICBhdXRvIHByb3BlcnR5TmFtZSA9 IHN1YnNjcmlwdC50b1Byb3BlcnR5S2V5KGdsb2JhbE9iamVjdCk7Ci0gICAgRVhDRVBUSU9OX0FT U0VSVCghc2NvcGUuZXhjZXB0aW9uKCkpOworICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUs IHZvaWQoKSk7CiAKICAgICBzY29wZS5yZWxlYXNlKCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9sbGludC9MTEludFNsb3dQYXRocy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvbGxpbnQvTExJbnRTbG93UGF0aHMuY3BwCmluZGV4IGY5ZDFkYjVhNDY5MzRjNjY3MTZl ZjY3NTgwYTVjNWEyMjhjMWQ0YjUuLmZlNDMyZjg3NjY4ZWY5YzAzNTQ5YzgwZTY1OTczMDY2YTU2 MzZmZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludFNsb3dQ YXRocy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50U2xvd1BhdGhz LmNwcApAQCAtMTQ2OCw3ICsxNDY4LDcgQEAgTExJTlRfU0xPV19QQVRIX0RFQ0woc2xvd19wYXRo X2hhc19wcml2YXRlX25hbWUpCiAgICAgYXV0byBwcm9wZXJ0eVZhbHVlID0gZ2V0T3BlcmFuZChj YWxsRnJhbWUsIGJ5dGVjb2RlLm1fcHJvcGVydHkpOwogICAgIEFTU0VSVChwcm9wZXJ0eVZhbHVl LmlzU3ltYm9sKCkpOwogICAgIGF1dG8gcHJvcGVydHkgPSBwcm9wZXJ0eVZhbHVlLnRvUHJvcGVy dHlLZXkoZ2xvYmFsT2JqZWN0KTsKLSAgICBFWENFUFRJT05fQVNTRVJUKCF0aHJvd1Njb3BlLmV4 Y2VwdGlvbigpKTsKKyAgICBMTElOVF9DSEVDS19FWENFUFRJT04oKTsKIAogICAgIExMSU5UX1JF VFVSTihqc0Jvb2xlYW4oYXNPYmplY3QoYmFzZVZhbHVlKS0+aGFzUHJpdmF0ZUZpZWxkKGdsb2Jh bE9iamVjdCwgcHJvcGVydHkpKSk7CiB9CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBi L0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDk3YzU0MzA1Y2Y3YmY0YjAxNDlkMmUzM2NmYjU0ZWRm OGQwOWUxZGUuLjZmMDRmZGE3OGZmOGY5ZDQwYWEyMzdlZjNmMWU0NzlkMTJmZjJhNmMgMTAwNjQ0 Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTQgQEAKKzIwMjEtMTEtMjkgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4K KworICAgICAgICBbSlNDXSBwcml2YXRlIG5hbWUgb3BlcmF0aW9uIHNob3VsZCB1c2UgUkVUVVJO X0lGX0VYQ0VQVElPTgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjMzNTc3CisgICAgICAgIHJkYXI6Ly84NTgxMzg2OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL3Rlcm1pbmF0aW9uLWVycm9y LWluLXByaXZhdGUtbmFtZS5qczogQWRkZWQuCisgICAgICAgIChDKToKKwogMjAyMS0xMS0yNCAg TWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9yZz4KIAogICAgICAgICBTa2lw IG5ldyBzdHJlc3MgdGVzdCBnZXQtYXJyYXktbGVuZ3RoLXJldXNlLmpzIGlmIG1lbW9yeS1saW1p dGVkCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy90ZXJtaW5hdGlvbi1lcnJvci1pbi1wcml2 YXRlLW5hbWUuanMgYi9KU1Rlc3RzL3N0cmVzcy90ZXJtaW5hdGlvbi1lcnJvci1pbi1wcml2YXRl LW5hbWUuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uNjAwYmFiMGZmYjUzMGQ1MjM2N2UzY2E1MzZmODEzYTdlYTNh MDc2ZgotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvc3RyZXNzL3Rlcm1pbmF0aW9uLWVycm9y LWluLXByaXZhdGUtbmFtZS5qcwpAQCAtMCwwICsxLDE0IEBACisvL0AgcnVuRGVmYXVsdCgiLS13 YXRjaGRvZz0yIiwgIi0td2F0Y2hkb2ctZXhjZXB0aW9uLW9rIikKKworY2xhc3MgQyB7CisgICNm aWVsZDsKKworICBjb25zdHJ1Y3RvcigpIHsKKyAgICBnYygpOworICAgICNmaWVsZCBpbiB0aGlz OworICB9Cit9CisKK2ZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDsgaSsrKSB7CisgIG5ldyBDKCk7 Cit9Cg==