233571 2021-11-29 10:05:00 -0800 [JSC] GetTypedArrayLengthAsInt52 can get Array::Generic ArrayMode 2021-11-29 11:10:32 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1818269 0 ysuzuki 2021-11-29 10:05:00 -0800 [JSC] GetTypedArrayLengthAsInt52 can get Array::Generic ArrayMode 1818271 1 445291 ysuzuki 2021-11-29 10:07:09 -0800 Created attachment 445291 Patch 1818272 2 ysuzuki 2021-11-29 10:07:14 -0800 <rdar://problem/85812164> 1818292 3 445291 mark.lam 2021-11-29 10:25:43 -0800 Comment on attachment 445291 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445291&action=review r=me > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:5110 > + // If arrayMode is ForceExit, we do not compile it. I suggest rephrasing this as "If arrayMode is ForceExit, we would not compile this node and hence, should not have arrived here." 1818324 4 445291 ysuzuki 2021-11-29 11:09:52 -0800 Comment on attachment 445291 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445291&action=review Thanks! >> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:5110 >> + // If arrayMode is ForceExit, we do not compile it. > > I suggest rephrasing this as "If arrayMode is ForceExit, we would not compile this node and hence, should not have arrived here." Sounds good. Changed. 1818326 5 ysuzuki 2021-11-29 11:10:32 -0800 Committed r286228 (244609@main): <https://commits.webkit.org/244609@main> 445291 2021-11-29 10:07:09 -0800 2021-11-29 10:25:43 -0800 Patch bug-233571-20211129130708.patch text/plain 7357 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ZTQxZDliMzc4Y2ZjOTUzZjcyNTYwZTUyYmMyY2VlZjU4YWI4MTg3Li5jN2NhNmI3YTQ3MWYwNTFj MDI3MDAyZTc5MjMyM2E3MjQ2YTkxZTcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAyMS0xMS0yOSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEdldFR5cGVkQXJyYXlMZW5ndGhBc0ludDUyIGNhbiBnZXQgQXJy YXk6OkdlbmVyaWMgQXJyYXlNb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMzM1NzEKKyAgICAgICAgcmRhcjovLzg1ODEyMTY0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgc3BlY3VsYXRpb24gaXMg bm90IHBvcHVsYXRlZCBlbm91Z2gsIHRoZW4gR2V0VHlwZWRBcnJheUxlbmd0aEFzSW50NTIgY2Fu IGdldCBBcnJheTo6R2VuZXJpYy4KKyAgICAgICAgSW4gdGhhdCBjYXNlLCB3ZSBzaG91bGQgY29u dmVydCBpdCB0byBBcnJheTo6Rm9yY2VFeGl0IGFzIGl0IGlzIGRvbmUgaW4gR2V0QXJyYXlMZW5n dGguCisgICAgICAgIEFuZCBibGVzc0FycmF5T3BlcmF0aW9uIGluc2VydHMgRm9yY2VPU1JFeGl0 LiBTbyBHZXRUeXBlZEFycmF5TGVuZ3RoQXNJbnQ1MiB3b24ndCBiZSBjb21waWxlZC4KKworICAg ICAgICAqIGRmZy9ERkdDbG9iYmVyaXplLmg6CisgICAgICAgIChKU0M6OkRGRzo6Y2xvYmJlcml6 ZSk6CisgICAgICAgICogZGZnL0RGR0ZpeHVwUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6 OkZpeHVwUGhhc2U6OmZpeHVwTm9kZSk6CisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklU NjQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlR2V0VHlw ZWRBcnJheUxlbmd0aEFzSW50NTIpOgorICAgICAgICAqIGZ0bC9GVExMb3dlckRGR1RvQjMuY3Bw OgorICAgICAgICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0IzOjpjb21waWxlR2V0VHlwZWRB cnJheUxlbmd0aEFzSW50NTIpOgorCiAyMDIxLTExLTI5ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJz ZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbUklTQ1Y2NF0gUG9wdWxhdGUgUklTQ1Y2NEFzc2Vt YmxlciB3aXRoIGluc3RydWN0aW9uLWdlbmVyYXRpb24gbWV0aG9kcwpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDbG9iYmVyaXplLmggYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0Nsb2JiZXJpemUuaAppbmRleCAzMDUzYzBiYTBmMTYxZDBlMGZlMWQ5YzAx MDgyOTdlN2VkNmUyMWVmLi4yZjZkNDNmZTJkOGQzN2Q1NGE3ZWMyMDdkYzczMTgxMDA2ODhmNDFh IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Nsb2JiZXJpemUuaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Nsb2JiZXJpemUuaApAQCAtMTQ1Niw3 ICsxNDU2LDcgQEAgdm9pZCBjbG9iYmVyaXplKEdyYXBoJiBncmFwaCwgTm9kZSogbm9kZSwgY29u c3QgUmVhZEZ1bmN0b3ImIHJlYWQsIGNvbnN0IFdyaXRlRnUKICAgICAgICAgfQogCiAgICAgICAg IGRlZmF1bHQ6Ci0gICAgICAgICAgICBBU1NFUlQobW9kZS5pc1NvbWVUeXBlZEFycmF5Vmlldygp KTsKKyAgICAgICAgICAgIERGR19BU1NFUlQoZ3JhcGgsIG5vZGUsIG1vZGUuaXNTb21lVHlwZWRB cnJheVZpZXcoKSk7CiAgICAgICAgICAgICByZWFkKE1pc2NGaWVsZHMpOwogICAgICAgICAgICAg ZGVmKEhlYXBMb2NhdGlvbihBcnJheUxlbmd0aExvYywgTWlzY0ZpZWxkcywgbm9kZS0+Y2hpbGQx KCkpLCBMYXp5Tm9kZShub2RlKSk7CiAgICAgICAgICAgICByZXR1cm47CkBAIC0xNDY1LDEwICsx NDY1LDE2IEBAIHZvaWQgY2xvYmJlcml6ZShHcmFwaCYgZ3JhcGgsIE5vZGUqIG5vZGUsIGNvbnN0 IFJlYWRGdW5jdG9yJiByZWFkLCBjb25zdCBXcml0ZUZ1CiAKICAgICBjYXNlIEdldFR5cGVkQXJy YXlMZW5ndGhBc0ludDUyOiB7CiAgICAgICAgIEFycmF5TW9kZSBtb2RlID0gbm9kZS0+YXJyYXlN b2RlKCk7Ci0gICAgICAgIFJFTEVBU0VfQVNTRVJUKG1vZGUuaXNTb21lVHlwZWRBcnJheVZpZXco KSk7Ci0gICAgICAgIHJlYWQoTWlzY0ZpZWxkcyk7Ci0gICAgICAgIGRlZihIZWFwTG9jYXRpb24o VHlwZWRBcnJheUxlbmd0aEludDUyTG9jLCBNaXNjRmllbGRzLCBub2RlLT5jaGlsZDEoKSksIExh enlOb2RlKG5vZGUpKTsKLSAgICAgICAgcmV0dXJuOworICAgICAgICBERkdfQVNTRVJUKGdyYXBo LCBub2RlLCBtb2RlLmlzU29tZVR5cGVkQXJyYXlWaWV3KCkgfHwgbW9kZS50eXBlKCkgPT0gQXJy YXk6OkZvcmNlRXhpdCk7CisgICAgICAgIHN3aXRjaCAobW9kZS50eXBlKCkpIHsKKyAgICAgICAg Y2FzZSBBcnJheTo6Rm9yY2VFeGl0OgorICAgICAgICAgICAgd3JpdGUoU2lkZVN0YXRlKTsKKyAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgIHJlYWQoTWlz Y0ZpZWxkcyk7CisgICAgICAgICAgICBkZWYoSGVhcExvY2F0aW9uKFR5cGVkQXJyYXlMZW5ndGhJ bnQ1MkxvYywgTWlzY0ZpZWxkcywgbm9kZS0+Y2hpbGQxKCkpLCBMYXp5Tm9kZShub2RlKSk7Cisg ICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KICAgICB9CiAKICAgICBjYXNlIEdldFZlY3Rv ckxlbmd0aDogewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdGaXh1 cFBoYXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAK aW5kZXggMWZhNzU5MTMyYWZkNWFhMzc0YTcxNGE2MGFmMzNhOGQ1ZDExYzVlOC4uM2VjMjQyZTkw MjVmYTA5MGQ4MjNhZmFlN2UwZTRhYzc1ZGY2YTkwYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCkBAIC0yMTU0LDcgKzIxNTQsNyBAQCBjbGFzcyBGaXh1 cFBoYXNlIDogcHVibGljIFBoYXNlIHsKICAgICAgICAgICAgIC8vIFdlIGRvbid0IGtub3cgaG93 IHRvIGhhbmRsZSBnZW5lcmljIGFuZCB3ZSBvbmx5IGVtaXQgdGhpcyBpbiB0aGUgUGFyc2VyIHdo ZW4gd2UgaGF2ZSBjaGVja2VkIHRoZSB2YWx1ZSBpcyBhbiBBcnJheS9UeXBlZEFycmF5LgogICAg ICAgICAgICAgaWYgKGFycmF5TW9kZS50eXBlKCkgPT0gQXJyYXk6OkdlbmVyaWMpCiAgICAgICAg ICAgICAgICAgYXJyYXlNb2RlID0gYXJyYXlNb2RlLndpdGhUeXBlKEFycmF5OjpGb3JjZUV4aXQp OwotICAgICAgICAgICAgQVNTRVJUKGFycmF5TW9kZS5pc1NwZWNpZmljKCkgfHwgYXJyYXlNb2Rl LnR5cGUoKSA9PSBBcnJheTo6Rm9yY2VFeGl0KTsKKyAgICAgICAgICAgIERGR19BU1NFUlQobV9n cmFwaCwgbm9kZSwgYXJyYXlNb2RlLmlzU3BlY2lmaWMoKSB8fCBhcnJheU1vZGUudHlwZSgpID09 IEFycmF5OjpGb3JjZUV4aXQpOwogICAgICAgICAgICAgbm9kZS0+c2V0QXJyYXlNb2RlKGFycmF5 TW9kZSk7CiAgICAgICAgICAgICBibGVzc0FycmF5T3BlcmF0aW9uKG5vZGUtPmNoaWxkMSgpLCBF ZGdlKCksIG5vZGUtPmNoaWxkMigpLCBsZW5ndGhOZWVkc1N0b3JhZ2UpOwogCkBAIC0yMTY0LDcg KzIxNjQsOSBAQCBjbGFzcyBGaXh1cFBoYXNlIDogcHVibGljIFBoYXNlIHsKIAogICAgICAgICBj YXNlIEdldFR5cGVkQXJyYXlMZW5ndGhBc0ludDUyOiB7CiAgICAgICAgICAgICBBcnJheU1vZGUg YXJyYXlNb2RlID0gbm9kZS0+YXJyYXlNb2RlKCkucmVmaW5lKG1fZ3JhcGgsIG5vZGUsIG5vZGUt PmNoaWxkMSgpLT5wcmVkaWN0aW9uKCksIEFycmF5TW9kZTo6dW51c2VkSW5kZXhTcGVjdWxhdGVk VHlwZSk7Ci0gICAgICAgICAgICBBU1NFUlQoYXJyYXlNb2RlLmlzU29tZVR5cGVkQXJyYXlWaWV3 KCkpOworICAgICAgICAgICAgaWYgKGFycmF5TW9kZS50eXBlKCkgPT0gQXJyYXk6OkdlbmVyaWMp CisgICAgICAgICAgICAgICAgYXJyYXlNb2RlID0gYXJyYXlNb2RlLndpdGhUeXBlKEFycmF5OjpG b3JjZUV4aXQpOworICAgICAgICAgICAgREZHX0FTU0VSVChtX2dyYXBoLCBub2RlLCBhcnJheU1v ZGUuaXNTb21lVHlwZWRBcnJheVZpZXcoKSB8fCBhcnJheU1vZGUudHlwZSgpID09IEFycmF5OjpG b3JjZUV4aXQpOwogICAgICAgICAgICAgbm9kZS0+c2V0QXJyYXlNb2RlKGFycmF5TW9kZSk7CiAg ICAgICAgICAgICBibGVzc0FycmF5T3BlcmF0aW9uKG5vZGUtPmNoaWxkMSgpLCBFZGdlKCksIG5v ZGUtPmNoaWxkMigpLCBsZW5ndGhOZWVkc1N0b3JhZ2UpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAppbmRleCA3NzA3M2YzNGFmYmZk Zjk1ZmU1ODI1YTNjODk4OWMzMjIzZGRhYTVhLi5jNjY0NTQ3NDEyMmY2MTYzM2U1MTc3NzJjODdl MTZkNGRiZDNmYTU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw ZWN1bGF0aXZlSklUNjQuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3Bl Y3VsYXRpdmVKSVQ2NC5jcHAKQEAgLTI5MDgsNyArMjkwOCw4IEBAIHZvaWQgU3BlY3VsYXRpdmVK SVQ6OmNvbXBpbGVOZXdUeXBlZEFycmF5V2l0aEludDUyU2l6ZShOb2RlKiBub2RlKQogCiB2b2lk IFNwZWN1bGF0aXZlSklUOjpjb21waWxlR2V0VHlwZWRBcnJheUxlbmd0aEFzSW50NTIoTm9kZSog bm9kZSkKIHsKLSAgICBSRUxFQVNFX0FTU0VSVChub2RlLT5hcnJheU1vZGUoKS5pc1NvbWVUeXBl ZEFycmF5VmlldygpKTsKKyAgICAvLyBJZiBhcnJheU1vZGUgaXMgRm9yY2VFeGl0LCB3ZSBkbyBu b3QgY29tcGlsZSBpdC4KKyAgICBERkdfQVNTRVJUKG1fZ3JhcGgsIG5vZGUsIG5vZGUtPmFycmF5 TW9kZSgpLmlzU29tZVR5cGVkQXJyYXlWaWV3KCkpOwogICAgIFNwZWN1bGF0ZUNlbGxPcGVyYW5k IGJhc2UodGhpcywgbm9kZS0+Y2hpbGQxKCkpOwogICAgIEdQUlRlbXBvcmFyeSByZXN1bHQodGhp cywgUmV1c2UsIGJhc2UpOwogICAgIEdQUlJlZyBiYXNlR1BSID0gYmFzZS5ncHIoKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAppbmRleCA3NzFlNjI4 NmRlZGU2NmFmODE1MGFhYTYyYzFmMzg2ZGNjZGIxYzg3Li4xYmNlMmFkOGIzMDRiM2RmOWE5OWQ1 ZDJmMTFkN2U1NGY4MTZlYjlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRs L0ZUTExvd2VyREZHVG9CMy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExM b3dlckRGR1RvQjMuY3BwCkBAIC01MTA3LDYgKzUxMDcsNyBAQCBJR05PUkVfQ0xBTkdfV0FSTklO R1NfRU5ECiBJR05PUkVfQ0xBTkdfV0FSTklOR1NfQkVHSU4oIm1pc3Npbmctbm9yZXR1cm4iKQog ICAgIHZvaWQgY29tcGlsZUdldFR5cGVkQXJyYXlMZW5ndGhBc0ludDUyKCkKICAgICB7CisgICAg ICAgIC8vIElmIGFycmF5TW9kZSBpcyBGb3JjZUV4aXQsIHdlIGRvIG5vdCBjb21waWxlIGl0Lgog ICAgICAgICBSRUxFQVNFX0FTU0VSVChtX25vZGUtPmFycmF5TW9kZSgpLmlzU29tZVR5cGVkQXJy YXlWaWV3KCkpOwogICAgICAgICAvLyBUaGUgcHJlcHJvY2Vzc29yIGNob2tlcyBvbiBSRUxFQVNF X0FTU0VSVChVU0UoTEFSR0VfVFlQRURfQVJSQVlTKSksIHRoaXMgaXMgZXF1aXZhbGVudC4KICAg ICAgICAgUkVMRUFTRV9BU1NFUlQoc2l6ZW9mKHNpemVfdCkgPT0gc2l6ZW9mKHVpbnQ2NF90KSk7 CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4 IDk3YzU0MzA1Y2Y3YmY0YjAxNDlkMmUzM2NmYjU0ZWRmOGQwOWUxZGUuLjRiNGRkMTBiODA0NThj YjY5NDY5MzVhYTIyZTg5Y2Q1YmM0MjE3ZjEgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9n CisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMTEtMjkgIFl1 c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBbSlNDXSBHZXRUeXBl ZEFycmF5TGVuZ3RoQXNJbnQ1MiBjYW4gZ2V0IEFycmF5OjpHZW5lcmljIEFycmF5TW9kZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzNTcxCisgICAg ICAgIHJkYXI6Ly84NTgxMjE2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogc3RyZXNzL2dldC10eXBlZC1hcnJheS1sZW5ndGgtYXMtaW50NTItZ2Vu ZXJpYy5qczogQWRkZWQuCisgICAgICAgIChmb28uYmFyKToKKyAgICAgICAgKGZvbyk6CisKIDIw MjEtMTEtMjQgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CiAKICAg ICAgICAgU2tpcCBuZXcgc3RyZXNzIHRlc3QgZ2V0LWFycmF5LWxlbmd0aC1yZXVzZS5qcyBpZiBt ZW1vcnktbGltaXRlZApkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvZ2V0LXR5cGVkLWFycmF5 LWxlbmd0aC1hcy1pbnQ1Mi1nZW5lcmljLmpzIGIvSlNUZXN0cy9zdHJlc3MvZ2V0LXR5cGVkLWFy cmF5LWxlbmd0aC1hcy1pbnQ1Mi1nZW5lcmljLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZlNGRiZjBjNTY2YTlm ZWNkODg0NGEyODA4NDBmODMxN2NlYmYzMmUKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0 cmVzcy9nZXQtdHlwZWQtYXJyYXktbGVuZ3RoLWFzLWludDUyLWdlbmVyaWMuanMKQEAgLTAsMCAr MSwxMiBAQAorLy9AIHNraXAgaWYgbm90ICRqaXRUZXN0cworLy9AIHJ1bkRlZmF1bHQoIi0taml0 UG9saWN5U2NhbGU9MCIsICItLXVzZUxMSW50PTAiKQorZnVuY3Rpb24gZm9vKCkgeworICBmdW5j dGlvbiBiYXIoKSB7fQorICBiYXIoLi4uYXJndW1lbnRzKTsKKyAgYXJndW1lbnRzLmxlbmd0aCA9 IHVuZGVmaW5lZDsKKyAgYmFyKC4uLmFyZ3VtZW50cyk7CisgIGZvciAobGV0IF8gb2YgbmV3IFVp bnQ4QXJyYXkoKSk7Cit9CisKK2ZvciAobGV0IGkgPSAwOyBpIDwgMTUwMDA7IGkrKykKKyAgZm9v KCk7Cg==