233566 2021-11-29 09:33:02 -0800 Make support for WebKitAdditions in Framework headers conditional based on deployment target 2021-11-29 11:58:28 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 233374 233569 1 cdumez cdumez kkinnunen thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1818246 0 cdumez 2021-11-29 09:33:02 -0800 Make support for WebKitAdditions in Framework headers conditional based on deployment target. 1818247 1 445285 cdumez 2021-11-29 09:34:26 -0800 Created attachment 445285 Patch 1818334 2 445285 wenson_hsieh 2021-11-29 11:17:47 -0800 Comment on attachment 445285 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445285&action=review > Source/WebKit/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). While the change is pretty self-explanatory, I think a brief sentence here enumerating the supported OS versions might still be helpful. 1818374 3 cdumez 2021-11-29 11:57:25 -0800 Committed r286250 (244613@main): <https://commits.webkit.org/244613@main> 1818376 4 webkit-bug-importer 2021-11-29 11:58:28 -0800 <rdar://problem/85828458> 445285 2021-11-29 09:34:26 -0800 2021-11-29 11:16:33 -0800 Patch bug-233566-20211129093426.patch text/plain 2656 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRhZDkyOTg1YzkwZDQ4MWJk M2Y3NjM0ZjgxMzlkZmY2MjdmY2MwN2QuLjU0YTNkZmQ5YmE4OWM1YmNjYzQzNDBiNmY3ZDlmYmRh NzU1NzAxNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMTEtMjkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIHN1cHBvcnQgZm9yIFdlYktp dEFkZGl0aW9ucyBpbiBGcmFtZXdvcmsgaGVhZGVycyBjb25kaXRpb25hbCBiYXNlZCBvbiBkZXBs b3ltZW50IHRhcmdldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjMzNTY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBtYWMvcmVwbGFjZS13ZWJraXQtYWRkaXRpb25zLWluY2x1ZGVzLnB5OgorICAgICAg ICAoaXNfc3VwcG9ydGVkX29zKToKKyAgICAgICAgKG1haW4pOgorCiAyMDIxLTExLTI5ICBLaW1t byBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CiAKICAgICAgICAgR1BVUCBHcmFwaGlj c0NvbnRleHRHTCBjcmVhdGlvbiBmYWlsdXJlIGNhbm5vdCBiZSBkZXRlY3RlZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9tYWMvcmVwbGFjZS13ZWJraXQtYWRkaXRpb25zLWluY2x1ZGVzLnB5 IGIvU291cmNlL1dlYktpdC9tYWMvcmVwbGFjZS13ZWJraXQtYWRkaXRpb25zLWluY2x1ZGVzLnB5 CmluZGV4IDU4ZGFjZjQwYjU1NGZhMjk0OWU0MTRlNjk5MWMzNWNjZGQ1MDFkOGMuLjNlMDA4NDYy NGI2MTA1YmI1MTQwMWExZDkyYzMxMDQyMDc3Njg4NGYgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJL aXQvbWFjL3JlcGxhY2Utd2Via2l0LWFkZGl0aW9ucy1pbmNsdWRlcy5weQorKysgYi9Tb3VyY2Uv V2ViS2l0L21hYy9yZXBsYWNlLXdlYmtpdC1hZGRpdGlvbnMtaW5jbHVkZXMucHkKQEAgLTQyLDYg KzQyLDI2IEBAIGRlZiByZWFkX2NvbnRlbnRfZnJvbV93ZWJraXRfYWRkaXRpb25zKGJ1aWx0X3By b2R1Y3RzX2RpcmVjdG9yeSwgc2RrX3Jvb3RfZGlyZWN0CiAgICAgICAgICAgICByZXR1cm4gIiIK IAogCitkZWYgaXNfc3VwcG9ydGVkX29zKCk6CisgICAgb3NfdmVyc2lvbl9zdHJpbmcgPSBvcy5l bnZpcm9uLmdldCgiTUFDT1NYX0RFUExPWU1FTlRfVEFSR0VUIikKKyAgICBpZiBvc192ZXJzaW9u X3N0cmluZyBpcyBub3QgTm9uZToKKyAgICAgICAgb3NfdmVyc2lvbiA9IGZsb2F0KCcuJy5qb2lu KG9zX3ZlcnNpb25fc3RyaW5nLnNwbGl0KCcuJylbOjJdKSkKKyAgICAgICAgcmV0dXJuIG9zX3Zl cnNpb24gPj0gMTMuMAorICAgIG9zX3ZlcnNpb25fc3RyaW5nID0gb3MuZW52aXJvbi5nZXQoIklQ SE9ORU9TX0RFUExPWU1FTlRfVEFSR0VUIikKKyAgICBpZiBvc192ZXJzaW9uX3N0cmluZyBpcyBu b3QgTm9uZToKKyAgICAgICAgb3NfdmVyc2lvbiA9IGZsb2F0KCcuJy5qb2luKG9zX3ZlcnNpb25f c3RyaW5nLnNwbGl0KCcuJylbOjJdKSkKKyAgICAgICAgcmV0dXJuIG9zX3ZlcnNpb24gPj0gMTYu MAorICAgIG9zX3ZlcnNpb25fc3RyaW5nID0gb3MuZW52aXJvbi5nZXQoIldBVENIT1NfREVQTE9Z TUVOVF9UQVJHRVQiKQorICAgIGlmIG9zX3ZlcnNpb25fc3RyaW5nIGlzIG5vdCBOb25lOgorICAg ICAgICBvc192ZXJzaW9uID0gZmxvYXQoJy4nLmpvaW4ob3NfdmVyc2lvbl9zdHJpbmcuc3BsaXQo Jy4nKVs6Ml0pKQorICAgICAgICByZXR1cm4gb3NfdmVyc2lvbiA+PSA5LjAKKyAgICBvc192ZXJz aW9uX3N0cmluZyA9IG9zLmVudmlyb24uZ2V0KCJUVk9TX0RFUExPWU1FTlRfVEFSR0VUIikKKyAg ICBpZiBvc192ZXJzaW9uX3N0cmluZyBpcyBub3QgTm9uZToKKyAgICAgICAgb3NfdmVyc2lvbiA9 IGZsb2F0KCcuJy5qb2luKG9zX3ZlcnNpb25fc3RyaW5nLnNwbGl0KCcuJylbOjJdKSkKKyAgICAg ICAgcmV0dXJuIG9zX3ZlcnNpb24gPj0gMTYuMAorICAgIHJhaXNlIFJ1bnRpbWVFcnJvcignVW5y ZWNvZ25pemVkIGRlcGxveW1lbnQgdGFyZ2V0JykKKworCiBkZWYgbWFpbihhcmd2PU5vbmUpOgog ICAgIGlmIG5vdCBhcmd2OgogICAgICAgICBhcmd2ID0gc3lzLmFyZ3YKQEAgLTY1LDYgKzg1LDEw IEBAIGRlZiBtYWluKGFyZ3Y9Tm9uZSk6CiAgICAgICAgIHByaW50KCIoJXMpOiBTREsgcm9vdCBk aXJlY3RvcnkgdW5zcGVjaWZpZWQiICUgYXJndlswXSkKICAgICAgICAgcmV0dXJuIDEKIAorICAg ICMgV2UgY3VycmVudGx5IG9ubHkgc3VwcG9ydCBXZWJLaXRBZGRpdGlvbnMgaW4gRnJhbWV3b3Jr IGhlYWRlcnMgb24gbWFjT1MgMTMrIGFuZCBpT1MgMTYrLgorICAgIGlmIG5vdCBpc19zdXBwb3J0 ZWRfb3MoKToKKyAgICAgICAgcmV0dXJuIDAKKwogICAgIGFkZGl0aW9uc19pbXBvcnRfcGF0dGVy biA9IHJlLmNvbXBpbGUociJcI2lmIFVTRVwoQVBQTEVfSU5URVJOQUxfU0RLXClcbiNpbXBvcnQg PFdlYktpdEFkZGl0aW9ucy8oLiopPlxuI2VuZGlmIikKICAgICB0cnk6CiAgICAgICAgIHdpdGgg b3BlbihoZWFkZXJfcGF0aCwgInIiKSBhcyBoZWFkZXI6Cg==