233556 2021-11-29 06:01:22 -0800 Console Timing API does not contain space before duration when it gets printed 2022-02-12 23:04:34 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 1 max webkit-unassigned bfulgham eric.carlson ews-watchlist hi inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff pangle saam tzagallo webkit-bug-importer youssefdevelops oldest_to_newest 1818192 0 max 2021-11-29 06:01:22 -0800 ```js console.time("MyTimer"); console.timeLog("MyTimer"); ``` Expected: ``` MyTimer: 0.018 ms ``` Actual: ``` MyTimer: 0.018ms ``` There should be a space between the duration and the unit, see here in the spec: https://console.spec.whatwg.org/#timelog 1818718 1 445416 youssefdevelops 2021-11-30 07:35:05 -0800 Created attachment 445416 Patch 1818815 2 hi 2021-11-30 10:35:34 -0800 (In reply to Max Schmitt from comment #0) > There should be a space between the duration and the unit, see here in the spec: https://console.spec.whatwg.org/#timelog I dont think this is correct. The exact wording is > Let _duration_ be a string representing the difference between the current time and _startTime_, in an implementation-defined format. The only space that's required is between the `:` and the _duration_, which we already have. The example includes spaces, but that's just an example not required output. 1818826 3 youssefdevelops 2021-11-30 10:47:43 -0800 (In reply to Devin Rousso from comment #2) > (In reply to Max Schmitt from comment #0) > > There should be a space between the duration and the unit, see here in the spec: https://console.spec.whatwg.org/#timelog > > I dont think this is correct. The exact wording is > > > Let _duration_ be a string representing the difference between the current time and _startTime_, in an implementation-defined format. > > The only space that's required is between the `:` and the _duration_, which > we already have. The example includes spaces, but that's just an example > not required output. Thanks, Devin, the spec never explicitly mentions a space between the value and unit in _duration_. For example, in the latest Node.js release, the output is `MyTimer: 0.018ms`. 1818831 4 445416 hi 2021-11-30 10:50:11 -0800 Comment on attachment 445416 Patch Our normal style in Web Inspector is to not have a space between the value and unit, so unless there's some compelling reason to do this I don't think we should break from our usual style. 1820592 5 webkit-bug-importer 2021-12-06 06:02:20 -0800 <rdar://problem/86100703> 445416 2021-11-30 07:35:05 -0800 2021-11-30 10:50:11 -0800 Patch bug-233556-20211130103504.patch text/plain 4406 youssefdevelops U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2Mjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ZDMyZjViZDg4MjUwOTk0ZTEwNmRmZGYwYTFkZTQ5YzZkMGFkZjZlLi4yY2E2YmM4YTc0MjUyMWY0 YmJkZjAwMWRhMWJlZWEwYmQ3NjFkNzgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMS0xMS0zMCAgWW91c3NlZiBTb2xpbWFuICA8eW91c3NlZmRldmVsb3Bz QGdtYWlsLmNvbT4KKworICAgICAgICBDb25zb2xlIFRpbWluZyBBUEkgZG9lcyBub3QgY29udGFp biBzcGFjZSBiZWZvcmUgZHVyYXRpb24gd2hlbiBpdCBnZXRzIHByaW50ZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMzU1NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHNwYWNlIGJldHdlZW4g ZHVyYXRpb24gYW5kIHVuaXQgYXMgcGVyIHRpbWVsb2cgc3BlYy4KKworICAgICAgICAqIGluc3Bl Y3Rvci9hZ2VudHMvSW5zcGVjdG9yQ29uc29sZUFnZW50LmNwcDoKKyAgICAgICAgKEluc3BlY3Rv cjo6SW5zcGVjdG9yQ29uc29sZUFnZW50Ojpsb2dUaW1pbmcpOgorICAgICAgICAoSW5zcGVjdG9y OjpJbnNwZWN0b3JDb25zb2xlQWdlbnQ6OnN0b3BUaW1pbmcpOgorCiAyMDIxLTExLTI5ICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10ganVtcEZvclR5 cGVkQXJyYXlPdXRPZkJvdW5kcyBzaG91bGQgdXNlIGFzQW55SW50IHNpbmNlIGl0IHVzZXMgaXNB bnlJbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRz L0luc3BlY3RvckNvbnNvbGVBZ2VudC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVj dG9yL2FnZW50cy9JbnNwZWN0b3JDb25zb2xlQWdlbnQuY3BwCmluZGV4IDI1YjcyMzFhMjVlN2Ex NmMyYTA0OTgwZjFhZTk3NzE3YWM4NWExZGUuLmU1YmRmZjQwOTE3ODk2NzRkNTVhMWYyYWU1M2Nk MTRkNTlmYmExODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Iv YWdlbnRzL0luc3BlY3RvckNvbnNvbGVBZ2VudC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ29uc29sZUFnZW50LmNwcApAQCAtMTYxLDcg KzE2MSw3IEBAIHZvaWQgSW5zcGVjdG9yQ29uc29sZUFnZW50Ojpsb2dUaW1pbmcoSlNDOjpKU0ds b2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBjb25zdCBTCiAKICAgICBNb25vdG9uaWNUaW1lIHN0 YXJ0VGltZSA9IGl0LT52YWx1ZTsKICAgICBTZWNvbmRzIGVsYXBzZWQgPSBNb25vdG9uaWNUaW1l Ojpub3coKSAtIHN0YXJ0VGltZTsKLSAgICBhdXRvIG1lc3NhZ2UgPSBtYWtlU3RyaW5nKFNjcmlw dEFyZ3VtZW50czo6dHJ1bmNhdGVTdHJpbmdGb3JDb25zb2xlTWVzc2FnZShsYWJlbCksICI6ICIs IEZvcm1hdHRlZE51bWJlcjo6Zml4ZWRXaWR0aChlbGFwc2VkLm1pbGxpc2Vjb25kcygpLCAzKSwg Im1zIik7CisgICAgYXV0byBtZXNzYWdlID0gbWFrZVN0cmluZyhTY3JpcHRBcmd1bWVudHM6OnRy dW5jYXRlU3RyaW5nRm9yQ29uc29sZU1lc3NhZ2UobGFiZWwpLCAiOiAiLCBGb3JtYXR0ZWROdW1i ZXI6OmZpeGVkV2lkdGgoZWxhcHNlZC5taWxsaXNlY29uZHMoKSwgMyksICIgbXMiKTsKICAgICBh ZGRNZXNzYWdlVG9Db25zb2xlKG1ha2VVbmlxdWU8Q29uc29sZU1lc3NhZ2U+KE1lc3NhZ2VTb3Vy Y2U6OkNvbnNvbGVBUEksIE1lc3NhZ2VUeXBlOjpUaW1pbmcsIE1lc3NhZ2VMZXZlbDo6RGVidWcs IG1lc3NhZ2UsIFdURk1vdmUoYXJndW1lbnRzKSwgV1RGTW92ZShjYWxsU3RhY2spKSk7CiB9CiAK QEAgLTE4Myw3ICsxODMsNyBAQCB2b2lkIEluc3BlY3RvckNvbnNvbGVBZ2VudDo6c3RvcFRpbWlu ZyhKU0M6OkpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIGNvbnN0CiAKICAgICBNb25vdG9u aWNUaW1lIHN0YXJ0VGltZSA9IGl0LT52YWx1ZTsKICAgICBTZWNvbmRzIGVsYXBzZWQgPSBNb25v dG9uaWNUaW1lOjpub3coKSAtIHN0YXJ0VGltZTsKLSAgICBhdXRvIG1lc3NhZ2UgPSBtYWtlU3Ry aW5nKFNjcmlwdEFyZ3VtZW50czo6dHJ1bmNhdGVTdHJpbmdGb3JDb25zb2xlTWVzc2FnZShsYWJl bCksICI6ICIsIEZvcm1hdHRlZE51bWJlcjo6Zml4ZWRXaWR0aChlbGFwc2VkLm1pbGxpc2Vjb25k cygpLCAzKSwgIm1zIik7CisgICAgYXV0byBtZXNzYWdlID0gbWFrZVN0cmluZyhTY3JpcHRBcmd1 bWVudHM6OnRydW5jYXRlU3RyaW5nRm9yQ29uc29sZU1lc3NhZ2UobGFiZWwpLCAiOiAiLCBGb3Jt YXR0ZWROdW1iZXI6OmZpeGVkV2lkdGgoZWxhcHNlZC5taWxsaXNlY29uZHMoKSwgMyksICIgbXMi KTsKICAgICBhZGRNZXNzYWdlVG9Db25zb2xlKG1ha2VVbmlxdWU8Q29uc29sZU1lc3NhZ2U+KE1l c3NhZ2VTb3VyY2U6OkNvbnNvbGVBUEksIE1lc3NhZ2VUeXBlOjpUaW1pbmcsIE1lc3NhZ2VMZXZl bDo6RGVidWcsIG1lc3NhZ2UsIFdURk1vdmUoY2FsbFN0YWNrKSkpOwogCiAgICAgbV90aW1lcy5y ZW1vdmUoaXQpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCmluZGV4IDYxMDY2Y2NlOWNkNzRiYjc4MDZiMTVlNjQ0YzU1ZTFmNGZlYjZk NDAuLjlhODkyMDFkYThkNTk0OWEyMzY0MGQ1YzVlYzdkMGIwZWUyMjBiOTYgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAyMS0xMS0zMCAgWW91c3NlZiBTb2xpbWFuICA8eW91c3NlZmRldmVsb3Bz QGdtYWlsLmNvbT4KKworICAgICAgICBDb25zb2xlIFRpbWluZyBBUEkgZG9lcyBub3QgY29udGFp biBzcGFjZSBiZWZvcmUgZHVyYXRpb24gd2hlbiBpdCBnZXRzIHByaW50ZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMzU1NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIHRlc3QgcmVnZXggdG8g c3VwcG9ydCB0aW1lbG9nIHNwZWMgd2l0aCBhIHNwYWNlIGJldHdlZW4gdW5pdCBhbmQgZHVyYXRp b24uCisKKyAgICAgICAgKiBpbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLXRpbWUuaHRtbDoKKwog MjAyMS0xMS0yOSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAg ICAgICBbV2VicGFnZSB0cmFuc2xhdGlvbl0gQXZvaWQgdHJhbnNsYXRpbmcgdGV4dCBpbnNpZGUg aW1hZ2Ugb3ZlcmxheXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xl L2NvbnNvbGUtdGltZS5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29uc29s ZS10aW1lLmh0bWwKaW5kZXggOTNkY2VkZTcxZjBmNTNkM2I4Y2QzYTAyNTgwZjdiOTQ3NGNhOGFi YS4uNWYxMTNkMDY5Yjk4MzAxMTk4MjQ3ZTJhMDFhYmM0OGU4MjQwYjdhYiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS10aW1lLmh0bWwKKysrIGIvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS10aW1lLmh0bWwKQEAgLTE1Nyw3ICsx NTcsNyBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4 cGVjdFRoYXQobWVzc2FnZS50eXBlID09PSBXSS5Db25zb2xlTWVzc2FnZS5NZXNzYWdlVHlwZS5U aW1pbmcsICJTaG91bGQgcmVjZWl2ZSBhIFRpbWluZyB0eXBlIG1lc3NhZ2UuIik7CiAgICAgICAg ICAgICAgICAgSW5zcGVjdG9yVGVzdC5leHBlY3RUaGF0KG1lc3NhZ2UubWVzc2FnZVRleHQuaW5j bHVkZXMoIm15LXRpbWVsb2ctbGFiZWwiKSwgIk1lc3NhZ2Ugc2hvdWxkIGNvbnRhaW4gdGhlICdt eS10aW1lbG9nLWxhYmVsJyBsYWJlbCBuYW1lIHNvbWV3aGVyZS4iKTsKIAotICAgICAgICAgICAg ICAgIGxldCBtYXRjaCA9IG1lc3NhZ2UubWVzc2FnZVRleHQubWF0Y2goL15teS10aW1lbG9nLWxh YmVsOiAoXGQrKFwuXGQrKT9tcykvKQorICAgICAgICAgICAgICAgIGxldCBtYXRjaCA9IG1lc3Nh Z2UubWVzc2FnZVRleHQubWF0Y2goL15teS10aW1lbG9nLWxhYmVsOiAoXGQrKFwuXGQrKT8gbXMp LykKICAgICAgICAgICAgICAgICBpZiAobWF0Y2gpIHsKICAgICAgICAgICAgICAgICAgICAgbGV0 IGN1cnJlbnRUaW1lID0gcGFyc2VGbG9hdChtYXRjaFsxXSk7CiAgICAgICAgICAgICAgICAgICAg IGlmIChsYXN0VGltZSkgewo=