<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>23353</bug_id>
          
          <creation_ts>2009-01-15 12:01:53 -0800</creation_ts>
          <short_desc>build fix for ThreadingPthreads.cpp</short_desc>
          <delta_ts>2009-01-15 13:06:26 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>23347</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Trivial</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Daniel Mack">webkit</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>105937</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Mack">webkit</who>
    <bug_when>2009-01-15 12:01:53 -0800</bug_when>
    <thetext>The current svn HEAD does not compile on a Debian/unstable box due to the following reason. The attached patch fixes that trivial problem.

../../JavaScriptCore/wtf/ThreadingPthreads.cpp: In member function ‘bool WTF::ThreadCondition::timedWait(WTF::Mutex&amp;, double)’:
../../JavaScriptCore/wtf/ThreadingPthreads.cpp:241: error: ‘INT_MAX’ was not declared in this scope
make[1]: *** [JavaScriptCore/wtf/libJavaScriptCore_la-ThreadingPthreads.lo] Error 1
make[1]: Leaving directory `/home/daniel/src/WebKit/WebKit/WebKitBuild/Release&apos;
make: *** [all] Error 2

Failed to build WebKit using &apos;make&apos;!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>105938</commentid>
    <comment_count>1</comment_count>
      <attachid>26765</attachid>
    <who name="Daniel Mack">webkit</who>
    <bug_when>2009-01-15 12:03:35 -0800</bug_when>
    <thetext>Created attachment 26765
include #limits.h to make the built succeed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>105941</commentid>
    <comment_count>2</comment_count>
      <attachid>26765</attachid>
    <who name="Daniel Mack">webkit</who>
    <bug_when>2009-01-15 12:12:52 -0800</bug_when>
    <thetext>Comment on attachment 26765
include #limits.h to make the built succeed

superseeded by 2nd patch - ignore this one</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>105942</commentid>
    <comment_count>3</comment_count>
      <attachid>26767</attachid>
    <who name="Daniel Mack">webkit</who>
    <bug_when>2009-01-15 12:13:26 -0800</bug_when>
    <thetext>Created attachment 26767
include #limits.h to make the built succeed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>105944</commentid>
    <comment_count>4</comment_count>
      <attachid>26767</attachid>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2009-01-15 12:22:15 -0800</bug_when>
    <thetext>Comment on attachment 26767
include #limits.h to make the built succeed

Okay, I will add a reference to the bug URL in the changelog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>105948</commentid>
    <comment_count>5</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-01-15 13:05:51 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of 23347 ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>105950</commentid>
    <comment_count>6</comment_count>
      <attachid>26767</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-01-15 13:06:26 -0800</bug_when>
    <thetext>Comment on attachment 26767
include #limits.h to make the built succeed

There&apos;s an already-reviewed patch in another bug. Someone just needs to land it.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="0"
              isprivate="0"
          >
            <attachid>26765</attachid>
            <date>2009-01-15 12:03:35 -0800</date>
            <delta_ts>2009-01-15 12:12:52 -0800</delta_ts>
            <desc>include #limits.h to make the built succeed</desc>
            <filename>ThreadingPthreads-limits-h.diff</filename>
            <type>text/plain</type>
            <size>343</size>
            <attacher name="Daniel Mack">webkit</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1B0aHJlYWRzLmNwcAkocmV2aXNpb24g
Mzk5MzMpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwCSh3b3Jr
aW5nIGNvcHkpCkBAIC00MCw2ICs0MCw3IEBACiAKICNpbmNsdWRlIDxlcnJuby5oPgogI2luY2x1
ZGUgPHN5cy90aW1lLmg+CisjaW5jbHVkZSA8bGltaXRzLmg+CiAKIG5hbWVzcGFjZSBXVEYgewog
Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>26767</attachid>
            <date>2009-01-15 12:13:26 -0800</date>
            <delta_ts>2009-01-15 13:06:26 -0800</delta_ts>
            <desc>include #limits.h to make the built succeed</desc>
            <filename>ThreadingPthreads-limits-h.diff</filename>
            <type>text/plain</type>
            <size>835</size>
            <attacher name="Daniel Mack">webkit</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM5OTQwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsOSBAQAorMjAwOS0wMS0xNSAgRGFuaWVsIE1h
Y2sgIDxkYW5pZWxAY2FpYXEuZGU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgKiB3dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwOiAjaW5jbHVkZSA8bGlt
aXRzLmg+IGZvciBJTlRfTUFYCisKIDIwMDktMDEtMTQgIERhdmlkIEtpbHplciAgPGRka2lsemVy
QGFwcGxlLmNvbT4KIAogICAgICAgICBCdWcgMjMxNTM6IEpTQyBidWlsZCBhbHdheXMgdG91Y2hl
cyBKYXZhU2NyaXB0Q29yZS9kb2NzL2J5dGVjb2RlLmh0bWwKSW5kZXg6IEphdmFTY3JpcHRDb3Jl
L3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUv
d3RmL1RocmVhZGluZ1B0aHJlYWRzLmNwcAkocmV2aXNpb24gMzk5MzMpCisrKyBKYXZhU2NyaXB0
Q29yZS93dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0
MCw3IEBACiAKICNpbmNsdWRlIDxlcnJuby5oPgogI2luY2x1ZGUgPHN5cy90aW1lLmg+CisjaW5j
bHVkZSA8bGltaXRzLmg+CiAKIG5hbWVzcGFjZSBXVEYgewogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>