233529 2021-11-26 14:33:51 -0800 REGRESSION(r283855) [GTK][WPE] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower.html fails 2021-11-30 08:03:27 -0800 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=231458 InRadar P2 Normal --- 1 crzwdjk cdumez aperez cdumez cgarcia clopez dpino eric.carlson ews-watchlist glenn jer.noble mcatanzaro philipj pnormand sergio webkit-bug-importer oldest_to_newest 1818001 0 crzwdjk 2021-11-26 14:33:51 -0800 In r283855, EqualPowerPanner::pan() was modified to use vector instructions where available. This caused a regression on GTK and WPE in the test imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower.html, presumably because of some problem in the implementation of VectorMath::multiplyByScalarThenAddToVector() which is implemented in the WebKit code for non-Apple platforms but uses an Apple library on Apple platforms. 1818441 1 cdumez 2021-11-29 13:28:55 -0800 (In reply to Arcady Goldmints-Orlov from comment #0) > In r283855, EqualPowerPanner::pan() was modified to use vector instructions > where available. This caused a regression on GTK and WPE in the test > imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode- > interface/panner-equalpower.html, presumably because of some problem in the > implementation of VectorMath::multiplyByScalarThenAddToVector() which is > implemented in the WebKit code for non-Apple platforms but uses an Apple > library on Apple platforms. What architecture does it fail on? ARM or Intel? 1818443 2 cdumez 2021-11-29 13:31:05 -0800 Ok, I can reproduce the following failure on Intel if I disable the `#if USE(ACCELERATE)` in VectorMath.cpp: --- /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt +++ /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-actual.txt @@ -14,7 +14,13 @@ PASS Mono: Left and right channels is identical to the array [expected array]. PASS < [mono source=listener] All assertions passed. (total 1 assertions) PASS > [stereo source=listener] Source and listener at the same position -PASS Stereo: Left and right channels is identical to the array [expected array]. -PASS < [stereo source=listener] All assertions passed. (total 1 assertions) -PASS # AUDIT TASK RUNNER FINISHED: 3 tasks ran successfully. +FAIL X Stereo: Left and right channels expected to be equal to the array [expected array] but differs in 8025 places: + Index Actual Expected + [129] -9.094678e-1 -9.937366e-1 + [130] -8.316806e-1 -9.996189e-1 + [131] -7.479766e-1 -9.983897e-1 + [132] -6.589520e-1 -9.900583e-1 + ...and 8021 more errors. assert_true: expected true got false +FAIL < [stereo source=listener] 1 out of 1 assertions were failed. assert_true: expected true got false +FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 3 tasks were failed. assert_true: expected true got false Seems to confirm that the Intel implementation for one of our vector math functions is somehow wrong. The results seem pretty different so it doesn't look like a simple precision issue. 1818444 3 cdumez 2021-11-29 13:33:09 -0800 Seems that this is wrong somehow: ``` void multiplyByScalarThenAddToVector(const float* inputVector1, float scalar, const float* inputVector2, float* outputVector, size_t numberOfElementsToProcess) { multiplyByScalarThenAddToOutput(inputVector1, scalar, outputVector, numberOfElementsToProcess); add(outputVector, inputVector2, outputVector, numberOfElementsToProcess); } ``` I am looking into it. 1818451 4 445333 cdumez 2021-11-29 13:37:46 -0800 Created attachment 445333 Patch 1818462 5 445333 pnormand 2021-11-29 13:54:48 -0800 Comment on attachment 445333 Patch Thanks Arcady for spotting this issue and Chris for fixing it ;) 1818485 6 ews-feeder 2021-11-29 14:38:48 -0800 Committed r286264 (244627@main): <https://commits.webkit.org/244627@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445333. 1818486 7 webkit-bug-importer 2021-11-29 14:39:22 -0800 <rdar://problem/85835819> 1818735 8 crzwdjk 2021-11-30 08:03:27 -0800 *** Bug 217845 has been marked as a duplicate of this bug. *** 445333 2021-11-29 13:37:46 -0800 2021-11-29 14:38:51 -0800 Patch bug-233529-20211129133746.patch text/plain 3512 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTg1M2E5MDNkOWZiNDMx YTE3MDMyMDljNjQwODc5OTE2OTM3NmQ0Ny4uYmI5YTFlMTU3YmUyY2Y1OTExMDE1MWU3ZTlkYjAx MDFmM2Q3MjczNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTExLTI5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjgzODU1 KSBbR1RLXVtXUEVdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8vdGhl LWF1ZGlvLWFwaS90aGUtcGFubmVybm9kZS1pbnRlcmZhY2UvcGFubmVyLWVxdWFscG93ZXIuaHRt bCBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjMzNTI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIG5vbi1VU0UoQUNDRUxFUkFURSkgaW1wbGVtZW50YXRpb24gZm9yIFZlY3Rvck1hdGg6Om11 bHRpcGx5QnlTY2FsYXJUaGVuQWRkVG9WZWN0b3IoKSB3YXMgd3JvbmcsIGNhdXNpbmcgdGhlIHRl c3QKKyAgICAgICAgdG8gZmFpbCBvbiBub24gQ29jb2EgcG9ydHMuIFRoZSBpbXBsZW1lbnRhdGlv biB3YXMgd3JvbmdseSBjYWxsaW5nIG11bHRpcGx5QnlTY2FsYXJUaGVuQWRkVG9PdXRwdXQoKSBp bnN0ZWFkIG9mCisgICAgICAgIG11bHRpcGx5QnlTY2FsYXIoKSBiZWZvcmUgY2FsbGluZyBhZGQo KS4KKworICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL1ZlY3Rvck1hdGguY3BwOgorICAgICAgICAo V2ViQ29yZTo6VmVjdG9yTWF0aDo6bXVsdGlwbHlCeVNjYWxhclRoZW5BZGRUb1ZlY3Rvcik6CisK IDIwMjEtMTEtMjkgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAog ICAgICAgICBbQ29jb2FdIFJFR1JFU1NJT04ocjI4MTI5MSk6IFRleHQgU3R5bGUgZm9udHMgZG9u J3QgaGF2ZSB0aGUgY29ycmVjdCB3ZWlnaHQgc2V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9hdWRpby9WZWN0b3JNYXRoLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2F1ZGlvL1ZlY3Rvck1hdGguY3BwCmluZGV4IDk1MWZkZjU2ZDcxNjAzODBlZGQ4YjIxYTY2ZTY0 ODIyZGNiNDA3MjEuLjFkZWM5YzA5YWViNzZhMTQ1ZjY5MTc4YTBmNTNlMjE3OWQ5MzQxNzYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1ZlY3Rvck1hdGguY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1ZlY3Rvck1hdGguY3BwCkBAIC0xNDUs NyArMTQ1LDcgQEAgc3RhdGljIGlubGluZSBib29sIGlzMTZCeXRlQWxpZ25lZChjb25zdCBmbG9h dCogdmVjdG9yKQogCiB2b2lkIG11bHRpcGx5QnlTY2FsYXJUaGVuQWRkVG9WZWN0b3IoY29uc3Qg ZmxvYXQqIGlucHV0VmVjdG9yMSwgZmxvYXQgc2NhbGFyLCBjb25zdCBmbG9hdCogaW5wdXRWZWN0 b3IyLCBmbG9hdCogb3V0cHV0VmVjdG9yLCBzaXplX3QgbnVtYmVyT2ZFbGVtZW50c1RvUHJvY2Vz cykKIHsKLSAgICBtdWx0aXBseUJ5U2NhbGFyVGhlbkFkZFRvT3V0cHV0KGlucHV0VmVjdG9yMSwg c2NhbGFyLCBvdXRwdXRWZWN0b3IsIG51bWJlck9mRWxlbWVudHNUb1Byb2Nlc3MpOworICAgIG11 bHRpcGx5QnlTY2FsYXIoaW5wdXRWZWN0b3IxLCBzY2FsYXIsIG91dHB1dFZlY3RvciwgbnVtYmVy T2ZFbGVtZW50c1RvUHJvY2Vzcyk7CiAgICAgYWRkKG91dHB1dFZlY3RvciwgaW5wdXRWZWN0b3Iy LCBvdXRwdXRWZWN0b3IsIG51bWJlck9mRWxlbWVudHNUb1Byb2Nlc3MpOwogfQogCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg M2IwMmYzNzQ1Yzk3MGRmNTk1OTA0MjAyYmMzMDg4OGEzZmUyZWI2ZC4uMzAyN2E4NzhmZDEyOTRm MTgwMDJkNzUxZTAwM2Q5ZTBhYWMyYzIzNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTEx LTI5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lP TihyMjgzODU1KSBbR1RLXVtXUEVdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2Vi YXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtcGFubmVybm9kZS1pbnRlcmZhY2UvcGFubmVyLWVxdWFs cG93ZXIuaHRtbCBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjMzNTI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVW5za2lwIHRlc3QgdGhhdCBpcyBub3cgcGFzc2luZy4KKworICAgICAgICAqIHBs YXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAyMS0xMS0yOSAgTXlsZXMgQy4gTWF4 ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gUkVHUkVTU0lP TihyMjgxMjkxKTogVGV4dCBTdHlsZSBmb250cyBkb24ndCBoYXZlIHRoZSBjb3JyZWN0IHdlaWdo dCBzZXQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0 aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA5 MTc3N2YwNjA5MzMwYTQ0ZWIzYzJhZDY5MTBjZmI0NmNkMmI3MWI5Li5hNDZmYjJmZDZkODMxNGE2 ZGYzY2FjMTc5NjY1MjIxMDlkNDgwOWM5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ2xpYi9U ZXN0RXhwZWN0YXRpb25zCkBAIC0xMjM2LDggKzEyMzYsNiBAQCB3ZWJraXQub3JnL2IvMjI5MjE5 IGh0dHAvdGVzdHMvc2VjdXJpdHkvd2ViYXVkaW8tcmVuZGVyLXJlbW90ZS1hdWRpby1hbGxvd2Vk LWNybwogCiB3ZWJraXQub3JnL2IvMjMyNzI2IHdlYmF1ZGlvL0F1ZGlvQnVmZmVyL2h1Z2UtYnVm ZmVyLmh0bWwgWyBQYXNzIFNsb3cgXQogCi13ZWJraXQub3JnL2IvMjMzNTI5IGltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtcGFubmVybm9k ZS1pbnRlcmZhY2UvcGFubmVyLWVxdWFscG93ZXIuaHRtbCBbIEZhaWx1cmUgXQotCiAjLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogIyBFbmQgb2YgV2ViQXVkaW8tcmVsYXRlZCBidWdz CiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwo=