233512 2021-11-25 23:16:05 -0800 GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platform specific code 2021-11-26 06:36:13 -0800 1 1 1 Unclassified WebKit WebGL WebKit Local Build Unspecified Unspecified RESOLVED DUPLICATE 233513 P2 Normal --- 221664 1 kkinnunen webkit-unassigned dino kbr kkinnunen oldest_to_newest 1817889 0 kkinnunen 2021-11-25 23:16:05 -0800 GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platform specific code This blocks the task of removing ifdefs from GraphicsContextGLOpenGL.h by means of separating various code paths to separate classes. GraphicsContextGLOpenGL.cpp should contain only "OpenGL" specific code. Currently that code lives in GraphicsContextGLOpenGLCommon.cpp, so GraphicsContextGLOpenGL.cpp should be made empty and then ultimately GraphicsContextGLOpenGLCommon.cpp would be renamed to GraphicsContextGLOpenGL.cpp ANGLE specific code should go into GraphicsContextGLANGLE.cpp Platform specific code should go into platform specific files such as GraphicsContextGLCocoa.cpp and compositor specific files such as GraphicsContextGLTextureMapper.cpp. 1817963 1 kkinnunen 2021-11-26 06:36:13 -0800 *** This bug has been marked as a duplicate of bug 233513 ***