233511 2021-11-25 22:04:32 -0800 Investigate if ScriptBufferSourceProvider could do without having to flatten underlying SharedBuffer 2021-12-12 14:23:19 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=233030 https://bugs.webkit.org/show_bug.cgi?id=234215 InRadar P2 Normal --- 1 jean-yves.avenard webkit-unassigned webkit-bug-importer oldest_to_newest 1817885 0 jean-yves.avenard 2021-11-25 22:04:32 -0800 Seen in https://bugs.webkit.org/show_bug.cgi?id=233030#c13 ScriptBufferSourceProvider wraps a ScriptBuffer and ScriptBufferSourceProvider::source() flatten that ScriptBuffer's SharedBuffer to access the raw content and use this information to return a StringView. A StringView is non-owning requiring ScriptBufferSourceProvider to take an extra reference to the flatten SharedBuffer so we have the content held in both the ScriptBuffer (non-flattened) and in ScriptBufferSourceProvider (flattened) Ideally, we would have StringView keep a raw reference to the SharedBuffer and use SharedBuffer:read() to access the content when needed on demand. Depends on the requirements: speed vs memory cost. 1820027 1 webkit-bug-importer 2021-12-02 22:05:24 -0800 <rdar://problem/86003855>