233505 2021-11-25 14:44:47 -0800 [GTK][GTK4][WebDriver] Flaky crashes exiting many prompty-related webdriver tests 2021-12-01 00:22:22 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 210100 1 lmoura lmoura bburg berto bugs-noreply cgarcia ews-watchlist gustavo webkit-bug-importer oldest_to_newest 1817853 0 lmoura 2021-11-25 14:44:47 -0800 Running the webdriver suite with GTK4 has been suffering from frequent flaky crashes in the teardown of many prompt tests (which are very common in the suite). On the bot, this is causing the disk to fill rather quickly, despite shortening the interval to clean up the generated core dumps. For example: imported/w3c/webdriver/tests/get_element_css_value/user_prompts.py::test_default[prompt-None] During the teardown, if a crash happens, it shows: ``` Ignored exception unknown error (500): Ignored exception invalid session id (404): session deleted because of page crash or hang. ``` Inspecting the dump (through GDB inside the flatpak SDK) looks like the WebKitScriptDialogImpl defaultButton is invalidated/deleted while being still used as the default widget of the window (or something like that). Dump: #0 0x00007f53bdd028ef in gtk_widget_remove_css_class (widget=0x5600175d54b0, css_class=0x7f53bdf21c30 "default") at ../gtk/gtkwidget.c:12747 12747 g_return_if_fail (GTK_IS_WIDGET (widget)); [Current thread is 1 (Thread 0x7f53b6e679c0 (LWP 1861))] #0 0x00007f53bdd028ef in gtk_widget_remove_css_class (widget=0x5600175d54b0, css_class=0x7f53bdf21c30 "default") at ../gtk/gtkwidget.c:12747 #1 0x00007f53bdd0c35c in gtk_window_set_default_widget (window=0x56001755a310 [BrowserWindow], default_widget=0x0) at ../gtk/gtkwindow.c:2282 #2 0x00007f53bdd0c548 in maybe_unset_focus_and_default (window=0x56001755a310 [BrowserWindow]) at ../gtk/gtkwindow.c:4670 #3 surface_render (surface=surface@entry=0x560017358170 [GdkX11Toplevel], region=region@entry=0x56001a5365a0, widget=0x56001755a310 [BrowserWindow]) at ../gtk/gtkwindow.c:4683 #4 0x00007f53bddf9438 in _gdk_marshal_BOOLEAN__BOXEDv (closure=closure@entry=0x56001a91fb70, return_value=return_value@entry=0x7ffe05a91db0, instance=instance@entry=0x560017358170, args=args@entry=0x7ffe05a91e80, marshal_data=marshal_data@entry=0x0, n_params=n_params@entry=1, param_types=0x560017355d90) at gdk/gdkmarshalers.c:130 #5 0x00007f53b8482229 in _g_closure_invoke_va (closure=closure@entry=0x56001a91fb70, return_value=return_value@entry=0x7ffe05a91db0, instance=instance@entry=0x560017358170, args=args@entry=0x7ffe05a91e80, n_params=1, param_types=0x560017355d90) at ../gobject/gclosure.c:893 #6 0x00007f53b849ad9b in g_signal_emit_valist (instance=0x560017358170, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffe05a91e80) at ../gobject/gsignal.c:3406 #7 0x00007f53b849bcb3 in g_signal_emit (instance=instance@entry=0x560017358170, signal_id=<optimized out>, detail=detail@entry=0) at ../gobject/gsignal.c:3553 #8 0x00007f53bde20f37 in gdk_surface_process_updates_internal (surface=0x560017358170 [GdkX11Toplevel]) at ../gdk/gdksurface.c:1344 #9 gdk_surface_paint_on_clock (clock=<optimized out>, data=<optimized out>) at ../gdk/gdksurface.c:1432 #10 0x00007f53b8482229 in _g_closure_invoke_va (closure=closure@entry=0x5600175e4360, return_value=return_value@entry=0x0, instance=instance@entry=0x560017356300, args=args@entry=0x7ffe05a92180, n_params=0, param_types=0x0) at ../gobject/gclosure.c:893 #11 0x00007f53b849ba98 in g_signal_emit_valist (instance=0x560017356300, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffe05a92180) at ../gobject/gsignal.c:3406 #12 0x00007f53b849bcb3 in g_signal_emit (instance=instance@entry=0x560017356300, signal_id=<optimized out>, detail=detail@entry=0) at ../gobject/gsignal.c:3553 #13 0x00007f53bde13103 in _gdk_frame_clock_emit_paint (frame_clock=frame_clock@entry=0x560017356300 [GdkFrameClockIdle]) at ../gdk/gdkframeclock.c:709 #14 0x00007f53bde13b9e in gdk_frame_clock_paint_idle (data=<error reading variable: value has been optimized out>) at ../gdk/gdkframeclockidle.c:602 #15 0x00007f53c3387e28 in g_timeout_dispatch (source=0x560019169760, callback=<optimized out>, user_data=<optimized out>) at ../glib/gmain.c:4933 #16 0x00007f53c3387294 in g_main_dispatch (context=0x560017354a70) at ../glib/gmain.c:3381 #17 g_main_context_dispatch (context=0x560017354a70) at ../glib/gmain.c:4099 #18 0x00007f53c3387638 in g_main_context_iterate (context=context@entry=0x560017354a70, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/gmain.c:4175 #19 0x00007f53c3387703 in g_main_context_iteration (context=context@entry=0x560017354a70, may_block=may_block@entry=1) at ../glib/gmain.c:4240 #20 0x00007f53b85bf765 in g_application_run (application=0x56001736c260 [GtkApplication], argc=94970852, argv=<optimized out>) at ../gio/gapplication.c:2569 #21 0x0000560016a5655b in main () 1819074 1 445512 lmoura 2021-11-30 21:03:56 -0800 Created attachment 445512 Tentative patch 1819076 2 ews-watchlist 2021-11-30 21:05:15 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1819137 3 ews-feeder 2021-12-01 00:21:56 -0800 Committed r286354 (244713@main): <https://commits.webkit.org/244713@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445512. 1819138 4 webkit-bug-importer 2021-12-01 00:22:22 -0800 <rdar://problem/85910770> 445512 2021-11-30 21:03:56 -0800 2021-12-01 00:21:58 -0800 Tentative patch bug-233505-20211201020355.patch text/plain 2695 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU3NDhkYmUyOWVhYmNiZWM0 MmIyNDlmOGM2NWNlMjY0ODczYjY3NTEuLjQwZDcxODA1NTE3N2Q2Y2I1MzZkYTE2MzE3N2FiYWZk NTI0NjNhOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjEtMTEtMzAgIExhdXJvIE1v dXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bR1RLNF1bV2ViRHJpdmVy XSBGbGFreSBjcmFzaGVzIGV4aXRpbmcgbWFueSBwcm9tcHR5LXJlbGF0ZWQgd2ViZHJpdmVyIHRl c3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzM1 MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3Zl cmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgIFdoZW4gYnVpbGRpbmcgZm9yIEdUSzQs IHVwb24gZGlhbG9nIGNsb3N1cmUgdGhlIGRpYWxvZyB3aWRnZXRzIG1pZ2h0CisgICAgICAgIGJl IHJlbW92ZWQgd2l0aCBgd2Via2l0V2ViVmlld0RpYWxvZ1NldENoaWxkKGRpYWxvZywgTlVMTClg IHdoaWxlCisgICAgICAgIHRoZSBidXR0b24gaXMgc3RpbGwgcmVnaXN0ZXJlZCBhcyB0aGUgZGVm YXVsdCB3aWRnZXQgb2YgdGhlIHRvcGxldmVsLgorCisgICAgICAgIFRoaXMgY29tbWl0IG1ha2Vz IHN1cmUgd2UgZG9uJ3QgaGF2ZSBhIGRlZmF1bHQgd2lkZ2V0IHdoaWxlIHRoZQorICAgICAgICBk aWFsb2cgaXMgdW5tYXBwZWQsIHRvIG1pcnJvciB0aGUgbWFwKCkgYmVoYXZpb3IuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTY3JpcHREaWFsb2dJbXBsLmNwcDoKKyAgICAg ICAgKHdlYmtpdFNjcmlwdERpYWxvZ0ltcGxVbm1hcCk6IEFkZGVkIHRvIHVuc2V0IHRoZSBkZWZh dWx0IHdpZGdldC4KKyAgICAgICAgKHdlYmtpdF9zY3JpcHRfZGlhbG9nX2ltcGxfY2xhc3NfaW5p dCk6IFJlZ2lzdGVyIHVubWFwIGNhbGxiYWNrLgorCiAyMDIxLTExLTI1ICBLaW1tbyBLaW5udW5l biAgPGtraW5udW5lbkBhcHBsZS5jb20+CiAKICAgICAgICAgR3JhcGhpY3NDb250ZXh0R0wgaW1w bGVtZW50YXRpb25zIHNob3VsZCBoYXZlIHNlcGFyYXRlIGNsYXNzIGRlZmluaXRpb25zCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNjcmlwdERpYWxv Z0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTY3JpcHRE aWFsb2dJbXBsLmNwcAppbmRleCBhZjg1YjQ2ZTBhYjY5NDExNTZiMzM4MzczMzdmYTg0OWQwZmNl ZmM5Li45MWUyYWE0MWViYTAxN2E0ZjRiMTRkZWVmYmYyMDUzYmVjZGMwMzE1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNjcmlwdERpYWxvZ0ltcGwu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2NyaXB0RGlh bG9nSW1wbC5jcHAKQEAgLTc0LDYgKzc0LDIwIEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRTY3Jp cHREaWFsb2dJbXBsS2V5UHJlc3NFdmVudChHdGtXaWRnZXQqIHdpZGdldCwgR2RrRXZlbnRLCiB9 CiAjZW5kaWYKIAorI2lmIFVTRShHVEs0KQorc3RhdGljIHZvaWQgd2Via2l0U2NyaXB0RGlhbG9n SW1wbFVubWFwKEd0a1dpZGdldCogd2lkZ2V0KQoreworICAgIGlmICghZ3RrX3dpZGdldF9nZXRf bWFwcGVkKHdpZGdldCkpCisgICAgICAgIHJldHVybjsKKworICAgIGF1dG8qIHRvcGxldmVsID0g Z3RrX3dpZGdldF9nZXRfdG9wbGV2ZWwoR1RLX1dJREdFVCh3aWRnZXQpKTsKKyAgICBpZiAoV2Vi Q29yZTo6d2lkZ2V0SXNPbnNjcmVlblRvcGxldmVsV2luZG93KHRvcGxldmVsKSkKKyAgICAgICAg Z3RrX3dpbmRvd19zZXRfZGVmYXVsdChHVEtfV0lORE9XKHRvcGxldmVsKSwgbnVsbHB0cik7CisK KyAgICBHVEtfV0lER0VUX0NMQVNTKHdlYmtpdF9zY3JpcHRfZGlhbG9nX2ltcGxfcGFyZW50X2Ns YXNzKS0+dW5tYXAod2lkZ2V0KTsKK30KKyNlbmRpZgorCiBzdGF0aWMgdm9pZCB3ZWJraXRTY3Jp cHREaWFsb2dJbXBsTWFwKEd0a1dpZGdldCogd2lkZ2V0KQogewogICAgIFdlYktpdFNjcmlwdERp YWxvZ0ltcGxQcml2YXRlKiBwcml2ID0gV0VCS0lUX1NDUklQVF9ESUFMT0dfSU1QTCh3aWRnZXQp LT5wcml2OwpAQCAtMjM1LDYgKzI0OSw5IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9zY3JpcHRfZGlh bG9nX2ltcGxfY2xhc3NfaW5pdChXZWJLaXRTY3JpcHREaWFsb2dJbXBsQ2xhc3MqIGtsCiAgICAg d2lkZ2V0Q2xhc3MtPmtleV9wcmVzc19ldmVudCA9IHdlYmtpdFNjcmlwdERpYWxvZ0ltcGxLZXlQ cmVzc0V2ZW50OwogI2VuZGlmCiAgICAgd2lkZ2V0Q2xhc3MtPm1hcCA9IHdlYmtpdFNjcmlwdERp YWxvZ0ltcGxNYXA7CisjaWYgVVNFKEdUSzQpCisgICAgd2lkZ2V0Q2xhc3MtPnVubWFwID0gd2Vi a2l0U2NyaXB0RGlhbG9nSW1wbFVubWFwOworI2VuZGlmCiAjaWYgIVVTRShHVEs0KQogICAgIGd0 a193aWRnZXRfY2xhc3Nfc2V0X2FjY2Vzc2libGVfcm9sZSh3aWRnZXRDbGFzcywgQVRLX1JPTEVf QUxFUlQpOwogI2VuZGlmCg==