23350 2009-01-15 09:11:49 -0800 Build failure because of missing include in wtf/ThreadingPthreads.cpp 2009-01-15 10:29:57 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED DUPLICATE 23347 P2 Normal --- 1 gustavo gustavo oldest_to_newest 105904 0 gustavo 2009-01-15 09:11:49 -0800 Revision 39908 adds usage of INT_MAX and other limits to threading implementations, but missed the limits.h include for the pthreads implementation. 105905 1 26760 gustavo 2009-01-15 09:14:02 -0800 Created attachment 26760 proposed fix 105911 2 bfulgham 2009-01-15 10:01:51 -0800 > #include <errno.h> > #include <sys/time.h> > +#include <limits.h> We generally put the includes in ASCII order. 105913 3 darin 2009-01-15 10:29:28 -0800 *** This bug has been marked as a duplicate of 23347 *** 105915 4 26760 darin 2009-01-15 10:29:57 -0800 Comment on attachment 26760 proposed fix Patch is fine, but there's already a reviewed patch in the other bug. 26760 2009-01-15 09:14:02 -0800 2009-01-15 10:29:57 -0800 proposed fix 0001-missing-limits.h-include-in-ThreadingPthreads.cpp.patch text/plain 1351 gustavo RnJvbSAzOGM4ZjUwODczYTgzYjVhZWI4NDQ3ZTNkZmU0YjY1YTU3NTBhYmYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBUaHUsIDE1IEphbiAyMDA5IDE1OjA2OjI4IC0wMjAwClN1YmplY3Q6IFtQQVRDSF0g bWlzc2luZyBsaW1pdHMuaCBpbmNsdWRlIGluIFRocmVhZGluZ1B0aHJlYWRzLmNwcAoKLS0tCiBK YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAxMSArKysrKysrKysr KwogSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1B0aHJlYWRzLmNwcCB8ICAgIDEgKwogMiBm aWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpp bmRleCAxYzAyZGU4Li4wODE0YTBjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDkt MDEtMTUgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMzUwCisKKyAgICAgICAgQWRkIG1pc3NpbmcgbGltaXRz LmggaW5jbHVkZSBpbiBUaHJlYWRpbmdQdGhyZWFkcy5jcHAgd2hpY2ggd2FzCisgICAgICAgIGNh dXNpbmcgYSBidWlsZCBmYWlsdXJlIGluIEdUSysgYWZ0ZXIgMzk5MDguCisKKyAgICAgICAgKiB3 dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwOgorCiAyMDA5LTAxLTE0ICBEYXZpZCBLaWx6ZXIgIDxk ZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgQnVnIDIzMTUzOiBKU0MgYnVpbGQgYWx3YXlz IHRvdWNoZXMgSmF2YVNjcmlwdENvcmUvZG9jcy9ieXRlY29kZS5odG1sCmRpZmYgLS1naXQgYS9K YXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwIGIvSmF2YVNjcmlwdENvcmUv d3RmL1RocmVhZGluZ1B0aHJlYWRzLmNwcAppbmRleCBlZDEwMmU1Li5kZGFiMzI3IDEwMDY0NAot LS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwCisrKyBiL0phdmFT Y3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAKQEAgLTQwLDYgKzQwLDcgQEAKIAog I2luY2x1ZGUgPGVycm5vLmg+CiAjaW5jbHVkZSA8c3lzL3RpbWUuaD4KKyNpbmNsdWRlIDxsaW1p dHMuaD4KIAogbmFtZXNwYWNlIFdURiB7CiAKLS0gCjEuNS42LjUKCg==