233492 2021-11-25 05:03:24 -0800 [GStreamer][WPE] Control on-disk multimedia buffering via the WPE_SHELL_DISABLE_MEDIA_DISK_CACHE environment variable 2021-11-29 06:33:27 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eocanha eocanha calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj pnormand sergio vjaquez webkit-bug-importer oldest_to_newest 1817793 0 eocanha 2021-11-25 05:03:24 -0800 Embedded platforms often don't have a persistent storage suitable for repetitive writes (eg: caching media files may wear out a flash drive, and RAM memory is scarce enough to use a tmpfs for caching). Those platforms need a way to disable on-disk caching. Metrological has been successfully using an environment variable for that purpose downstream since 2016. If that implementation is upstreamed, other WPE users can benefit from it. 1817798 1 445136 eocanha 2021-11-25 06:02:01 -0800 Created attachment 445136 Patch 1817936 2 445136 calvaris 2021-11-26 03:27:41 -0800 Comment on attachment 445136 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445136&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2565 > + static bool computed = false; Please, use std::once... 1817990 3 445136 eocanha 2021-11-26 12:00:25 -0800 Comment on attachment 445136 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445136&action=review >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2565 >> + static bool computed = false; > > Please, use std::once... I've ended up using std::once_flag and std::call_once. They're very useful and I didn't know about them. Thanks! 1817991 4 445207 eocanha 2021-11-26 12:00:56 -0800 Created attachment 445207 Patch 1818193 5 ews-feeder 2021-11-29 06:32:30 -0800 Committed r286210 (244592@main): <https://commits.webkit.org/244592@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445207. 1818194 6 webkit-bug-importer 2021-11-29 06:33:27 -0800 <rdar://problem/85814319> 445136 2021-11-25 06:02:01 -0800 2021-11-26 12:00:51 -0800 Patch bug-233492-20211125150200.patch text/plain 2811 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0NDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjk2MDkwOTlhN2Q4NDVm YmVmYzljYTEwZGE5YTgzZTAyMGE2YzE3ZS4uOWEwMTYzMzQyMDU4NWJhZTYzYWE3MzBjZTlkMTBh OWZjNjkxNzQ0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTExLTI1ICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl1bV1BFXSBDb250cm9sIG9uLWRpc2sgbXVsdGltZWRpYSBidWZmZXJpbmcgdmlhIHRo ZSBXUEVfU0hFTExfRElTQUJMRV9NRURJQV9ESVNLX0NBQ0hFIGVudmlyb25tZW50IHZhcmlhYmxl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzM0OTIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbWJlZGRl ZCBwbGF0Zm9ybXMgb2Z0ZW4gZG9uJ3QgaGF2ZSBhIHBlcnNpc3RlbnQgc3RvcmFnZSBzdWl0YWJs ZSBmb3IgcmVwZXRpdGl2ZSB3cml0ZXMgKGVnOiBjYWNoaW5nCisgICAgICAgIG1lZGlhIGZpbGVz IG1heSB3ZWFyIG91dCBhIGZsYXNoIGRyaXZlLCBhbmQgUkFNIG1lbW9yeSBpcyBzY2FyY2UgZW5v dWdoIHRvIHVzZSBhIHRtcGZzIGZvciBjYWNoaW5nKS4KKyAgICAgICAgVGhvc2UgcGxhdGZvcm1z IG5lZWQgYSB3YXkgdG8gZGlzYWJsZSBvbi1kaXNrIGNhY2hpbmcuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDog SG9ub3IgZW52aXJvbm1lbnQgdmFyaWFibGUuCisKIDIwMjEtMTAtMTkgIFlvdWVubiBGYWJsZXQg IDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEV4cG9zZSBNZWRpYUNhcGFiaWxpdGllcyB0 byBXb3JrZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIu Y3BwCmluZGV4IDhkMzY2MzVmYzNhMTgyMzc5NGUwZjQwMmExYzlkMTU2NmE1MWYzNzkuLmQ4Mzk3 MjQ0YzI1MjE3ODE1NWY0MWQzY2M2MTNkYWY5NjM4NmQ2Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCkBAIC0yNTU4LDYgKzI1NTgsMjYgQEAg TWVkaWFQbGF5ZXI6OlN1cHBvcnRzVHlwZSBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnN1 cHBvcnRzVHlwZShjb25zdCBNZWRpYUUKICAgICByZXR1cm4gZmluYWxSZXN1bHQ7CiB9CiAKK2Jv b2wgaXNNZWRpYURpc2tDYWNoZURpc2FibGVkKCkKK3sKKyAgICBzdGF0aWMgYm9vbCByZXN1bHQg PSBmYWxzZTsKKyNpZiBQTEFURk9STShXUEUpCisgICAgc3RhdGljIGJvb2wgY29tcHV0ZWQgPSBm YWxzZTsKKworICAgIGlmIChjb21wdXRlZCkKKyAgICAgICAgcmV0dXJuIHJlc3VsdDsKKworICAg IFN0cmluZyBzKHN0ZDo6Z2V0ZW52KCJXUEVfU0hFTExfRElTQUJMRV9NRURJQV9ESVNLX0NBQ0hF IikpOworICAgIGlmICghcy5pc0VtcHR5KCkpIHsKKyAgICAgICAgU3RyaW5nIHZhbHVlID0gcy5z dHJpcFdoaXRlU3BhY2UoKS5jb252ZXJ0VG9Mb3dlcmNhc2VXaXRob3V0TG9jYWxlKCk7CisgICAg ICAgIHJlc3VsdCA9ICh2YWx1ZSA9PSAiMSIgfHwgdmFsdWUgPT0gInQiIHx8IHZhbHVlID09ICJ0 cnVlIik7CisgICAgfQorCisgICAgY29tcHV0ZWQgPSB0cnVlOworI2VuZGlmCisgICAgcmV0dXJu IHJlc3VsdDsKK30KKwogdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnVwZGF0ZURv d25sb2FkQnVmZmVyaW5nRmxhZygpCiB7CiAgICAgaWYgKCFtX3BpcGVsaW5lKQpAQCAtMjU4MSw3 ICsyNjAxLDEwIEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjp1cGRhdGVEb3du bG9hZEJ1ZmZlcmluZ0ZsYWcoKQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgYm9vbCBz aG91bGREb3dubG9hZCA9ICFtX2lzTGl2ZVN0cmVhbSAmJiBtX3ByZWxvYWQgPT0gTWVkaWFQbGF5 ZXI6OlByZWxvYWQ6OkF1dG87CisgICAgYm9vbCBkaXNrQ2FjaGVEaXNhYmxlZCA9IGlzTWVkaWFE aXNrQ2FjaGVEaXNhYmxlZCgpOworICAgIEdTVF9ERUJVR19PQkpFQ1QocGlwZWxpbmUoKSwgIk1l ZGlhIG9uLWRpc2sgY2FjaGUgaXMgJXMiLCAoZGlza0NhY2hlRGlzYWJsZWQpID8gImRpc2FibGVk IiA6ICJlbmFibGVkIik7CisKKyAgICBib29sIHNob3VsZERvd25sb2FkID0gIW1faXNMaXZlU3Ry ZWFtICYmIG1fcHJlbG9hZCA9PSBNZWRpYVBsYXllcjo6UHJlbG9hZDo6QXV0byAmJiAhZGlza0Nh Y2hlRGlzYWJsZWQ7CiAgICAgaWYgKHNob3VsZERvd25sb2FkKSB7CiAgICAgICAgIEdTVF9JTkZP X09CSkVDVChwaXBlbGluZSgpLCAiRW5hYmxpbmcgb24tZGlzayBidWZmZXJpbmciKTsKICAgICAg ICAgZ19vYmplY3Rfc2V0KG1fcGlwZWxpbmUuZ2V0KCksICJmbGFncyIsIGZsYWdzIHwgZmxhZ0Rv d25sb2FkLCBudWxscHRyKTsK 445207 2021-11-26 12:00:56 -0800 2021-11-29 06:32:32 -0800 Patch bug-233492-20211126210055.patch text/plain 2800 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0NDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjk2MDkwOTlhN2Q4NDVm YmVmYzljYTEwZGE5YTgzZTAyMGE2YzE3ZS4uOWEwMTYzMzQyMDU4NWJhZTYzYWE3MzBjZTlkMTBh OWZjNjkxNzQ0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTExLTI1ICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl1bV1BFXSBDb250cm9sIG9uLWRpc2sgbXVsdGltZWRpYSBidWZmZXJpbmcgdmlhIHRo ZSBXUEVfU0hFTExfRElTQUJMRV9NRURJQV9ESVNLX0NBQ0hFIGVudmlyb25tZW50IHZhcmlhYmxl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzM0OTIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbWJlZGRl ZCBwbGF0Zm9ybXMgb2Z0ZW4gZG9uJ3QgaGF2ZSBhIHBlcnNpc3RlbnQgc3RvcmFnZSBzdWl0YWJs ZSBmb3IgcmVwZXRpdGl2ZSB3cml0ZXMgKGVnOiBjYWNoaW5nCisgICAgICAgIG1lZGlhIGZpbGVz IG1heSB3ZWFyIG91dCBhIGZsYXNoIGRyaXZlLCBhbmQgUkFNIG1lbW9yeSBpcyBzY2FyY2UgZW5v dWdoIHRvIHVzZSBhIHRtcGZzIGZvciBjYWNoaW5nKS4KKyAgICAgICAgVGhvc2UgcGxhdGZvcm1z IG5lZWQgYSB3YXkgdG8gZGlzYWJsZSBvbi1kaXNrIGNhY2hpbmcuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDog SG9ub3IgZW52aXJvbm1lbnQgdmFyaWFibGUuCisKIDIwMjEtMTAtMTkgIFlvdWVubiBGYWJsZXQg IDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEV4cG9zZSBNZWRpYUNhcGFiaWxpdGllcyB0 byBXb3JrZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIu Y3BwCmluZGV4IDhkMzY2MzVmYzNhMTgyMzc5NGUwZjQwMmExYzlkMTU2NmE1MWYzNzkuLmZhZDg3 MTA1ZTE5MzFhYjA5ZjYyZjNmYWY0NDFhZWZmMTcwOWQ5MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCkBAIC0yNTU4LDYgKzI1NTgsMjIgQEAg TWVkaWFQbGF5ZXI6OlN1cHBvcnRzVHlwZSBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnN1 cHBvcnRzVHlwZShjb25zdCBNZWRpYUUKICAgICByZXR1cm4gZmluYWxSZXN1bHQ7CiB9CiAKK2Jv b2wgaXNNZWRpYURpc2tDYWNoZURpc2FibGVkKCkKK3sKKyAgICBzdGF0aWMgYm9vbCByZXN1bHQg PSBmYWxzZTsKKyNpZiBQTEFURk9STShXUEUpCisgICAgc3RhdGljIHN0ZDo6b25jZV9mbGFnIG9u Y2U7CisgICAgc3RkOjpjYWxsX29uY2Uob25jZSwgW10oKSB7CisgICAgICAgIFN0cmluZyBzKHN0 ZDo6Z2V0ZW52KCJXUEVfU0hFTExfRElTQUJMRV9NRURJQV9ESVNLX0NBQ0hFIikpOworICAgICAg ICBpZiAoIXMuaXNFbXB0eSgpKSB7CisgICAgICAgICAgICBTdHJpbmcgdmFsdWUgPSBzLnN0cmlw V2hpdGVTcGFjZSgpLmNvbnZlcnRUb0xvd2VyY2FzZVdpdGhvdXRMb2NhbGUoKTsKKyAgICAgICAg ICAgIHJlc3VsdCA9ICh2YWx1ZSA9PSAiMSIgfHwgdmFsdWUgPT0gInQiIHx8IHZhbHVlID09ICJ0 cnVlIik7CisgICAgICAgIH0KKyAgICB9KTsKKyNlbmRpZgorICAgIHJldHVybiByZXN1bHQ7Cit9 CisKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjp1cGRhdGVEb3dubG9hZEJ1ZmZl cmluZ0ZsYWcoKQogewogICAgIGlmICghbV9waXBlbGluZSkKQEAgLTI1ODEsNyArMjU5NywxMCBA QCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6dXBkYXRlRG93bmxvYWRCdWZmZXJp bmdGbGFnKCkKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGJvb2wgc2hvdWxkRG93bmxv YWQgPSAhbV9pc0xpdmVTdHJlYW0gJiYgbV9wcmVsb2FkID09IE1lZGlhUGxheWVyOjpQcmVsb2Fk OjpBdXRvOworICAgIGJvb2wgZGlza0NhY2hlRGlzYWJsZWQgPSBpc01lZGlhRGlza0NhY2hlRGlz YWJsZWQoKTsKKyAgICBHU1RfREVCVUdfT0JKRUNUKHBpcGVsaW5lKCksICJNZWRpYSBvbi1kaXNr IGNhY2hlIGlzICVzIiwgKGRpc2tDYWNoZURpc2FibGVkKSA/ICJkaXNhYmxlZCIgOiAiZW5hYmxl ZCIpOworCisgICAgYm9vbCBzaG91bGREb3dubG9hZCA9ICFtX2lzTGl2ZVN0cmVhbSAmJiBtX3By ZWxvYWQgPT0gTWVkaWFQbGF5ZXI6OlByZWxvYWQ6OkF1dG8gJiYgIWRpc2tDYWNoZURpc2FibGVk OwogICAgIGlmIChzaG91bGREb3dubG9hZCkgewogICAgICAgICBHU1RfSU5GT19PQkpFQ1QocGlw ZWxpbmUoKSwgIkVuYWJsaW5nIG9uLWRpc2sgYnVmZmVyaW5nIik7CiAgICAgICAgIGdfb2JqZWN0 X3NldChtX3BpcGVsaW5lLmdldCgpLCAiZmxhZ3MiLCBmbGFncyB8IGZsYWdEb3dubG9hZCwgbnVs bHB0cik7Cg==