233483 2021-11-24 15:30:46 -0800 check-webkit-style: regenerate localized strings when LocalizedStrings source files change 2021-12-01 15:31:23 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=232642 InRadar P2 Normal --- 1 ddkilzer webkit-unassigned ap jbedard webkit-bug-importer oldest_to_newest 1817712 0 ddkilzer 2021-11-24 15:30:46 -0800 The webkit-patch script should regenerate localized strings when LocalizedStrings*.* source files change, and exit with an error if the Source/WebCore/en.lproj/Localizable.strings contains local changes (that didn't exist before). It's too easy to make localized string changes and forget to run Tools/Scripts/update-webkit-localizable-strings. 1818109 1 ap 2021-11-28 17:59:45 -0800 should this be part of style checker? Webkit-patch changes would only help people who use webkit-patch. 1818216 2 jbedard 2021-11-29 08:02:48 -0800 webkit-patch invokes check-webkit-style (as will git-webkit), that's the right place to do this sort of thing. 1819158 3 ddkilzer 2021-12-01 02:20:15 -0800 My thinking was that knowledge of the changed files in the patch being uploaded would be needed in order to make a decision about whether this check needs to be done, and webkit-patch would have that (not check-WebKit-style). For example, if LocalizedStrings.cpp or LocalizedStringsCocoa.mm changed, then this should be checked, but otherwise it should not (to save time). I guess the actual code to do the checking could be in check-webkit-style, and the logic about whether to run the checker could be in webkit-patch, though. 1819216 4 jbedard 2021-12-01 06:45:27 -0800 (In reply to David Kilzer (:ddkilzer) from comment #3) > My thinking was that knowledge of the changed files in the patch being > uploaded would be needed in order to make a decision about whether this > check needs to be done, and webkit-patch would have that (not > check-WebKit-style). > > For example, if LocalizedStrings.cpp or LocalizedStringsCocoa.mm changed, > then this should be checked, but otherwise it should not (to save time). > > I guess the actual code to do the checking could be in check-webkit-style, > and the logic about whether to run the checker could be in webkit-patch, > though. check-webkit-style actually owns the knowledge of the changed files, since it only operates on the blocks of code a user is changing 1819442 5 webkit-bug-importer 2021-12-01 15:31:23 -0800 <rdar://problem/85942550>