<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>23347</bug_id>
          
          <creation_ts>2009-01-15 05:54:36 -0800</creation_ts>
          <short_desc>Compilation of JavaScriptCore/wtf/ThreadingPthreads.cpp fails</short_desc>
          <delta_ts>2009-01-15 13:32:41 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Craig Schlenter">craig.schlenter</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>gustavo</cc>
    
    <cc>webkit</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>105881</commentid>
    <comment_count>0</comment_count>
    <who name="Craig Schlenter">craig.schlenter</who>
    <bug_when>2009-01-15 05:54:36 -0800</bug_when>
    <thetext>When I try to compile r39933 on linux, the compilation of JavaScriptCore/wtf/ThreadingPthreads.cpp fails because INT_MAX is not defined. Including limits.h fixes this. I&apos;ll attach a patch. I have not tested this on other platforms.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>105883</commentid>
    <comment_count>1</comment_count>
      <attachid>26752</attachid>
    <who name="Craig Schlenter">craig.schlenter</who>
    <bug_when>2009-01-15 05:56:19 -0800</bug_when>
    <thetext>Created attachment 26752
patch to fix compiler error</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>105896</commentid>
    <comment_count>2</comment_count>
      <attachid>26752</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-01-15 08:19:54 -0800</bug_when>
    <thetext>Comment on attachment 26752
patch to fix compiler error

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>105914</commentid>
    <comment_count>3</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-01-15 10:29:28 -0800</bug_when>
    <thetext>*** Bug 23350 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>105949</commentid>
    <comment_count>4</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-01-15 13:05:51 -0800</bug_when>
    <thetext>*** Bug 23353 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>105962</commentid>
    <comment_count>5</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2009-01-15 13:32:41 -0800</bug_when>
    <thetext>Committed as &lt;http://trac.webkit.org/changeset/39945&gt;.

</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>26752</attachid>
            <date>2009-01-15 05:56:19 -0800</date>
            <delta_ts>2009-01-15 08:19:54 -0800</delta_ts>
            <desc>patch to fix compiler error</desc>
            <filename>compilefix.txt</filename>
            <type>text/plain</type>
            <size>896</size>
            <attacher name="Craig Schlenter">craig.schlenter</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM5OTMzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDktMDEtMTUgIENyYWlnIFNj
aGxlbnRlciAgPGNyYWlnLnNjaGxlbnRlckBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvVGhyZWFkaW5nUHRocmVhZHMuY3Bw
OiBpbmNsdWRlZCBsaW1pdHMuaCBhcyBJTlRfTUFYIGlzIGRlZmluZWQKKwl0aGVyZS4KKwogMjAw
OS0wMS0xNCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1
ZyAyMzE1MzogSlNDIGJ1aWxkIGFsd2F5cyB0b3VjaGVzIEphdmFTY3JpcHRDb3JlL2RvY3MvYnl0
ZWNvZGUuaHRtbApJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1B0aHJlYWRzLmNw
cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nUHRocmVhZHMuY3Bw
CShyZXZpc2lvbiAzOTkzMykKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdQdGhyZWFk
cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5LDYgKzM5LDcgQEAKICNpbmNsdWRlICJSYW5kb21O
dW1iZXJTZWVkLmgiCiAKICNpbmNsdWRlIDxlcnJuby5oPgorI2luY2x1ZGUgPGxpbWl0cy5oPgog
I2luY2x1ZGUgPHN5cy90aW1lLmg+CiAKIG5hbWVzcGFjZSBXVEYgewo=
</data>
<flag name="review"
          id="12760"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>