233467 2021-11-23 23:49:19 -0800 WebSWServerConnection::createFetchTask does not need to query twice for a registration 2021-12-01 04:27:50 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen cdumez webkit-bug-importer oldest_to_newest 1817589 0 youennf 2021-11-23 23:49:19 -0800 WebSWServerConnection::createFetchTask does not need to query twice for a registration 1817590 1 445073 youennf 2021-11-23 23:51:30 -0800 Created attachment 445073 Patch 1818739 2 445073 cdumez 2021-11-30 08:05:13 -0800 Comment on attachment 445073 Patch r=me 1818740 3 445073 cdumez 2021-11-30 08:05:27 -0800 Comment on attachment 445073 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445073&action=review > Source/WebKit/ChangeLog:8 > + Instead of searching for a wokrer and then searching for a registration, typo: wokrer 1819126 4 webkit-bug-importer 2021-11-30 23:50:22 -0800 <rdar://problem/85909888> 1819166 5 445545 youennf 2021-12-01 03:17:33 -0800 Created attachment 445545 Patch for landing 1819178 6 ews-feeder 2021-12-01 04:27:45 -0800 Committed r286359 (244718@main): <https://commits.webkit.org/244718@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445545. 445073 2021-11-23 23:51:30 -0800 2021-12-01 03:17:27 -0800 Patch bug-233467-20211124085129.patch text/plain 2681 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk0YjZkYjJiYzlhM2JmMTQz YWE5Nzg2YTEyMmJiMDAzMjhhMDQ0ZjIuLmJmNzg2YzRhZDk5N2JhM2IxOWFmNmQ2ZDFlODlmM2Ez YmE2MWUyNDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMTEtMjMgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFdlYlNXU2VydmVyQ29ubmVjdGlv bjo6Y3JlYXRlRmV0Y2hUYXNrIGRvZXMgbm90IG5lZWQgdG8gcXVlcnkgdHdpY2UgZm9yIGEgcmVn aXN0cmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzM0NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbnN0ZWFkIG9mIHNlYXJjaGluZyBmb3IgYSB3b2tyZXIgYW5kIHRoZW4gc2VhcmNoaW5nIGZv ciBhIHJlZ2lzdHJhdGlvbiwKKyAgICAgICAgd2Ugbm93IHNlYXJjaCBmb3IgYSByZWdpc3RyYXRp b24gYW5kLCBpZiBub3QgbnVsbCwgZGlyZWN0bHkgZ2V0IGl0cyBhY3RpdmUgd29ya2VyLgorICAg ICAgICBUaGlzIG1ha2VzIGl0IGNsZWFyIHRoZSByZWdpc3RyYXRpb24gaXMgbm90IG51bGwgaW4g Zm9sbG93LXVwIGNvZGUgYW5kIHJlbW92ZXMgYSByZWR1bmRhbnQgcXVlcnkuCisKKyAgICAgICAg Tm8gY2hhbmdlIG9mIGJlaGF2aW9yLCB0aGlzIGlzIGEgcmVmYWN0b3JpbmcuCisKKyAgICAgICAg KiBOZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1dlYlNXU2VydmVyQ29ubmVjdGlvbi5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYlNXU2VydmVyQ29ubmVjdGlvbjo6Y3JlYXRlRmV0Y2hUYXNr KToKKwogMjAyMS0xMS0yMyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAg ICAgICAgQXBwbHkgV2ViUHJlZmVyZW5jZXMgb24gU2VydmljZVdvcmtlciBzZXR0aW5ncwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1dlYlNX U2VydmVyQ29ubmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1NlcnZp Y2VXb3JrZXIvV2ViU1dTZXJ2ZXJDb25uZWN0aW9uLmNwcAppbmRleCAzYzMxOWMxN2NiZjE0MTBi ZDNhZWFmNmQ3NDVmZDc0OTk3ODNjNWE2Li5jNDVlZTZlZjY1NzNhZTFlYmFiMDRmYmUwNWM3MGZi NDM4MzQ0ZGU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1NlcnZp Y2VXb3JrZXIvV2ViU1dTZXJ2ZXJDb25uZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIvV2ViU1dTZXJ2ZXJDb25uZWN0aW9uLmNwcApAQCAt MTc3LDE0ICsxNzcsMTQgQEAgc3RkOjp1bmlxdWVfcHRyPFNlcnZpY2VXb3JrZXJGZXRjaFRhc2s+ IFdlYlNXU2VydmVyQ29ubmVjdGlvbjo6Y3JlYXRlRmV0Y2hUYXNrKE4KICAgICAgICAgc2Vydmlj ZVdvcmtlclJlZ2lzdHJhdGlvbklkZW50aWZpZXIgPSAqbG9hZGVyLnBhcmFtZXRlcnMoKS5zZXJ2 aWNlV29ya2VyUmVnaXN0cmF0aW9uSWRlbnRpZmllcjsKICAgICB9CiAKLSAgICBhdXRvKiB3b3Jr ZXIgPSBzZXJ2ZXIoKS5hY3RpdmVXb3JrZXJGcm9tUmVnaXN0cmF0aW9uSUQoKnNlcnZpY2VXb3Jr ZXJSZWdpc3RyYXRpb25JZGVudGlmaWVyKTsKKyAgICBhdXRvKiByZWdpc3RyYXRpb24gPSBzZXJ2 ZXIoKS5nZXRSZWdpc3RyYXRpb24oKnNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25JZGVudGlmaWVy KTsKKyAgICBhdXRvKiB3b3JrZXIgPSByZWdpc3RyYXRpb24gPyByZWdpc3RyYXRpb24tPmFjdGl2 ZVdvcmtlcigpIDogbnVsbHB0cjsKICAgICBpZiAoIXdvcmtlcikgewogICAgICAgICBTV1NFUlZF UkNPTk5FQ1RJT05fUkVMRUFTRV9MT0dfRVJST1IoInN0YXJ0RmV0Y2g6IERpZE5vdEhhbmRsZSBi ZWNhdXNlIG5vIGFjdGl2ZSB3b3JrZXIgZm9yIHJlZ2lzdHJhdGlvbiAlIiBQUkl1NjQsIHNlcnZp Y2VXb3JrZXJSZWdpc3RyYXRpb25JZGVudGlmaWVyLT50b1VJbnQ2NCgpKTsKICAgICAgICAgcmV0 dXJuIG51bGxwdHI7CiAgICAgfQogCi0gICAgYXV0byogcmVnaXN0cmF0aW9uID0gc2VydmVyKCku Z2V0UmVnaXN0cmF0aW9uKCpzZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uSWRlbnRpZmllcik7Ci0g ICAgYm9vbCBzaG91bGRTb2Z0VXBkYXRlID0gcmVnaXN0cmF0aW9uICYmIHJlZ2lzdHJhdGlvbi0+ c2hvdWxkU29mdFVwZGF0ZShsb2FkZXIucGFyYW1ldGVycygpLm9wdGlvbnMpOworICAgIGJvb2wg c2hvdWxkU29mdFVwZGF0ZSA9IHJlZ2lzdHJhdGlvbi0+c2hvdWxkU29mdFVwZGF0ZShsb2FkZXIu cGFyYW1ldGVycygpLm9wdGlvbnMpOwogICAgIGlmICh3b3JrZXItPnNob3VsZFNraXBGZXRjaEV2 ZW50KCkpIHsKICAgICAgICAgaWYgKHNob3VsZFNvZnRVcGRhdGUpCiAgICAgICAgICAgICByZWdp c3RyYXRpb24tPnNjaGVkdWxlU29mdFVwZGF0ZShsb2FkZXIuaXNBcHBJbml0aWF0ZWQoKSA/IFdl YkNvcmU6OklzQXBwSW5pdGlhdGVkOjpZZXMgOiBXZWJDb3JlOjpJc0FwcEluaXRpYXRlZDo6Tm8p Owo= 445545 2021-12-01 03:17:33 -0800 2021-12-01 04:27:48 -0800 Patch for landing bug-233467-20211201121731.patch text/plain 2674 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAyYTQzNTgwN2YwODNiYWI4 YjhhMDk5NGVmZjJhMDI0YmU5Y2MzNjkuLjdlZDFkZTU4ZTFkYTVkNGM5YmI0ZWI5ZDhmNzA3ODhj MTdkOGE3NTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMTItMDEgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFdlYlNXU2VydmVyQ29ubmVjdGlv bjo6Y3JlYXRlRmV0Y2hUYXNrIGRvZXMgbm90IG5lZWQgdG8gcXVlcnkgdHdpY2UgZm9yIGEgcmVn aXN0cmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzM0NjcKKworICAgICAgICBSZXZpZXdlZCBieSBDaHJpcyBEdW1lei4KKworICAgICAgICBJ bnN0ZWFkIG9mIHNlYXJjaGluZyBmb3IgYSB3b3JrZXIgYW5kIHRoZW4gc2VhcmNoaW5nIGZvciBh IHJlZ2lzdHJhdGlvbiwKKyAgICAgICAgd2Ugbm93IHNlYXJjaCBmb3IgYSByZWdpc3RyYXRpb24g YW5kLCBpZiBub3QgbnVsbCwgZGlyZWN0bHkgZ2V0IGl0cyBhY3RpdmUgd29ya2VyLgorICAgICAg ICBUaGlzIG1ha2VzIGl0IGNsZWFyIHRoZSByZWdpc3RyYXRpb24gaXMgbm90IG51bGwgaW4gZm9s bG93LXVwIGNvZGUgYW5kIHJlbW92ZXMgYSByZWR1bmRhbnQgcXVlcnkuCisKKyAgICAgICAgTm8g Y2hhbmdlIG9mIGJlaGF2aW9yLCB0aGlzIGlzIGEgcmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiBO ZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1dlYlNXU2VydmVyQ29ubmVjdGlvbi5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYlNXU2VydmVyQ29ubmVjdGlvbjo6Y3JlYXRlRmV0Y2hUYXNrKToK KwogMjAyMS0xMi0wMSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIFdLV2Vic2l0ZURhdGFTdG9yZSBjb25maWd1cmF0aW9uIG9wdGlvbiB0byBlbmFibGUg TW9jayBhcHAgYnVuZGxlIHRlc3RpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIvV2ViU1dTZXJ2ZXJDb25uZWN0aW9uLmNwcCBiL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9XZWJTV1NlcnZlckNvbm5lY3Rp b24uY3BwCmluZGV4IGJmNzc3MDNjODI2NjQ3MjRiMzlkOGNhYjM5YjY2MjcyZmIzMzg0YjguLmQ5 YzRkZjM3MmEzZGQ0ZDc5YjkyMzVkMmVmMDZlZDBjMDE2ZjVkZGQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9XZWJTV1NlcnZlckNvbm5lY3Rp b24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9X ZWJTV1NlcnZlckNvbm5lY3Rpb24uY3BwCkBAIC0xNzcsMTUgKzE3NywxNSBAQCBzdGQ6OnVuaXF1 ZV9wdHI8U2VydmljZVdvcmtlckZldGNoVGFzaz4gV2ViU1dTZXJ2ZXJDb25uZWN0aW9uOjpjcmVh dGVGZXRjaFRhc2soTgogICAgICAgICBzZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uSWRlbnRpZmll ciA9ICpsb2FkZXIucGFyYW1ldGVycygpLnNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25JZGVudGlm aWVyOwogICAgIH0KIAotICAgIGF1dG8qIHdvcmtlciA9IHNlcnZlcigpLmFjdGl2ZVdvcmtlckZy b21SZWdpc3RyYXRpb25JRCgqc2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbklkZW50aWZpZXIpOwor ICAgIGF1dG8qIHJlZ2lzdHJhdGlvbiA9IHNlcnZlcigpLmdldFJlZ2lzdHJhdGlvbigqc2Vydmlj ZVdvcmtlclJlZ2lzdHJhdGlvbklkZW50aWZpZXIpOworICAgIGF1dG8qIHdvcmtlciA9IHJlZ2lz dHJhdGlvbiA/IHJlZ2lzdHJhdGlvbi0+YWN0aXZlV29ya2VyKCkgOiBudWxscHRyOwogICAgIGlm ICghd29ya2VyKSB7CiAgICAgICAgIFNXU0VSVkVSQ09OTkVDVElPTl9SRUxFQVNFX0xPR19FUlJP Uigic3RhcnRGZXRjaDogRGlkTm90SGFuZGxlIGJlY2F1c2Ugbm8gYWN0aXZlIHdvcmtlciBmb3Ig cmVnaXN0cmF0aW9uICUiIFBSSXU2NCwgc2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbklkZW50aWZp ZXItPnRvVUludDY0KCkpOwogICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICB9CiAKLSAgICBh dXRvKiByZWdpc3RyYXRpb24gPSBzZXJ2ZXIoKS5nZXRSZWdpc3RyYXRpb24oKnNlcnZpY2VXb3Jr ZXJSZWdpc3RyYXRpb25JZGVudGlmaWVyKTsKICAgICBpZiAod29ya2VyLT5zaG91bGRTa2lwRmV0 Y2hFdmVudCgpKSB7Ci0gICAgICAgIGlmIChyZWdpc3RyYXRpb24gJiYgcmVnaXN0cmF0aW9uLT5z aG91bGRTb2Z0VXBkYXRlKGxvYWRlci5wYXJhbWV0ZXJzKCkub3B0aW9ucykpCisgICAgICAgIGlm IChyZWdpc3RyYXRpb24tPnNob3VsZFNvZnRVcGRhdGUobG9hZGVyLnBhcmFtZXRlcnMoKS5vcHRp b25zKSkKICAgICAgICAgICAgIHJlZ2lzdHJhdGlvbi0+c2NoZWR1bGVTb2Z0VXBkYXRlKGxvYWRl ci5pc0FwcEluaXRpYXRlZCgpID8gV2ViQ29yZTo6SXNBcHBJbml0aWF0ZWQ6OlllcyA6IFdlYkNv cmU6OklzQXBwSW5pdGlhdGVkOjpObyk7CiAKICAgICAgICAgcmV0dXJuIG51bGxwdHI7Cg==