<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>233455</bug_id>
          
          <creation_ts>2021-11-23 20:06:51 -0800</creation_ts>
          <short_desc>[GTK][GTK4] MiniBrowser asserts in isInAcceleratedCompositingMode opening page in debug mode</short_desc>
          <delta_ts>2023-03-30 02:34:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=195879</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>210100</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Lauro Moura">lmoura</reporter>
          <assigned_to name="Carlos Garcia Campos">cgarcia</assigned_to>
          <cc>bugs-noreply</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1817550</commentid>
    <comment_count>0</comment_count>
    <who name="Lauro Moura">lmoura</who>
    <bug_when>2021-11-23 20:06:51 -0800</bug_when>
    <thetext>Steps to reproduce:

* Build with GTK4 enabled: --cmakeargs=&quot;-DUSE_GTK4=On&quot;   
* Run MiniBrowser

It asserts checking for drawingArea-&gt;isInAcceleratedCompositingMode().

Looks like the snapshots are being requested before the rendering scheme effectively transitions to AC mode.

Trace:

ASSERTION FAILED: drawingArea-&gt;isInAcceleratedCompositingMode()
/app/webkit/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp(729) : void webkitWebViewBaseSnapshot(GtkWidget*, GtkSnapshot*)
1   0x7f4b7f437c2d WTFCrash
2   0x7f4b82b02f56 std::numeric_limits&lt;unsigned int&gt;::max()
3   0x7f4b83bbb587 /app/webkit/WebKitBuild/Debug/lib/libwebkit2gtk-5.0.so.0(+0x20a9587) [0x7f4b83bbb587]
4   0x7f4b815c874f /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x31774f) [0x7f4b815c874f]
5   0x7f4b815cb614 /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x31a614) [0x7f4b815cb614]
6   0x7f4b815d8003 gtk_widget_snapshot_child
7   0x7f4b814c7af5 /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x216af5) [0x7f4b814c7af5]
8   0x7f4b815c874f /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x31774f) [0x7f4b815c874f]
9   0x7f4b815cb614 /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x31a614) [0x7f4b815cb614]
10  0x7f4b815d8003 gtk_widget_snapshot_child
11  0x7f4b815d808e /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x32708e) [0x7f4b815d808e]
12  0x7f4b815c874f /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x31774f) [0x7f4b815c874f]
13  0x7f4b815cb614 /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x31a614) [0x7f4b815cb614]
14  0x7f4b815d8003 gtk_widget_snapshot_child
15  0x7f4b815c874f /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x31774f) [0x7f4b815c874f]
16  0x7f4b815cb614 /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x31a614) [0x7f4b815cb614]
17  0x7f4b815d8003 gtk_widget_snapshot_child
18  0x7f4b815d808e /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x32708e) [0x7f4b815d808e]
19  0x7f4b815c874f /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x31774f) [0x7f4b815c874f]
20  0x7f4b815cb614 /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x31a614) [0x7f4b815cb614]
21  0x7f4b815d8003 gtk_widget_snapshot_child
22  0x7f4b815d808e /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x32708e) [0x7f4b815d808e]
23  0x7f4b815c874f /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x31774f) [0x7f4b815c874f]
24  0x7f4b815cb614 /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x31a614) [0x7f4b815cb614]
25  0x7f4b815d8003 gtk_widget_snapshot_child
26  0x7f4b815d808e /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x32708e) [0x7f4b815d808e]
27  0x7f4b815c8b26 /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x317b26) [0x7f4b815c8b26]
28  0x7f4b815cb614 /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x31a614) [0x7f4b815cb614]
29  0x7f4b815d79b3 /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x3269b3) [0x7f4b815d79b3]
30  0x7f4b815e44e6 /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x3334e6) [0x7f4b815e44e6]
31  0x7f4b816d1438 /usr/lib/x86_64-linux-gnu/libgtk-4.so.1(+0x420438) [0x7f4b816d1438]
Mesa: The provided filesystem timestamp for the cache is bogus! Disabling On-disk cache.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1944928</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2023-03-29 02:52:06 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/12104</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1945280</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-03-30 02:34:39 -0700</bug_when>
    <thetext>Committed 262317@main (8203d28d8126): &lt;https://commits.webkit.org/262317@main&gt;

Reviewed commits have been landed. Closing PR #12104 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>