233452 2021-11-23 14:56:35 -0800 [GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range 2021-11-23 19:47:15 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 210100 1 lmoura lmoura bugs-noreply mcatanzaro oldest_to_newest 1817523 0 lmoura 2021-11-23 14:56:35 -0800 [GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range 1817524 1 445051 lmoura 2021-11-23 14:57:32 -0800 Created attachment 445051 Patch 1817532 2 445051 mcatanzaro 2021-11-23 15:50:47 -0800 Comment on attachment 445051 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445051&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:1336 > window->backgroundColor.alpha = 1; Nit: might as well write this as 1.0 as well, to be consistent with the line above. Or write 1 in both places. Doesn't matter, of course.... 1817546 3 445058 lmoura 2021-11-23 19:17:53 -0800 Created attachment 445058 Patch for landing 1817548 4 ews-feeder 2021-11-23 19:47:13 -0800 Committed r286141 (244528@main): <https://commits.webkit.org/244528@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445058. 445051 2021-11-23 14:57:32 -0800 2021-11-23 19:17:48 -0800 Patch bug-233452-20211123195731.patch text/plain 1657 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MTE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2FjODA1ZjNiMjg4MWE3ZjBkNjM2Y2Q0MGFhNDA3YzBl ODIyMWUwZS4uNjU1NTc5ZjA4YjI3YWQ5M2RkMDFjN2QyZjM1MWM1NDY2YWE2OTc0MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIxLTExLTIzICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtHVEtdIEdka1JHQkEgZXhwZWN0cyBjb2xvcnMgdG8gYmUgaW4gdGhlIDAuMCB0byAxLjAg cmFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIz MzQ1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdU SzQgZGVidWcgd2FzIGhpdHRpbmcgYXNzZXJ0SW5SYW5nZSBpbnNpZGUgQ29sb3JUeXBlcy5oIGR1 ZSB0byAyNTUKKyAgICAgICAgYmVpbmcgdXNlZCBhcyB0aGUgbWF4IHZhbHVlLCB3aGlsZSBHZGtS R0JBIGV4cGVjdHMgdGhlIHZhbHVlIHRvIGJlCisgICAgICAgIGJldHdlZW4gMC4wIGFuZCAxLjAs IHBlciB0aGUgb2ZmaWNpYWwgZG9jcyBbMV1bMl0uCisKKyAgICAgICAgWzFdIGh0dHBzOi8vZG9j cy5ndGsub3JnL2dkazMvc3RydWN0LlJHQkEuaHRtbAorICAgICAgICBbMl0gaHR0cHM6Ly9kb2Nz Lmd0ay5vcmcvZ2RrNC9zdHJ1Y3QuUkdCQS5odG1sCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9n dGsvQnJvd3NlcldpbmRvdy5jOgorCiAyMDIxLTExLTIyICBHZXphIExvcmUgIDxnbG9yZUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtKU0NdIE1ha2Ugc2hhcmluZyBvZiB1bmxpbmtlZCBiYXNlbGlu ZSBjb2RlIHBvc3NpYmxlIG9uIEpTVkFMVUUzMl82NApkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJy b3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2Vy V2luZG93LmMKaW5kZXggMjlhMDlkZGFmZTRkYmQ1MGY4YTJjNDYxYTkxYzYzZmJlZWRlMDAzYS4u OWRjMTA2OTNiMjQwYmZhNDg5MTI2ODg1Y2UyNjlkN2VlMjFlNGFkNyAxMDA2NDQKLS0tIGEvVG9v bHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYworKysgYi9Ub29scy9NaW5pQnJvd3Nl ci9ndGsvQnJvd3NlcldpbmRvdy5jCkBAIC0xMzMyLDcgKzEzMzIsNyBAQCBzdGF0aWMgY29uc3Qg R0FjdGlvbkVudHJ5IGFjdGlvbnNbXSA9IHsKIAogc3RhdGljIHZvaWQgYnJvd3Nlcl93aW5kb3df aW5pdChCcm93c2VyV2luZG93ICp3aW5kb3cpCiB7Ci0gICAgd2luZG93LT5iYWNrZ3JvdW5kQ29s b3IucmVkID0gd2luZG93LT5iYWNrZ3JvdW5kQ29sb3IuZ3JlZW4gPSB3aW5kb3ctPmJhY2tncm91 bmRDb2xvci5ibHVlID0gMjU1OworICAgIHdpbmRvdy0+YmFja2dyb3VuZENvbG9yLnJlZCA9IHdp bmRvdy0+YmFja2dyb3VuZENvbG9yLmdyZWVuID0gd2luZG93LT5iYWNrZ3JvdW5kQ29sb3IuYmx1 ZSA9IDEuMDsKICAgICB3aW5kb3ctPmJhY2tncm91bmRDb2xvci5hbHBoYSA9IDE7CiAKICAgICBn dGtfd2luZG93X3NldF90aXRsZShHVEtfV0lORE9XKHdpbmRvdyksIGRlZmF1bHRXaW5kb3dUaXRs ZSk7Cg== 445058 2021-11-23 19:17:53 -0800 2021-11-23 19:47:14 -0800 Patch for landing bug-233452-20211124001751.patch text/plain 1784 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MTQwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGM1NmJhNDU5N2JmYzdkYjk1ZmE5MjM1OWIzYjA0Yjc3 YTQwNzc0Yy4uYTU4ZmZjMWU3N2EwOWZjNmQ3ZGFlYzY4YTA2NDVkZjQ2ZjkzZTE1YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIxLTExLTIzICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtHVEtdIEdka1JHQkEgZXhwZWN0cyBjb2xvcnMgdG8gYmUgaW4gdGhlIDAuMCB0byAxLjAg cmFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIz MzQ1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE1pY2hhZWwgQ2F0YW56YXJvLgorCisgICAgICAg IEdUSzQgZGVidWcgd2FzIGhpdHRpbmcgYXNzZXJ0SW5SYW5nZSBpbnNpZGUgQ29sb3JUeXBlcy5o IGR1ZSB0byAyNTUKKyAgICAgICAgYmVpbmcgdXNlZCBhcyB0aGUgbWF4IHZhbHVlLCB3aGlsZSBH ZGtSR0JBIGV4cGVjdHMgdGhlIHZhbHVlIHRvIGJlCisgICAgICAgIGJldHdlZW4gMC4wIGFuZCAx LjAsIHBlciB0aGUgb2ZmaWNpYWwgZG9jcyBbMV1bMl0uCisKKyAgICAgICAgWzFdIGh0dHBzOi8v ZG9jcy5ndGsub3JnL2dkazMvc3RydWN0LlJHQkEuaHRtbAorICAgICAgICBbMl0gaHR0cHM6Ly9k b2NzLmd0ay5vcmcvZ2RrNC9zdHJ1Y3QuUkdCQS5odG1sCisKKyAgICAgICAgKiBNaW5pQnJvd3Nl ci9ndGsvQnJvd3NlcldpbmRvdy5jOgorCiAyMDIxLTExLTIzICBDYXJsb3MgR2FyY2lhIENhbXBv cyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBDaGFuZ2UgaGFyZHdhcmUt YWNjZWxlcmF0aW9uLXBvbGljeSBzZXR0aW5nIGRlZmF1bHQgdmFsdWUgdG8gYWx3YXlzCmRpZmYg LS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jIGIvVG9vbHMvTWlu aUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYwppbmRleCAyOWEwOWRkYWZlNGRiZDUwZjhhMmM0 NjFhOTFjNjNmYmVlZGUwMDNhLi44ODE2MDljOWZlOGYyYjVlZDYxNThhNTk3MjQzOGMxNGZkNjUw Y2Y1IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCisr KyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMKQEAgLTEzMzIsOCArMTMz Miw4IEBAIHN0YXRpYyBjb25zdCBHQWN0aW9uRW50cnkgYWN0aW9uc1tdID0gewogCiBzdGF0aWMg dm9pZCBicm93c2VyX3dpbmRvd19pbml0KEJyb3dzZXJXaW5kb3cgKndpbmRvdykKIHsKLSAgICB3 aW5kb3ctPmJhY2tncm91bmRDb2xvci5yZWQgPSB3aW5kb3ctPmJhY2tncm91bmRDb2xvci5ncmVl biA9IHdpbmRvdy0+YmFja2dyb3VuZENvbG9yLmJsdWUgPSAyNTU7Ci0gICAgd2luZG93LT5iYWNr Z3JvdW5kQ29sb3IuYWxwaGEgPSAxOworICAgIHdpbmRvdy0+YmFja2dyb3VuZENvbG9yLnJlZCA9 IHdpbmRvdy0+YmFja2dyb3VuZENvbG9yLmdyZWVuID0gd2luZG93LT5iYWNrZ3JvdW5kQ29sb3Iu Ymx1ZSA9IDEuMDsKKyAgICB3aW5kb3ctPmJhY2tncm91bmRDb2xvci5hbHBoYSA9IDEuMDsKIAog ICAgIGd0a193aW5kb3dfc2V0X3RpdGxlKEdUS19XSU5ET1cod2luZG93KSwgZGVmYXVsdFdpbmRv d1RpdGxlKTsKICAgICBndGtfd2luZG93X3NldF9kZWZhdWx0X3NpemUoR1RLX1dJTkRPVyh3aW5k b3cpLCAxMDI0LCA3NjgpOwo=