233420 2021-11-22 06:46:13 -0800 Window.location setter not adding new global history entry (session history works as expected) 2022-03-22 23:22:08 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified NEW https://lapcatsoftware.com/articles/history.html InRadar P2 Normal --- 1 gsnedders webkit-unassigned achristensen beidson cdumez opendarwin simon.fraser webkit-bug-importer oldest_to_newest 1817280 0 gsnedders 2021-11-22 06:46:13 -0800 <div> <button id="mybutton1" type="button"> Change location </button> </div> <script> function MyClick1(event) { location = "https://underpassapp.com"; } document.getElementById("mybutton1") .addEventListener("click", MyClick1); </script> In Firefox and Chrome this creates a a new history item, in Safari this doesn't. Perhaps https://wpt.fyi/results/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&q=location-setter, but likely we have some WPT coverage for this. 1818195 1 webkit-bug-importer 2021-11-29 06:47:26 -0800 <rdar://problem/85814717> 1818474 2 cdumez 2021-11-29 14:21:48 -0800 I am unable to reproduce. When I click the button, I see history.length increase by one and there is an option to go back in the Safari UI. 1818479 3 cdumez 2021-11-29 14:24:45 -0800 I see this was reported on macOS 10.13 High Sierra which is super old. I am on macOS 12.1 Monterey so this could be why I cannot reproduce. 1818687 4 gsnedders 2021-11-30 04:23:14 -0800 (In reply to Chris Dumez from comment #3) > I see this was reported on macOS 10.13 High Sierra which is super old. I am > on macOS 12.1 Monterey so this could be why I cannot reproduce. The post says "This bug appears to be many years old: it occurs in the latest version 15.1, and it occurs in the oldest version that I could test, Safari 11 on macOS 10.13 High Sierra." Certainly I can reproduce it on 12.0.1 (21A559), but I don't have 12.1 immediately to hand. 1819234 5 cdumez 2021-12-01 07:48:40 -0800 *** Bug 233685 has been marked as a duplicate of this bug. *** 1854061 6 beidson 2022-03-22 23:19:35 -0700 Chris I think you were testing the wrong thing. This is about browser global history, not session history. 1854062 7 beidson 2022-03-22 23:20:22 -0700 This blog post that spawned the radar mentioned that, not sure why that wasn’t included in the report https://lapcatsoftware.com/articles/history.html 1854063 8 beidson 2022-03-22 23:22:08 -0700 And on that note, this may be WebKit not sending a sensible history delegate message to Safari, or it might be Safari mishandling it. Investigation will be needed.