<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>233412</bug_id>
          
          <creation_ts>2021-11-21 21:35:50 -0800</creation_ts>
          <short_desc>[MSVC] RenderBlock.cpp(2259): warning C4239: nonstandard extension used: &apos;initializing&apos;: conversion from &apos;WebCore::Length&apos; to &apos;WebCore::Length &amp;&apos;</short_desc>
          <delta_ts>2021-11-22 12:43:21 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>changseok</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>pdr</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>svillar</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1817230</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2021-11-21 21:35:50 -0800</bug_when>
    <thetext>[MSVC] RenderBlock.cpp(2259): warning C4239: nonstandard extension used: &apos;initializing&apos;: conversion from &apos;WebCore::Length&apos; to &apos;WebCore::Length &amp;&apos;

WinCairo build reports the following warnings.

Source\WebCore\rendering/RenderBlock.cpp(2259): warning C4239: nonstandard extension used: &apos;initializing&apos;: conversion from &apos;WebCore::Length&apos; to &apos;WebCore::Length &amp;&apos;
Source\WebCore\rendering/RenderBlock.cpp(2259): note: A non-const reference may only be bound to an lvalue
Source\WebCore\rendering/RenderBox.cpp(3116): warning C4239: nonstandard extension used: &apos;initializing&apos;: conversion from &apos;WebCore::Length&apos; to &apos;WebCore::Length &amp;&apos;
Source\WebCore\rendering/RenderBox.cpp(3116): note: A non-const reference may only be bound to an lvalue</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1817233</commentid>
    <comment_count>1</comment_count>
      <attachid>444943</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2021-11-21 21:39:38 -0800</bug_when>
    <thetext>Created attachment 444943
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1817235</commentid>
    <comment_count>2</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2021-11-21 21:40:15 -0800</bug_when>
    <thetext>Bug 230755 added the code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1817331</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-11-22 12:42:18 -0800</bug_when>
    <thetext>Committed r286118 (244505@main): &lt;https://commits.webkit.org/244505@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444943.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1817332</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-11-22 12:43:21 -0800</bug_when>
    <thetext>&lt;rdar://problem/85682648&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>444943</attachid>
            <date>2021-11-21 21:39:38 -0800</date>
            <delta_ts>2021-11-22 12:42:19 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-233412-20211122143937.patch</filename>
            <type>text/plain</type>
            <size>3559</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQ0YWUwOGI5ZjZjNGJm
MDUxZDc3YWFkOGNjNWEzNDA4NzZjODZmNy4uMDI0NWU1OWFkMTFmZjIwNzZlM2VkOThkZTFkYjNl
MGM0MDBiZDcyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTExLTIxICBGdWpp
aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtNU1ZDXSBS
ZW5kZXJCbG9jay5jcHAoMjI1OSk6IHdhcm5pbmcgQzQyMzk6IG5vbnN0YW5kYXJkIGV4dGVuc2lv
biB1c2VkOiAnaW5pdGlhbGl6aW5nJzogY29udmVyc2lvbiBmcm9tICdXZWJDb3JlOjpMZW5ndGgn
IHRvICdXZWJDb3JlOjpMZW5ndGggJicKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTIzMzQxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgIFdpbkNhaXJvIGJ1aWxkIHJlcG9ydGVkIHRoZSBmb2xsb3dpbmcgd2Fy
bmluZ3MuCisKKyAgICAgICAgPiBTb3VyY2VcV2ViQ29yZVxyZW5kZXJpbmcvUmVuZGVyQmxvY2su
Y3BwKDIyNTkpOiB3YXJuaW5nIEM0MjM5OiBub25zdGFuZGFyZCBleHRlbnNpb24gdXNlZDogJ2lu
aXRpYWxpemluZyc6IGNvbnZlcnNpb24gZnJvbSAnV2ViQ29yZTo6TGVuZ3RoJyB0byAnV2ViQ29y
ZTo6TGVuZ3RoICYnCisgICAgICAgID4gU291cmNlXFdlYkNvcmVccmVuZGVyaW5nL1JlbmRlckJs
b2NrLmNwcCgyMjU5KTogbm90ZTogQSBub24tY29uc3QgcmVmZXJlbmNlIG1heSBvbmx5IGJlIGJv
dW5kIHRvIGFuIGx2YWx1ZQorICAgICAgICA+IFNvdXJjZVxXZWJDb3JlXHJlbmRlcmluZy9SZW5k
ZXJCb3guY3BwKDMxMTYpOiB3YXJuaW5nIEM0MjM5OiBub25zdGFuZGFyZCBleHRlbnNpb24gdXNl
ZDogJ2luaXRpYWxpemluZyc6IGNvbnZlcnNpb24gZnJvbSAnV2ViQ29yZTo6TGVuZ3RoJyB0byAn
V2ViQ29yZTo6TGVuZ3RoICYnCisgICAgICAgID4gU291cmNlXFdlYkNvcmVccmVuZGVyaW5nL1Jl
bmRlckJveC5jcHAoMzExNik6IG5vdGU6IEEgbm9uLWNvbnN0IHJlZmVyZW5jZSBtYXkgb25seSBi
ZSBib3VuZCB0byBhbiBsdmFsdWUKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5j
cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6Y29tcHV0ZVByZWZlcnJlZExvZ2lj
YWxXaWR0aHMpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3guY3BwOgorICAgICAgICAo
V2ViQ29yZTo6UmVuZGVyQm94Ojpjb21wdXRlTG9naWNhbEhlaWdodCBjb25zdCk6CisgICAgICAg
IENoYW5nZWQgImF1dG8mIiB0byAiY29uc3QgYXV0byYiLgorCiAyMDIxLTExLTIxICBBbGFuIEJ1
anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gRW5h
YmxlIGJpZGkgY29udGVudCBmb3Igbm9uLWlubGluZS1ib3ggY2FzZXMKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y
ZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCmluZGV4IGZkNDJhNTZhYTYyZjI4OWEzZjdkMDhjZTMy
NTA3MzE5ZjI5Zjc0YjEuLmM1NjYyZTZiMDMxYzUzNTFlMDhlNTg4NDRkYjRiOTkwMzM2NzNhNzgg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKKysr
IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcApAQCAtMjI1Niw3ICsy
MjU2LDcgQEAgdm9pZCBSZW5kZXJCbG9jazo6Y29tcHV0ZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMo
KQogICAgIG1fbWF4UHJlZmVycmVkTG9naWNhbFdpZHRoID0gMDsKIAogICAgIGNvbnN0IFJlbmRl
clN0eWxlJiBzdHlsZVRvVXNlID0gc3R5bGUoKTsKLSAgICBhdXRvJiBsZW5ndGhUb1VzZSA9IGhh
c092ZXJyaWRpbmdMb2dpY2FsV2lkdGhMZW5ndGgoKSA/IG92ZXJyaWRpbmdMb2dpY2FsV2lkdGhM
ZW5ndGgoKSA6IHN0eWxlVG9Vc2UubG9naWNhbFdpZHRoKCk7CisgICAgY29uc3QgYXV0byYgbGVu
Z3RoVG9Vc2UgPSBoYXNPdmVycmlkaW5nTG9naWNhbFdpZHRoTGVuZ3RoKCkgPyBvdmVycmlkaW5n
TG9naWNhbFdpZHRoTGVuZ3RoKCkgOiBzdHlsZVRvVXNlLmxvZ2ljYWxXaWR0aCgpOwogICAgIGlm
ICghaXNUYWJsZUNlbGwoKSAmJiBsZW5ndGhUb1VzZS5pc0ZpeGVkKCkgJiYgbGVuZ3RoVG9Vc2Uu
dmFsdWUoKSA+PSAwCiAgICAgICAgICYmICEoaXNEZXByZWNhdGVkRmxleEl0ZW0oKSAmJiAhbGVu
Z3RoVG9Vc2UuaW50VmFsdWUoKSkpCiAgICAgICAgIG1fbWluUHJlZmVycmVkTG9naWNhbFdpZHRo
ID0gbV9tYXhQcmVmZXJyZWRMb2dpY2FsV2lkdGggPSBhZGp1c3RDb250ZW50Qm94TG9naWNhbFdp
ZHRoRm9yQm94U2l6aW5nKGxlbmd0aFRvVXNlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L3JlbmRlcmluZy9SZW5kZXJCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl
ckJveC5jcHAKaW5kZXggNjE1OWQ2YmFhN2QyYWI0YzE0NDQzZjEwZjUwY2E5Njc1OThkZWZiZS4u
NzliN2FiZjg4YzhhYTI3NjMyY2Y5YzBlMzg1ZjY3NmJlYjY2YWVhOCAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv
cmVuZGVyaW5nL1JlbmRlckJveC5jcHAKQEAgLTMxMTMsNyArMzExMyw3IEBAIFJlbmRlckJveDo6
TG9naWNhbEV4dGVudENvbXB1dGVkVmFsdWVzIFJlbmRlckJveDo6Y29tcHV0ZUxvZ2ljYWxIZWln
aHQoTGF5b3V0VW5pCiAgICAgICAgIGJvb2wgc3RyZXRjaGluZyA9IHBhcmVudCgpLT5zdHlsZSgp
LmJveEFsaWduKCkgPT0gQm94QWxpZ25tZW50OjpTdHJldGNoOwogICAgICAgICBib29sIHRyZWF0
QXNSZXBsYWNlZCA9IHNob3VsZENvbXB1dGVTaXplQXNSZXBsYWNlZCgpICYmICghaW5Ib3Jpem9u
dGFsQm94IHx8ICFzdHJldGNoaW5nKTsKICAgICAgICAgYm9vbCBjaGVja01pbk1heEhlaWdodCA9
IGZhbHNlOwotICAgICAgICBhdXRvJiBsb2dpY2FsSGVpZ2h0SW5Vc2UgPSBoYXNPdmVycmlkaW5n
TG9naWNhbEhlaWdodExlbmd0aCgpID8gb3ZlcnJpZGluZ0xvZ2ljYWxIZWlnaHRMZW5ndGgoKSA6
IHN0eWxlKCkubG9naWNhbEhlaWdodCgpOworICAgICAgICBjb25zdCBhdXRvJiBsb2dpY2FsSGVp
Z2h0SW5Vc2UgPSBoYXNPdmVycmlkaW5nTG9naWNhbEhlaWdodExlbmd0aCgpID8gb3ZlcnJpZGlu
Z0xvZ2ljYWxIZWlnaHRMZW5ndGgoKSA6IHN0eWxlKCkubG9naWNhbEhlaWdodCgpOwogCiAgICAg
ICAgIC8vIFRoZSBwYXJlbnQgYm94IGlzIGZsZXhpbmcgdXMsIHNvIGl0IGhhcyBpbmNyZWFzZWQg
b3IgZGVjcmVhc2VkIG91ciBoZWlnaHQuICBXZSBoYXZlIHRvCiAgICAgICAgIC8vIGdyYWIgb3Vy
IGNhY2hlZCBmbGV4aWJsZSBoZWlnaHQuCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>