233378 2021-11-19 11:43:08 -0800 WKContentView should allow -captureTextFromCamera: with a caret selection unless the sender is the callout bar 2021-11-29 13:25:06 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh akeerthi dino graouts hi megan_gardner thorton webkit-bug-importer oldest_to_newest 1816956 0 wenson_hsieh 2021-11-19 11:43:08 -0800 rdar://85478344 1816959 1 444841 wenson_hsieh 2021-11-19 11:51:57 -0800 Created attachment 444841 Patch 1818440 2 ews-feeder 2021-11-29 13:25:04 -0800 Committed r286260 (244623@main): <https://commits.webkit.org/244623@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444841. 444841 2021-11-19 11:51:57 -0800 2021-11-29 13:25:05 -0800 Patch bug-233378-20211119115156.patch text/plain 6282 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU5NDhlMThhZjI5OWM2OTdk NDc3YTJjYjE0MTIzZDk3YjA2OThkMjkuLjBmMzc2ZDZiNjdjYWQ3ODM4ODFkMGFlOTIzN2M5MDI3 ZTZhNWIyNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjEtMTEtMTkgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgV0tDb250ZW50VmlldyBz aG91bGQgYWxsb3cgLWNhcHR1cmVUZXh0RnJvbUNhbWVyYTogd2l0aCBhIGNhcmV0IHNlbGVjdGlv biB1bmxlc3MgdGhlIHNlbmRlciBpcyB0aGUgY2FsbG91dCBiYXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMzM3OAorICAgICAgICByZGFyOi8vODU0 NzgzNDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB bGxvdyBjbGllbnRzIHRvIHF1ZXJ5IHdoZXRoZXIgb3Igbm90IHRoZSAiY2FwdHVyZSB0ZXh0IGZy b20gY2FtZXJhIiBhY3Rpb24gc2hvdWxkIGJlIGVuYWJsZWQgb24gV0tXZWJWaWV3IGluCisgICAg ICAgIGNvbnRleHRzIG91dHNpZGUgb2YgdGhlIGNhbGxvdXQgYmFyLiBDdXJyZW50bHksIFdLQ29u dGVudFZpZXcgcmV0dXJucyBOTyBmb3IgdGhpcyBhY3Rpb24gd2hlbiB0aGVyZSBpcyBhIG5vbi0K KyAgICAgICAgY29sbGFwc2VkIHNlbGVjdGlvbiByYW5nZSwgYnV0IHRoaXMgYmVoYXZpb3IgaXMg b25seSBpbnRlbmRlZCBmb3IgdGhlIGNhbGxvdXQgYmFyOyBpbiB0aGUgY2FzZSB3aGVyZSB0aGUg YWN0aW9uCisgICAgICAgIGlzIChmb3IgaW5zdGFuY2UpIHRyaWdnZXJlZCBieSBhIGJ1dHRvbiBp biB0aGUgd2ViIHZpZXcgY2hyb21lLCBpdCBkb2Vzbid0IG1ha2Ugc2Vuc2UgdG8gb25seSBlbmFi bGUgaXQgd2hlbiB0aGUKKyAgICAgICAgc2VsZWN0aW9uIGlzIGEgY2FyZXQuCisKKyAgICAgICAg QWRkaXRpb25hbGx5LCBhZGp1c3QgdGhlIGNoZWNrIHRvIHVzZSBmb2N1c2VkIGVsZW1lbnQgaW5m b3JtYXRpb24gaW5zdGVhZCBvZiBlZGl0b3Igc3RhdGUsIHN1Y2ggdGhhdCBXZWJLaXQKKyAgICAg ICAgY2xpZW50cyBjYW4gZWFzaWx5IHF1ZXJ5IHRoaXMgQVBJIChgLWNhblBlcmZvcm1BY3Rpb246 d2l0aFNlbmRlcjpgKSBpbnNpZGUgb2YgaW5wdXQgZGVsZWdhdGUgY2FsbGJhY2tzIHdoZW4KKyAg ICAgICAgYmVnaW5uaW5nIGFuIGlucHV0IHNlc3Npb24gdG8ga25vdyB3aGV0aGVyIG9yIG5vdCAi Y2FwdHVyZSB0ZXh0IGZyb20gY2FtZXJhIiBzaG91bGQgYmUgYWxsb3dlZC4KKworICAgICAgICAq IFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtX S0NvbnRlbnRWaWV3IGNhblBlcmZvcm1BY3Rpb25Gb3JXZWJWaWV3OndpdGhTZW5kZXI6XSk6CisK IDIwMjEtMTEtMTggIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgW01vZGVsXSBhZGQgc3VwcG9ydCBmb3IgcGF1c2luZyBhbmQgcmVzdW1pbmcgYW5pbWF0aW9u cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KaW5kZXggYThlOTBlNDI5YTZlY2UxMzY4N2I5ZjkxYmM3MzgyY2E3Y2Iw ZmYzZC4uMWE4MWNjZTQ0NTVlYjFhNzJiMTBlOGYyNDczYzYwYTI5MWVhNThiYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tCkBAIC0zOTM5LDkgKzM5MzksMTQgQEAgLSAoQk9PTCljYW5QZXJmb3JtQWN0aW9uRm9y V2ViVmlldzooU0VMKWFjdGlvbiB3aXRoU2VuZGVyOihpZClzZW5kZXIKICAgICB9CiAKICNpZiBF TkFCTEUoSU1BR0VfQU5BTFlTSVMpCi0gICAgaWYgKGFjdGlvbiA9PSBAc2VsZWN0b3IoY2FwdHVy ZVRleHRGcm9tQ2FtZXJhOikgJiYgKCFlZGl0b3JTdGF0ZS5pc0NvbnRlbnRFZGl0YWJsZSB8fCBl ZGl0b3JTdGF0ZS5zZWxlY3Rpb25Jc1JhbmdlKSkKLSAgICAgICAgcmV0dXJuIE5POwotI2VuZGlm CisgICAgaWYgKGFjdGlvbiA9PSBAc2VsZWN0b3IoY2FwdHVyZVRleHRGcm9tQ2FtZXJhOikpIHsK KyAgICAgICAgaWYgKCFtYXlDb250YWluU2VsZWN0YWJsZVRleHQoX2ZvY3VzZWRFbGVtZW50SW5m b3JtYXRpb24uZWxlbWVudFR5cGUpIHx8IF9mb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uLmlzUmVh ZE9ubHkpCisgICAgICAgICAgICByZXR1cm4gTk87CisKKyAgICAgICAgaWYgKFtzZW5kZXIgaXNL aW5kT2ZDbGFzczpVSU1lbnVDb250cm9sbGVyLmNsYXNzXSAmJiBlZGl0b3JTdGF0ZS5zZWxlY3Rp b25Jc1JhbmdlKQorICAgICAgICAgICAgcmV0dXJuIE5POworICAgIH0KKyNlbmRpZiAvLyBFTkFC TEUoSU1BR0VfQU5BTFlTSVMpCiAKICAgICByZXR1cm4gW3N1cGVyIGNhblBlcmZvcm1BY3Rpb246 YWN0aW9uIHdpdGhTZW5kZXI6c2VuZGVyXTsKIH0KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmMzQxODU1MWM0MjIzMzEyNmNiYTJlNTM0ODJlMjA1 Y2I2NGI0YjQwLi4xNWZiNDAxNzZiN2IzZjE3YWUwMWE4ZmVkNTQwMWQzNjhkYmFmOWZiIDEwMDY0 NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTUgQEAKKzIwMjEtMTEtMTkgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+ CisKKyAgICAgICAgV0tDb250ZW50VmlldyBzaG91bGQgYWxsb3cgLWNhcHR1cmVUZXh0RnJvbUNh bWVyYTogd2l0aCBhIGNhcmV0IHNlbGVjdGlvbiB1bmxlc3MgdGhlIHNlbmRlciBpcyB0aGUgY2Fs bG91dCBiYXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzMzM3OAorICAgICAgICByZGFyOi8vODU0NzgzNDQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGp1c3QgYW4gQVBJIHRlc3QgdG8gZXhlcmNpc2Ug dGhlIGNoYW5nZXMuIFNlZSBXZWJLaXQvQ2hhbmdlTG9nIGZvciBtb3JlIGRldGFpbHMuCisKKyAg ICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dLQ29udGVudFZpZXdFZGl0 aW5nQWN0aW9ucy5tbToKKwogMjAyMS0xMS0xOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2Fy Y2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bYTExeV0gQWRkIGltcGxlbWVudGF0aW9u IG9mIGRvY3VtZW50IGludGVyZmFjZSB3aGVuIGJ1aWxkaW5nIHdpdGggQVRTUEkKZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tDb250ZW50Vmlld0Vk aXRpbmdBY3Rpb25zLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9X S0NvbnRlbnRWaWV3RWRpdGluZ0FjdGlvbnMubW0KaW5kZXggNjk2ODA0YWM5M2IwODVkYmRkYzcw Yzg4OTA4MTg3YmVkYWE2MWFkMy4uMGYzNTgwNzllYjhlNTdkNTFmNTViMDFjODkxMmI5ZmJmYTA5 OWI3ZSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9X S0NvbnRlbnRWaWV3RWRpdGluZ0FjdGlvbnMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXRDb2NvYS9XS0NvbnRlbnRWaWV3RWRpdGluZ0FjdGlvbnMubW0KQEAgLTMwLDYg KzMwLDcgQEAKICNpbXBvcnQgIkluc3RhbmNlTWV0aG9kU3dpenpsZXIuaCIKICNpbXBvcnQgIlBs YXRmb3JtVXRpbGl0aWVzLmgiCiAjaW1wb3J0ICJUZXN0LmgiCisjaW1wb3J0ICJUZXN0SW5wdXRE ZWxlZ2F0ZS5oIgogI2ltcG9ydCAiVGVzdE5hdmlnYXRpb25EZWxlZ2F0ZS5oIgogI2ltcG9ydCAi VGVzdFdLV2ViVmlldy5oIgogI2ltcG9ydCAiVUlLaXRTUEkuaCIKQEAgLTExNSwxNyArMTE2LDI0 IEBAIFRFU1QoV2ViS2l0LCBDYXB0dXJlVGV4dEZyb21DYW1lcmEpCiAgICAgZ0NhblBlcmZvcm1B Y3Rpb25XaXRoU2VuZGVyUmVzdWx0ID0gWUVTOwogICAgIEluc3RhbmNlTWV0aG9kU3dpenpsZXIg c3dpenpsZXIgeyBVSVJlc3BvbmRlci5jbGFzcywgQHNlbGVjdG9yKGNhblBlcmZvcm1BY3Rpb246 d2l0aFNlbmRlcjopLCByZWludGVycHJldF9jYXN0PElNUD4oY2FuUGVyZm9ybUFjdGlvbldpdGhT ZW5kZXIpIH07CiAKKyAgICBhdXRvIGlucHV0RGVsZWdhdGUgPSBhZG9wdE5TKFtbVGVzdElucHV0 RGVsZWdhdGUgYWxsb2NdIGluaXRdKTsKKyAgICBbaW5wdXREZWxlZ2F0ZSBzZXRGb2N1c1N0YXJ0 c0lucHV0U2Vzc2lvblBvbGljeUhhbmRsZXI6W10gKFdLV2ViVmlldyAqLCBpZCA8X1dLRm9jdXNl ZEVsZW1lbnRJbmZvPikgeworICAgICAgICByZXR1cm4gX1dLRm9jdXNTdGFydHNJbnB1dFNlc3Np b25Qb2xpY3lBbGxvdzsKKyAgICB9XTsKKwogICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tU ZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAwLCA2 MDApXSk7CisgICAgW3dlYlZpZXcgX3NldElucHV0RGVsZWdhdGU6aW5wdXREZWxlZ2F0ZS5nZXQo KV07CiAgICAgYXV0byBjb250ZW50VmlldyA9IFt3ZWJWaWV3IHRleHRJbnB1dENvbnRlbnRWaWV3 XTsKIAotICAgIFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkSFRNTFN0cmluZzpAIjxpbnB1dCB2 YWx1ZT0nZm9vJyBhdXRvZm9jdXM+Il07CisgICAgW3dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRI VE1MU3RyaW5nOkAiPGlucHV0IHZhbHVlPSdmb28nIGF1dG9mb2N1cz48aW5wdXQgdmFsdWU9J2Jh cicgcmVhZG9ubHk+Il07CiAgICAgW3dlYlZpZXcgd2FpdEZvck5leHRQcmVzZW50YXRpb25VcGRh dGVdOwogICAgIEVYUEVDVF9FUShbd2ViVmlldyB0YXJnZXRGb3JBY3Rpb246QHNlbGVjdG9yKGNh cHR1cmVUZXh0RnJvbUNhbWVyYTopIHdpdGhTZW5kZXI6bmlsXSwgY29udGVudFZpZXcpOwogICAg IEVYUEVDVF9UUlVFKFt3ZWJWaWV3IGNhblBlcmZvcm1BY3Rpb246QHNlbGVjdG9yKGNhcHR1cmVU ZXh0RnJvbUNhbWVyYTopIHdpdGhTZW5kZXI6bmlsXSk7CiAKICAgICBbd2ViVmlldyBzZWxlY3RB bGw6bmlsXTsKICAgICBbd2ViVmlldyB3YWl0Rm9yTmV4dFByZXNlbnRhdGlvblVwZGF0ZV07Ci0g ICAgRVhQRUNUX0ZBTFNFKFt3ZWJWaWV3IGNhblBlcmZvcm1BY3Rpb246QHNlbGVjdG9yKGNhcHR1 cmVUZXh0RnJvbUNhbWVyYTopIHdpdGhTZW5kZXI6bmlsXSk7CisgICAgRVhQRUNUX1RSVUUoW3dl YlZpZXcgY2FuUGVyZm9ybUFjdGlvbjpAc2VsZWN0b3IoY2FwdHVyZVRleHRGcm9tQ2FtZXJhOikg d2l0aFNlbmRlcjpuaWxdKTsKKyAgICBFWFBFQ1RfRkFMU0UoW3dlYlZpZXcgY2FuUGVyZm9ybUFj dGlvbjpAc2VsZWN0b3IoY2FwdHVyZVRleHRGcm9tQ2FtZXJhOikgd2l0aFNlbmRlcjpVSU1lbnVD b250cm9sbGVyLnNoYXJlZE1lbnVDb250cm9sbGVyXSk7CiAKICAgICBbd2ViVmlldyBjb2xsYXBz ZVRvRW5kXTsKICAgICBbd2ViVmlldyB3YWl0Rm9yTmV4dFByZXNlbnRhdGlvblVwZGF0ZV07CkBA IC0xMzMsNiArMTQxLDExIEBAIFRFU1QoV2ViS2l0LCBDYXB0dXJlVGV4dEZyb21DYW1lcmEpCiAK ICAgICBnQ2FuUGVyZm9ybUFjdGlvbldpdGhTZW5kZXJSZXN1bHQgPSBOTzsKICAgICBFWFBFQ1Rf RkFMU0UoW3dlYlZpZXcgY2FuUGVyZm9ybUFjdGlvbjpAc2VsZWN0b3IoY2FwdHVyZVRleHRGcm9t Q2FtZXJhOikgd2l0aFNlbmRlcjpuaWxdKTsKKworICAgIGdDYW5QZXJmb3JtQWN0aW9uV2l0aFNl bmRlclJlc3VsdCA9IFlFUzsKKyAgICBbd2ViVmlldyBvYmplY3RCeUV2YWx1YXRpbmdKYXZhU2Ny aXB0OkAiZG9jdW1lbnQucXVlcnlTZWxlY3RvcignaW5wdXRbcmVhZG9ubHldJykuZm9jdXMoKSJd OworICAgIFt3ZWJWaWV3IHdhaXRGb3JOZXh0UHJlc2VudGF0aW9uVXBkYXRlXTsKKyAgICBFWFBF Q1RfRkFMU0UoW3dlYlZpZXcgY2FuUGVyZm9ybUFjdGlvbjpAc2VsZWN0b3IoY2FwdHVyZVRleHRG cm9tQ2FtZXJhOikgd2l0aFNlbmRlcjpuaWxdKTsKIH0KIAogI2VuZGlmIC8vIEVOQUJMRShJTUFH RV9BTkFMWVNJUykK