233376 2021-11-19 11:26:16 -0800 [Model] Reduce use of callOnMainRunLoop in ModelElementControllerCocoa 2021-11-19 14:42:21 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts webkit-bug-importer wenson_hsieh oldest_to_newest 1816944 0 graouts 2021-11-19 11:26:16 -0800 [Model] Reduce use of callOnMainRunLoop in ModelElementControllerCocoa 1816945 1 444840 graouts 2021-11-19 11:27:32 -0800 Created attachment 444840 Patch 1817006 2 ews-feeder 2021-11-19 14:41:37 -0800 Committed r286081 (244468@main): <https://commits.webkit.org/244468@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444840. 1817007 3 webkit-bug-importer 2021-11-19 14:42:21 -0800 <rdar://problem/85620293> 444840 2021-11-19 11:27:32 -0800 2021-11-19 14:41:38 -0800 Patch bug-233376-20211119202731.patch text/plain 6367 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI1YjZjNzI3M2U5MTkzZTcz ZWQwODYxZDI3ZTE4YTMyMmY3ZjUxYTMuLjM3YTQxMGJlY2I5NTRmZmZkMTdiNzcxOTFmODdkYzZi YmI2NmE2NzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMTEtMTkgIEFudG9pbmUg UXVpbnQgIDxncmFvdXRzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW01vZGVsXSBSZWR1Y2UgdXNl IG9mIGNhbGxPbk1haW5SdW5Mb29wIGluIE1vZGVsRWxlbWVudENvbnRyb2xsZXJDb2NvYQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzMzc2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugb25seSBuZWVk IHRvIHVzZSBjYWxsT25NYWluUnVuTG9vcCBpbnNpZGUgb2YgYmxvY2tzLgorCisgICAgICAgICog VUlQcm9jZXNzL0NvY29hL01vZGVsRWxlbWVudENvbnRyb2xsZXJDb2NvYS5tbToKKyAgICAgICAg KFdlYktpdDo6TW9kZWxFbGVtZW50Q29udHJvbGxlcjo6Z2V0Q2FtZXJhRm9yTW9kZWxFbGVtZW50 KToKKyAgICAgICAgKFdlYktpdDo6TW9kZWxFbGVtZW50Q29udHJvbGxlcjo6c2V0Q2FtZXJhRm9y TW9kZWxFbGVtZW50KToKKyAgICAgICAgKFdlYktpdDo6TW9kZWxFbGVtZW50Q29udHJvbGxlcjo6 aXNQbGF5aW5nQW5pbWF0aW9uRm9yTW9kZWxFbGVtZW50KToKKyAgICAgICAgKFdlYktpdDo6TW9k ZWxFbGVtZW50Q29udHJvbGxlcjo6c2V0QW5pbWF0aW9uSXNQbGF5aW5nRm9yTW9kZWxFbGVtZW50 KToKKwogMjAyMS0xMS0xOSAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KIAog ICAgICAgICBbTW9kZWxdIGFkZCBzdXBwb3J0IGZvciBzZWVraW5nIGFuaW1hdGlvbnMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL01vZGVsRWxlbWVudENvbnRyb2xs ZXJDb2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL01vZGVsRWxlbWVudENv bnRyb2xsZXJDb2NvYS5tbQppbmRleCBmMzAwYjA3YWU3NGFiZDg0N2Q1ODI4NjMwNzRlYWQ3NTNh ZDViY2ZkLi44NjhjMWU1NzM2MTVjMjAyODJmMjc0N2ZlNzZiMTZjOWU1NTcwMmEzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9Nb2RlbEVsZW1lbnRDb250cm9sbGVy Q29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvTW9kZWxFbGVtZW50 Q29udHJvbGxlckNvY29hLm1tCkBAIC0yNDYsMTkgKzI0NiwxNiBAQCB2b2lkIE1vZGVsRWxlbWVu dENvbnRyb2xsZXI6OmdldENhbWVyYUZvck1vZGVsRWxlbWVudChNb2RlbElkZW50aWZpZXIgbW9k ZWxJZGVudAogewogICAgIGF1dG8qIHByZXZpZXcgPSBwcmV2aWV3Rm9yTW9kZWxJZGVudGlmaWVy KG1vZGVsSWRlbnRpZmllcik7CiAgICAgaWYgKCFwcmV2aWV3SGFzQ2FtZXJhU3VwcG9ydChwcmV2 aWV3KSkgewotICAgICAgICBjYWxsT25NYWluUnVuTG9vcChbd2Vha1RoaXMgPSBXZWFrUHRyIHsg KnRoaXMgfSwgY29tcGxldGlvbkhhbmRsZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSwg ZXJyb3IgPSBXZWJDb3JlOjpSZXNvdXJjZUVycm9yIHsgV2ViQ29yZTo6UmVzb3VyY2VFcnJvcjo6 VHlwZTo6R2VuZXJhbCB9XSAoKSBtdXRhYmxlIHsKLSAgICAgICAgICAgIGlmICh3ZWFrVGhpcykK LSAgICAgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihtYWtlVW5leHBlY3RlZChlcnJvcikp OwotICAgICAgICB9KTsKKyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIobWFrZVVuZXhwZWN0ZWQo V2ViQ29yZTo6UmVzb3VyY2VFcnJvciB7IFdlYkNvcmU6OlJlc291cmNlRXJyb3I6OlR5cGU6Okdl bmVyYWwgfSkpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCiAjaWYgRU5BQkxFKEFSS0lUX0lO TElORV9QUkVWSUVXX0NBTUVSQV9UUkFOU0ZPUk0pCiAgICAgW3ByZXZpZXcgZ2V0Q2FtZXJhVHJh bnNmb3JtOm1ha2VCbG9ja1B0cihbd2Vha1RoaXMgPSBXZWFrUHRyIHsgKnRoaXMgfSwgY29tcGxl dGlvbkhhbmRsZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKV0gKHNpbWRfZmxvYXQzIGNh bWVyYVRyYW5zZm9ybSwgTlNFcnJvciAqZXJyb3IpIG11dGFibGUgewogICAgICAgICBpZiAoZXJy b3IpIHsKLSAgICAgICAgICAgIGNhbGxPbk1haW5SdW5Mb29wKFt3ZWFrVGhpcyA9IFdURk1vdmUo d2Vha1RoaXMpLCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIp LCBlcnJvciA9IFdlYkNvcmU6OlJlc291cmNlRXJyb3IgeyBXZWJDb3JlOjpSZXNvdXJjZUVycm9y OjpUeXBlOjpHZW5lcmFsIH1dICgpIG11dGFibGUgeworICAgICAgICAgICAgY2FsbE9uTWFpblJ1 bkxvb3AoW3dlYWtUaGlzID0gV1RGTW92ZSh3ZWFrVGhpcyksIGNvbXBsZXRpb25IYW5kbGVyID0g V1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcildICgpIG11dGFibGUgewogICAgICAgICAgICAgICAg IGlmICh3ZWFrVGhpcykKLSAgICAgICAgICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIobWFr ZVVuZXhwZWN0ZWQoZXJyb3IpKTsKKyAgICAgICAgICAgICAgICAgICAgY29tcGxldGlvbkhhbmRs ZXIobWFrZVVuZXhwZWN0ZWQoV2ViQ29yZTo6UmVzb3VyY2VFcnJvciB7IFdlYkNvcmU6OlJlc291 cmNlRXJyb3I6OlR5cGU6OkdlbmVyYWwgfSkpOwogICAgICAgICAgICAgfSk7CiAgICAgICAgICAg ICByZXR1cm47CiAgICAgICAgIH0KQEAgLTI2OSwxMSArMjY2LDcgQEAgdm9pZCBNb2RlbEVsZW1l bnRDb250cm9sbGVyOjpnZXRDYW1lcmFGb3JNb2RlbEVsZW1lbnQoTW9kZWxJZGVudGlmaWVyIG1v ZGVsSWRlbnQKICAgICAgICAgfSk7CiAgICAgfSkuZ2V0KCldOwogI2Vsc2UKLSAgICBjYWxsT25N YWluUnVuTG9vcChbd2Vha1RoaXMgPSBXZWFrUHRyIHsgKnRoaXMgfSwgY29tcGxldGlvbkhhbmRs ZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSwgZXJyb3IgPSBXZWJDb3JlOjpSZXNvdXJj ZUVycm9yIHsgV2ViQ29yZTo6UmVzb3VyY2VFcnJvcjo6VHlwZTo6R2VuZXJhbCB9XSAoKSBtdXRh YmxlIHsKLSAgICAgICAgaWYgKHdlYWtUaGlzKQotICAgICAgICAgICAgY29tcGxldGlvbkhhbmRs ZXIobWFrZVVuZXhwZWN0ZWQoZXJyb3IpKTsKLSAgICB9KTsKLSAgICByZXR1cm47CisgICAgQVNT RVJUX05PVF9SRUFDSEVEKCk7CiAjZW5kaWYKIH0KIApAQCAtMjgxLDI1ICsyNzQsMTYgQEAgdm9p ZCBNb2RlbEVsZW1lbnRDb250cm9sbGVyOjpzZXRDYW1lcmFGb3JNb2RlbEVsZW1lbnQoTW9kZWxJ ZGVudGlmaWVyIG1vZGVsSWRlbnQKIHsKICAgICBhdXRvKiBwcmV2aWV3ID0gcHJldmlld0Zvck1v ZGVsSWRlbnRpZmllcihtb2RlbElkZW50aWZpZXIpOwogICAgIGlmICghcHJldmlld0hhc0NhbWVy YVN1cHBvcnQocHJldmlldykpIHsKLSAgICAgICAgY2FsbE9uTWFpblJ1bkxvb3AoW3dlYWtUaGlz ID0gV2Vha1B0ciB7ICp0aGlzIH0sIGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0 aW9uSGFuZGxlcildICgpIG11dGFibGUgewotICAgICAgICAgICAgaWYgKHdlYWtUaGlzKQotICAg ICAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKGZhbHNlKTsKLSAgICAgICAgfSk7CisgICAg ICAgIGNvbXBsZXRpb25IYW5kbGVyKGZhbHNlKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAog I2lmIEVOQUJMRShBUktJVF9JTkxJTkVfUFJFVklFV19DQU1FUkFfVFJBTlNGT1JNKQogICAgIFtw cmV2aWV3IHNldENhbWVyYVRyYW5zZm9ybTpzaW1kX21ha2VfZmxvYXQzKGNhbWVyYS5waXRjaCwg Y2FtZXJhLnlhdywgY2FtZXJhLnNjYWxlKV07Ci0jZW5kaWYKLQotICAgIGNhbGxPbk1haW5SdW5M b29wKFt3ZWFrVGhpcyA9IFdlYWtQdHIgeyAqdGhpcyB9LCBjb21wbGV0aW9uSGFuZGxlciA9IFdU Rk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXSAoKSBtdXRhYmxlIHsKLSAgICAgICAgaWYgKHdlYWtU aGlzKQotI2lmIEVOQUJMRShBUktJVF9JTkxJTkVfUFJFVklFV19DQU1FUkFfVFJBTlNGT1JNKQot ICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIodHJ1ZSk7CisgICAgY29tcGxldGlvbkhhbmRs ZXIodHJ1ZSk7CiAjZWxzZQotICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoZmFsc2UpOwor ICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogI2VuZGlmCi0gICAgfSk7CiB9CiAKIHN0YXRpYyBi b29sIHByZXZpZXdIYXNBbmltYXRpb25TdXBwb3J0KEFTVklubGluZVByZXZpZXcgKnByZXZpZXcp CkBAIC0zMTUsMzIgKzI5OSwyMiBAQCB2b2lkIE1vZGVsRWxlbWVudENvbnRyb2xsZXI6OmlzUGxh eWluZ0FuaW1hdGlvbkZvck1vZGVsRWxlbWVudChNb2RlbElkZW50aWZpZXIgbQogewogICAgIGF1 dG8qIHByZXZpZXcgPSBwcmV2aWV3Rm9yTW9kZWxJZGVudGlmaWVyKG1vZGVsSWRlbnRpZmllcik7 CiAgICAgaWYgKCFwcmV2aWV3SGFzQW5pbWF0aW9uU3VwcG9ydChwcmV2aWV3KSkgewotICAgICAg ICBjYWxsT25NYWluUnVuTG9vcChbd2Vha1RoaXMgPSBXZWFrUHRyIHsgKnRoaXMgfSwgY29tcGxl dGlvbkhhbmRsZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSwgZXJyb3IgPSBXZWJDb3Jl OjpSZXNvdXJjZUVycm9yIHsgV2ViQ29yZTo6UmVzb3VyY2VFcnJvcjo6VHlwZTo6R2VuZXJhbCB9 XSAoKSBtdXRhYmxlIHsKLSAgICAgICAgICAgIGlmICh3ZWFrVGhpcykKLSAgICAgICAgICAgICAg ICBjb21wbGV0aW9uSGFuZGxlcihtYWtlVW5leHBlY3RlZChlcnJvcikpOwotICAgICAgICB9KTsK KyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIobWFrZVVuZXhwZWN0ZWQoV2ViQ29yZTo6UmVzb3Vy Y2VFcnJvciB7IFdlYkNvcmU6OlJlc291cmNlRXJyb3I6OlR5cGU6OkdlbmVyYWwgfSkpOwogICAg ICAgICByZXR1cm47CiAgICAgfQogCiAjaWYgRU5BQkxFKEFSS0lUX0lOTElORV9QUkVWSUVXX0FO SU1BVElPTlNfQ09OVFJPTCkKLSAgICBhdXRvIGlzUGxheWluZyA9IFtwcmV2aWV3IGlzUGxheWlu Z107CisgICAgY29tcGxldGlvbkhhbmRsZXIoW3ByZXZpZXcgaXNQbGF5aW5nXSk7CiAjZWxzZQot ICAgIGF1dG8gaXNQbGF5aW5nID0gZmFsc2U7CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAj ZW5kaWYKLSAgICBjYWxsT25NYWluUnVuTG9vcChbaXNQbGF5aW5nLCB3ZWFrVGhpcyA9IFdlYWtQ dHIgeyAqdGhpcyB9LCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRs ZXIpXSAoKSBtdXRhYmxlIHsKLSAgICAgICAgaWYgKHdlYWtUaGlzKQotICAgICAgICAgICAgY29t cGxldGlvbkhhbmRsZXIoaXNQbGF5aW5nKTsKLSAgICB9KTsKIH0KIAogdm9pZCBNb2RlbEVsZW1l bnRDb250cm9sbGVyOjpzZXRBbmltYXRpb25Jc1BsYXlpbmdGb3JNb2RlbEVsZW1lbnQoTW9kZWxJ ZGVudGlmaWVyIG1vZGVsSWRlbnRpZmllciwgYm9vbCBpc1BsYXlpbmcsIENvbXBsZXRpb25IYW5k bGVyPHZvaWQoYm9vbCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCiB7CiAgICAgYXV0byogcHJldmll dyA9IHByZXZpZXdGb3JNb2RlbElkZW50aWZpZXIobW9kZWxJZGVudGlmaWVyKTsKICAgICBpZiAo IXByZXZpZXdIYXNBbmltYXRpb25TdXBwb3J0KHByZXZpZXcpKSB7Ci0gICAgICAgIGNhbGxPbk1h aW5SdW5Mb29wKFt3ZWFrVGhpcyA9IFdlYWtQdHIgeyAqdGhpcyB9LCBjb21wbGV0aW9uSGFuZGxl ciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXSAoKSBtdXRhYmxlIHsKLSAgICAgICAgICAg IGlmICh3ZWFrVGhpcykKLSAgICAgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihmYWxzZSk7 Ci0gICAgICAgIH0pOworICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihmYWxzZSk7CiAgICAgICAg IHJldHVybjsKICAgICB9CiAKQEAgLTM1MiwxMCArMzI2LDcgQEAgdm9pZCBNb2RlbEVsZW1lbnRD b250cm9sbGVyOjpzZXRBbmltYXRpb25Jc1BsYXlpbmdGb3JNb2RlbEVsZW1lbnQoTW9kZWxJZGVu dGlmaWUKICAgICAgICAgfSk7CiAgICAgfSkuZ2V0KCldOwogI2Vsc2UKLSAgICBjYWxsT25NYWlu UnVuTG9vcChbd2Vha1RoaXMgPSBXZWFrUHRyIHsgKnRoaXMgfSwgY29tcGxldGlvbkhhbmRsZXIg PSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKV0gKCkgbXV0YWJsZSB7Ci0gICAgICAgIGlmICh3 ZWFrVGhpcykKLSAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKGZhbHNlKTsKLSAgICB9KTsK KyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICNlbmRpZgogfQogCg==