233299 2021-11-17 17:59:34 -0800 [JSC] TypedArray GetArrayLength should not use Reuse 2021-11-24 14:36:56 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam mcatanzaro msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1816247 0 ysuzuki 2021-11-17 17:59:34 -0800 [JSC] TypedArray GetArrayLength should not use Reuse 1816249 1 444621 ysuzuki 2021-11-17 18:02:21 -0800 Created attachment 444621 Patch 1816250 2 ysuzuki 2021-11-17 18:03:25 -0800 rdar://85502079 1816251 3 444621 rmorisset 2021-11-17 18:04:11 -0800 Comment on attachment 444621 Patch r=me 1816301 4 ysuzuki 2021-11-17 21:01:57 -0800 Committed r285978 (244375@main): <https://commits.webkit.org/244375@main> 1816826 5 mcatanzaro 2021-11-19 06:00:07 -0800 This new test is failing on cloop on every architecture. Example failure: Running stress/get-array-length-reuse.js.default stress/get-array-length-reuse.js.default: Crashing because current footprint: 632360960 exceeds limit: 629145600 stress/get-array-length-reuse.js.default: test_script_9640: line 2: 3125653 Aborted (core dumped) ( "$@" /var/lib/jenkins/workspace/WebKit-JSC/label/x86_64/WebKitBuild/Release/bin/jsc --useFTLJIT\=false --useFunctionDotArguments\=true --validateExceptionChecks\=true --useDollarVM\=true --maxPerThreadStackUsage\=1572864 --useFTLJIT\=true get-array-length-reuse.js ) stress/get-array-length-reuse.js.default: ERROR: Unexpected exit code: 134 FAIL: stress/get-array-length-reuse.js.default Seems it runs successfully, then crashes at the very end because the artificial memory limit was exceeded? The tests are failing on the JSC EWS with a different error: Exception: RangeError: length too large 1817278 6 mcatanzaro 2021-11-22 06:11:13 -0800 Reopening because the test is broken in two different ways. Yusuke, any ideas? 1817456 7 mcatanzaro 2021-11-23 06:33:45 -0800 I'm going to start by skipping the entire test: //@ skip temporarily, until Yusuke gets a chance to look at this. I considered: //@ skip if $memoryLimited but I'm not sure that the EWS failure is actually related to memory, or that the EWS is a memory-limited environment. 1817476 8 445035 mcatanzaro 2021-11-23 08:07:45 -0800 Created attachment 445035 Patch 1817553 9 445035 ysuzuki 2021-11-23 20:15:34 -0800 Comment on attachment 445035 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445035&action=review > JSTests/stress/get-array-length-reuse.js:2 > +//@ skip > +// FIXME: Unskip: https://bugs.webkit.org/show_bug.cgi?id=233299#c5 We should make it `//@ skip if $memoryLimited`. 1817628 10 445094 mcatanzaro 2021-11-24 05:59:37 -0800 Created attachment 445094 Patch 1817706 11 ews-feeder 2021-11-24 14:36:54 -0800 Committed r286153 (244537@main): <https://commits.webkit.org/244537@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445094. 444621 2021-11-17 18:02:21 -0800 2021-11-24 06:00:08 -0800 Patch bug-233299-20211117180220.patch text/plain 2757 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1OTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ZGZkZTAzMjgzNDNkYTY4YjdiNDZhZjdhODM4OGY2YTRmMTQ5ODM4Li5lYWMzNTk1ZjYxYjk2ODk0 MTY5N2I3M2UwOTgxNDJiYWQxN2NhZGZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMS0xMS0xNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFR5cGVkQXJyYXkgR2V0QXJyYXlMZW5ndGggc2hvdWxkIG5vdCB1 c2UgUmV1c2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzMzI5OQorICAgICAgICByZGFyOi8vODU1MDIwNzkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBzaG91bGQgbm90IHBlcmZvcm0gT1NSIGV4aXQg YWZ0ZXIgYXNzaWduaW5nIGEgdmFsdWUgdG8gYSByZXVzZWQgcmVnaXN0ZXIsIG90aGVyd2lzZSwK KyAgICAgICAgT1NSIGV4aXQgY2Fubm90IHJlY292ZXIgdGhlIHByb3BlciB2YWx1ZS4gTm93IFR5 cGVkQXJyYXkgR2V0QXJyYXlMZW5ndGggY2FuIHBlcmZvcm0KKyAgICAgICAgT1NSIGV4aXQgYWZ0 ZXIgbG9hZGluZyBhIGxlbmd0aCwgc28gd2Ugc2hvdWxkIG5vdCB1c2UgcmV1c2VkIHJlZ2lzdGVy IGZvciBsZW5ndGguCisKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgorCiAy MDIxLTExLTE3ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAg W0pTQ10gUmV2aXNlIEpTT04ucGFyc2UgYXRvbWl6ZSBwb2xpY3kKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAKaW5kZXggYjk0OWQ0MDI4OTMwY2I5 ZGQ3ODZlMWZjMGUyOWQ5OWYxM2QyYWI2NS4uNTI1YWUxN2M3Y2ZiYjZjYWUwYWI0ZDM5OTkyNDM4 NjIyZjEzODVkNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj dWxhdGl2ZUpJVC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxh dGl2ZUpJVC5jcHAKQEAgLTg2NjEsNyArODY2MSw3IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNv bXBpbGVHZXRBcnJheUxlbmd0aChOb2RlKiBub2RlKQogICAgIGRlZmF1bHQ6IHsKICAgICAgICAg QVNTRVJUKG5vZGUtPmFycmF5TW9kZSgpLmlzU29tZVR5cGVkQXJyYXlWaWV3KCkpOwogICAgICAg ICBTcGVjdWxhdGVDZWxsT3BlcmFuZCBiYXNlKHRoaXMsIG5vZGUtPmNoaWxkMSgpKTsKLSAgICAg ICAgR1BSVGVtcG9yYXJ5IHJlc3VsdCh0aGlzLCBSZXVzZSwgYmFzZSk7CisgICAgICAgIEdQUlRl bXBvcmFyeSByZXN1bHQodGhpcyk7CiAgICAgICAgIEdQUlJlZyBiYXNlR1BSID0gYmFzZS5ncHIo KTsKICAgICAgICAgR1BSUmVnIHJlc3VsdEdQUiA9IHJlc3VsdC5ncHIoKTsKICNpZiBVU0UoTEFS R0VfVFlQRURfQVJSQVlTKQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3Rz L0NoYW5nZUxvZwppbmRleCAyN2YwZDIwZDA4ZjRjYzI3OTZkZTAxOTMxNDI0M2M2NGU3NGRkYmJh Li5kZGVjMDhjMzg2MWE0OGFlOGUzM2RkYzA1MmEyNDI3NGVjMmMwNWRjIDEwMDY0NAotLS0gYS9K U1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDIxLTExLTE3ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAg ICAgW0pTQ10gVHlwZWRBcnJheSBHZXRBcnJheUxlbmd0aCBzaG91bGQgbm90IHVzZSBSZXVzZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzMjk5Cisg ICAgICAgIHJkYXI6Ly84NTUwMjA3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogc3RyZXNzL2dldC1hcnJheS1sZW5ndGgtcmV1c2UuanM6IEFkZGVk LgorICAgICAgICAoZm9vKToKKwogMjAyMS0xMS0xNSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lA YXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIFVzZSBvcGVyYXRpb24gcGF0aCB3aGVuIFB1dEJ5 VmFsIGNoaWxkMSBpcyBub3Qgc3BlY3VsYXRlZCBhcyBhIENlbGwKZGlmZiAtLWdpdCBhL0pTVGVz dHMvc3RyZXNzL2dldC1hcnJheS1sZW5ndGgtcmV1c2UuanMgYi9KU1Rlc3RzL3N0cmVzcy9nZXQt YXJyYXktbGVuZ3RoLXJldXNlLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjQ3YjQzZTdlN2YxZjNiNGMzMzMxMDdl MmFlY2IzZjdjMGRkNDJiNjYKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9nZXQt YXJyYXktbGVuZ3RoLXJldXNlLmpzCkBAIC0wLDAgKzEsMTAgQEAKK2Z1bmN0aW9uIGZvbyhhKSB7 CisgIGFyZ3VtZW50czsKKyAgYS5sZW5ndGg7Cit9CisKK2xldCB4ID0gbmV3IFVpbnQ4QXJyYXko KTsKK2ZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDA7ICsraSkKKyAgZm9vKHgpOworCitmb28obmV3 IFVpbnQ4QXJyYXkoMioqMzEpKTsK 445035 2021-11-23 08:07:45 -0800 2021-11-24 05:59:34 -0800 Patch bug-233299-20211123100744.patch text/plain 1079 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MTM1CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGU5MjZlNDRmYTgxNGMxMzFmNjNmOWUwOTgwNzA1 MmExNjA2NTRhYzAuLmEzZGI4MzI0OTRkNzRmNDY0MDI0NjZjNDU2ZjM5MDg0YmI4NmFiMzcgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMjEtMTEtMjMgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bn bm9tZS5vcmc+CisKKyAgICAgICAgVGVtcG9yYXJpbHkgc2tpcCBuZXcgc3RyZXNzIHRlc3QgZ2V0 LWFycmF5LWxlbmd0aC1yZXVzZS5qcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjMzMjk5CisgICAgICAgIHJkYXI6Ly84NTUwMjA3OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL2dldC1hcnJh eS1sZW5ndGgtcmV1c2UuanM6CisKIDIwMjEtMTEtMTkgIEFzdW11IFRha2lrYXdhICA8YXN1bXVA aWdhbGlhLmNvbT4KIAogICAgICAgICBGaXggV2ViQXNzZW1ibHkgbWVtb3J5LmZpbGwgb3V0IG9m IGJvdW5kcyBlcnJvciBtZXNzYWdlCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9nZXQtYXJy YXktbGVuZ3RoLXJldXNlLmpzIGIvSlNUZXN0cy9zdHJlc3MvZ2V0LWFycmF5LWxlbmd0aC1yZXVz ZS5qcwppbmRleCAxMDY0ZTdhNWYxYzU4YWYxN2NjNjJiZDI5MGM5MzMyYjc1OWRiMDU5Li43NTg4 NWQ5NGIyMzRhOGY5MDVlZWNlNzk3MjlkNTQwZmI1NzQ4OGI2IDEwMDY0NAotLS0gYS9KU1Rlc3Rz L3N0cmVzcy9nZXQtYXJyYXktbGVuZ3RoLXJldXNlLmpzCisrKyBiL0pTVGVzdHMvc3RyZXNzL2dl dC1hcnJheS1sZW5ndGgtcmV1c2UuanMKQEAgLTEsMyArMSw2IEBACisvL0Agc2tpcAorLy8gRklY TUU6IFVuc2tpcDogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMzI5 OSNjNQorCiBmdW5jdGlvbiBmb28oYSkgewogICBhcmd1bWVudHM7CiAgIGEubGVuZ3RoOwo= 445094 2021-11-24 05:59:37 -0800 2021-11-24 14:36:55 -0800 Patch bug-233299-20211124075936.patch text/plain 1033 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MTQ2CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGU5MjZlNDRmYTgxNGMxMzFmNjNmOWUwOTgwNzA1 MmExNjA2NTRhYzAuLjk4NGFmNmYxYzU0YTQwY2QwMjFmODE2NGNmMDdlYTlmODA0MDQ3NDkgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMjEtMTEtMjQgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bn bm9tZS5vcmc+CisKKyAgICAgICAgU2tpcCBuZXcgc3RyZXNzIHRlc3QgZ2V0LWFycmF5LWxlbmd0 aC1yZXVzZS5qcyBpZiBtZW1vcnktbGltaXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzMjk5CisgICAgICAgIHJkYXI6Ly84NTUwMjA3OQorCisg ICAgICAgIFJldmlld2VkIGJ5IFl1c3VrZSBTdXp1a2kuCisKKyAgICAgICAgKiBzdHJlc3MvZ2V0 LWFycmF5LWxlbmd0aC1yZXVzZS5qczoKKwogMjAyMS0xMS0xOSAgQXN1bXUgVGFraWthd2EgIDxh c3VtdUBpZ2FsaWEuY29tPgogCiAgICAgICAgIEZpeCBXZWJBc3NlbWJseSBtZW1vcnkuZmlsbCBv dXQgb2YgYm91bmRzIGVycm9yIG1lc3NhZ2UKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL2dl dC1hcnJheS1sZW5ndGgtcmV1c2UuanMgYi9KU1Rlc3RzL3N0cmVzcy9nZXQtYXJyYXktbGVuZ3Ro LXJldXNlLmpzCmluZGV4IDEwNjRlN2E1ZjFjNThhZjE3Y2M2MmJkMjkwYzkzMzJiNzU5ZGIwNTku LjEyNjc5NGEwZDI3ZmQwZDA4MDE4MGZkNTRlMjY3MTU5ZDJjM2E5M2QgMTAwNjQ0Ci0tLSBhL0pT VGVzdHMvc3RyZXNzL2dldC1hcnJheS1sZW5ndGgtcmV1c2UuanMKKysrIGIvSlNUZXN0cy9zdHJl c3MvZ2V0LWFycmF5LWxlbmd0aC1yZXVzZS5qcwpAQCAtMSwzICsxLDUgQEAKKy8vQCBza2lwIGlm ICRtZW1vcnlMaW1pdGVkCisKIGZ1bmN0aW9uIGZvbyhhKSB7CiAgIGFyZ3VtZW50czsKICAgYS5s ZW5ndGg7Cg==