233297 2021-11-17 17:43:02 -0800 [iOS] Allow WKWebView clients to override undoManager 2021-12-06 11:00:34 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 matthew_gilligan webkit-unassigned kkinnunen matthew_gilligan webkit-bug-importer wenson_hsieh oldest_to_newest 1816241 0 matthew_gilligan 2021-11-17 17:43:02 -0800 <rdar://problem/85526549> 1816263 1 444625 matthew_gilligan 2021-11-17 18:35:34 -0800 Created attachment 444625 Patch 1820670 2 ews-feeder 2021-12-06 11:00:33 -0800 Committed r286552 (244882@main): <https://commits.webkit.org/244882@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444625. 444625 2021-11-17 18:35:34 -0800 2021-12-06 11:00:34 -0800 Patch bug-233297-20211117183533.patch text/plain 6240 matthew_gilligan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1OTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZjNTA3MDhmYTdkMzdkNmNj ZGFiYmJkNTZkNzFjMjNiMzM5M2I4MWEuLmU2NjJjMDYxM2I5MTcyNDE5ZjQ4MjM0MzEzNjUxZWNi YzllZDgyNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMjEtMTEtMTcgIE1hdHQgR2ls bGlnYW4gIDxtYXR0aGV3X2dpbGxpZ2FuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBbGxv dyBXS1dlYlZpZXcgY2xpZW50cyB0byBvdmVycmlkZSB1bmRvTWFuYWdlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzMjk3CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS84NTUyNjU0OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBNb3ZlIFdLQ29udGVudFZpZXcncyB1bmRvTWFuYWdlciB1cCB0aGUgcmVz cG9uZGVyIGNoYWluIHRvIFdLV2ViVmlldyBzbyB3ZWIgdmlldworICAgICAgICBzdWJjbGFzc2Vz IGNhbiBjdXN0b21pemUgdGhlIHVuZG8gbWFuYWdlciB1c2VkIHdoZW4gV0tDb250ZW50VmlldyBp cyBmaXJzdCByZXNwb25kZXIuCisKKyAgICAgICAgVGVzdDogS2V5Ym9hcmRJbnB1dFRlc3RzLk92 ZXJyaWRlVW5kb01hbmFnZXIKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvaW9zL1dLV2ViVmll d0lPUy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IHVuZG9NYW5hZ2VyXSk6CisgICAgICAgIFJl dHVybiB0aGUgdW5kbyBtYW5hZ2VyIHByb3ZpZGVkIGJ5IF9jb250ZW50VmlldyB3aGVuIGl0IGlz IGN1cnJlbnQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcuaDoKKyAg ICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW06CisgICAgICAgICgtW1dLQ29u dGVudFZpZXcgdW5kb01hbmFnZXJGb3JXZWJWaWV3XSk6CisgICAgICAgIFByb3ZpZGUgdGhlIHZp ZXcncyB1bmRvIG1hbmFnZXIgdmlhIHRoaXMgcHJvcGVydHkgc28gdGhhdCAtdW5kb01hbmFnZXIg d2lsbCBsb29rIHVwIHRoZQorICAgICAgICByZXNwb25kZXIgY2hhaW4gdG8gV0tXZWJWaWV3Lgor CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgdW5kb01hbmFnZXJdKTogRGVsZXRlZC4KKwogMjAy MS0xMS0xNyAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIE1v ZGVsRG9jdW1lbnQgZm9yIGRpcmVjdGx5IHNob3dpbmcgY29udGVudCB0aGF0IGNhbiBiZSBoYW5k bGVkIGJ5IDxtb2RlbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9p b3MvV0tXZWJWaWV3SU9TLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2lvcy9XS1dl YlZpZXdJT1MubW0KaW5kZXggNWEwYWU2MzBmMTFmZjEwYmQ3MTNhYWFhMTEwZWM5MGY4MmRiNTZl MS4uM2VlZDA2ZDcyZmQ3MTIyYTRkYTE3NmVmY2I4ZmE1MmM2MzFjYzM5NSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2lvcy9XS1dlYlZpZXdJT1MubW0KKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2lvcy9XS1dlYlZpZXdJT1MubW0KQEAgLTMxOCw2ICsz MTgsMTQgQEAgQUxMT1dfREVQUkVDQVRFRF9ERUNMQVJBVElPTlNfRU5ECiAgICAgcmV0dXJuIFtz dXBlciByZXNpZ25GaXJzdFJlc3BvbmRlcl07CiB9CiAKKy0gKE5TVW5kb01hbmFnZXIgKil1bmRv TWFuYWdlcgoreworICAgIGlmIChzZWxmLl9jdXJyZW50Q29udGVudFZpZXcgPT0gX2NvbnRlbnRW aWV3KQorICAgICAgICByZXR1cm4gW19jb250ZW50VmlldyB1bmRvTWFuYWdlckZvcldlYlZpZXdd OworCisgICAgcmV0dXJuIFtzdXBlciB1bmRvTWFuYWdlcl07Cit9CisKIEZPUl9FQUNIX1dLQ09O VEVOVFZJRVdfQUNUSU9OKEZPUldBUkRfQUNUSU9OX1RPX1dLQ09OVEVOVFZJRVcpCiAKIC0gKEJP T0wpY2FuUGVyZm9ybUFjdGlvbjooU0VMKWFjdGlvbiB3aXRoU2VuZGVyOihpZClzZW5kZXIKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3LmggYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5oCmluZGV4IGE3MmJlMDQ0 MWMyNWE3MTJjYTU5NmU4ODJjZTAzODhiZGNjMjAxNjIuLmUyNDgzZGU4YTg4OTFiZjUwZjU5ZDQ5 NjM0YjBjMWYxMmEwOTNmMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXcuaApAQCAtNzEsNiArNzEsNyBAQCBlbnVtIGNsYXNzIFZpZXdTdGFiaWxpdHlGbGFn IDogdWludDhfdDsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSwgZ2V0dGVyPWlzUmVz aWduaW5nRmlyc3RSZXNwb25kZXIpIEJPT0wgcmVzaWduaW5nRmlyc3RSZXNwb25kZXI7CiBAcHJv cGVydHkgKG5vbmF0b21pYykgQk9PTCBzaXplQ2hhbmdlZFNpbmNlTGFzdFZpc2libGVDb250ZW50 UmVjdFVwZGF0ZTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgVUlJbnRlcmZhY2VP cmllbnRhdGlvbiBpbnRlcmZhY2VPcmllbnRhdGlvbjsKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCBy ZWFkb25seSkgTlNVbmRvTWFuYWdlciAqdW5kb01hbmFnZXJGb3JXZWJWaWV3OwogCiAtIChpbnN0 YW5jZXR5cGUpaW5pdFdpdGhGcmFtZTooQ0dSZWN0KWZyYW1lIHByb2Nlc3NQb29sOihOYWtlZFJl ZjxXZWJLaXQ6OldlYlByb2Nlc3NQb29sPilwcm9jZXNzUG9vbCBjb25maWd1cmF0aW9uOihSZWY8 QVBJOjpQYWdlQ29uZmlndXJhdGlvbj4mJiljb25maWd1cmF0aW9uIHdlYlZpZXc6KFdLV2ViVmll dyAqKXdlYlZpZXc7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9X S0NvbnRlbnRWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXcubW0KaW5kZXggZDExZjcxZmIxMWQyMWZhYTVmNzE5M2JkZjUwMWU4ZmFlMGRkMGEyMC4uYTJj ODU5Y2MyODZiODkxYmE0Zjk2ODAyMTlmZWRmNmRkNTM1M2NiZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0KKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0KQEAgLTU2Miw3ICs1NjIsNyBAQCBzdGF0 aWMgV2ViQ29yZTo6RmxvYXRCb3hFeHRlbnQgZmxvYXRCb3hFeHRlbnQoVUlFZGdlSW5zZXRzIGlu c2V0cykKICAgICBbc2VsZiBfZGlkRW5kU2Nyb2xsaW5nT3Jab29taW5nXTsKIH0KIAotLSAoTlNV bmRvTWFuYWdlciAqKXVuZG9NYW5hZ2VyCistIChOU1VuZG9NYW5hZ2VyICopdW5kb01hbmFnZXJG b3JXZWJWaWV3CiB7CiAgICAgaWYgKHNlbGYuZm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbi5zaG91 bGRTeW50aGVzaXplS2V5RXZlbnRzRm9yRWRpdGluZyAmJiBzZWxmLmhhc0hpZGRlbkNvbnRlbnRF ZGl0YWJsZSkgewogICAgICAgICBpZiAoIV9xdWlya3lVbmRvTWFuYWdlcikKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4M2YxZjY5ZTM1ZDhkNWYy ODdjZTE1Y2QzMDQ3NDA3ODRlYTUwZTE1Li5kNjQ2NGE3MDgyNGFiODQ5NGI2OTM5MmZhMDFjNzEw MGRlNTYxOTE1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMTEtMTcgIE1hdHQgR2lsbGlnYW4gIDxtYXR0aGV3 X2dpbGxpZ2FuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBbGxvdyBXS1dlYlZpZXcgY2xp ZW50cyB0byBvdmVycmlkZSB1bmRvTWFuYWdlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzMjk3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NTUy NjU0OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFRlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0tleWJvYXJkSW5wdXRUZXN0c0lPUy5tbToKKyAgICAg ICAgKC1bQ3VzdG9tVW5kb01hbmFnZXJXZWJWaWV3IHVuZG9NYW5hZ2VyXSk6CisgICAgICAgIChU ZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAyMS0xMS0xNyAgWml4aW5nIExpdSAgPGxpdXNodXl1 MDExQGdtYWlsLmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVdIFN1cHBvcnQgZ2V0dGluZyBhbmQg c2V0dGluZyBIVFRQIGhlYWRlcnMgaW4gY3VzdG9tIFVSSSBzY2hlbWUgaGFuZGxlcnMKZGlmZiAt LWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0tleWJvYXJkSW5wdXRUZXN0c0lP Uy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0tleWJvYXJkSW5wdXRUZXN0c0lP Uy5tbQppbmRleCA0M2JjYzdmZDllNjE1YzBjZTc2ZjBmMzMzNzAxNGI3MjVkYWYzZTljLi4xZjUz NjZkMDgwMWVmZTg4YWE0ZDA2MjUzOTFkMGM4M2I3OWVhZGNkIDEwMDY0NAotLS0gYS9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9LZXlib2FyZElucHV0VGVzdHNJT1MubW0KKysrIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvS2V5Ym9hcmRJbnB1dFRlc3RzSU9TLm1tCkBAIC00 Miw2ICs0Miw3IEBACiAjaW1wb3J0IDxjbWF0aD4KIAogQGludGVyZmFjZSBXS0NvbnRlbnRWaWV3 ICgpCitAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIE5TVW5kb01hbmFnZXIgKnVuZG9N YW5hZ2VyRm9yV2ViVmlldzsKIC0gKEJPT0wpX3Nob3VsZFNpbXVsYXRlS2V5Ym9hcmRJbnB1dE9u VGV4dEluc2VydGlvbjsKIEBlbmQKIApAQCAtMTg3LDYgKzE4OCwxOSBAQCBzdGF0aWMgQ0dSZWN0 IHJvdW5kZWQoQ0dSZWN0IHJlY3QpCiAKIEBlbmQKIAorQGludGVyZmFjZSBDdXN0b21VbmRvTWFu YWdlcldlYlZpZXcgOiBUZXN0V0tXZWJWaWV3CitAcHJvcGVydHkgKG5vbmF0b21pYywgc3Ryb25n KSBOU1VuZG9NYW5hZ2VyICpjdXN0b21VbmRvTWFuYWdlcjsKK0BlbmQKKworQGltcGxlbWVudGF0 aW9uIEN1c3RvbVVuZG9NYW5hZ2VyV2ViVmlldworCistIChOU1VuZG9NYW5hZ2VyICopdW5kb01h bmFnZXIKK3sKKyAgICByZXR1cm4gX2N1c3RvbVVuZG9NYW5hZ2VyID86IHN1cGVyLnVuZG9NYW5h Z2VyOworfQorCitAZW5kCisKIHN0YXRpYyBSZXRhaW5QdHI8VGVzdFdLV2ViVmlldz4gd2ViVmll d1dpdGhBdXRvZm9jdXNlZElucHV0KGNvbnN0IFJldGFpblB0cjxUZXN0SW5wdXREZWxlZ2F0ZT4m IGlucHV0RGVsZWdhdGUpCiB7CiAgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbW1Rlc3RXS1dl YlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0TWFrZSgwLCAwLCAzMjAsIDUwMCldKTsK QEAgLTgwMSw2ICs4MTUsMTcgQEAgVEVTVChLZXlib2FyZElucHV0VGVzdHMsIEluc2VydERpY3Rh dGlvbkFsdGVybmF0aXZlc1NpbXVsYXRpbmdLZXlib2FyZElucHV0KQogICAgIEVYUEVDVF9OU19F UVVBTCgoQFtAImtleWRvd24iLCBAImJlZm9yZWlucHV0IiwgQCJpbnB1dCIsIEAia2V5dXAiLCBA ImNoYW5nZSJdKSwgW3dlYlZpZXcgb2JqZWN0QnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImZpcmVk RXZlbnRzIl0pOwogfQogCitURVNUKEtleWJvYXJkSW5wdXRUZXN0cywgT3ZlcnJpZGVVbmRvTWFu YWdlcikKK3sKKyAgICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtbQ3VzdG9tVW5kb01hbmFnZXJX ZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdE1ha2UoMCwgMCwgMzIwLCA1MDApXSk7 CisgICAgYXV0byBjb250ZW50VmlldyA9IFt3ZWJWaWV3IHdrQ29udGVudFZpZXddOworICAgIEVY UEVDVF9FUShjb250ZW50Vmlldy51bmRvTWFuYWdlciwgY29udGVudFZpZXcudW5kb01hbmFnZXJG b3JXZWJWaWV3KTsKKworICAgIGF1dG8gdW5kb01hbmFnZXIgPSBhZG9wdE5TKFtbTlNVbmRvTWFu YWdlciBhbGxvY10gaW5pdF0pOworICAgIFt3ZWJWaWV3IHNldEN1c3RvbVVuZG9NYW5hZ2VyOnVu ZG9NYW5hZ2VyLmdldCgpXTsKKyAgICBFWFBFQ1RfRVEoY29udGVudFZpZXcudW5kb01hbmFnZXIs IHVuZG9NYW5hZ2VyKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSQogCiAjZW5k aWYgLy8gUExBVEZPUk0oSU9TX0ZBTUlMWSkK