233272 2021-11-17 12:30:32 -0800 Momentum animator: Short scrolls are too far, medium scrolls aren't far enough 2021-11-17 16:24:39 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton darin simon.fraser oldest_to_newest 1816058 0 thorton 2021-11-17 12:30:32 -0800 Momentum animator: Short scrolls are too far, medium scrolls aren't far enough 1816060 1 444550 thorton 2021-11-17 12:32:18 -0800 Created attachment 444550 Patch 1816124 2 444577 thorton 2021-11-17 14:23:45 -0800 Created attachment 444577 patch 1816126 3 thorton 2021-11-17 14:24:11 -0800 <rdar://problem/85472653> 1816167 4 ews-feeder 2021-11-17 15:55:54 -0800 Committed r285964 (244364@main): <https://commits.webkit.org/244364@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444577. 1816173 5 444577 darin 2021-11-17 16:01:38 -0800 Comment on attachment 444577 patch View in context: https://bugs.webkit.org/attachment.cgi?id=444577&action=review > Source/WebCore/platform/mac/ScrollingEffectsController.mm:139 > + float value = fabs(originalValue); > + float powerLow = 6.7 * pow(value, -.166); > + float powerHigh = 36.3 * pow(value, -.392); > + const float transitionVelocity = 2000; This currently mixes float and double, as a cleanup (not at ll urgent) we should use std::abs instead of fabs, which will keep it float instead of converting float to double and then back to float. And 6.7f, std::pow, -.166f, so that is done as float instead of as double then converted to float. Then same for powerHigh. Also nice to use constexpr instead of const. > Source/WebCore/platform/mac/ScrollingEffectsController.mm:146 > + return copysign(value * multiplier, originalValue); This converts to double and then back to float. Should use std::copysign. 1816191 6 thorton 2021-11-17 16:24:39 -0800 ... all good points 444550 2021-11-17 12:32:18 -0800 2021-11-17 14:23:45 -0800 Patch bug-233272-20211117123218.patch text/plain 3254 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1OTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWExYTdiNWJmOTdjOGQ3 MDlkMDJmODgzOTllMzQwZDMxZDU4MDIwMS4uYzY3NjVjYWM0ZjllODRjN2I5MGU0ZjAxYjY1M2U4 NTE0ZGE4NTcwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTExLTE3ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIE1vbWVudHVtIGFu aW1hdG9yOiBTaG9ydCBzY3JvbGxzIGFyZSB0b28gZmFyLCBtZWRpdW0gc2Nyb2xscyBhcmVuJ3Qg ZmFyIGVub3VnaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMzMjcyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NTQ3MjY1Mz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9TY3Jv bGxpbmdFZmZlY3RzQ29udHJvbGxlci5tbToKKyAgICAgICAgKFdlYkNvcmU6OmFkanVzdGVkVmVs b2NpdHkpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nRWZmZWN0c0NvbnRyb2xsZXI6Omhh bmRsZVdoZWVsRXZlbnQpOgorICAgICAgICBBdHRlbXB0IHRvIGFwcGx5IGEgZW1waXJpY2FsbHkt ZGVyaXZlZCBjdXJ2ZSB0byB0aGUgaW5pdGlhbCB2ZWxvY2l0eQorICAgICAgICB0byBmaXQgdGhl IGRpc3RhbmNlIG9mIGEgbm9ybWFsIG1vbWVudHVtIHNjcm9sbC4KKwogMjAyMS0xMS0xNyAgVGlt IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBNb21lbnR1bSBh bmltYXRvciBzb21ldGltZXMgc3RhcnRzIHRoZSBhbmltYXRpb24gYXQgYSB2ZXJ5IGhpZ2ggdmVs b2NpdHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxpbmdF ZmZlY3RzQ29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxp bmdFZmZlY3RzQ29udHJvbGxlci5tbQppbmRleCBjYWMzYzZjNGNjNDUyZjJiZTNkNmFkZDNlYTdm MGM5N2Q1NzI2MTM4Li5mNTg3YzVjNzg3YjE1NDc5NjBiOTdkMDJiZmFkMTY2MGQ3ZjE5NDdiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsaW5nRWZmZWN0c0Nv bnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbGluZ0Vm ZmVjdHNDb250cm9sbGVyLm1tCkBAIC0xMjcsNiArMTI3LDI4IEBAIHN0YXRpYyBjb25zdCBjaGFy KiBwaGFzZVRvU3RyaW5nKFBsYXRmb3JtV2hlZWxFdmVudFBoYXNlIHBoYXNlKQogfQogI2VuZGlm CiAKK3N0YXRpYyBGbG9hdFNpemUgYWRqdXN0ZWRWZWxvY2l0eShGbG9hdFNpemUgdmVsb2NpdHkp Cit7CisgICAgYXV0byBhcHBseUN1cnZlID0gXihmbG9hdCBvcmlnaW5hbFZhbHVlKSB7CisgICAg ICAgIGlmICghb3JpZ2luYWxWYWx1ZSkKKyAgICAgICAgICAgIHJldHVybiBvcmlnaW5hbFZhbHVl OworCisgICAgICAgIGZsb2F0IHZhbHVlID0gZmFicyhvcmlnaW5hbFZhbHVlKTsKKyAgICAgICAg ZmxvYXQgcG93ZXJMb3cgPSA2LjcgKiBwb3codmFsdWUsIC0uMTY2KTsKKyAgICAgICAgZmxvYXQg cG93ZXJIaWdoID0gMzYuMyAqIHBvdyh2YWx1ZSwgLS4zOTIpOworICAgICAgICBjb25zdCBmbG9h dCB0cmFuc2l0aW9uVmVsb2NpdHkgPSAyMDAwOworCisgICAgICAgIGF1dG8gaW50ZXJwb2xhdGUg PSBeKGZsb2F0IHYwLCBmbG9hdCB2MSwgZmxvYXQgdCkgeworICAgICAgICAgICAgcmV0dXJuICgx IC0gdCkgKiB2MCArIHQgKiB2MTsKKyAgICAgICAgfTsKKyAgICAgICAgCisgICAgICAgIGZsb2F0 IG11bHRpcGxpZXIgPSBpbnRlcnBvbGF0ZShwb3dlckxvdywgcG93ZXJIaWdoLCBzdGQ6Om1pbih2 YWx1ZSwgdHJhbnNpdGlvblZlbG9jaXR5KSAvIHRyYW5zaXRpb25WZWxvY2l0eSk7CisgICAgICAg IHJldHVybiBjb3B5c2lnbih2YWx1ZSAqIG11bHRpcGxpZXIsIG9yaWdpbmFsVmFsdWUpOworICAg IH07CisKKyAgICByZXR1cm4geyBhcHBseUN1cnZlKHZlbG9jaXR5LndpZHRoKCkpLCBhcHBseUN1 cnZlKHZlbG9jaXR5LmhlaWdodCgpKSB9OworfQorCiBib29sIFNjcm9sbGluZ0VmZmVjdHNDb250 cm9sbGVyOjpoYW5kbGVXaGVlbEV2ZW50KGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYgd2hlZWxF dmVudCkKIHsKICAgICBpZiAocHJvY2Vzc1doZWVsRXZlbnRGb3JTY3JvbGxTbmFwKHdoZWVsRXZl bnQpKQpAQCAtMjI1LDcgKzI0Nyw3IEBAIGJvb2wgU2Nyb2xsaW5nRWZmZWN0c0NvbnRyb2xsZXI6 OmhhbmRsZVdoZWVsRXZlbnQoY29uc3QgUGxhdGZvcm1XaGVlbEV2ZW50JiB3aGVlCiAgICAgaWYg KCFtX21vbWVudHVtU2Nyb2xsSW5Qcm9ncmVzcyAmJiAobW9tZW50dW1QaGFzZSA9PSBQbGF0Zm9y bVdoZWVsRXZlbnRQaGFzZTo6QmVnYW4gfHwgbW9tZW50dW1QaGFzZSA9PSBQbGF0Zm9ybVdoZWVs RXZlbnRQaGFzZTo6Q2hhbmdlZCkpIHsKICAgICAgICAgbV9tb21lbnR1bVNjcm9sbEluUHJvZ3Jl c3MgPSB0cnVlOwogICAgICAgICBpZiAobW9tZW50dW1TY3JvbGxpbmdBbmltYXRvckVuYWJsZWQo KSkgewotICAgICAgICAgICAgc3RhcnRNb21lbnR1bVNjcm9sbFdpdGhJbml0aWFsVmVsb2NpdHko bV9jbGllbnQuc2Nyb2xsT2Zmc2V0KCksIC13aGVlbEV2ZW50LnNjcm9sbGluZ1ZlbG9jaXR5KCks IC13aGVlbEV2ZW50LmRlbHRhKCksIFtdKGNvbnN0IEZsb2F0UG9pbnQmIHRhcmdldE9mZnNldCkg eyByZXR1cm4gdGFyZ2V0T2Zmc2V0OyB9KTsKKyAgICAgICAgICAgIHN0YXJ0TW9tZW50dW1TY3Jv bGxXaXRoSW5pdGlhbFZlbG9jaXR5KG1fY2xpZW50LnNjcm9sbE9mZnNldCgpLCAtYWRqdXN0ZWRW ZWxvY2l0eSh3aGVlbEV2ZW50LnNjcm9sbGluZ1ZlbG9jaXR5KCkpLCAtd2hlZWxFdmVudC5kZWx0 YSgpLCBbXShjb25zdCBGbG9hdFBvaW50JiB0YXJnZXRPZmZzZXQpIHsgcmV0dXJuIHRhcmdldE9m ZnNldDsgfSk7CiAjaWYgIUxPR19ESVNBQkxFRAogICAgICAgICAgICAgbV9ldmVudERyaXZlblNj cm9sbE9mZnNldCA9IG1fY2xpZW50LnNjcm9sbE9mZnNldCgpOwogICAgICAgICAgICAgbV9ldmVu dERyaXZlblNjcm9sbE1vbWVudHVtU3RhcnRPZmZzZXQgPSBtX2V2ZW50RHJpdmVuU2Nyb2xsT2Zm c2V0Owo= 444577 2021-11-17 14:23:45 -0800 2021-11-17 15:55:55 -0800 patch 2.diff text/plain 3254 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1OTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWExYTdiNWJmOTdjOGQ3 MDlkMDJmODgzOTllMzQwZDMxZDU4MDIwMS4uYzY3NjVjYWM0ZjllODRjN2I5MGU0ZjAxYjY1M2U4 NTE0ZGE4NTcwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTExLTE3ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIE1vbWVudHVtIGFu aW1hdG9yOiBTaG9ydCBzY3JvbGxzIGFyZSB0b28gZmFyLCBtZWRpdW0gc2Nyb2xscyBhcmVuJ3Qg ZmFyIGVub3VnaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMzMjcyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NTQ3MjY1Mz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9TY3Jv bGxpbmdFZmZlY3RzQ29udHJvbGxlci5tbToKKyAgICAgICAgKFdlYkNvcmU6OmFkanVzdGVkVmVs b2NpdHkpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nRWZmZWN0c0NvbnRyb2xsZXI6Omhh bmRsZVdoZWVsRXZlbnQpOgorICAgICAgICBBdHRlbXB0IHRvIGFwcGx5IGEgZW1waXJpY2FsbHkt ZGVyaXZlZCBjdXJ2ZSB0byB0aGUgaW5pdGlhbCB2ZWxvY2l0eQorICAgICAgICB0byBmaXQgdGhl IGRpc3RhbmNlIG9mIGEgbm9ybWFsIG1vbWVudHVtIHNjcm9sbC4KKwogMjAyMS0xMS0xNyAgVGlt IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBNb21lbnR1bSBh bmltYXRvciBzb21ldGltZXMgc3RhcnRzIHRoZSBhbmltYXRpb24gYXQgYSB2ZXJ5IGhpZ2ggdmVs b2NpdHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxpbmdF ZmZlY3RzQ29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxp bmdFZmZlY3RzQ29udHJvbGxlci5tbQppbmRleCBjYWMzYzZjNGNjNDUyZjJiZTNkNmFkZDNlYTdm MGM5N2Q1NzI2MTM4Li5mNTg3YzVjNzg3YjE1NDc5NjBiOTdkMDJiZmFkMTY2MGQ3ZjE5NDdiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsaW5nRWZmZWN0c0Nv bnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbGluZ0Vm ZmVjdHNDb250cm9sbGVyLm1tCkBAIC0xMjcsNiArMTI3LDI4IEBAIHN0YXRpYyBjb25zdCBjaGFy KiBwaGFzZVRvU3RyaW5nKFBsYXRmb3JtV2hlZWxFdmVudFBoYXNlIHBoYXNlKQogfQogI2VuZGlm CiAKK3N0YXRpYyBGbG9hdFNpemUgYWRqdXN0ZWRWZWxvY2l0eShGbG9hdFNpemUgdmVsb2NpdHkp Cit7CisgICAgYXV0byBhcHBseUN1cnZlID0gXihmbG9hdCBvcmlnaW5hbFZhbHVlKSB7CisgICAg ICAgIGlmICghb3JpZ2luYWxWYWx1ZSkKKyAgICAgICAgICAgIHJldHVybiBvcmlnaW5hbFZhbHVl OworCisgICAgICAgIGZsb2F0IHZhbHVlID0gZmFicyhvcmlnaW5hbFZhbHVlKTsKKyAgICAgICAg ZmxvYXQgcG93ZXJMb3cgPSA2LjcgKiBwb3codmFsdWUsIC0uMTY2KTsKKyAgICAgICAgZmxvYXQg cG93ZXJIaWdoID0gMzYuMyAqIHBvdyh2YWx1ZSwgLS4zOTIpOworICAgICAgICBjb25zdCBmbG9h dCB0cmFuc2l0aW9uVmVsb2NpdHkgPSAyMDAwOworCisgICAgICAgIGF1dG8gaW50ZXJwb2xhdGUg PSBeKGZsb2F0IHYwLCBmbG9hdCB2MSwgZmxvYXQgdCkgeworICAgICAgICAgICAgcmV0dXJuICgx IC0gdCkgKiB2MCArIHQgKiB2MTsKKyAgICAgICAgfTsKKyAgICAgICAgCisgICAgICAgIGZsb2F0 IG11bHRpcGxpZXIgPSBpbnRlcnBvbGF0ZShwb3dlckxvdywgcG93ZXJIaWdoLCBzdGQ6Om1pbih2 YWx1ZSwgdHJhbnNpdGlvblZlbG9jaXR5KSAvIHRyYW5zaXRpb25WZWxvY2l0eSk7CisgICAgICAg IHJldHVybiBjb3B5c2lnbih2YWx1ZSAqIG11bHRpcGxpZXIsIG9yaWdpbmFsVmFsdWUpOworICAg IH07CisKKyAgICByZXR1cm4geyBhcHBseUN1cnZlKHZlbG9jaXR5LndpZHRoKCkpLCBhcHBseUN1 cnZlKHZlbG9jaXR5LmhlaWdodCgpKSB9OworfQorCiBib29sIFNjcm9sbGluZ0VmZmVjdHNDb250 cm9sbGVyOjpoYW5kbGVXaGVlbEV2ZW50KGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYgd2hlZWxF dmVudCkKIHsKICAgICBpZiAocHJvY2Vzc1doZWVsRXZlbnRGb3JTY3JvbGxTbmFwKHdoZWVsRXZl bnQpKQpAQCAtMjI1LDcgKzI0Nyw3IEBAIGJvb2wgU2Nyb2xsaW5nRWZmZWN0c0NvbnRyb2xsZXI6 OmhhbmRsZVdoZWVsRXZlbnQoY29uc3QgUGxhdGZvcm1XaGVlbEV2ZW50JiB3aGVlCiAgICAgaWYg KCFtX21vbWVudHVtU2Nyb2xsSW5Qcm9ncmVzcyAmJiAobW9tZW50dW1QaGFzZSA9PSBQbGF0Zm9y bVdoZWVsRXZlbnRQaGFzZTo6QmVnYW4gfHwgbW9tZW50dW1QaGFzZSA9PSBQbGF0Zm9ybVdoZWVs RXZlbnRQaGFzZTo6Q2hhbmdlZCkpIHsKICAgICAgICAgbV9tb21lbnR1bVNjcm9sbEluUHJvZ3Jl c3MgPSB0cnVlOwogICAgICAgICBpZiAobW9tZW50dW1TY3JvbGxpbmdBbmltYXRvckVuYWJsZWQo KSkgewotICAgICAgICAgICAgc3RhcnRNb21lbnR1bVNjcm9sbFdpdGhJbml0aWFsVmVsb2NpdHko bV9jbGllbnQuc2Nyb2xsT2Zmc2V0KCksIC13aGVlbEV2ZW50LnNjcm9sbGluZ1ZlbG9jaXR5KCks IC13aGVlbEV2ZW50LmRlbHRhKCksIFtdKGNvbnN0IEZsb2F0UG9pbnQmIHRhcmdldE9mZnNldCkg eyByZXR1cm4gdGFyZ2V0T2Zmc2V0OyB9KTsKKyAgICAgICAgICAgIHN0YXJ0TW9tZW50dW1TY3Jv bGxXaXRoSW5pdGlhbFZlbG9jaXR5KG1fY2xpZW50LnNjcm9sbE9mZnNldCgpLCAtYWRqdXN0ZWRW ZWxvY2l0eSh3aGVlbEV2ZW50LnNjcm9sbGluZ1ZlbG9jaXR5KCkpLCAtd2hlZWxFdmVudC5kZWx0 YSgpLCBbXShjb25zdCBGbG9hdFBvaW50JiB0YXJnZXRPZmZzZXQpIHsgcmV0dXJuIHRhcmdldE9m ZnNldDsgfSk7CiAjaWYgIUxPR19ESVNBQkxFRAogICAgICAgICAgICAgbV9ldmVudERyaXZlblNj cm9sbE9mZnNldCA9IG1fY2xpZW50LnNjcm9sbE9mZnNldCgpOwogICAgICAgICAgICAgbV9ldmVu dERyaXZlblNjcm9sbE1vbWVudHVtU3RhcnRPZmZzZXQgPSBtX2V2ZW50RHJpdmVuU2Nyb2xsT2Zm c2V0Owo=