233264 2021-11-17 11:17:23 -0800 Web Inspector: fix IPC race between unregistering an extension and Web Inspector closing 2021-11-30 10:53:34 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg ews-watchlist hi inspector-bugzilla-changes joepeck pangle webkit-bug-importer oldest_to_newest 1816021 0 bburg 2021-11-17 11:17:23 -0800 . 1816025 1 444540 bburg 2021-11-17 11:21:14 -0800 Created attachment 444540 Patch v1.0 1816045 2 444540 hi 2021-11-17 12:03:07 -0800 Comment on attachment 444540 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=444540&action=review r=me > Source/WebKit/UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp:89 > + m_extensionAPIObjectMap.clear(); Style: add newline before 1816218 3 webkit-bug-importer 2021-11-17 16:51:11 -0800 <rdar://problem/85526823> 1818792 4 445430 bburg 2021-11-30 09:58:04 -0800 Created attachment 445430 Patch 1.0.1 (for landing) 1818834 5 ews-feeder 2021-11-30 10:53:32 -0800 Committed r286306 (244665@main): <https://commits.webkit.org/244665@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445430. 444540 2021-11-17 11:21:14 -0800 2021-11-30 09:58:02 -0800 Patch v1.0 bug-233264-20211117112113.patch text/plain 3021 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1ODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZmZjA4Mzg0MDA0ZDY1YmQ4 NTRjYWVkNWRkMWQwNzAzN2M0ZjdhZTcuLmVhMTEzYzAxMmUzNDkyNDQ5MmUwZGJlMDIyYjgwMDI5 NTQ5NGFkMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMTEtMTcgIEJKIEJ1cmcg IDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogZml4IElQQyByYWNl IGJldHdlZW4gdW5yZWdpc3RlcmluZyBhbiBleHRlbnNpb24gYW5kIFdlYiBJbnNwZWN0b3IgY2xv c2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMz MjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvSW5zcGVjdG9yL1dlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlclByb3h5 LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yVUlFeHRlbnNpb25Db250cm9sbGVy UHJveHk6Omluc3BlY3RvckZyb250ZW5kV2lsbENsb3NlKToKKyAgICAgICAgUmVtYWluaW5nIHJl Z2lzdHJhdGlvbnMgd2lsbCBub3QgYmUgcmVtb3ZlZCB2aWEgdW5yZWdpc3RlckV4dGVuc2lvbigp IGlmCisgICAgICAgIHRoZSBmcm9udGVuZCBpcyBhbHJlYWR5IGluIHRoZSBtaWRzdCBvZiBjbG9z aW5nLiBDbGVhciBvdXQgdGhlIHJlZ2lzdHJ5LgorCisgICAgICAgIChXZWJLaXQ6OldlYkluc3Bl Y3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlclByb3h5OjpyZWdpc3RlckV4dGVuc2lvbik6CisgICAg ICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlclByb3h5Ojp1bnJl Z2lzdGVyRXh0ZW5zaW9uKToKKyAgICAgICAgQmFpbCBvdXQgaWYgdGhlIGluc3BlY3RvciBoYXMg Y2xvc2VkIGJldHdlZW4gdGhlIElQQyBtZXNzYWdlIGJlaW5nIHNlbnQKKyAgICAgICAgYW5kIHJl Y2VpdmluZyB0aGUgYXN5bmMgcmVzcG9uc2UuCisKIDIwMjEtMTEtMTUgIE1pY2hhZWwgQ2F0YW56 YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CiAKICAgICAgICAgTWFrZSB2YWxncmluZCB3b3Jr IHByb3Blcmx5IHdpdGhvdXQgZXh0cmEgZW52aXJvbm1lbnQgdmFyaWFibGVzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3IvV2ViSW5zcGVjdG9yVUlFeHRlbnNp b25Db250cm9sbGVyUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9y L1dlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlclByb3h5LmNwcAppbmRleCA3YmQxZTI4 ZjRmMTk2YmYxYmQzMzJjY2M4M2MxYjllOGIyZjM5YmRlLi4yNjE3OGE3NDdiYTY0OWRkZThiMzQ5 OTcyMTU3MzNkYTdkZDhlZmJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9J bnNwZWN0b3IvV2ViSW5zcGVjdG9yVUlFeHRlbnNpb25Db250cm9sbGVyUHJveHkuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0b3JVSUV4dGVuc2lv bkNvbnRyb2xsZXJQcm94eS5jcHAKQEAgLTg2LDYgKzg2LDcgQEAgdm9pZCBXZWJJbnNwZWN0b3JV SUV4dGVuc2lvbkNvbnRyb2xsZXJQcm94eTo6aW5zcGVjdG9yRnJvbnRlbmRXaWxsQ2xvc2UoKQog CiAgICAgbV9pbnNwZWN0b3JQYWdlLT5wcm9jZXNzKCkucmVtb3ZlTWVzc2FnZVJlY2VpdmVyKE1l c3NhZ2VzOjpXZWJJbnNwZWN0b3JVSUV4dGVuc2lvbkNvbnRyb2xsZXJQcm94eTo6bWVzc2FnZVJl Y2VpdmVyTmFtZSgpLCBtX2luc3BlY3RvclBhZ2UtPndlYlBhZ2VJRCgpKTsKICAgICBtX2luc3Bl Y3RvclBhZ2UgPSBudWxscHRyOworICAgIG1fZXh0ZW5zaW9uQVBJT2JqZWN0TWFwLmNsZWFyKCk7 CiB9CiAKIC8vIEFQSQpAQCAtMTA0LDYgKzEwNSwxMSBAQCB2b2lkIFdlYkluc3BlY3RvclVJRXh0 ZW5zaW9uQ29udHJvbGxlclByb3h5OjpyZWdpc3RlckV4dGVuc2lvbihjb25zdCBJbnNwZWN0b3I6 OgogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KIAorICAgICAgICAgICAg aWYgKCFzdHJvbmdUaGlzLT5tX2luc3BlY3RvclBhZ2UpIHsKKyAgICAgICAgICAgICAgICBjb21w bGV0aW9uSGFuZGxlcihtYWtlVW5leHBlY3RlZChJbnNwZWN0b3I6OkV4dGVuc2lvbkVycm9yOjpD b250ZXh0RGVzdHJveWVkKSk7CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAg fQorCiAgICAgICAgICAgICBSZWZQdHI8QVBJOjpJbnNwZWN0b3JFeHRlbnNpb24+IGV4dGVuc2lv bkFQSU9iamVjdCA9IEFQSTo6SW5zcGVjdG9yRXh0ZW5zaW9uOjpjcmVhdGUoZXh0ZW5zaW9uSUQs IHN0cm9uZ1RoaXMuZ2V0KCkpOwogICAgICAgICAgICAgc3Ryb25nVGhpcy0+bV9leHRlbnNpb25B UElPYmplY3RNYXAuc2V0KGV4dGVuc2lvbklELCBleHRlbnNpb25BUElPYmplY3QuY29weVJlZigp KTsKIApAQCAtMTI2LDYgKzEzMiwxMSBAQCB2b2lkIFdlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29u dHJvbGxlclByb3h5Ojp1bnJlZ2lzdGVyRXh0ZW5zaW9uKGNvbnN0IEluc3BlY3RvcgogICAgICAg ICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KIAorICAgICAgICAgICAgaWYgKCFzdHJv bmdUaGlzLT5tX2luc3BlY3RvclBhZ2UpIHsKKyAgICAgICAgICAgICAgICBjb21wbGV0aW9uSGFu ZGxlcihtYWtlVW5leHBlY3RlZChJbnNwZWN0b3I6OkV4dGVuc2lvbkVycm9yOjpDb250ZXh0RGVz dHJveWVkKSk7CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgfQorCiAgICAg ICAgICAgICBzdHJvbmdUaGlzLT5tX2V4dGVuc2lvbkFQSU9iamVjdE1hcC50YWtlKGV4dGVuc2lv bklEKTsKIAogICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoV1RGTW92ZShyZXN1bHQpKTsK 445430 2021-11-30 09:58:04 -0800 2021-11-30 10:53:33 -0800 Patch 1.0.1 (for landing) bug-233264-20211130095803.patch text/plain 3010 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2MzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdhNjk5MzY0NTIyNGU1MTky MmUyNmI4OTJlNTIzZTQ2M2ZiOTFiNWQuLjE5MGQ1OGVjMDI4MGEwYmRkYzM1ZWVmMTVmNzI1YTBm NWVhMDgyYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMTEtMzAgIEJKIEJ1cmcg IDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogZml4IElQQyByYWNl IGJldHdlZW4gdW5yZWdpc3RlcmluZyBhbiBleHRlbnNpb24gYW5kIFdlYiBJbnNwZWN0b3IgY2xv c2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMz MjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGV2aW4gUm91c3NvLgorCisgICAgICAgICogVUlQ cm9jZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0b3JVSUV4dGVuc2lvbkNvbnRyb2xsZXJQcm94eS5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlclBy b3h5OjppbnNwZWN0b3JGcm9udGVuZFdpbGxDbG9zZSk6CisgICAgICAgIFJlbWFpbmluZyByZWdp c3RyYXRpb25zIHdpbGwgbm90IGJlIHJlbW92ZWQgdmlhIHVucmVnaXN0ZXJFeHRlbnNpb24oKSBp ZgorICAgICAgICB0aGUgZnJvbnRlbmQgaXMgYWxyZWFkeSBpbiB0aGUgbWlkc3Qgb2YgY2xvc2lu Zy4gQ2xlYXIgb3V0IHRoZSByZWdpc3RyeS4KKworICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0 b3JVSUV4dGVuc2lvbkNvbnRyb2xsZXJQcm94eTo6cmVnaXN0ZXJFeHRlbnNpb24pOgorICAgICAg ICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JVSUV4dGVuc2lvbkNvbnRyb2xsZXJQcm94eTo6dW5yZWdp c3RlckV4dGVuc2lvbik6CisgICAgICAgIEJhaWwgb3V0IGlmIHRoZSBpbnNwZWN0b3IgaGFzIGNs b3NlZCBiZXR3ZWVuIHRoZSBJUEMgbWVzc2FnZSBiZWluZyBzZW50CisgICAgICAgIGFuZCByZWNl aXZpbmcgdGhlIGFzeW5jIHJlc3BvbnNlLgorCiAyMDIxLTExLTMwICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBNaWdyYXRlIHNvbWUgV2ViU1dDbGllbnRDb25u ZWN0aW9uIG1lc3NhZ2VzIHRvIGFzeW5jIHJlcGxpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0b3JVSUV4dGVuc2lvbkNvbnRyb2xsZXJQ cm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3IvV2ViSW5zcGVjdG9y VUlFeHRlbnNpb25Db250cm9sbGVyUHJveHkuY3BwCmluZGV4IDdiZDFlMjhmNGYxOTZiZjFiZDMz MmNjYzgzYzFiOWU4YjJmMzliZGUuLmY3NjE5NmRkMzdmY2RlYTBkNzllZDBhZDFhYTk1NmRjZmVm ODk2ZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9XZWJJ bnNwZWN0b3JVSUV4dGVuc2lvbkNvbnRyb2xsZXJQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvSW5zcGVjdG9yL1dlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlclBy b3h5LmNwcApAQCAtODYsNiArODYsOCBAQCB2b2lkIFdlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29u dHJvbGxlclByb3h5OjppbnNwZWN0b3JGcm9udGVuZFdpbGxDbG9zZSgpCiAKICAgICBtX2luc3Bl Y3RvclBhZ2UtPnByb2Nlc3MoKS5yZW1vdmVNZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OldlYklu c3BlY3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlclByb3h5OjptZXNzYWdlUmVjZWl2ZXJOYW1lKCks IG1faW5zcGVjdG9yUGFnZS0+d2ViUGFnZUlEKCkpOwogICAgIG1faW5zcGVjdG9yUGFnZSA9IG51 bGxwdHI7CisKKyAgICBtX2V4dGVuc2lvbkFQSU9iamVjdE1hcC5jbGVhcigpOwogfQogCiAvLyBB UEkKQEAgLTEwNCw2ICsxMDYsMTEgQEAgdm9pZCBXZWJJbnNwZWN0b3JVSUV4dGVuc2lvbkNvbnRy b2xsZXJQcm94eTo6cmVnaXN0ZXJFeHRlbnNpb24oY29uc3QgSW5zcGVjdG9yOjoKICAgICAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CiAKKyAgICAgICAgICAgIGlmICghc3Ryb25n VGhpcy0+bV9pbnNwZWN0b3JQYWdlKSB7CisgICAgICAgICAgICAgICAgY29tcGxldGlvbkhhbmRs ZXIobWFrZVVuZXhwZWN0ZWQoSW5zcGVjdG9yOjpFeHRlbnNpb25FcnJvcjo6Q29udGV4dERlc3Ry b3llZCkpOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKwogICAgICAg ICAgICAgUmVmUHRyPEFQSTo6SW5zcGVjdG9yRXh0ZW5zaW9uPiBleHRlbnNpb25BUElPYmplY3Qg PSBBUEk6Okluc3BlY3RvckV4dGVuc2lvbjo6Y3JlYXRlKGV4dGVuc2lvbklELCBzdHJvbmdUaGlz LmdldCgpKTsKICAgICAgICAgICAgIHN0cm9uZ1RoaXMtPm1fZXh0ZW5zaW9uQVBJT2JqZWN0TWFw LnNldChleHRlbnNpb25JRCwgZXh0ZW5zaW9uQVBJT2JqZWN0LmNvcHlSZWYoKSk7CiAKQEAgLTEy Niw2ICsxMzMsMTEgQEAgdm9pZCBXZWJJbnNwZWN0b3JVSUV4dGVuc2lvbkNvbnRyb2xsZXJQcm94 eTo6dW5yZWdpc3RlckV4dGVuc2lvbihjb25zdCBJbnNwZWN0b3IKICAgICAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgICAgICB9CiAKKyAgICAgICAgICAgIGlmICghc3Ryb25nVGhpcy0+bV9p bnNwZWN0b3JQYWdlKSB7CisgICAgICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIobWFrZVVu ZXhwZWN0ZWQoSW5zcGVjdG9yOjpFeHRlbnNpb25FcnJvcjo6Q29udGV4dERlc3Ryb3llZCkpOwor ICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgc3Ry b25nVGhpcy0+bV9leHRlbnNpb25BUElPYmplY3RNYXAudGFrZShleHRlbnNpb25JRCk7CiAKICAg ICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKFdURk1vdmUocmVzdWx0KSk7Cg==