233229 2021-11-16 18:05:28 -0800 Fix formatting and string literals in FileInputType.cpp 2021-11-17 09:28:21 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andreu webkit-unassigned cdumez changseok darin esprehn+autocc ews-watchlist gyuyoung.kim mifenton webkit-bug-importer oldest_to_newest 1815760 0 andreu 2021-11-16 18:05:28 -0800 Fix formatting and string literals in FileInputType.cpp 1815763 1 444463 andreu 2021-11-16 18:09:12 -0800 Created attachment 444463 Patch 1815930 2 444463 cdumez 2021-11-17 07:19:15 -0800 Comment on attachment 444463 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444463&action=review > Source/WebCore/html/FileInputType.cpp:185 > + auto file = File::create(document, Blob::create(document, { }, WebCore::defaultMIMEType()), emptyString()); Is "WebCore::" really needed? 1815945 3 444524 andreu 2021-11-17 08:12:04 -0800 Created attachment 444524 Patch 1815968 4 ews-feeder 2021-11-17 09:27:41 -0800 Committed r285932 (244341@main): <https://commits.webkit.org/244341@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444524. 1815969 5 webkit-bug-importer 2021-11-17 09:28:21 -0800 <rdar://problem/85507623> 444463 2021-11-16 18:09:12 -0800 2021-11-17 08:11:58 -0800 Patch bug-233229-20211117030911.patch text/plain 2547 andreu U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1OTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODUyNDdhYmQ5N2Y0MDY5 ZjE0NTg4NGY4MjA0NGQ1N2YxNTlmMTkxMC4uNjZiMGYxODA2N2FmMDAwNGRhYTliZWQ1MjhiMDY0 MTFmMTFjNTI2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTExLTE2ICBBbmRy ZXUgQm90ZWxsYSAgPGFuZHJldUBhbmRyZXVib3RlbGxhLmNvbT4KKworICAgICAgICBGaXggZm9y bWF0dGluZyBhbmQgc3RyaW5nIGxpdGVyYWxzIGluIEZpbGVJbnB1dFR5cGUuY3BwCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzMyMjkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGNoYW5nZSB1c2Vz IHRoZSBlbXB0eVN0cmluZygpIGFuZCBXZWJDb3JlOjpkZWZhdWx0TUlNRVR5cGUoKSBmdW5jdGlv bnMgcmF0aGVyIHRoYW4KKyAgICAgICAgdXNpbmcgc3RyaW5nIGxpdGVyYWxzLCBmaXhlcyB0aGUg Y29kaW5nIHN0eWxlLCBhbmQgcmV2ZXJ0cyBhbiB1bm5lY2Vzc2FyeSBjaGFuZ2UgaW4gdGhlCisg ICAgICAgIGNvbW1lbnRzLgorCisgICAgICAgIFRoaXMgZml4ZXMgY29kZSByZXZpZXcgc3VnZ2Vz dGlvbnMgZnJvbSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1NDE2 IGFuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIx NTQ5CisKKyAgICAgICAgKiBodG1sL0ZpbGVJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RmlsZUlucHV0VHlwZTo6YXBwZW5kRm9ybURhdGEgY29uc3QpOgorCiAyMDIxLTExLTE2ICBO aWtvbGFvcyBNb3VjaHRhcmlzICA8bm1vdWNodGFyaXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJl bmFtZSBUZXh0RGVjb3JhdGlvbiB0byBUZXh0RGVjb3JhdGlvbkxpbmUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvRmlsZUlucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0ZpbGVJbnB1dFR5cGUuY3BwCmluZGV4IDQxMDk3YWJhZDZiY2RjNzAwMGUxMjQyYWE3ZWU0NmI0 YTliMjM2NmQuLjJmNzRhOTJhZmQ4ODNmNzUyMTFiMGY5NzMwOWQ2MTJlNzQ3YmZlYzcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRmlsZUlucHV0VHlwZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvaHRtbC9GaWxlSW5wdXRUeXBlLmNwcApAQCAtMTcxLDIyICsxNzEsMTggQEAgYm9v bCBGaWxlSW5wdXRUeXBlOjphcHBlbmRGb3JtRGF0YShET01Gb3JtRGF0YSYgZm9ybURhdGEsIGJv b2wgbXVsdGlwYXJ0KSBjb25zdAogICAgICAgICAvLyA0LjEwLjE2LjQgYW5kIDQuMTAuMTYuNiBz ZWN0aW9ucyBpbiBIVE1MNS4KIAogICAgICAgICBpZiAoZmlsZUxpc3QtPmlzRW1wdHkoKSkKLSAg ICAgICAgICAgIGZvcm1EYXRhLmFwcGVuZChuYW1lLCAiIik7CisgICAgICAgICAgICBmb3JtRGF0 YS5hcHBlbmQobmFtZSwgZW1wdHlTdHJpbmcoKSk7CiAKICAgICAgICAgZm9yIChhdXRvJiBmaWxl IDogZmlsZUxpc3QtPmZpbGVzKCkpCiAgICAgICAgICAgICBmb3JtRGF0YS5hcHBlbmQobmFtZSwg ZmlsZS0+bmFtZSgpKTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCi0gICAgLy8gSWYg bm8gZmlsZW5hbWUgYXQgYWxsIGlzIGVudGVyZWQsIHJldHVybiBzdWNjZXNzZnVsIGJ1dCBlbXB0 eSwgd2l0aAotICAgIC8vIGFwcGxpY2F0aW9uL29jdGV0LXN0cmVhbSBjb250ZW50IHR5cGUuIE51 bGwgd291bGQgYmUgbW9yZSBsb2dpY2FsLCBidXQKLSAgICAvLyBOZXRzY2FwZSBwb3N0cyBhbiBl bXB0eSBmaWxlLiBBcmdoLgorICAgIC8vIElmIG5vIGZpbGVuYW1lIGF0IGFsbCBpcyBlbnRlcmVk LCByZXR1cm4gc3VjY2Vzc2Z1bCBidXQgZW1wdHkuCisgICAgLy8gTnVsbCB3b3VsZCBiZSBtb3Jl IGxvZ2ljYWwsIGJ1dCBOZXRzY2FwZSBwb3N0cyBhbiBlbXB0eSBmaWxlLiBBcmdoLgogICAgIGlm IChmaWxlTGlzdC0+aXNFbXB0eSgpKSB7CiAgICAgICAgIGF1dG8qIGRvY3VtZW50ID0gZWxlbWVu dCgpID8gJmVsZW1lbnQoKS0+ZG9jdW1lbnQoKSA6IG51bGxwdHI7Ci0gICAgICAgIGF1dG8gZmls ZSA9IEZpbGU6OmNyZWF0ZSgKLSAgICAgICAgICAgIGRvY3VtZW50LAotICAgICAgICAgICAgQmxv Yjo6Y3JlYXRlKGRvY3VtZW50LCB7IH0sICJhcHBsaWNhdGlvbi9vY3RldC1zdHJlYW0iKSwKLSAg ICAgICAgICAgIGVtcHR5U3RyaW5nKCkpOworICAgICAgICBhdXRvIGZpbGUgPSBGaWxlOjpjcmVh dGUoZG9jdW1lbnQsIEJsb2I6OmNyZWF0ZShkb2N1bWVudCwgeyB9LCBXZWJDb3JlOjpkZWZhdWx0 TUlNRVR5cGUoKSksIGVtcHR5U3RyaW5nKCkpOwogICAgICAgICBmb3JtRGF0YS5hcHBlbmQobmFt ZSwgZmlsZSk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0K 444524 2021-11-17 08:12:04 -0800 2021-11-17 09:27:42 -0800 Patch bug-233229-20211117171203.patch text/plain 2520 andreu U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1OTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODUyNDdhYmQ5N2Y0MDY5 ZjE0NTg4NGY4MjA0NGQ1N2YxNTlmMTkxMC4uYWU2NmY1YTk3NTU5NjNmODlhZWM2MTA0MzU1OWJj NGIwNDRiNTM0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTExLTE2ICBBbmRy ZXUgQm90ZWxsYSAgPGFuZHJldUBhbmRyZXVib3RlbGxhLmNvbT4KKworICAgICAgICBGaXggZm9y bWF0dGluZyBhbmQgc3RyaW5nIGxpdGVyYWxzIGluIEZpbGVJbnB1dFR5cGUuY3BwCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzMyMjkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGNoYW5nZSB1c2Vz IHRoZSBlbXB0eVN0cmluZygpIGFuZCBkZWZhdWx0TUlNRVR5cGUoKSBmdW5jdGlvbnMgcmF0aGVy IHRoYW4gdXNpbmcgc3RyaW5nCisgICAgICAgIGxpdGVyYWxzLCBmaXhlcyB0aGUgY29kaW5nIHN0 eWxlLCBhbmQgcmV2ZXJ0cyBhbiB1bm5lY2Vzc2FyeSBjaGFuZ2UgaW4gdGhlIGNvbW1lbnRzLgor CisgICAgICAgIFRoaXMgZml4ZXMgY29kZSByZXZpZXcgc3VnZ2VzdGlvbnMgZnJvbSBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1NDE2IGFuZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNTQ5CisKKyAgICAgICAgKiBo dG1sL0ZpbGVJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RmlsZUlucHV0VHlwZTo6 YXBwZW5kRm9ybURhdGEgY29uc3QpOgorCiAyMDIxLTExLTE2ICBOaWtvbGFvcyBNb3VjaHRhcmlz ICA8bm1vdWNodGFyaXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBUZXh0RGVjb3JhdGlv biB0byBUZXh0RGVjb3JhdGlvbkxpbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv RmlsZUlucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ZpbGVJbnB1dFR5cGUuY3Bw CmluZGV4IDQxMDk3YWJhZDZiY2RjNzAwMGUxMjQyYWE3ZWU0NmI0YTliMjM2NmQuLmIwYzlmYWU3 ZDNkYTU0NzExYTcyNTlmMDVlMzQ2MGI0NmFjZjRlZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvRmlsZUlucHV0VHlwZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9GaWxl SW5wdXRUeXBlLmNwcApAQCAtMTcxLDIyICsxNzEsMTggQEAgYm9vbCBGaWxlSW5wdXRUeXBlOjph cHBlbmRGb3JtRGF0YShET01Gb3JtRGF0YSYgZm9ybURhdGEsIGJvb2wgbXVsdGlwYXJ0KSBjb25z dAogICAgICAgICAvLyA0LjEwLjE2LjQgYW5kIDQuMTAuMTYuNiBzZWN0aW9ucyBpbiBIVE1MNS4K IAogICAgICAgICBpZiAoZmlsZUxpc3QtPmlzRW1wdHkoKSkKLSAgICAgICAgICAgIGZvcm1EYXRh LmFwcGVuZChuYW1lLCAiIik7CisgICAgICAgICAgICBmb3JtRGF0YS5hcHBlbmQobmFtZSwgZW1w dHlTdHJpbmcoKSk7CiAKICAgICAgICAgZm9yIChhdXRvJiBmaWxlIDogZmlsZUxpc3QtPmZpbGVz KCkpCiAgICAgICAgICAgICBmb3JtRGF0YS5hcHBlbmQobmFtZSwgZmlsZS0+bmFtZSgpKTsKICAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCi0gICAgLy8gSWYgbm8gZmlsZW5hbWUgYXQgYWxs IGlzIGVudGVyZWQsIHJldHVybiBzdWNjZXNzZnVsIGJ1dCBlbXB0eSwgd2l0aAotICAgIC8vIGFw cGxpY2F0aW9uL29jdGV0LXN0cmVhbSBjb250ZW50IHR5cGUuIE51bGwgd291bGQgYmUgbW9yZSBs b2dpY2FsLCBidXQKLSAgICAvLyBOZXRzY2FwZSBwb3N0cyBhbiBlbXB0eSBmaWxlLiBBcmdoLgor ICAgIC8vIElmIG5vIGZpbGVuYW1lIGF0IGFsbCBpcyBlbnRlcmVkLCByZXR1cm4gc3VjY2Vzc2Z1 bCBidXQgZW1wdHkuCisgICAgLy8gTnVsbCB3b3VsZCBiZSBtb3JlIGxvZ2ljYWwsIGJ1dCBOZXRz Y2FwZSBwb3N0cyBhbiBlbXB0eSBmaWxlLiBBcmdoLgogICAgIGlmIChmaWxlTGlzdC0+aXNFbXB0 eSgpKSB7CiAgICAgICAgIGF1dG8qIGRvY3VtZW50ID0gZWxlbWVudCgpID8gJmVsZW1lbnQoKS0+ ZG9jdW1lbnQoKSA6IG51bGxwdHI7Ci0gICAgICAgIGF1dG8gZmlsZSA9IEZpbGU6OmNyZWF0ZSgK LSAgICAgICAgICAgIGRvY3VtZW50LAotICAgICAgICAgICAgQmxvYjo6Y3JlYXRlKGRvY3VtZW50 LCB7IH0sICJhcHBsaWNhdGlvbi9vY3RldC1zdHJlYW0iKSwKLSAgICAgICAgICAgIGVtcHR5U3Ry aW5nKCkpOworICAgICAgICBhdXRvIGZpbGUgPSBGaWxlOjpjcmVhdGUoZG9jdW1lbnQsIEJsb2I6 OmNyZWF0ZShkb2N1bWVudCwgeyB9LCBkZWZhdWx0TUlNRVR5cGUoKSksIGVtcHR5U3RyaW5nKCkp OwogICAgICAgICBmb3JtRGF0YS5hcHBlbmQobmFtZSwgZmlsZSk7CiAgICAgICAgIHJldHVybiB0 cnVlOwogICAgIH0K