233201 2021-11-16 10:34:35 -0800 [IFC][Integration] Clear the preferredLogicalWidths dirty bits after calling LineLayout::computeIntrinsicWidthConstraints 2021-11-17 11:48:29 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok darin esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1815556 0 zalan 2021-11-16 10:34:35 -0800 ssia 1815558 1 444408 zalan 2021-11-16 10:36:21 -0800 Created attachment 444408 Patch 1815907 2 ews-feeder 2021-11-17 06:20:01 -0800 Committed r285925 (244334@main): <https://commits.webkit.org/244334@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444408. 1815908 3 webkit-bug-importer 2021-11-17 06:21:23 -0800 <rdar://problem/85501834> 1815965 4 444408 darin 2021-11-17 09:26:21 -0800 Comment on attachment 444408 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444408&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:4583 > + return true; > return true; I think we can just keep one of these 1815977 5 zalan 2021-11-17 09:47:54 -0800 (In reply to Darin Adler from comment #4) > Comment on attachment 444408 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444408&action=review > > > Source/WebCore/rendering/RenderBlockFlow.cpp:4583 > > + return true; > > return true; > > I think we can just keep one of these oops! 1815980 6 zalan 2021-11-17 09:49:17 -0800 (In reply to zalan from comment #5) > (In reply to Darin Adler from comment #4) > > Comment on attachment 444408 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=444408&action=review > > > > > Source/WebCore/rendering/RenderBlockFlow.cpp:4583 > > > + return true; > > > return true; > > > > I think we can just keep one of these > oops! good spotting! thanks thanks 1816015 7 444537 zalan 2021-11-17 10:53:19 -0800 Created attachment 444537 Post review patch 1816019 8 zalan 2021-11-17 11:03:32 -0800 post review patch. 1816039 9 ews-feeder 2021-11-17 11:48:25 -0800 Committed r285946 (244349@main): <https://commits.webkit.org/244349@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444537. 444408 2021-11-16 10:36:21 -0800 2021-11-17 06:20:03 -0800 Patch bug-233201-20211116103620.patch text/plain 1696 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1ODYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDMzMTRkNTUyNTU5NmYy NDY3YjIyNmYxNThjYTAwNDRlYTIzMmJjOC4uZTQ4OGYzODQ3YTQ3MzMzYmJhMzdlYzNkY2E5MDJm YWFhNjY3YzdlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTExLTE2ICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbSUZDXVtJbnRlZ3JhdGlvbl0g Q2xlYXIgdGhlIHByZWZlcnJlZExvZ2ljYWxXaWR0aHMgZGlydHkgYml0cyBhZnRlciBjYWxsaW5n IExpbmVMYXlvdXQ6OmNvbXB1dGVJbnRyaW5zaWNXaWR0aENvbnN0cmFpbnRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzMyMDEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGluIHByZXBhcmF0 aW9uIGZvciBlbmFibGluZyBwcmVmZXJyZWQgd2lkdGggY29tcHV0YXRpb24gdGhyb3VnaCBJRkMu CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckJsb2NrRmxvdzo6dHJ5Q29tcHV0ZVByZWZlcnJlZFdpZHRoc1VzaW5nTW9k ZXJuUGF0aCk6CisKIDIwMjEtMTEtMTYgIEFuZHJldSBCb3RlbGxhICA8YW5kcmV1QGFuZHJldWJv dGVsbGEuY29tPgogCiAgICAgICAgIEVtcHR5IDxpbnB1dCB0eXBlPWZpbGU+IGlzIHJlcHJlc2Vu dGVkIGluY29ycmVjdGx5IGluIEZvcm1EYXRhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9ja0Zsb3cuY3BwCmluZGV4IGNjZjkzMGQ2MmI3ZjBhYzdkNTVlZDgyYTUwMDRiZjYw ZTBiNjMyZTIuLjgxNWU4YTBmNDlhMzk2ZDg5N2U5MjY2ZmU0MzJhMjgyZTUzZGZiYjAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCkBAIC00NTc3LDYg KzQ1NzcsOSBAQCBib29sIFJlbmRlckJsb2NrRmxvdzo6dHJ5Q29tcHV0ZVByZWZlcnJlZFdpZHRo c1VzaW5nTW9kZXJuUGF0aChMYXlvdXRVbml0JiBtaW5MbwogICAgICAgICBtX2xpbmVMYXlvdXQg PSBtYWtlVW5pcXVlPExheW91dEludGVncmF0aW9uOjpMaW5lTGF5b3V0PigqdGhpcyk7CiAKICAg ICBzdGQ6OnRpZShtaW5Mb2dpY2FsV2lkdGgsIG1heExvZ2ljYWxXaWR0aCkgPSBtb2Rlcm5MaW5l TGF5b3V0KCktPmNvbXB1dGVJbnRyaW5zaWNXaWR0aENvbnN0cmFpbnRzKCk7CisgICAgZm9yIChh dXRvIHdhbGtlciA9IElubGluZVdhbGtlcigqdGhpcyk7ICF3YWxrZXIuYXRFbmQoKTsgd2Fsa2Vy LmFkdmFuY2UoKSkKKyAgICAgICAgd2Fsa2VyLmN1cnJlbnQoKS0+c2V0UHJlZmVycmVkTG9naWNh bFdpZHRoc0RpcnR5KGZhbHNlKTsKKyAgICByZXR1cm4gdHJ1ZTsKICAgICByZXR1cm4gdHJ1ZTsK ICNlbHNlCiAgICAgVU5VU0VEX1BBUkFNKG1pbkxvZ2ljYWxXaWR0aCk7Cg== 444537 2021-11-17 10:53:19 -0800 2021-11-17 11:48:27 -0800 Post review patch Patch.txt text/plain 1238 zalan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkNDAzMjQ5YjZjYzguLmJlNmJlNWQ0YWMzYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEyIEBACisyMDIxLTExLTE3ICBBbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4K KworICAgICAgICBBZGRyZXNzIHBvc3QgcmV2aWV3IGNvbW1lbnQgYWZ0ZXIgcjI4NTkyNS4KKwor ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJCbG9ja0Zsb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2tGbG93Ojp0 cnlDb21wdXRlUHJlZmVycmVkV2lkdGhzVXNpbmdNb2Rlcm5QYXRoKToKKwogMjAyMS0xMS0xNyAg QWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBEbyBu b3QgYXBwbHkgdGhlICJkbyBub3QgdHJpbSB3aGl0ZXNwYWNlIGZvbGxvd2VkIGJ5IGJyIiBsZWdh Y3kgbGluZSBsYXlvdXQgcXVpcmsgd2hlbiBjb21wdXRpbmcgdGhlIGludHJpbnNpYyB3aWR0aHMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKaW5kZXggODE1 ZThhMGY0OWEzLi4xMGY3OWUzMzNiNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9ja0Zsb3cuY3BwCkBAIC00NTgwLDcgKzQ1ODAsNiBAQCBib29sIFJlbmRlckJsb2Nr Rmxvdzo6dHJ5Q29tcHV0ZVByZWZlcnJlZFdpZHRoc1VzaW5nTW9kZXJuUGF0aChMYXlvdXRVbml0 JiBtaW5MbwogICAgIGZvciAoYXV0byB3YWxrZXIgPSBJbmxpbmVXYWxrZXIoKnRoaXMpOyAhd2Fs a2VyLmF0RW5kKCk7IHdhbGtlci5hZHZhbmNlKCkpCiAgICAgICAgIHdhbGtlci5jdXJyZW50KCkt PnNldFByZWZlcnJlZExvZ2ljYWxXaWR0aHNEaXJ0eShmYWxzZSk7CiAgICAgcmV0dXJuIHRydWU7 Ci0gICAgcmV0dXJuIHRydWU7CiAjZWxzZQogICAgIFVOVVNFRF9QQVJBTShtaW5Mb2dpY2FsV2lk dGgpOwogICAgIFVOVVNFRF9QQVJBTShtYXhMb2dpY2FsV2lkdGgpOwo=