23320 2009-01-14 10:07:36 -0800 Make it possible to use notImplemented outside of the WebCore namespace 2009-01-14 10:35:12 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd eric oldest_to_newest 105697 0 fishd 2009-01-14 10:07:36 -0800 Make it possible to use notImplemented outside of the WebCore namespace Currently, you have to do "using namespace Webcore" in order to use notImplemented() outside the WebCore namespace. Instead, we can just make a small tweak to the notImplemented() macro to avoid that. 105705 1 26714 fishd 2009-01-14 10:15:05 -0800 Created attachment 26714 v1 patch 105706 2 26714 darin 2009-01-14 10:17:19 -0800 Comment on attachment 26714 v1 patch If you're making the macro work in other namespaces, then I suggest ::WebCore::LogNotYetImplemented is even slightly better. r=me 105711 3 fishd 2009-01-14 10:25:23 -0800 good idea! 105714 4 fishd 2009-01-14 10:35:12 -0800 http://trac.webkit.org/changeset/39894 26714 2009-01-14 10:15:05 -0800 2009-01-14 10:17:19 -0800 v1 patch not_1.diff text/plain 1166 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM5ODkx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDEt MTQgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBFcmljIFNlaWRlbC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjMzMjAKKyAgICAgICAgTWFrZSBpdCBwb3NzaWJsZSB0byB1c2Ugbm90SW1w bGVtZW50ZWQgb3V0c2lkZSBvZiB0aGUgV2ViQ29yZSBuYW1lc3BhY2UKKworICAgICAgICAqIHBs YXRmb3JtL05vdEltcGxlbWVudGVkLmg6CisKIDIwMDktMDEtMTQgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJ bmRleDogcGxhdGZvcm0vTm90SW1wbGVtZW50ZWQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwbGF0Zm9ybS9O b3RJbXBsZW1lbnRlZC5oCShyZXZpc2lvbiAzOTg5MSkKKysrIHBsYXRmb3JtL05vdEltcGxlbWVu dGVkLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDcgKzQ1LDcgQEAKICNkZWZpbmUgbm90SW1wbGVt ZW50ZWQoKSBkbyB7IFwKICAgICAgICAgc3RhdGljIGJvb2wgaGF2ZVByaW50ZWQgPSBmYWxzZTsg XAogICAgICAgICBpZiAoIWhhdmVQcmludGVkICYmICFzdXByZXNzTm90SW1wbGVtZW50ZWRXYXJu aW5nKCkpIHsgXAotICAgICAgICAgICAgV1RGTG9nVmVyYm9zZShfX0ZJTEVfXywgX19MSU5FX18s IFdURl9QUkVUVFlfRlVOQ1RJT04sICZMb2dOb3RZZXRJbXBsZW1lbnRlZCwgIlVOSU1QTEVNRU5U RUQ6ICIpOyBcCisgICAgICAgICAgICBXVEZMb2dWZXJib3NlKF9fRklMRV9fLCBfX0xJTkVfXywg V1RGX1BSRVRUWV9GVU5DVElPTiwgJldlYkNvcmU6OkxvZ05vdFlldEltcGxlbWVudGVkLCAiVU5J TVBMRU1FTlRFRDogIik7IFwKICAgICAgICAgICAgIGhhdmVQcmludGVkID0gdHJ1ZTsgXAogICAg ICAgICB9IFwKICAgICB9IHdoaWxlICgwKQo=