233168 2021-11-15 20:38:30 -0800 Use IOHIDEvent timestamps for momentum velocity computation 2021-11-16 14:06:25 -0800 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser cmarcelo ews-watchlist fred.wang jamesr luiz simon.fraser thorton tonikitoo webkit-bug-importer oldest_to_newest 1815334 0 simon.fraser 2021-11-15 20:38:30 -0800 Use IOHIDEvent timestamps for momentum velocity computation 1815335 1 444338 simon.fraser 2021-11-15 20:40:17 -0800 Created attachment 444338 Patch 1815351 2 444338 thorton 2021-11-15 21:51:55 -0800 Comment on attachment 444338 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444338&action=review > Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp:-340 > - LOG_WITH_STREAM(ScrollAnimations, stream << "ThreadedScrollingTree::willStartRenderingUpdate - scrollingThreadIsActive " << scrollingThreadIsActive()); Where'd this go? 1815630 3 simon.fraser 2021-11-16 13:57:45 -0800 (In reply to Tim Horton from comment #2) > Comment on attachment 444338 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444338&action=review > > > Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp:-340 > > - LOG_WITH_STREAM(ScrollAnimations, stream << "ThreadedScrollingTree::willStartRenderingUpdate - scrollingThreadIsActive " << scrollingThreadIsActive()); > > Where'd this go? It annoyed me so I removed it. 1815634 4 ews-feeder 2021-11-16 14:05:08 -0800 Committed r285883 (244308@main): <https://commits.webkit.org/244308@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444338. 1815635 5 webkit-bug-importer 2021-11-16 14:06:25 -0800 <rdar://problem/85474517> 444338 2021-11-15 20:40:17 -0800 2021-11-16 14:05:09 -0800 Patch bug-233168-20211115204016.patch text/plain 5645 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1Nzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGUwOWY5NTk5ZDBmNWM4 N2EzNWIyNTRiZjUyNzNhZTZjMzZmZTI4YS4uMjNmMzk3MGE0ZmI4NzAxNmEwYTQyNDNkNTE4Y2Vi YjQyM2UyMWZlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTExLTE1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBJT0hJREV2 ZW50IHRpbWVzdGFtcHMgZm9yIG1vbWVudHVtIHZlbG9jaXR5IGNvbXB1dGF0aW9uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzMxNjgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOU0V2ZW50IHRpbWV0YW1w cyBjYW4gaGF2ZSBzb21lIGppdHRlciBvbiBzb21lIGRldmljZXMgKHJkYXI6Ly84NTMwOTYzOSkg c28gZHJvcAorICAgICAgICBkb3duIHRvIElPSElERXZlbnQgdGltZXN0YW1wcyB3aGVuIGNvbXB1 dGluZyB0aGUgaW5pdGlhbCB2ZWxvY2l0eSBmb3IgYSBtb21lbnR1bQorICAgICAgICBzY3JvbGwg YW5pbWF0aW9uLCBmb3IgaW1wcm92ZWQgYWNjdXJhY3kuCisKKyAgICAgICAgKiBwYWdlL21hYy9X aGVlbEV2ZW50RGVsdGFGaWx0ZXJNYWMuaDoKKyAgICAgICAgKiBwYWdlL21hYy9XaGVlbEV2ZW50 RGVsdGFGaWx0ZXJNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpXaGVlbEV2ZW50RGVsdGFGaWx0 ZXJNYWM6OnVwZGF0ZUZyb21FdmVudCk6CisgICAgICAgIChXZWJDb3JlOjpXaGVlbEV2ZW50RGVs dGFGaWx0ZXJNYWM6OnJlc2V0KToKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9UaHJlYWRlZFNj cm9sbGluZ1RyZWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGhyZWFkZWRTY3JvbGxpbmdUcmVl Ojp3aWxsU3RhcnRSZW5kZXJpbmdVcGRhdGUpOgorCiAyMDIxLTExLTE0ICBTaW1vbiBGcmFzZXIg IDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEZpbmdlcnMgZG93biBvbiB0aGUg dHJhY2twYWQgc2hvdWxkIHN0b3AgYW4gYW5pbWF0ZWQgc2Nyb2xsCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL21hYy9XaGVlbEV2ZW50RGVsdGFGaWx0ZXJNYWMuaCBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvbWFjL1doZWVsRXZlbnREZWx0YUZpbHRlck1hYy5oCmluZGV4IDc1ZmFmYjMz YjM1MzBiZWY1ZGUxYmU2OWVjYmQ2MDZkNDk1ZjkxNWEuLjljYmI1Y2RmNWNkMjQ1MzMyYWQ2NjUy NDYwYjkwMGJlYTNiNjVmY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvbWFjL1do ZWVsRXZlbnREZWx0YUZpbHRlck1hYy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvbWFjL1do ZWVsRXZlbnREZWx0YUZpbHRlck1hYy5oCkBAIC00Nyw2ICs0Nyw3IEBAIHByaXZhdGU6CiAKICAg ICBSZXRhaW5QdHI8X05TU2Nyb2xsaW5nUHJlZG9taW5hbnRBeGlzRmlsdGVyPiBtX3ByZWRvbWlu YW50QXhpc0ZpbHRlcjsKICAgICBXYWxsVGltZSBtX2luaXRpYWxXYWxsVGltZTsKKyAgICBXYWxs VGltZSBtX2xhc3RJT0hJREV2ZW50VGltZXN0YW1wOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2Vi Q29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9tYWMvV2hlZWxFdmVudERlbHRh RmlsdGVyTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGFnZS9tYWMvV2hlZWxFdmVudERlbHRhRmls dGVyTWFjLm1tCmluZGV4IDQxYzExNWE3ODhhZjE1ODYwNjJkMDY2NTAwODJlMjBjNzdiNjA5ZTMu LjU4ZGQwZWViODAyMmMwN2Y0ZjNiOTBjOGJjOTdlZDZjMjRiNDJkNjIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvbWFjL1doZWVsRXZlbnREZWx0YUZpbHRlck1hYy5tbQorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL21hYy9XaGVlbEV2ZW50RGVsdGFGaWx0ZXJNYWMubW0KQEAgLTI5 LDYgKzI5LDcgQEAKICNpbXBvcnQgIldoZWVsRXZlbnREZWx0YUZpbHRlck1hYy5oIgogCiAjaW1w b3J0ICJGbG9hdFBvaW50LmgiCisjaW1wb3J0ICJMb2dnaW5nLmgiCiAjaW1wb3J0ICJQbGF0Zm9y bVdoZWVsRXZlbnQuaCIKICNpbXBvcnQgPHBhbC9zcGkvbWFjL05TU2Nyb2xsaW5nSW5wdXRGaWx0 ZXJTUEkuaD4KIApAQCAtNDMsMzMgKzQ0LDUyIEBAIFdoZWVsRXZlbnREZWx0YUZpbHRlck1hYzo6 V2hlZWxFdmVudERlbHRhRmlsdGVyTWFjKCkKIAogdm9pZCBXaGVlbEV2ZW50RGVsdGFGaWx0ZXJN YWM6OnVwZGF0ZUZyb21FdmVudChjb25zdCBQbGF0Zm9ybVdoZWVsRXZlbnQmIGV2ZW50KQogewot ICAgIGlmIChldmVudC5tb21lbnR1bVBoYXNlKCkgIT0gUGxhdGZvcm1XaGVlbEV2ZW50UGhhc2U6 Ok5vbmUpCisgICAgaWYgKGV2ZW50Lm1vbWVudHVtUGhhc2UoKSAhPSBQbGF0Zm9ybVdoZWVsRXZl bnRQaGFzZTo6Tm9uZSkgeworICAgICAgICBtX2xhc3RJT0hJREV2ZW50VGltZXN0YW1wID0gZXZl bnQuaW9ISURFdmVudFRpbWVzdGFtcCgpOwogICAgICAgICByZXR1cm47CisgICAgfQogCiAgICAg Ly8gVGhlIGFic29sdXRlIHZhbHVlIG9mIHRpbWVzdGFtcCBkb2Vzbid0IG1hdHRlcjsgdGhlIGZp bHRlciBsb29rcyBhdCBkZWx0YXMgZnJvbSB0aGUgcHJldmlvdXMgZXZlbnQuCiAgICAgYXV0byB0 aW1lc3RhbXAgPSBldmVudC50aW1lc3RhbXAoKSAtIG1faW5pdGlhbFdhbGxUaW1lOwogCiAgICAg c3dpdGNoIChldmVudC5waGFzZSgpKSB7CiAgICAgY2FzZSBQbGF0Zm9ybVdoZWVsRXZlbnRQaGFz ZTo6Tm9uZToKKyAgICBjYXNlIFBsYXRmb3JtV2hlZWxFdmVudFBoYXNlOjpFbmRlZDoKICAgICAg ICAgYnJlYWs7CiAKICAgICBjYXNlIFBsYXRmb3JtV2hlZWxFdmVudFBoYXNlOjpCZWdhbjoKKyAg ICAgICAgcmVzZXQoKTsKKyAgICAgICAgRkFMTFRIUk9VR0g7CiAgICAgY2FzZSBQbGF0Zm9ybVdo ZWVsRXZlbnRQaGFzZTo6Q2hhbmdlZDogewogICAgICAgICBOU1BvaW50IGZpbHRlcmVkRGVsdGFS ZXN1bHQ7CiAgICAgICAgIE5TUG9pbnQgZmlsdGVyZWRWZWxvY2l0eVJlc3VsdDsKIAogICAgICAg ICBbbV9wcmVkb21pbmFudEF4aXNGaWx0ZXIgZmlsdGVySW5wdXREZWx0YTp0b0Zsb2F0UG9pbnQo ZXZlbnQuZGVsdGEoKSkgdGltZXN0YW1wOnRpbWVzdGFtcC5zZWNvbmRzKCkgb3V0cHV0RGVsdGE6 JmZpbHRlcmVkRGVsdGFSZXN1bHQgdmVsb2NpdHk6JmZpbHRlcmVkVmVsb2NpdHlSZXN1bHRdOwot ICAgICAgICBtX2N1cnJlbnRGaWx0ZXJlZFZlbG9jaXR5ID0gdG9GbG9hdFNpemUoZmlsdGVyZWRW ZWxvY2l0eVJlc3VsdCk7CisgICAgICAgIGF1dG8gYXhpc0ZpbHRlcmVkVmVsb2NpdHkgPSB0b0Zs b2F0U2l6ZShmaWx0ZXJlZFZlbG9jaXR5UmVzdWx0KTsKICAgICAgICAgbV9jdXJyZW50RmlsdGVy ZWREZWx0YSA9IHRvRmxvYXRTaXplKGZpbHRlcmVkRGVsdGFSZXN1bHQpOworCisgICAgICAgIC8v IFVzZSBhIDFtcyBtaW5pbXVtIHRvIGF2b2lkIGRpdmlkZSBieSB6ZXJvLiBUaGUgdXN1YWwgY2Fk ZW5jZSBvZiB0aGVzZSBldmVudHMgbWF0Y2hlcyBzY3JlZW4gcmVmcmVzaCByYXRlLgorICAgICAg ICBhdXRvIGRlbHRhRnJvbUxhc3RFdmVudCA9IHN0ZDo6bWF4KGV2ZW50LmlvSElERXZlbnRUaW1l c3RhbXAoKSAtIG1fbGFzdElPSElERXZlbnRUaW1lc3RhbXAsIDFfbXMpOworICAgICAgICBtX2N1 cnJlbnRGaWx0ZXJlZFZlbG9jaXR5ID0gZXZlbnQuZGVsdGEoKSAvIGRlbHRhRnJvbUxhc3RFdmVu dC5zZWNvbmRzKCk7CisKKyAgICAgICAgLy8gQXBwbHkgdGhlIGF4aXMtbG9ja2luZyB0aGF0IG1f cHJlZG9taW5hbnRBeGlzRmlsdGVyIGRvZXMuCisgICAgICAgIGlmICghYXhpc0ZpbHRlcmVkVmVs b2NpdHkud2lkdGgoKSkKKyAgICAgICAgICAgIG1fY3VycmVudEZpbHRlcmVkVmVsb2NpdHkuc2V0 V2lkdGgoMCk7CisgICAgICAgIGlmICghYXhpc0ZpbHRlcmVkVmVsb2NpdHkuaGVpZ2h0KCkpCisg ICAgICAgICAgICBtX2N1cnJlbnRGaWx0ZXJlZFZlbG9jaXR5LnNldEhlaWdodCgwKTsKKworICAg ICAgICBMT0coU2Nyb2xsQW5pbWF0aW9ucywgIldoZWVsRXZlbnREZWx0YUZpbHRlck1hYzo6dXBk YXRlRnJvbUV2ZW50OiBfTlNTY3JvbGxpbmdQcmVkb21pbmFudEF4aXNGaWx0ZXIgdmVsb2NpdHkg JS4yZiwgJTJmLCBJT0hJREV2ZW50IHZlbG9jaXR5ICUuMmYsJS4yZiIsCisgICAgICAgICAgICBh eGlzRmlsdGVyZWRWZWxvY2l0eS53aWR0aCgpLCBheGlzRmlsdGVyZWRWZWxvY2l0eS5oZWlnaHQo KSwgbV9jdXJyZW50RmlsdGVyZWRWZWxvY2l0eS53aWR0aCgpLCBtX2N1cnJlbnRGaWx0ZXJlZFZl bG9jaXR5LmhlaWdodCgpKTsKICAgICAgICAgYnJlYWs7CiAgICAgfQogICAgIGNhc2UgUGxhdGZv cm1XaGVlbEV2ZW50UGhhc2U6Ok1heUJlZ2luOgogICAgIGNhc2UgUGxhdGZvcm1XaGVlbEV2ZW50 UGhhc2U6OkNhbmNlbGxlZDoKICAgICBjYXNlIFBsYXRmb3JtV2hlZWxFdmVudFBoYXNlOjpTdGF0 aW9uYXJ5OgotICAgIGNhc2UgUGxhdGZvcm1XaGVlbEV2ZW50UGhhc2U6OkVuZGVkOgogICAgICAg ICByZXNldCgpOwogICAgICAgICBicmVhazsKICAgICB9CisKKyAgICBtX2xhc3RJT0hJREV2ZW50 VGltZXN0YW1wID0gZXZlbnQuaW9ISURFdmVudFRpbWVzdGFtcCgpOwogfQogCiB2b2lkIFdoZWVs RXZlbnREZWx0YUZpbHRlck1hYzo6cmVzZXQoKQpAQCAtNzcsNiArOTcsNyBAQCB2b2lkIFdoZWVs RXZlbnREZWx0YUZpbHRlck1hYzo6cmVzZXQoKQogICAgIFttX3ByZWRvbWluYW50QXhpc0ZpbHRl ciByZXNldF07CiAgICAgbV9jdXJyZW50RmlsdGVyZWRWZWxvY2l0eSA9IHsgfTsKICAgICBtX2N1 cnJlbnRGaWx0ZXJlZERlbHRhID0geyB9OworICAgIG1fbGFzdElPSElERXZlbnRUaW1lc3RhbXAg PSB7IH07CiB9CiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5n L1RocmVhZGVkU2Nyb2xsaW5nVHJlZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGlu Zy9UaHJlYWRlZFNjcm9sbGluZ1RyZWUuY3BwCmluZGV4IGIwYjM0ZGY4NWUyM2M5Mjg3MDU4OWU1 OGQ3YzA5YmFjZDA1MGNkMjQuLmQwMmUzNjk5NWRiMDA5YjE2M2I0MzIzMmE5Njc3ZTRjMzI0YmZh NWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1RocmVhZGVkU2Ny b2xsaW5nVHJlZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFk ZWRTY3JvbGxpbmdUcmVlLmNwcApAQCAtMzM3LDggKzMzNyw2IEBAIHZvaWQgVGhyZWFkZWRTY3Jv bGxpbmdUcmVlOjp3aWxsU3RhcnRSZW5kZXJpbmdVcGRhdGUoKQogewogICAgIEFTU0VSVChpc01h aW5UaHJlYWQoKSk7CiAKLSAgICBMT0dfV0lUSF9TVFJFQU0oU2Nyb2xsQW5pbWF0aW9ucywgc3Ry ZWFtIDw8ICJUaHJlYWRlZFNjcm9sbGluZ1RyZWU6OndpbGxTdGFydFJlbmRlcmluZ1VwZGF0ZSAt IHNjcm9sbGluZ1RocmVhZElzQWN0aXZlICIgPDwgc2Nyb2xsaW5nVGhyZWFkSXNBY3RpdmUoKSk7 Ci0KICAgICBpZiAoIXNjcm9sbGluZ1RocmVhZElzQWN0aXZlKCkpCiAgICAgICAgIHJldHVybjsK IAo=