233150 2021-11-15 14:39:36 -0800 [LFC][IFC] Fix fast/text/basic/005.html 2021-11-16 08:39:25 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1815222 0 zalan 2021-11-15 14:39:36 -0800 ssia 1815269 1 444316 zalan 2021-11-15 16:15:11 -0800 Created attachment 444316 Patch 1815449 2 444316 koivisto 2021-11-16 06:31:09 -0800 Comment on attachment 444316 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444316&action=review > Source/WebCore/ChangeLog:3 > + [LFC][IFC] Fix fast/text/basic/005.html (in context of preferred width computation) Someone might wonder why no test results change. 1815453 3 zalan 2021-11-16 06:40:56 -0800 (In reply to Antti Koivisto from comment #2) > Comment on attachment 444316 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444316&action=review > > > Source/WebCore/ChangeLog:3 > > + [LFC][IFC] Fix fast/text/basic/005.html > > (in context of preferred width computation) > > Someone might wonder why no test results change. good point 1815467 4 444377 zalan 2021-11-16 07:25:15 -0800 Created attachment 444377 Patch 1815506 5 ews-feeder 2021-11-16 08:38:59 -0800 Committed r285863 (244289@main): <https://commits.webkit.org/244289@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444377. 1815507 6 webkit-bug-importer 2021-11-16 08:39:25 -0800 <rdar://problem/85459713> 444316 2021-11-15 16:15:11 -0800 2021-11-16 07:25:13 -0800 Patch bug-233150-20211115161510.patch text/plain 3501 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1ODI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzI5MmIzODIwNTJiZWRm YTk3OTVmYmU3YWZjNTA3YTIxYmQyMDIzYi4uMmIxYjY1MGVhYzlmMjk3MDQ0NDc2OWZmZWQ0YmI0 YTI0OTYzY2YyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTExLTE1ICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJRkNdIEZpeCBmYXN0 L3RleHQvYmFzaWMvMDA1Lmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIzMzE1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5lZ2F0aXZlIHdvcmQtc3BhY2luZyBhY3RzIGFzIG5lZ2F0aXZlIG1hcmdp biwgcHVsbGluZyB0aGUgY29udGVudCB0byB0aGUgbGVmdC4gSW4gdGhpcyBwYXRjaCB3ZSBhY2Nv dW50IGZvciBzdWNoIG5lZ2F0aXZlIHZhbHVlcyB3aGVuCisgICAgICAgIGNvbXB1dGluZyB0aGUg b3ZlcmFsbCBjb250ZW50IHdpZHRoLgorCisgICAgICAgICogbGF5b3V0L2Zvcm1hdHRpbmdDb250 ZXh0cy9pbmxpbmUvSW5saW5lTGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6Okxp bmU6OmFwcGVuZFRleHRDb250ZW50KToKKwogMjAyMS0xMS0xNSAgQWxhbiBCdWp0YXMgIDx6YWxh bkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBGaXggZmFzdC90ZXh0L2xldHRlci1z cGFjaW5nLW5lZ2F0aXZlLW9wYWNpdHkuaHRtbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGluZS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lLmNwcApp bmRleCAyZTJlYjg5YTI1NjNhNDlkZDE3OWMzNzRlMjc1NmIyNmVjMmQwMGZhLi5hZDJhYjQ5YzZm MjVhMGI1NGFkNDkxOWYzYTI2Y2Q0YjBkMWUyMmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5l LmNwcApAQCAtMzQzLDE3ICszNDMsMjcgQEAgdm9pZCBMaW5lOjphcHBlbmRUZXh0Q29udGVudChj b25zdCBJbmxpbmVUZXh0SXRlbSYgaW5saW5lVGV4dEl0ZW0sIGNvbnN0IFJlbmRlclMKICAgICAg ICAgYXV0byBjb250ZW50TG9naWNhbFJpZ2h0ID0gcnVuTG9naWNhbExlZnQgKyBsb2dpY2FsV2lk dGggKyBtX2Nsb25lZEVuZERlY29yYXRpb25XaWR0aEZvcklubGluZUJveFJ1bnM7CiAgICAgICAg IG1fY29udGVudExvZ2ljYWxXaWR0aCA9IHN0ZDo6bWF4KG9sZENvbnRlbnRMb2dpY2FsV2lkdGgs IGNvbnRlbnRMb2dpY2FsUmlnaHQpOwogICAgIH0gZWxzZSBpZiAoc3R5bGUubGV0dGVyU3BhY2lu ZygpID49IDApIHsKLSAgICAgICAgbV9ydW5zLmxhc3QoKS5leHBhbmQoaW5saW5lVGV4dEl0ZW0s IGxvZ2ljYWxXaWR0aCk7Ci0gICAgICAgIG1fY29udGVudExvZ2ljYWxXaWR0aCArPSBsb2dpY2Fs V2lkdGg7CisgICAgICAgIGF1dG8mIGxhc3RSdW4gPSBtX3J1bnMubGFzdCgpOworICAgICAgICBs YXN0UnVuLmV4cGFuZChpbmxpbmVUZXh0SXRlbSwgbG9naWNhbFdpZHRoKTsKKyAgICAgICAgLy8g RW5zdXJlIHRoYXQgcHJvcGVydHkgdmFsdWVzIHRoYXQgYWN0IGxpa2UgbmVnYXRpdmUgbWFyZ2lu IGFyZSBub3QgbWFraW5nIHRoZSBsaW5lIHdpZGVyLgorICAgICAgICBtX2NvbnRlbnRMb2dpY2Fs V2lkdGggPSBzdGQ6Om1heChvbGRDb250ZW50TG9naWNhbFdpZHRoLCBsYXN0UnVuLmxvZ2ljYWxS aWdodCgpKTsKICAgICB9IGVsc2UgewogICAgICAgICBhdXRvJiBsYXN0UnVuID0gbV9ydW5zLmxh c3QoKTsKICAgICAgICAgQVNTRVJUKGxhc3RSdW4uaXNUZXh0KCkpOwogICAgICAgICAvLyBOZWdh dGl2ZSBsZXR0ZXIgc3BhY2luZyBzaG91bGQgb25seSBzaG9ydGVuIHRoZSBjb250ZW50IHRvIHRo ZSBib3VuZGFyeSBvZiB0aGUgcHJldmlvdXMgcnVuLgogICAgICAgICAvLyBGSVhNRTogV2UgbWF5 IG5lZWQgdG8gdHJhdmVyc2UgYWxsIHRoZSB3YXkgdG8gdGhlIHByZXZpb3VzIG5vbi10ZXh0IHJ1 biAob3IgZXZlbiBhY3Jvc3MgaW5saW5lIGJveGVzKS4KLSAgICAgICAgYXV0byBsYXN0UnVuTG9n aWNhbFdpZHRoID0gbGFzdFJ1bi5sb2dpY2FsV2lkdGgoKTsKLSAgICAgICAgYXV0byBjb250ZW50 V2lkdGhXaXRob3V0TGFzdFRleHRSdW4gPSBtX2NvbnRlbnRMb2dpY2FsV2lkdGggLSBzdGQ6Om1h eCgwLmYsIGxhc3RSdW5Mb2dpY2FsV2lkdGgpOworICAgICAgICBhdXRvIGNvbnRlbnRXaWR0aFdp dGhvdXRMYXN0VGV4dFJ1biA9IFsmXSB7CisgICAgICAgICAgICBpZiAoc3R5bGUuZm9udENhc2Nh ZGUoKS53b3JkU3BhY2luZygpID49IDApCisgICAgICAgICAgICAgICAgcmV0dXJuIG1fY29udGVu dExvZ2ljYWxXaWR0aCAtIHN0ZDo6bWF4KDAuZiwgbGFzdFJ1bi5sb2dpY2FsV2lkdGgoKSk7Cisg ICAgICAgICAgICAvLyBGSVhNRTogTGV0J3Mgc2VlIGlmIHdlIG5lZWQgdG8gb3B0aW1pemUgZm9y IHRoaXMgaXMgdGhlIHJhcmUgY2FzZSBvZiBib3RoIGxldHRlciBhbmQgd29yZCBzcGFjaW5nIGJl aW5nIG5lZ2F0aXZlLgorICAgICAgICAgICAgYXV0byByaWdodE1vc3RQb3NpdGlvbiA9IElubGlu ZUxheW91dFVuaXQgeyB9OworICAgICAgICAgICAgZm9yIChhdXRvJiBydW4gOiBtYWtlUmV2ZXJz ZWRSYW5nZShtX3J1bnMpKQorICAgICAgICAgICAgICAgIHJpZ2h0TW9zdFBvc2l0aW9uID0gc3Rk OjptYXgocmlnaHRNb3N0UG9zaXRpb24sIHJ1bi5sb2dpY2FsUmlnaHQoKSk7CisgICAgICAgICAg ICByZXR1cm4gc3RkOjptYXgoMC5mLCByaWdodE1vc3RQb3NpdGlvbik7CisgICAgICAgIH0oKTsK KyAgICAgICAgYXV0byBsYXN0UnVuTG9naWNhbFJpZ2h0ID0gbGFzdFJ1bi5sb2dpY2FsUmlnaHQo KTsKICAgICAgICAgbGFzdFJ1bi5leHBhbmQoaW5saW5lVGV4dEl0ZW0sIGxvZ2ljYWxXaWR0aCk7 Ci0gICAgICAgIG1fY29udGVudExvZ2ljYWxXaWR0aCA9IHN0ZDo6bWF4KGNvbnRlbnRXaWR0aFdp dGhvdXRMYXN0VGV4dFJ1biwgbGFzdFJ1bkxvZ2ljYWxXaWR0aCArIGxvZ2ljYWxXaWR0aCk7Cisg ICAgICAgIG1fY29udGVudExvZ2ljYWxXaWR0aCA9IHN0ZDo6bWF4KGNvbnRlbnRXaWR0aFdpdGhv dXRMYXN0VGV4dFJ1biwgbGFzdFJ1bkxvZ2ljYWxSaWdodCArIGxvZ2ljYWxXaWR0aCk7CiAgICAg fQogCiAgICAgLy8gSGFuZGxlIHRyYWlsaW5nIGNvbnRlbnQsIHNwZWNpZmljYWxseSB3aGl0ZXNw YWNlIGFuZCBsZXR0ZXIgc3BhY2luZy4K 444377 2021-11-16 07:25:15 -0800 2021-11-16 08:39:00 -0800 Patch bug-233150-20211116072515.patch text/plain 3590 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1ODYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTYyMjhmMmFjNDQ2NjJi ZjYyOTJiMWI2ZGEyOWIyZGI0OWRkNGEyZS4uODRlNTliMTMyMDc2MDk1MWY1M2ViZmY3MmIwZWVl ZDU2MmJhNzQ2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTExLTE2ICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJRkNdIEZpeCBmYXN0 L3RleHQvYmFzaWMvMDA1Lmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIzMzE1MAorCisgICAgICAgIFJldmlld2VkIGJ5IEFudHRpIEtvaXZpc3Rv LgorCisgICAgICAgIE5lZ2F0aXZlIHdvcmQtc3BhY2luZyBhY3RzIGFzIG5lZ2F0aXZlIG1hcmdp biwgcHVsbGluZyB0aGUgY29udGVudCB0byB0aGUgbGVmdC4gSW4gdGhpcyBwYXRjaCB3ZSBhY2Nv dW50IGZvciBzdWNoIG5lZ2F0aXZlIHZhbHVlcyB3aGVuCisgICAgICAgIGNvbXB1dGluZyB0aGUg b3ZlcmFsbCBjb250ZW50IHdpZHRoLgorCisgICAgICAgIE5vdGUgdGhhdCB0aGlzIHBhdGNoIGlz IGluIHByZXBhcmF0aW9uIGZvciBlbmFibGluZyBJRkMgcHJlZmVycmVkIHdpZHRoIGNvbXB1dGF0 aW9uLgorCisgICAgICAgICogbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5l TGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmU6OmFwcGVuZFRleHRDb250 ZW50KToKKwogMjAyMS0xMS0xNiAgQWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW0xGQ11bSUZDXSBGaXggZmFzdC90ZXh0L3RleHQtaW5kZW50LWluc2lkZS1mbG9hdC5o dG1sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRz L2lubGluZS9JbmxpbmVMaW5lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5n Q29udGV4dHMvaW5saW5lL0lubGluZUxpbmUuY3BwCmluZGV4IDJlMmViODlhMjU2M2E0OWRkMTc5 YzM3NGUyNzU2YjI2ZWMyZDAwZmEuLmFkMmFiNDljNmYyNWEwYjU0YWQ0OTE5ZjNhMjZjZDRiMGQx ZTIyYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4 dHMvaW5saW5lL0lubGluZUxpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3Jt YXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxpbmUuY3BwCkBAIC0zNDMsMTcgKzM0MywyNyBA QCB2b2lkIExpbmU6OmFwcGVuZFRleHRDb250ZW50KGNvbnN0IElubGluZVRleHRJdGVtJiBpbmxp bmVUZXh0SXRlbSwgY29uc3QgUmVuZGVyUwogICAgICAgICBhdXRvIGNvbnRlbnRMb2dpY2FsUmln aHQgPSBydW5Mb2dpY2FsTGVmdCArIGxvZ2ljYWxXaWR0aCArIG1fY2xvbmVkRW5kRGVjb3JhdGlv bldpZHRoRm9ySW5saW5lQm94UnVuczsKICAgICAgICAgbV9jb250ZW50TG9naWNhbFdpZHRoID0g c3RkOjptYXgob2xkQ29udGVudExvZ2ljYWxXaWR0aCwgY29udGVudExvZ2ljYWxSaWdodCk7CiAg ICAgfSBlbHNlIGlmIChzdHlsZS5sZXR0ZXJTcGFjaW5nKCkgPj0gMCkgewotICAgICAgICBtX3J1 bnMubGFzdCgpLmV4cGFuZChpbmxpbmVUZXh0SXRlbSwgbG9naWNhbFdpZHRoKTsKLSAgICAgICAg bV9jb250ZW50TG9naWNhbFdpZHRoICs9IGxvZ2ljYWxXaWR0aDsKKyAgICAgICAgYXV0byYgbGFz dFJ1biA9IG1fcnVucy5sYXN0KCk7CisgICAgICAgIGxhc3RSdW4uZXhwYW5kKGlubGluZVRleHRJ dGVtLCBsb2dpY2FsV2lkdGgpOworICAgICAgICAvLyBFbnN1cmUgdGhhdCBwcm9wZXJ0eSB2YWx1 ZXMgdGhhdCBhY3QgbGlrZSBuZWdhdGl2ZSBtYXJnaW4gYXJlIG5vdCBtYWtpbmcgdGhlIGxpbmUg d2lkZXIuCisgICAgICAgIG1fY29udGVudExvZ2ljYWxXaWR0aCA9IHN0ZDo6bWF4KG9sZENvbnRl bnRMb2dpY2FsV2lkdGgsIGxhc3RSdW4ubG9naWNhbFJpZ2h0KCkpOwogICAgIH0gZWxzZSB7CiAg ICAgICAgIGF1dG8mIGxhc3RSdW4gPSBtX3J1bnMubGFzdCgpOwogICAgICAgICBBU1NFUlQobGFz dFJ1bi5pc1RleHQoKSk7CiAgICAgICAgIC8vIE5lZ2F0aXZlIGxldHRlciBzcGFjaW5nIHNob3Vs ZCBvbmx5IHNob3J0ZW4gdGhlIGNvbnRlbnQgdG8gdGhlIGJvdW5kYXJ5IG9mIHRoZSBwcmV2aW91 cyBydW4uCiAgICAgICAgIC8vIEZJWE1FOiBXZSBtYXkgbmVlZCB0byB0cmF2ZXJzZSBhbGwgdGhl IHdheSB0byB0aGUgcHJldmlvdXMgbm9uLXRleHQgcnVuIChvciBldmVuIGFjcm9zcyBpbmxpbmUg Ym94ZXMpLgotICAgICAgICBhdXRvIGxhc3RSdW5Mb2dpY2FsV2lkdGggPSBsYXN0UnVuLmxvZ2lj YWxXaWR0aCgpOwotICAgICAgICBhdXRvIGNvbnRlbnRXaWR0aFdpdGhvdXRMYXN0VGV4dFJ1biA9 IG1fY29udGVudExvZ2ljYWxXaWR0aCAtIHN0ZDo6bWF4KDAuZiwgbGFzdFJ1bkxvZ2ljYWxXaWR0 aCk7CisgICAgICAgIGF1dG8gY29udGVudFdpZHRoV2l0aG91dExhc3RUZXh0UnVuID0gWyZdIHsK KyAgICAgICAgICAgIGlmIChzdHlsZS5mb250Q2FzY2FkZSgpLndvcmRTcGFjaW5nKCkgPj0gMCkK KyAgICAgICAgICAgICAgICByZXR1cm4gbV9jb250ZW50TG9naWNhbFdpZHRoIC0gc3RkOjptYXgo MC5mLCBsYXN0UnVuLmxvZ2ljYWxXaWR0aCgpKTsKKyAgICAgICAgICAgIC8vIEZJWE1FOiBMZXQn cyBzZWUgaWYgd2UgbmVlZCB0byBvcHRpbWl6ZSBmb3IgdGhpcyBpcyB0aGUgcmFyZSBjYXNlIG9m IGJvdGggbGV0dGVyIGFuZCB3b3JkIHNwYWNpbmcgYmVpbmcgbmVnYXRpdmUuCisgICAgICAgICAg ICBhdXRvIHJpZ2h0TW9zdFBvc2l0aW9uID0gSW5saW5lTGF5b3V0VW5pdCB7IH07CisgICAgICAg ICAgICBmb3IgKGF1dG8mIHJ1biA6IG1ha2VSZXZlcnNlZFJhbmdlKG1fcnVucykpCisgICAgICAg ICAgICAgICAgcmlnaHRNb3N0UG9zaXRpb24gPSBzdGQ6Om1heChyaWdodE1vc3RQb3NpdGlvbiwg cnVuLmxvZ2ljYWxSaWdodCgpKTsKKyAgICAgICAgICAgIHJldHVybiBzdGQ6Om1heCgwLmYsIHJp Z2h0TW9zdFBvc2l0aW9uKTsKKyAgICAgICAgfSgpOworICAgICAgICBhdXRvIGxhc3RSdW5Mb2dp Y2FsUmlnaHQgPSBsYXN0UnVuLmxvZ2ljYWxSaWdodCgpOwogICAgICAgICBsYXN0UnVuLmV4cGFu ZChpbmxpbmVUZXh0SXRlbSwgbG9naWNhbFdpZHRoKTsKLSAgICAgICAgbV9jb250ZW50TG9naWNh bFdpZHRoID0gc3RkOjptYXgoY29udGVudFdpZHRoV2l0aG91dExhc3RUZXh0UnVuLCBsYXN0UnVu TG9naWNhbFdpZHRoICsgbG9naWNhbFdpZHRoKTsKKyAgICAgICAgbV9jb250ZW50TG9naWNhbFdp ZHRoID0gc3RkOjptYXgoY29udGVudFdpZHRoV2l0aG91dExhc3RUZXh0UnVuLCBsYXN0UnVuTG9n aWNhbFJpZ2h0ICsgbG9naWNhbFdpZHRoKTsKICAgICB9CiAKICAgICAvLyBIYW5kbGUgdHJhaWxp bmcgY29udGVudCwgc3BlY2lmaWNhbGx5IHdoaXRlc3BhY2UgYW5kIGxldHRlciBzcGFjaW5nLgo=