233134 2021-11-15 09:52:39 -0800 Remove some dead code from IPC::Encoder / IPC::Decoder 2021-11-15 12:06:29 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin ggaren kkinnunen sam webkit-bug-importer youennf oldest_to_newest 1815100 0 cdumez 2021-11-15 09:52:39 -0800 Remove some dead code from IPC::Encoder / IPC::Decoder. 1815102 1 444268 cdumez 2021-11-15 09:54:00 -0800 Created attachment 444268 Patch 1815140 2 ews-feeder 2021-11-15 11:20:00 -0800 Committed r285818 (244260@main): <https://commits.webkit.org/244260@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444268. 1815141 3 webkit-bug-importer 2021-11-15 11:23:44 -0800 <rdar://problem/85421330> 1815165 4 444268 darin 2021-11-15 12:06:29 -0800 Comment on attachment 444268 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444268&action=review > Source/WebKit/Platform/IPC/Decoder.h:63 > Decoder(const Decoder&) = delete; > Decoder(Decoder&&) = delete; > + Decoder& operator=(const Decoder&) = delete; > + Decoder& operator=(Decoder&&) = delete; I understand the elegance of explicitly deleting both the copy and move constructor and assignment operator, but keep in mind that if you delete the copy and don’t define a move you will get a compilation error just you would if it was deleted. So you don’t need to delete the move ones. > Source/WebKit/Platform/IPC/Encoder.h:52 > + Encoder(const Encoder&) = delete; > + Encoder(Encoder&&) = delete; > + Encoder& operator=(const Encoder&) = delete; > + Encoder& operator=(Encoder&&) = delete; Ditto. 444268 2021-11-15 09:54:00 -0800 2021-11-15 11:20:01 -0800 Patch bug-233134-20211115095400.patch text/plain 6402 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1ODA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ1OGRmMzlmNWEzYWUwZmYw YWUyMjI3N2YxYWEyNGViZGRhM2NlZGQuLjJmYzM3ODE1NGM1MzM3Yjk2OTZjZmQzYTNlYzljOTQ0 ZDQ4ZWFiNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMTEtMTUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgc29tZSBkZWFkIGNvZGUg ZnJvbSBJUEM6OkVuY29kZXIgLyBJUEM6OkRlY29kZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMzEzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBzb21lIGRlYWQgY29kZSBmcm9tIElQQzo6 RW5jb2RlciAvIElQQzo6RGVjb2RlciBhbmQgbWFrZSBzdXJlIGJvdGgKKyAgICAgICAgdHlwZXMg YXJlIG5vbi1jb3B5YWJsZSAvIG5vbi1tb3ZhYmxlLgorCisgICAgICAgICogUGxhdGZvcm0vSVBD L0RlY29kZXIuY3BwOgorICAgICAgICAqIFBsYXRmb3JtL0lQQy9EZWNvZGVyLmg6CisgICAgICAg IChJUEM6OkRlY29kZXI6OmRlY29kZVNpbmdsZU9iamVjdCk6IERlbGV0ZWQuCisgICAgICAgICgp OiBEZWxldGVkLgorICAgICAgICAqIFBsYXRmb3JtL0lQQy9FbmNvZGVyLmNwcDoKKyAgICAgICAg KElQQzo6RW5jb2Rlcjo6RW5jb2Rlcik6CisgICAgICAgICogUGxhdGZvcm0vSVBDL0VuY29kZXIu aDoKKwogMjAyMS0xMS0xNCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgR2V0IGRhZW1vbiBBUEkgcmVhZHkgdG8gd29yayBpbiB0aGUgaU9TIHNpbXVsYXRvciAo c3RhcnRpbmcgd2l0aCBXZWJQdXNoRCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZv cm0vSVBDL0RlY29kZXIuY3BwIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvRGVjb2Rlci5j cHAKaW5kZXggN2VmZTFmNmY4ZmM3MGNlMmQ5NGNhYTM3ZTUwMDI0MzE1MDZjZmUxZC4uM2MwYTE0 ZjgxZmZmNTNlZGI2Mjc1ZjkzODdiNTk2MzVlMDE2NjJiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9QbGF0Zm9ybS9JUEMvRGVjb2Rlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9y bS9JUEMvRGVjb2Rlci5jcHAKQEAgLTk0LDE2ICs5NCw2IEBAIERlY29kZXI6OkRlY29kZXIoY29u c3QgdWludDhfdCogYnVmZmVyLCBzaXplX3QgYnVmZmVyU2l6ZSwgdm9pZCAoKmJ1ZmZlckRlYWxs b2NhCiAgICAgICAgIHJldHVybjsKIH0KIAotRGVjb2Rlcjo6RGVjb2Rlcihjb25zdCB1aW50OF90 KiBidWZmZXIsIHNpemVfdCBidWZmZXJTaXplLCBDb25zdHJ1Y3RXaXRob3V0SGVhZGVyVGFnKQot ICAgIDogbV9idWZmZXIgeyBidWZmZXIgfQotICAgICwgbV9idWZmZXJQb3MgeyBtX2J1ZmZlciB9 Ci0gICAgLCBtX2J1ZmZlckVuZCB7IG1fYnVmZmVyICsgYnVmZmVyU2l6ZSB9Ci0gICAgLCBtX2J1 ZmZlckRlYWxsb2NhdG9yKFtdIChjb25zdCB1aW50OF90Kiwgc2l6ZV90KSB7IH0pCi17Ci0gICAg aWYgKFVOTElLRUxZKHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90PihtX2J1ZmZlcikgJSBhbGln bm9mKHVpbnQ2NF90KSkpCi0gICAgICAgIG1hcmtJbnZhbGlkKCk7Ci19Ci0KIERlY29kZXI6OkRl Y29kZXIoY29uc3QgdWludDhfdCogc3RyZWFtLCBzaXplX3Qgc3RyZWFtU2l6ZSwgdWludDY0X3Qg ZGVzdGluYXRpb25JRCkKICAgICA6IG1fYnVmZmVyIHsgc3RyZWFtIH0KICAgICAsIG1fYnVmZmVy UG9zIHsgbV9idWZmZXIgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMv RGVjb2Rlci5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvRGVjb2Rlci5oCmluZGV4IDZk NTUyMDI3NzVjOTY2NWI3ZWYxMGQzYTAyNTBjZmJkOWU3ZTVkZDEuLmIyNjVlYTZjZDkyNjRhZmMy MjQ5NTM5YTM1YjJkZTM5MTc3NGI5M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZv cm0vSVBDL0RlY29kZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9EZWNvZGVy LmgKQEAgLTU5LDYgKzU5LDggQEAgcHVibGljOgogCiAgICAgRGVjb2Rlcihjb25zdCBEZWNvZGVy JikgPSBkZWxldGU7CiAgICAgRGVjb2RlcihEZWNvZGVyJiYpID0gZGVsZXRlOworICAgIERlY29k ZXImIG9wZXJhdG9yPShjb25zdCBEZWNvZGVyJikgPSBkZWxldGU7CisgICAgRGVjb2RlciYgb3Bl cmF0b3I9KERlY29kZXImJikgPSBkZWxldGU7CiAKICAgICBSZWNlaXZlck5hbWUgbWVzc2FnZVJl Y2VpdmVyTmFtZSgpIGNvbnN0IHsgcmV0dXJuIHJlY2VpdmVyTmFtZShtX21lc3NhZ2VOYW1lKTsg fQogICAgIE1lc3NhZ2VOYW1lIG1lc3NhZ2VOYW1lKCkgY29uc3QgeyByZXR1cm4gbV9tZXNzYWdl TmFtZTsgfQpAQCAtMTQwLDI2ICsxNDIsMTEgQEAgcHVibGljOgogCiAgICAgYm9vbCByZW1vdmVB dHRhY2htZW50KEF0dGFjaG1lbnQmKTsKIAotICAgIHN0YXRpYyBjb25zdCBib29sIGlzSVBDRGVj b2RlciA9IHRydWU7Ci0KLSAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KLSAgICBzdGF0aWMgc3Rk OjpvcHRpb25hbDxUPiBkZWNvZGVTaW5nbGVPYmplY3QoY29uc3QgdWludDhfdCogc291cmNlLCBz aXplX3QgbnVtYmVyT2ZCeXRlcykKLSAgICB7Ci0gICAgICAgIHN0ZDo6b3B0aW9uYWw8VD4gcmVz dWx0OwotICAgICAgICBEZWNvZGVyIGRlY29kZXIoc291cmNlLCBudW1iZXJPZkJ5dGVzLCBDb25z dHJ1Y3RXaXRob3V0SGVhZGVyKTsKLSAgICAgICAgaWYgKCFkZWNvZGVyLmlzVmFsaWQoKSkKLSAg ICAgICAgICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7Ci0KLSAgICAgICAgZGVjb2RlciA+PiByZXN1 bHQ7Ci0gICAgICAgIHJldHVybiByZXN1bHQ7Ci0gICAgfQorICAgIHN0YXRpYyBjb25zdGV4cHIg Ym9vbCBpc0lQQ0RlY29kZXIgPSB0cnVlOwogCiBwcml2YXRlOgogICAgIERlY29kZXIoY29uc3Qg dWludDhfdCogYnVmZmVyLCBzaXplX3QgYnVmZmVyU2l6ZSwgdm9pZCAoKmJ1ZmZlckRlYWxsb2Nh dG9yKShjb25zdCB1aW50OF90Kiwgc2l6ZV90KSwgVmVjdG9yPEF0dGFjaG1lbnQ+JiYpOwogCi0g ICAgZW51bSBDb25zdHJ1Y3RXaXRob3V0SGVhZGVyVGFnIHsgQ29uc3RydWN0V2l0aG91dEhlYWRl ciB9OwotICAgIERlY29kZXIoY29uc3QgdWludDhfdCogYnVmZmVyLCBzaXplX3QgYnVmZmVyU2l6 ZSwgQ29uc3RydWN0V2l0aG91dEhlYWRlclRhZyk7Ci0KICAgICBib29sIGFsaWduQnVmZmVyUG9z aXRpb24oc2l6ZV90IGFsaWdubWVudCwgc2l6ZV90KTsKICAgICBib29sIGJ1ZmZlcklzTGFyZ2VF bm91Z2hUb0NvbnRhaW4oc2l6ZV90IGFsaWdubWVudCwgc2l6ZV90KSBjb25zdDsKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvRW5jb2Rlci5jcHAgYi9Tb3VyY2UvV2Vi S2l0L1BsYXRmb3JtL0lQQy9FbmNvZGVyLmNwcAppbmRleCA5ZjM2YWU3NTJjNzg3ZTQ5NmFlOWY3 MDI0NDkyZTk2NTU5NmY5NTk4Li4wYWM1ZGZkYTZkZTM5YTZlMDY2ZDRlMDkyOTViODllM2NmMmEx NzM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9FbmNvZGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9FbmNvZGVyLmNwcApAQCAtNjYsMjQgKzY2 LDEwIEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBmcmVlQnVmZmVyKHZvaWQqIGFkZHIsIHNpemVfdCBz aXplKQogRW5jb2Rlcjo6RW5jb2RlcihNZXNzYWdlTmFtZSBtZXNzYWdlTmFtZSwgdWludDY0X3Qg ZGVzdGluYXRpb25JRCkKICAgICA6IG1fbWVzc2FnZU5hbWUobWVzc2FnZU5hbWUpCiAgICAgLCBt X2Rlc3RpbmF0aW9uSUQoZGVzdGluYXRpb25JRCkKLSAgICAsIG1fYnVmZmVyKG1faW5saW5lQnVm ZmVyKQotICAgICwgbV9idWZmZXJQb2ludGVyKG1faW5saW5lQnVmZmVyKQotICAgICwgbV9idWZm ZXJTaXplKDApCi0gICAgLCBtX2J1ZmZlckNhcGFjaXR5KHNpemVvZihtX2lubGluZUJ1ZmZlcikp CiB7CiAgICAgZW5jb2RlSGVhZGVyKCk7CiB9CiAKLUVuY29kZXI6OkVuY29kZXIoQ29uc3RydWN0 V2l0aG91dEhlYWRlclRhZykKLSAgICA6IG1fbWVzc2FnZU5hbWUoKQotICAgICwgbV9kZXN0aW5h dGlvbklEKDApCi0gICAgLCBtX2J1ZmZlcihtX2lubGluZUJ1ZmZlcikKLSAgICAsIG1fYnVmZmVy UG9pbnRlcihtX2lubGluZUJ1ZmZlcikKLSAgICAsIG1fYnVmZmVyU2l6ZSgwKQotICAgICwgbV9i dWZmZXJDYXBhY2l0eShzaXplb2YobV9pbmxpbmVCdWZmZXIpKQotewotfQotCiBFbmNvZGVyOjp+ RW5jb2RlcigpCiB7CiAgICAgaWYgKG1fYnVmZmVyICE9IG1faW5saW5lQnVmZmVyKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvRW5jb2Rlci5oIGIvU291cmNlL1dlYktp dC9QbGF0Zm9ybS9JUEMvRW5jb2Rlci5oCmluZGV4IDY1NTc0MWUzZjVhMDkyZjk3ZTc0OTJiODU2 NGM4N2E3NWU5YWY4Y2MuLjhlYTA2NmFiODZjOTkxMGE2MWY1ZWI4OWEwYWFlNDM0Y2I0ZDVlN2Qg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0VuY29kZXIuaAorKysgYi9T b3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9FbmNvZGVyLmgKQEAgLTQ2LDYgKzQ2LDExIEBAIHB1 YmxpYzoKICAgICBFbmNvZGVyKE1lc3NhZ2VOYW1lLCB1aW50NjRfdCBkZXN0aW5hdGlvbklEKTsK ICAgICB+RW5jb2RlcigpOwogCisgICAgRW5jb2Rlcihjb25zdCBFbmNvZGVyJikgPSBkZWxldGU7 CisgICAgRW5jb2RlcihFbmNvZGVyJiYpID0gZGVsZXRlOworICAgIEVuY29kZXImIG9wZXJhdG9y PShjb25zdCBFbmNvZGVyJikgPSBkZWxldGU7CisgICAgRW5jb2RlciYgb3BlcmF0b3I9KEVuY29k ZXImJikgPSBkZWxldGU7CisKICAgICBSZWNlaXZlck5hbWUgbWVzc2FnZVJlY2VpdmVyTmFtZSgp IGNvbnN0IHsgcmV0dXJuIHJlY2VpdmVyTmFtZShtX21lc3NhZ2VOYW1lKTsgfQogICAgIE1lc3Nh Z2VOYW1lIG1lc3NhZ2VOYW1lKCkgY29uc3QgeyByZXR1cm4gbV9tZXNzYWdlTmFtZTsgfQogICAg IHVpbnQ2NF90IGRlc3RpbmF0aW9uSUQoKSBjb25zdCB7IHJldHVybiBtX2Rlc3RpbmF0aW9uSUQ7 IH0KQEAgLTc2LDI2ICs4MSw5IEBAIHB1YmxpYzoKICAgICBWZWN0b3I8QXR0YWNobWVudD4gcmVs ZWFzZUF0dGFjaG1lbnRzKCk7CiAgICAgdm9pZCByZXNlcnZlKHNpemVfdCk7CiAKLSAgICBzdGF0 aWMgY29uc3QgYm9vbCBpc0lQQ0VuY29kZXIgPSB0cnVlOwotCi0gICAgdGVtcGxhdGU8dHlwZW5h bWUgVD4KLSAgICBzdGF0aWMgUmVmUHRyPFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcj4gZW5jb2RlU2lu Z2xlT2JqZWN0KGNvbnN0IFQmIG9iamVjdCkKLSAgICB7Ci0gICAgICAgIEVuY29kZXIgZW5jb2Rl cihDb25zdHJ1Y3RXaXRob3V0SGVhZGVyKTsKLSAgICAgICAgZW5jb2RlciA8PCBvYmplY3Q7Ci0K LSAgICAgICAgaWYgKGVuY29kZXIuaGFzQXR0YWNobWVudHMoKSkgewotICAgICAgICAgICAgQVNT RVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgICAgICAgICByZXR1cm4gbnVsbHB0cjsKLSAgICAgICAg fQotCi0gICAgICAgIHJldHVybiBXZWJDb3JlOjpTaGFyZWRCdWZmZXI6OmNyZWF0ZShlbmNvZGVy LmJ1ZmZlcigpLCBlbmNvZGVyLmJ1ZmZlclNpemUoKSk7Ci0gICAgfQorICAgIHN0YXRpYyBjb25z dGV4cHIgYm9vbCBpc0lQQ0VuY29kZXIgPSB0cnVlOwogCiBwcml2YXRlOgotICAgIGVudW0gQ29u c3RydWN0V2l0aG91dEhlYWRlclRhZyB7IENvbnN0cnVjdFdpdGhvdXRIZWFkZXIgfTsKLSAgICBF bmNvZGVyKENvbnN0cnVjdFdpdGhvdXRIZWFkZXJUYWcpOwotCiAgICAgdWludDhfdCogZ3Jvdyhz aXplX3QgYWxpZ25tZW50LCBzaXplX3QpOwogCiAgICAgYm9vbCBoYXNBdHRhY2htZW50cygpIGNv bnN0OwpAQCAtMTA5LDExICs5NywxMSBAQCBwcml2YXRlOgogCiAgICAgdWludDhfdCBtX2lubGlu ZUJ1ZmZlcls1MTJdOwogCi0gICAgdWludDhfdCogbV9idWZmZXI7Ci0gICAgdWludDhfdCogbV9i dWZmZXJQb2ludGVyOworICAgIHVpbnQ4X3QqIG1fYnVmZmVyIHsgbV9pbmxpbmVCdWZmZXIgfTsK KyAgICB1aW50OF90KiBtX2J1ZmZlclBvaW50ZXIgeyBtX2lubGluZUJ1ZmZlciB9OwogICAgIAot ICAgIHNpemVfdCBtX2J1ZmZlclNpemU7Ci0gICAgc2l6ZV90IG1fYnVmZmVyQ2FwYWNpdHk7Cisg ICAgc2l6ZV90IG1fYnVmZmVyU2l6ZSB7IDAgfTsKKyAgICBzaXplX3QgbV9idWZmZXJDYXBhY2l0 eSB7IHNpemVvZihtX2lubGluZUJ1ZmZlcikgfTsKIAogICAgIFZlY3RvcjxBdHRhY2htZW50PiBt X2F0dGFjaG1lbnRzOwogfTsK