<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>233100</bug_id>
          
          <creation_ts>2021-11-14 10:12:01 -0800</creation_ts>
          <short_desc>Rather than hardcoding which settings are overrided by CaptivePortalModeEnabled, it should be controlled by a new field in the WebPreferences* yaml files</short_desc>
          <delta_ts>2025-02-28 16:37:34 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>CONFIGURATION CHANGED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sam Weinig">sam</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cdumez</cc>
    
    <cc>rniwa</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1814862</commentid>
    <comment_count>0</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2021-11-14 10:12:01 -0800</bug_when>
    <thetext>Rather than hardcoding which settings are overrided by CaptivePortalModeEnabled, it should be controlled by a new field in the WebPreferences* yaml files. This would be more future proof and allow easier refactoring and stick with the general philosophy of making as much of the settings code as possible declarative.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1817196</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-11-21 10:12:22 -0800</bug_when>
    <thetext>&lt;rdar://problem/85647258&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2099482</commentid>
    <comment_count>2</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2025-02-28 16:37:34 -0800</bug_when>
    <thetext>I&apos;ve done that in https://commits.webkit.org/281949@main.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>