233062 2021-11-12 13:14:03 -0800 webView._isBeingInspected does not work with Service Worker pages 2021-11-12 19:22:24 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy cdumez ews-watchlist hi inspector-bugzilla-changes joepeck pangle webkit-bug-importer oldest_to_newest 1814580 0 timothy 2021-11-12 13:14:03 -0800 When a service worker is loaded in a Page, we need to report its inspector frontend count up to the page's inspectorController so the client knows about it. 1814581 1 webkit-bug-importer 2021-11-12 13:14:21 -0800 <rdar://problem/85354982> 1814583 2 444096 timothy 2021-11-12 13:15:47 -0800 Created attachment 444096 Patch 1814712 3 444096 hi 2021-11-12 18:07:08 -0800 Comment on attachment 444096 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444096&action=review r=me > Source/WebCore/inspector/WorkerInspectorController.cpp:140 > +#if ENABLE(SERVICE_WORKER) Style: I'd add a newline after this > Source/WebCore/inspector/WorkerInspectorController.cpp:160 > +#endif Style: i'd add a newline before this and `// ENABLE(SERVICE_WORKER)` 1814725 4 444096 timothy 2021-11-12 19:18:56 -0800 Comment on attachment 444096 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444096&action=review >> Source/WebCore/inspector/WorkerInspectorController.cpp:140 >> +#if ENABLE(SERVICE_WORKER) > > Style: I'd add a newline after this Other places in the code don't do this, so I'll leave it as-is. 1814726 5 ews-feeder 2021-11-12 19:22:21 -0800 Committed r285771 (244215@main): <https://commits.webkit.org/244215@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444096. 444096 2021-11-12 13:15:47 -0800 2021-11-12 19:22:23 -0800 Patch bug-233062-20211112131546.patch text/plain 4050 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTQzOGIxNGE5YmFmNmNl NDY1NjI0NDUxNDRhMTkzNTRhZjQxODM1Zi4uM2VjODdkZDAzNzRhMjAxMmQ4MWUxMjhlYTZhNjNm MmQxNTc0OTc1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTExLTEyICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICB3ZWJWaWV3Ll9pc0Jl aW5nSW5zcGVjdGVkIGRvZXMgbm90IHdvcmsgd2l0aCBTZXJ2aWNlIFdvcmtlciBwYWdlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzMDYyCisgICAg ICAgIHJkYXI6Ly9wcm9ibGVtLzg1MzU0OTgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvV29ya2VySW5zcGVjdG9yQ29udHJvbGxl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJJbnNwZWN0b3JDb250cm9sbGVyOjpjb25u ZWN0RnJvbnRlbmQpOiBDYWxsIHVwZGF0ZVNlcnZpY2VXb3JrZXJQYWdlRnJvbnRlbmRDb3VudCgp LgorICAgICAgICAoV2ViQ29yZTo6V29ya2VySW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlzY29ubmVj dEZyb250ZW5kKTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJJbnNwZWN0b3JDb250 cm9sbGVyOjp1cGRhdGVTZXJ2aWNlV29ya2VyUGFnZUZyb250ZW5kQ291bnQpOiBBZGRlZC4KKyAg ICAgICAgKiBpbnNwZWN0b3IvV29ya2VySW5zcGVjdG9yQ29udHJvbGxlci5oOiBBZGRlZCB1cGRh dGVTZXJ2aWNlV29ya2VyUGFnZUZyb250ZW5kQ291bnQoKS4KKwogMjAyMS0xMS0xMCAgQW50b2lu ZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KIAogICAgICAgICBUaGUgY3NzVGV4dCBwcm9w ZXJ0eSBmb3IgYSBjb21wdXRlZCBzdHlsZSBzaG91bGQgcmV0dXJuIGFuIGVtcHR5IHN0cmluZwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1dvcmtlckluc3BlY3RvckNvbnRy b2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1dvcmtlckluc3BlY3RvckNvbnRy b2xsZXIuY3BwCmluZGV4IDdmNDg0NjAzMzI4YmZmYjQwZDc0MjhlMjQ0YzQ3YTBiOTI5ZDRiMmMu LmQzMmY5OGFmNjg2YmFjOGFhYjk1ZmJmYTJmNThlOGQ3MDJkNjI4YjYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9Xb3JrZXJJbnNwZWN0b3JDb250cm9sbGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvV29ya2VySW5zcGVjdG9yQ29udHJvbGxlci5jcHAK QEAgLTQ4LDYgKzQ4LDggQEAKICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9JbnNwZWN0b3JGcm9u dGVuZFJvdXRlci5oPgogCiAjaWYgRU5BQkxFKFNFUlZJQ0VfV09SS0VSKQorI2luY2x1ZGUgIklu c3BlY3RvckNsaWVudC5oIgorI2luY2x1ZGUgIlBhZ2UuaCIKICNpbmNsdWRlICJTZXJ2aWNlV29y a2VyQWdlbnQuaCIKICNpbmNsdWRlICJTZXJ2aWNlV29ya2VyR2xvYmFsU2NvcGUuaCIKICNlbmRp ZgpAQCAtMTA5LDYgKzExMSwxMCBAQCB2b2lkIFdvcmtlckluc3BlY3RvckNvbnRyb2xsZXI6OmNv bm5lY3RGcm9udGVuZCgpCiAgICAgbV9mb3J3YXJkaW5nQ2hhbm5lbCA9IG1ha2VVbmlxdWU8V29y a2VyVG9QYWdlRnJvbnRlbmRDaGFubmVsPihtX2dsb2JhbFNjb3BlKTsKICAgICBtX2Zyb250ZW5k Um91dGVyLT5jb25uZWN0RnJvbnRlbmQoKm1fZm9yd2FyZGluZ0NoYW5uZWwuZ2V0KCkpOwogICAg IG1fYWdlbnRzLmRpZENyZWF0ZUZyb250ZW5kQW5kQmFja2VuZCgmbV9mcm9udGVuZFJvdXRlci5n ZXQoKSwgJm1fYmFja2VuZERpc3BhdGNoZXIuZ2V0KCkpOworCisjaWYgRU5BQkxFKFNFUlZJQ0Vf V09SS0VSKQorICAgIHVwZGF0ZVNlcnZpY2VXb3JrZXJQYWdlRnJvbnRlbmRDb3VudCgpOworI2Vu ZGlmCiB9CiAKIHZvaWQgV29ya2VySW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlzY29ubmVjdEZyb250 ZW5kKEluc3BlY3Rvcjo6RGlzY29ubmVjdFJlYXNvbiByZWFzb24pCkBAIC0xMjUsNyArMTMxLDMz IEBAIHZvaWQgV29ya2VySW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlzY29ubmVjdEZyb250ZW5kKElu c3BlY3Rvcjo6RGlzY29ubmVjdFJlYXNvbiByCiAgICAgbV9hZ2VudHMud2lsbERlc3Ryb3lGcm9u dGVuZEFuZEJhY2tlbmQocmVhc29uKTsKICAgICBtX2Zyb250ZW5kUm91dGVyLT5kaXNjb25uZWN0 RnJvbnRlbmQoKm1fZm9yd2FyZGluZ0NoYW5uZWwuZ2V0KCkpOwogICAgIG1fZm9yd2FyZGluZ0No YW5uZWwgPSBudWxscHRyOworCisjaWYgRU5BQkxFKFNFUlZJQ0VfV09SS0VSKQorICAgIHVwZGF0 ZVNlcnZpY2VXb3JrZXJQYWdlRnJvbnRlbmRDb3VudCgpOworI2VuZGlmCit9CisKKyNpZiBFTkFC TEUoU0VSVklDRV9XT1JLRVIpCit2b2lkIFdvcmtlckluc3BlY3RvckNvbnRyb2xsZXI6OnVwZGF0 ZVNlcnZpY2VXb3JrZXJQYWdlRnJvbnRlbmRDb3VudCgpCit7CisgICAgaWYgKCFpczxTZXJ2aWNl V29ya2VyR2xvYmFsU2NvcGU+KG1fZ2xvYmFsU2NvcGUpKQorICAgICAgICByZXR1cm47CisKKyAg ICBhdXRvIHNlcnZpY2VXb3JrZXJQYWdlID0gZG93bmNhc3Q8U2VydmljZVdvcmtlckdsb2JhbFNj b3BlPihtX2dsb2JhbFNjb3BlKS5zZXJ2aWNlV29ya2VyUGFnZSgpOworICAgIGlmICghc2Vydmlj ZVdvcmtlclBhZ2UpCisgICAgICAgIHJldHVybjsKKworICAgIEFTU0VSVChpc01haW5UaHJlYWQo KSk7CisKKyAgICAvLyBXaGVuIGEgc2VydmljZSB3b3JrZXIgaXMgbG9hZGVkIGluIGEgUGFnZSwg d2UgbmVlZCB0byByZXBvcnQgaXRzIGluc3BlY3RvciBmcm9udGVuZCBjb3VudAorICAgIC8vIHVw IHRvIHRoZSBwYWdlJ3MgaW5zcGVjdG9yQ29udHJvbGxlciBzbyB0aGUgY2xpZW50IGtub3dzIGFi b3V0IGl0LgorICAgIGF1dG8gaW5zcGVjdG9yQ2xpZW50ID0gc2VydmljZVdvcmtlclBhZ2UtPmlu c3BlY3RvckNvbnRyb2xsZXIoKS5pbnNwZWN0b3JDbGllbnQoKTsKKyAgICBpZiAoIWluc3BlY3Rv ckNsaWVudCkKKyAgICAgICAgcmV0dXJuOworCisgICAgaW5zcGVjdG9yQ2xpZW50LT5mcm9udGVu ZENvdW50Q2hhbmdlZChtX2Zyb250ZW5kUm91dGVyLT5mcm9udGVuZENvdW50KCkpOwogfQorI2Vu ZGlmCiAKIHZvaWQgV29ya2VySW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlzcGF0Y2hNZXNzYWdlRnJv bUZyb250ZW5kKGNvbnN0IFN0cmluZyYgbWVzc2FnZSkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9Xb3JrZXJJbnNwZWN0b3JDb250cm9sbGVyLmggYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvV29ya2VySW5zcGVjdG9yQ29udHJvbGxlci5oCmluZGV4IDM4NTFiZGIz ZWVmNGIyN2EzMTM0NGFiMzliYjc1YjRiZWRkYzZlMjAuLmMzOTQ2YmVhZjZhNGIyNThkMWIzZGI3 MzdkZmQzZTEyYzgwYWMzNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9X b3JrZXJJbnNwZWN0b3JDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L1dvcmtlckluc3BlY3RvckNvbnRyb2xsZXIuaApAQCAtNzQsNiArNzQsMTAgQEAgcHJpdmF0ZToK ICAgICBXb3JrZXJBZ2VudENvbnRleHQgd29ya2VyQWdlbnRDb250ZXh0KCk7CiAgICAgdm9pZCBj cmVhdGVMYXp5QWdlbnRzKCk7CiAKKyNpZiBFTkFCTEUoU0VSVklDRV9XT1JLRVIpCisgICAgdm9p ZCB1cGRhdGVTZXJ2aWNlV29ya2VyUGFnZUZyb250ZW5kQ291bnQoKTsKKyNlbmRpZgorCiAgICAg UmVmPEluc3RydW1lbnRpbmdBZ2VudHM+IG1faW5zdHJ1bWVudGluZ0FnZW50czsKICAgICBzdGQ6 OnVuaXF1ZV9wdHI8V2ViSW5qZWN0ZWRTY3JpcHRNYW5hZ2VyPiBtX2luamVjdGVkU2NyaXB0TWFu YWdlcjsKICAgICBSZWY8SW5zcGVjdG9yOjpGcm9udGVuZFJvdXRlcj4gbV9mcm9udGVuZFJvdXRl cjsK