233052 2021-11-12 10:49:52 -0800 REGRESSION (r285698): Build correction after refactoring id handling 2021-11-12 12:20:59 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham cdumez ews-watchlist jiewen_tan ryanhaddad tsavell webkit-bug-importer oldest_to_newest 1814518 0 bfulgham 2021-11-12 10:49:52 -0800 In r285698 I added a new 'toNSData' inline for BufferSource, which is used in WebAuthenticatorCoordinatorProxy.mm. At the last minute, we decided to not export the function without its namespace but forgot to update WebAuthenticatorCoordinatorProxy.mm with that change. I missed this locally because I didn't do a clean build. 1814519 1 bfulgham 2021-11-12 10:50:10 -0800 <rdar://problem/85347865> 1814522 2 444083 bfulgham 2021-11-12 10:54:51 -0800 Created attachment 444083 Patch 1814558 3 ews-feeder 2021-11-12 12:15:46 -0800 Committed r285736 (244195@main): <https://commits.webkit.org/244195@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444083. 444083 2021-11-12 10:54:51 -0800 2021-11-12 12:15:47 -0800 Patch bug-233052-20211112105450.patch text/plain 4581 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRjMjcyMTkwZmNiNDM0YTUy OTMwNDg4NGRmMTk5NDcyNzZlMjVhYTcuLjMyZDUyZTcxOTM5ZDcyYjA4MTQ2Y2NiNjZlOGRlNGM1 ZDYwZTE5OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMTEtMTIgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI4NTY5 OCk6IEJ1aWxkIGNvcnJlY3Rpb24gYWZ0ZXIgcmVmYWN0b3JpbmcgaWQgaGFuZGxpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMzA1MgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vODUzNDc4NjU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQnVpbGQgZml4IGFmdGVyIHIyODU2OTguIFRoZSBuZXcgJ3Rv TlNEYXRhJyBtZXRob2QgbmVlZHMgaXRzIG5hbWVzcGFjZSBpbmNsdWRlZC4KKworICAgICAgICAq IFVJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Db2NvYS9XZWJBdXRoZW50aWNhdG9yQ29vcmRp bmF0b3JQcm94eS5tbToKKyAgICAgICAgKFdlYktpdDo6dG9BU0NEZXNjcmlwdG9yKToKKyAgICAg ICAgKFdlYktpdDo6Y29uZmlndXJlUmVnaXN0cmF0aW9uUmVxdWVzdENvbnRleHQpOgorICAgICAg ICAoV2ViS2l0Ojpjb25maWd1cmF0aW9uQXNzZXJ0aW9uUmVxdWVzdENvbnRleHQpOgorICAgICAg ICAoV2ViS2l0Ojp0b05TRGF0YSk6IERlbGV0ZWQuCisKIDIwMjEtMTEtMTIgIENocmlzIER1bWV6 ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBEaXNhYmxlIE1hdGhNTCB3aGVuIGluIENh cHRpdmUgUG9ydGFsIE1vZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl YkF1dGhlbnRpY2F0aW9uL0NvY29hL1dlYkF1dGhlbnRpY2F0b3JDb29yZGluYXRvclByb3h5Lm1t IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvV2ViQXV0 aGVudGljYXRvckNvb3JkaW5hdG9yUHJveHkubW0KaW5kZXggZWVjNTliZDdlYjk1ZTEwNGRjYzc5 ZDg0OTU0NTBjZjEzZDMyMjM1MC4uNDRiYWE4OTA3NmY1MzI3ZjYzZmE4ZTUyMjkyZjMyYTFiZDA5 ZWQ5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRp b24vQ29jb2EvV2ViQXV0aGVudGljYXRvckNvb3JkaW5hdG9yUHJveHkubW0KKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvV2ViQXV0aGVudGljYXRv ckNvb3JkaW5hdG9yUHJveHkubW0KQEAgLTM1LDYgKzM1LDcgQEAKICNpbXBvcnQgPEF1dGhlbnRp Y2F0aW9uU2VydmljZXMvQVNDT1NFQ29uc3RhbnRzLmg+CiAjaW1wb3J0IDxXZWJDb3JlL0F1dGhl bnRpY2F0b3JBdHRhY2htZW50Lmg+CiAjaW1wb3J0IDxXZWJDb3JlL0F1dGhlbnRpY2F0b3JSZXNw b25zZURhdGEuaD4KKyNpbXBvcnQgPFdlYkNvcmUvQnVmZmVyU291cmNlLmg+CiAjaW1wb3J0IDxX ZWJDb3JlL0V4Y2VwdGlvbkRhdGEuaD4KICNpbXBvcnQgPFdlYkNvcmUvUHVibGljS2V5Q3JlZGVu dGlhbENyZWF0aW9uT3B0aW9ucy5oPgogI2ltcG9ydCA8d3RmL0Jsb2NrUHRyLmg+CkBAIC00OSwx MSArNTAsNiBAQCBzdGF0aWMgaW5saW5lIFJlZjxBcnJheUJ1ZmZlcj4gdG9BcnJheUJ1ZmZlcihO U0RhdGEgKmRhdGEpCiAgICAgcmV0dXJuIEFycmF5QnVmZmVyOjpjcmVhdGUocmVpbnRlcnByZXRf Y2FzdDxjb25zdCB1aW50OF90Kj4oZGF0YS5ieXRlcyksIGRhdGEubGVuZ3RoKTsKIH0KIAotc3Rh dGljIGlubGluZSBSZXRhaW5QdHI8TlNEYXRhPiB0b05TRGF0YShjb25zdCBWZWN0b3I8dWludDhf dD4gdmVjdG9yKQotewotICAgIHJldHVybiBhZG9wdE5TKFtbTlNEYXRhIGFsbG9jXSBpbml0V2l0 aEJ5dGVzOnZlY3Rvci5kYXRhKCkgbGVuZ3RoOnZlY3Rvci5zaXplKCldKTsKLX0KLQogc3RhdGlj IGlubGluZSBSZXRhaW5QdHI8TlNTdHJpbmc+IHRvTlNTdHJpbmcoVXNlclZlcmlmaWNhdGlvblJl cXVpcmVtZW50IHVzZXJWZXJpZmljYXRpb25SZXF1aXJlbWVudCkKIHsKICAgICBzd2l0Y2ggKHVz ZXJWZXJpZmljYXRpb25SZXF1aXJlbWVudCkgewpAQCAtMTQ2LDcgKzE0Miw3IEBAIHN0YXRpYyBp bmxpbmUgUmV0YWluUHRyPEFTQ1B1YmxpY0tleUNyZWRlbnRpYWxEZXNjcmlwdG9yPiB0b0FTQ0Rl c2NyaXB0b3IoUHVibGljCiAgICAgICAgIH0KICAgICB9CiAKLSAgICByZXR1cm4gYWRvcHROUyhb YWxsb2NBU0NQdWJsaWNLZXlDcmVkZW50aWFsRGVzY3JpcHRvckluc3RhbmNlKCkgaW5pdFdpdGhD cmVkZW50aWFsSUQ6dG9OU0RhdGEoZGVzY3JpcHRvci5pZCkuZ2V0KCkgdHJhbnNwb3J0czp0cmFu c3BvcnRzLmdldCgpXSk7CisgICAgcmV0dXJuIGFkb3B0TlMoW2FsbG9jQVNDUHVibGljS2V5Q3Jl ZGVudGlhbERlc2NyaXB0b3JJbnN0YW5jZSgpIGluaXRXaXRoQ3JlZGVudGlhbElEOldlYkNvcmU6 OnRvTlNEYXRhKGRlc2NyaXB0b3IuaWQpLmdldCgpIHRyYW5zcG9ydHM6dHJhbnNwb3J0cy5nZXQo KV0pOwogfQogCiBzdGF0aWMgUmV0YWluUHRyPEFTQ0NyZWRlbnRpYWxSZXF1ZXN0Q29udGV4dD4g Y29uZmlndXJlUmVnaXN0cmF0aW9uUmVxdWVzdENvbnRleHQoY29uc3QgUHVibGljS2V5Q3JlZGVu dGlhbENyZWF0aW9uT3B0aW9ucyYgb3B0aW9ucykKQEAgLTE3MywxMCArMTY5LDEwIEBAIHN0YXRp YyBSZXRhaW5QdHI8QVNDQ3JlZGVudGlhbFJlcXVlc3RDb250ZXh0PiBjb25maWd1cmVSZWdpc3Ry YXRpb25SZXF1ZXN0Q29udGV4CiAKICAgICBhdXRvIGNyZWRlbnRpYWxDcmVhdGlvbk9wdGlvbnMg PSBhZG9wdE5TKFthbGxvY0FTQ1B1YmxpY0tleUNyZWRlbnRpYWxDcmVhdGlvbk9wdGlvbnNJbnN0 YW5jZSgpIGluaXRdKTsKIAotICAgIFtjcmVkZW50aWFsQ3JlYXRpb25PcHRpb25zIHNldENoYWxs ZW5nZTp0b05TRGF0YShvcHRpb25zLmNoYWxsZW5nZSkuZ2V0KCldOworICAgIFtjcmVkZW50aWFs Q3JlYXRpb25PcHRpb25zIHNldENoYWxsZW5nZTpXZWJDb3JlOjp0b05TRGF0YShvcHRpb25zLmNo YWxsZW5nZSkuZ2V0KCldOwogICAgIFtjcmVkZW50aWFsQ3JlYXRpb25PcHRpb25zIHNldFJlbHlp bmdQYXJ0eUlkZW50aWZpZXI6b3B0aW9ucy5ycC5pZF07CiAgICAgW2NyZWRlbnRpYWxDcmVhdGlv bk9wdGlvbnMgc2V0VXNlck5hbWU6b3B0aW9ucy51c2VyLm5hbWVdOwotICAgIFtjcmVkZW50aWFs Q3JlYXRpb25PcHRpb25zIHNldFVzZXJJZGVudGlmaWVyOnRvTlNEYXRhKG9wdGlvbnMudXNlci5p ZC5kYXRhKCkpLmdldCgpXTsKKyAgICBbY3JlZGVudGlhbENyZWF0aW9uT3B0aW9ucyBzZXRVc2Vy SWRlbnRpZmllcjpXZWJDb3JlOjp0b05TRGF0YShvcHRpb25zLnVzZXIuaWQpLmdldCgpXTsKICAg ICBbY3JlZGVudGlhbENyZWF0aW9uT3B0aW9ucyBzZXRVc2VyRGlzcGxheU5hbWU6b3B0aW9ucy51 c2VyLmRpc3BsYXlOYW1lXTsKICAgICBbY3JlZGVudGlhbENyZWF0aW9uT3B0aW9ucyBzZXRVc2Vy VmVyaWZpY2F0aW9uUHJlZmVyZW5jZTp1c2VyVmVyaWZpY2F0aW9uLmdldCgpXTsKICAgICBbY3Jl ZGVudGlhbENyZWF0aW9uT3B0aW9ucyBzZXRTaG91bGRSZXF1aXJlUmVzaWRlbnRLZXk6c2hvdWxk UmVxdWlyZVJlc2lkZW50S2V5XTsKQEAgLTIzMSw3ICsyMjcsNyBAQCBzdGF0aWMgUmV0YWluUHRy PEFTQ0NyZWRlbnRpYWxSZXF1ZXN0Q29udGV4dD4gY29uZmlndXJhdGlvbkFzc2VydGlvblJlcXVl c3RDb250ZQogICAgIGF1dG8gcmVxdWVzdENvbnRleHQgPSBhZG9wdE5TKFthbGxvY0FTQ0NyZWRl bnRpYWxSZXF1ZXN0Q29udGV4dEluc3RhbmNlKCkgaW5pdFdpdGhSZXF1ZXN0VHlwZXM6cmVxdWVz dFR5cGVzXSk7CiAgICAgW3JlcXVlc3RDb250ZXh0IHNldFJlbHlpbmdQYXJ0eUlkZW50aWZpZXI6 b3B0aW9ucy5ycElkXTsKIAotICAgIGF1dG8gY2hhbGxlbmdlID0gdG9OU0RhdGEob3B0aW9ucy5j aGFsbGVuZ2UpOworICAgIGF1dG8gY2hhbGxlbmdlID0gV2ViQ29yZTo6dG9OU0RhdGEob3B0aW9u cy5jaGFsbGVuZ2UpOwogCiAgICAgaWYgKHJlcXVlc3RUeXBlcyAmIEFTQ0NyZWRlbnRpYWxSZXF1 ZXN0VHlwZVBsYXRmb3JtUHVibGljS2V5QXNzZXJ0aW9uKQogICAgICAgICBbcmVxdWVzdENvbnRl eHQgc2V0UGxhdGZvcm1LZXlDcmVkZW50aWFsQXNzZXJ0aW9uT3B0aW9uczpbYWxsb2NBU0NQdWJs aWNLZXlDcmVkZW50aWFsQXNzZXJ0aW9uT3B0aW9uc0luc3RhbmNlKCkgaW5pdFdpdGhLaW5kOkFT Q1B1YmxpY0tleUNyZWRlbnRpYWxLaW5kUGxhdGZvcm0gcmVseWluZ1BhcnR5SWRlbnRpZmllcjpv cHRpb25zLnJwSWQgY2hhbGxlbmdlOmNoYWxsZW5nZS5nZXQoKSB1c2VyVmVyaWZpY2F0aW9uUHJl ZmVyZW5jZTp1c2VyVmVyaWZpY2F0aW9uLmdldCgpIGFsbG93ZWRDcmVkZW50aWFsczphbGxvd2Vk Q3JlZGVudGlhbHMuZ2V0KCldXTsK