233040 2021-11-12 06:08:52 -0800 Some C++ source files use #pragma once 2021-11-14 14:39:55 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez achristensen aperez cdumez clopez dino mcatanzaro mmaxfield webkit-bug-importer oldest_to_newest 1814407 0 aperez 2021-11-12 06:08:52 -0800 Given that “#pragma once” is intended to be used only in headers (or, more precisely, in files that get “#include”'d), it does not make sense to make use of it inside implementation .cpp files, yet it is present in a few: % rg --files-with-matches --glob '*.cpp' '^#pragma once' Source/ Source/WebKit/WebProcess/WebCoreSupport/WebCaptionPreferencesDelegate.cpp Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.cpp Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.cpp Source/WebCore/Modules/WebGPU/GPUQueue.cpp Source/WebCore/Modules/WebGPU/GPUQuerySet.cpp Source/WebCore/Modules/WebGPU/GPUComputePassEncoder.cpp Source/WebCore/Modules/WebGPU/GPUCommandEncoder.cpp Source/WebCore/Modules/WebGPU/GPUBuffer.cpp Source/WebCore/page/PerformanceNavigationTiming.cpp % At least GCC 11.1 will warn about these spurious uses. 1814409 1 444061 aperez 2021-11-12 06:11:56 -0800 Created attachment 444061 Patch 1814458 2 aperez 2021-11-12 08:28:39 -0800 Thanks cdumez! The build failure from the mac-wk1 is unrelated, that queue seems to be having trouble lately, so I'll go ahead and mark this cq+ :) 1814459 3 cdumez 2021-11-12 08:30:52 -0800 (In reply to Adrian Perez from comment #2) > Thanks cdumez! The build failure from the mac-wk1 is unrelated, that > queue seems to be having trouble lately, so I'll go ahead and mark > this cq+ :) Yes, I filed https://bugs.webkit.org/show_bug.cgi?id=233043 and skipped that test due to all these ews mac-wk1 false positives. 1814471 4 ews-feeder 2021-11-12 08:39:56 -0800 Committed r285724 (244183@main): <https://commits.webkit.org/244183@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444061. 1814472 5 webkit-bug-importer 2021-11-12 08:40:24 -0800 <rdar://problem/85344690> 1814525 6 mmaxfield 2021-11-12 11:01:17 -0800 Thanks for fixing this!!! 1814913 7 aperez 2021-11-14 14:39:55 -0800 (In reply to Myles C. Maxfield from comment #6) > Thanks for fixing this!!! No problem at all :) 444061 2021-11-12 06:11:56 -0800 2021-11-12 09:00:15 -0800 Patch bug-233040-20211112161155.patch text/plain 6076 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTg4YTcxOTcwMjVhZmJj NmUwNDQ5ODI0NThmNWJhZDgwZmJiM2UzZi4uYmRjMTRkYTA4NTM1ODMyZjljYWRlNmNmOTMyNzMw NzVkODMxZjNiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTExLTEyICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgU29tZSBD Kysgc291cmNlIGZpbGVzIHVzZSAjcHJhZ21hIG9uY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMzA0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBzcHVyaW91cyB1c2FnZSBvZiAiI3ByYWdt YSBvbmNlIiBpbiBpbXBsZW1lbnRhdGlvbiBmaWxlcy4KKworICAgICAgICBObyBuZXcgdGVzdHMg bmVlZGVkLgorCisgICAgICAgICogTW9kdWxlcy9XZWJHUFUvR1BVQnVmZmVyLmNwcDoKKyAgICAg ICAgKiBNb2R1bGVzL1dlYkdQVS9HUFVDb21tYW5kRW5jb2Rlci5jcHA6CisgICAgICAgICogTW9k dWxlcy9XZWJHUFUvR1BVQ29tcHV0ZVBhc3NFbmNvZGVyLmNwcDoKKyAgICAgICAgKiBNb2R1bGVz L1dlYkdQVS9HUFVRdWVyeVNldC5jcHA6CisgICAgICAgICogTW9kdWxlcy9XZWJHUFUvR1BVUXVl dWUuY3BwOgorICAgICAgICAqIE1vZHVsZXMvV2ViR1BVL0dQVVJlbmRlckJ1bmRsZUVuY29kZXIu Y3BwOgorICAgICAgICAqIE1vZHVsZXMvV2ViR1BVL0dQVVJlbmRlclBhc3NFbmNvZGVyLmNwcDoK KyAgICAgICAgKiBwYWdlL1BlcmZvcm1hbmNlTmF2aWdhdGlvblRpbWluZy5jcHA6CisKIDIwMjEt MTEtMTIgIFRpbSBOZ3V5ZW4gIDxudGltQGFwcGxlLmNvbT4KIAogICAgICAgICBSZS11c2UgaXND U1NXaWRlS2V5d29yZCBpbiBDU1NDdXN0b21Qcm9wZXJ0eVZhbHVlOjpjcmVhdGVXaXRoSUQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VM b2cKaW5kZXggNTIyMjA1ZDZkNDgyYzg1NmM5YWY2YjhiY2Y1YmU2MzY1MzBiMmE0Zi4uZjNkZGQ4 ZTgwNzJlYjdmY2UzMmRmNzA5MGMwOTYxNGZiYmJhODliYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NCBAQAorMjAyMS0xMS0xMiAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEu Y29tPgorCisgICAgICAgIFNvbWUgQysrIHNvdXJjZSBmaWxlcyB1c2UgI3ByYWdtYSBvbmNlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzMwNDAKKwor ICAgICAgICBSZW1vdmUgc3B1cmlvdXMgdXNhZ2Ugb2YgIiNwcmFnbWEgb25jZSIgaW4gaW1wbGVt ZW50YXRpb24gZmlsZXMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNhcHRpb25QcmVmZXJlbmNl c0RlbGVnYXRlLmNwcDoKKwogMjAyMS0xMS0xMSAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxs YXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbY3NzLWZsZXhib3hdIEFkZCBmbGV4LWJhc2lzOiBj b250ZW50IHN1cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvV2ViR1BV L0dQVUJ1ZmZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL1dlYkdQVS9HUFVCdWZmZXIu Y3BwCmluZGV4IGU4MTg5ZGJmMDVlZTE0M2M3YmM1YjFjNGZlZTMwYjlmMDgzY2JlNDMuLjdmZDQ4 NTcyYTllNTczYzk5YjAzZmIzMzI4YjI0ZDk2NDFjMjc0OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvV2ViR1BVL0dQVUJ1ZmZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9XZWJHUFUvR1BVQnVmZmVyLmNwcApAQCAtMjMsOCArMjMsNiBAQAogICogVEhFIFBP U1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKLSNwcmFnbWEgb25jZQotCiAjaW5jbHVk ZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiR1BVQnVmZmVyLmgiCiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvV2ViR1BVL0dQVUNvbW1hbmRFbmNvZGVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvV2ViR1BVL0dQVUNvbW1hbmRFbmNvZGVyLmNwcAppbmRleCA0ODFjZDUw NTRkYzgyNDVkYWNkZTE2YWEyMjM2OTZkNjc2M2NiYWQwLi44MTdjMzUyZWMwMGEyZGQ1MWVlN2Ix N2Q3MGM1ZGYyNThmZjhkNGM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL1dl YkdQVS9HUFVDb21tYW5kRW5jb2Rlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9X ZWJHUFUvR1BVQ29tbWFuZEVuY29kZXIuY3BwCkBAIC0yMyw4ICsyMyw2IEBACiAgKiBUSEUgUE9T U0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8KIAotI3ByYWdtYSBvbmNlCi0KICNpbmNsdWRl ICJjb25maWcuaCIKICNpbmNsdWRlICJHUFVDb21tYW5kRW5jb2Rlci5oIgogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL1dlYkdQVS9HUFVDb21wdXRlUGFzc0VuY29kZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVQ29tcHV0ZVBhc3NFbmNvZGVyLmNw cAppbmRleCBiNWUxNWU1MDQwYjZhNTcxMzJmM2VjOGUxMjcyNTFkNDc0OTY4MTE4Li5iMDExZjUw ZTc2NjJlMWVhOWU5OWQ3NzQ0MjhiOGNhMjI2OGQ0ZDE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL1dlYkdQVS9HUFVDb21wdXRlUGFzc0VuY29kZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvV2ViR1BVL0dQVUNvbXB1dGVQYXNzRW5jb2Rlci5jcHAKQEAgLTIz LDggKzIzLDYgQEAKICAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCi0j cHJhZ21hIG9uY2UKLQogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkdQVUNvbXB1dGVQ YXNzRW5jb2Rlci5oIgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL1dlYkdQ VS9HUFVRdWVyeVNldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL1dlYkdQVS9HUFVRdWVy eVNldC5jcHAKaW5kZXggNTY1MTNlMWM0MWI2YWMwM2I1MDRjZWIwMDQxODFiOGYwM2I0N2UxMC4u NDZmMjcyMzZkMGY3NjJjNWM0NzQ3YTU3ZWZjMzAwYWFlODM4YTNkNSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVUXVlcnlTZXQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvV2ViR1BVL0dQVVF1ZXJ5U2V0LmNwcApAQCAtMjMsOCArMjMsNiBAQAog ICogVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKLSNwcmFnbWEgb25jZQot CiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiR1BVUXVlcnlTZXQuaCIKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVUXVldWUuY3BwIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVUXVldWUuY3BwCmluZGV4IGU3MjVmNWY4NzdmZWMz MDZjYzVlOGViOWIxZDJiZjU1MTYzMGM3N2UuLmY1ODYxOTAyY2ZmZTY2ZjI4OGU1YTY3Nzk5ZjIz NTVmNWQzNzc0YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvV2ViR1BVL0dQ VVF1ZXVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL1dlYkdQVS9HUFVRdWV1ZS5j cHAKQEAgLTIzLDggKzIzLDYgQEAKICAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4K ICAqLwogCi0jcHJhZ21hIG9uY2UKLQogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkdQ VVF1ZXVlLmgiCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvV2ViR1BVL0dQ VVJlbmRlckJ1bmRsZUVuY29kZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUv R1BVUmVuZGVyQnVuZGxlRW5jb2Rlci5jcHAKaW5kZXggYmU4NTQ0NTBmNjhlN2UyOGNkNTQ5MTdi MGQ4ZjFmNmFkZWY4MTVmMC4uZjI1ODY3ZDJjNzc5ZmExMzBkMGFmNzZjY2U4YWM0Y2ZkZjY5OGQ4 ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVUmVuZGVyQnVu ZGxlRW5jb2Rlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVUmVu ZGVyQnVuZGxlRW5jb2Rlci5jcHAKQEAgLTIzLDggKzIzLDYgQEAKICAqIFRIRSBQT1NTSUJJTElU WSBPRiBTVUNIIERBTUFHRS4KICAqLwogCi0jcHJhZ21hIG9uY2UKLQogI2luY2x1ZGUgImNvbmZp Zy5oIgogI2luY2x1ZGUgIkdQVVJlbmRlckJ1bmRsZUVuY29kZXIuaCIKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVUmVuZGVyUGFzc0VuY29kZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVUmVuZGVyUGFzc0VuY29kZXIuY3BwCmlu ZGV4IGNjY2EyOThmOWJkMzBiZDY3ZjY1ZDRiMzEzNTUyYTAwODNlMDcyMDYuLmE5NTEwMTY2Zjhi ZTgyMTJlNzZjYWZlNGE3ZTJhNDYyOTVmMmJiODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvV2ViR1BVL0dQVVJlbmRlclBhc3NFbmNvZGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL1dlYkdQVS9HUFVSZW5kZXJQYXNzRW5jb2Rlci5jcHAKQEAgLTIzLDggKzIz LDYgQEAKICAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCi0jcHJhZ21h IG9uY2UKLQogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkdQVVJlbmRlclBhc3NFbmNv ZGVyLmgiCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VOYXZp Z2F0aW9uVGltaW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VOYXZpZ2F0 aW9uVGltaW5nLmNwcAppbmRleCA0MTI4MzU2MzA5YjEwOGQzMGExN2ZmOWJlYzRiMDgzNzc1Nzhm OWM1Li40NjMzOTQxZWVkNWEwZTM5NzI4YmQ3MjVlNjI1NGFhNmNiODM5YWU1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlTmF2aWdhdGlvblRpbWluZy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZU5hdmlnYXRpb25UaW1pbmcuY3BwCkBA IC0yMyw4ICsyMyw2IEBACiAgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0Yg VEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKLSNwcmFnbWEgb25jZQotCiAj aW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiUGVyZm9ybWFuY2VOYXZpZ2F0aW9uVGltaW5n LmgiCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y dC9XZWJDYXB0aW9uUHJlZmVyZW5jZXNEZWxlZ2F0ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2FwdGlvblByZWZlcmVuY2VzRGVsZWdhdGUuY3BwCmlu ZGV4IDc1ZDI1YmExYjFlMzhjYTVkOGE2MTg0NWJlODM0M2MzYzY0NGE0OTguLmFmYWY0YWVhMTAx ZDQ0NzhkZGM5YjAzZmJhOTJhOGExNmNjYjU1NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDYXB0aW9uUHJlZmVyZW5jZXNEZWxlZ2F0ZS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNhcHRp b25QcmVmZXJlbmNlc0RlbGVnYXRlLmNwcApAQCAtMjMsOCArMjMsNiBAQAogKiBPRiBUSElTIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF LgogKi8KIAotI3ByYWdtYSBvbmNlCi0KICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJX ZWJDYXB0aW9uUHJlZmVyZW5jZXNEZWxlZ2F0ZS5oIgogCg==