233016 2021-11-11 14:21:29 -0800 REGRESSION: 26 InAppBrowserPrivacy API failures on iOS 2021-11-11 15:08:35 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 232737 1 tsavell cdumez achristensen bfulgham cdumez ggaren webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1814225 0 tsavell 2021-11-11 14:21:29 -0800 26 API failures started between r285591 - r285609 these are all related to InAppBrowserPrivacy. build: https://build.webkit.org/#/builders/267/builds/498 stdio: https://build.webkit.org/#/builders/267/builds/498/steps/17/logs/stdio 1814227 1 webkit-bug-importer 2021-11-11 14:21:53 -0800 <rdar://problem/85315536> 1814229 2 tsavell 2021-11-11 14:23:47 -0800 It looks like https://trac.webkit.org/changeset/285594/webkit could have possibly caused this. 1814232 3 cdumez 2021-11-11 14:24:59 -0800 (In reply to Truitt Savell from comment #2) > It looks like https://trac.webkit.org/changeset/285594/webkit could have > possibly caused this. Oh? I can look but it seems a little surprising given that captive portal mode is disabled by default. 1814237 4 ryanhaddad 2021-11-11 14:32:19 -0800 (In reply to Chris Dumez from comment #3) > (In reply to Truitt Savell from comment #2) > > It looks like https://trac.webkit.org/changeset/285594/webkit could have > > possibly caused this. > > Oh? I can look but it seems a little surprising given that captive portal > mode is disabled by default. We noticed that ios-api EWS showed these as "new" failures on https://bugs.webkit.org/show_bug.cgi?id=232737, we're still confirming though. 1814241 5 444006 cdumez 2021-11-11 14:39:12 -0800 Created attachment 444006 Patch 1814242 6 444006 bfulgham 2021-11-11 14:40:51 -0800 Comment on attachment 444006 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444006&action=review r=me > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7629 > +// Also, some API tests rely on the browser entitlement not being present. We may have a way to address this, but should do so in a follow-up patch. 1814253 7 444006 cdumez 2021-11-11 15:08:32 -0800 Comment on attachment 444006 Patch Clearing flags on attachment: 444006 Committed r285672 (244159@main): <https://commits.webkit.org/244159@main> 1814254 8 cdumez 2021-11-11 15:08:35 -0800 All reviewed patches have been landed. Closing bug. 444006 2021-11-11 14:39:12 -0800 2021-11-11 15:08:32 -0800 Patch bug-233016-20211111143911.patch text/plain 2738 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NjU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDFjZDVjMjg2NjRhMWIxMzRjNzhhOGMxOWU2ZjFhZjY5 MGFlNTM1MS4uYTEyZWIwODZjMDE4YTgzMjBlMDk5MjNiY2QyZTg3ZmI3N2VhNzhlOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIxLTExLTExICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTjogMjYgSW5BcHBCcm93c2VyUHJpdmFjeSBBUEkgZmFpbHVyZXMgb24gaU9T CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzMwMTYK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg1MzE1NTM2PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHIyODU1OTQsIEkgaGF2ZSB0aGUgYnJvd3Nl ciBlbnRpdGxlbWVudCB0byBUZXN0V2ViS2l0IEFQSSB0byBtYWtlIG15IG5ldyBBUEkgdGVzdCB3 b3JrCisgICAgICAgIG9uIGlPUy4gSG93ZXZlciwgaXQgdHVybnMgb3V0IHRoYXQgMjYgSW5BcHBC cm93c2VyUHJpdmFjeSBBUEkgdGVzdHMgcmVseSBvbiB0aGUgYnJvd3NlcgorICAgICAgICBlbnRp dGxlbWVudCBub3QgYmVpbmcgcHJlc2VudC4gSSBhbSB0aGVyZWZvcmUgcmV2ZXJ0aW5nIHRoaXMg cGFydCBvZiBteSBjaGFuZ2UuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRp b25zL1Rlc3RXZWJLaXRBUEktaU9TLmVudGl0bGVtZW50czoKKyAgICAgICAgKiBUZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdENvY29hL1Byb2Nlc3NTd2FwT25OYXZpZ2F0aW9uLm1tOgorCiAyMDIx LTExLTExICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgRGlzYWJs ZSBNYXRoTUwgd2hlbiBpbiBDYXB0aXZlIFBvcnRhbCBNb2RlCmRpZmYgLS1naXQgYS9Ub29scy9U ZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25zL1Rlc3RXZWJLaXRBUEktaU9TLmVudGl0bGVtZW50 cyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ29uZmlndXJhdGlvbnMvVGVzdFdlYktpdEFQSS1pT1Mu ZW50aXRsZW1lbnRzCmluZGV4IDNmN2I3MjNmMzc5ZWY2YmU2NTliN2RlZTUzYzllYTg4ZTg3ZjI5 ZWYuLjZhYzQ1YzY4ZDQzMzQ0YmFmYjY4ZTM0ZjM0MDQwN2E4NDBjZDZmMjYgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ29uZmlndXJhdGlvbnMvVGVzdFdlYktpdEFQSS1pT1MuZW50 aXRsZW1lbnRzCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ29uZmlndXJhdGlvbnMvVGVzdFdl YktpdEFQSS1pT1MuZW50aXRsZW1lbnRzCkBAIC0xMCw3ICsxMCw1IEBACiAJPHRydWUvPgogCTxr ZXk+Y29tLmFwcGxlLlBhc3RlYm9hcmQucGFzdGUtdW5jaGVja2VkPC9rZXk+CiAJPHRydWUvPgot CTxrZXk+Y29tLmFwcGxlLmRldmVsb3Blci53ZWItYnJvd3Nlcjwva2V5PgotCTx0cnVlLz4KIDwv ZGljdD4KIDwvcGxpc3Q+CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdENvY29hL1Byb2Nlc3NTd2FwT25OYXZpZ2F0aW9uLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXRDb2NvYS9Qcm9jZXNzU3dhcE9uTmF2aWdhdGlvbi5tbQppbmRleCAxYzAz NzhjYmQ1MmM4NjA4ZGFkODBjODAzN2RmZGVkYmUyMDIwODM0Li5mNWIxZDFjYjVhMTg0OTZhNDE3 MWQ3N2NlNTBlZDYwOWJjMDgzNjQ2IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdENvY29hL1Byb2Nlc3NTd2FwT25OYXZpZ2F0aW9uLm1tCisrKyBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUHJvY2Vzc1N3YXBPbk5hdmlnYXRpb24ubW0K QEAgLTc2MjUsNiArNzYyNSwxMCBAQCBURVNUKFByb2Nlc3NTd2FwLCBOYXZpZ2F0aW5nQ3Jvc3NP cmlnaW5Gcm9tQ09PUFNhbWVPcmlnaW5BbGxvd1BvcHVwNCkKICAgICBydW5DT09QUHJvY2Vzc1N3 YXBUZXN0KCJzYW1lLW9yaWdpbi1hbGxvdy1wb3B1cCIsICJ1bnNhZmUtbm9uZSIsICJ1bnNhZmUt bm9uZSIsICJ1bnNhZmUtbm9uZSIsIElzU2FtZU9yaWdpbjo6Tm8sIERvU2VydmVyU2lkZVJlZGly ZWN0OjpObywgRXhwZWN0U3dhcDo6Tm8pOwogfQogCisvLyBPbiBpT1MsIHRvZ2dsaW5nIHRoZSBj YXB0aXZlIHBvcnRhbCBtb2RlIHJlcXVpcmVzIHRoZSBicm93c2VyIGVudGl0bGVtZW50LCB3aGlj aCBUZXN0V2ViS2l0IEFQSSBkb2Vzbid0IGhhdmUuCisvLyBBbHNvLCBzb21lIEFQSSB0ZXN0cyBy ZWx5IG9uIHRoZSBicm93c2VyIGVudGl0bGVtZW50IG5vdCBiZWluZyBwcmVzZW50LgorI2lmICFQ TEFURk9STShJT1MpCisKIHN0YXRpYyBib29sIGlzSklURW5hYmxlZChXS1dlYlZpZXcgKndlYlZp ZXcpCiB7CiAgICAgX19ibG9jayBib29sIGdvdFJlc3BvbnNlID0gZmFsc2U7CkBAIC03Nzk0LDMg Kzc3OTgsNSBAQCBURVNUKFByb2Nlc3NTd2FwLCBDYXB0aXZlUG9ydGFsTW9kZUVuYWJsZWRCeURl ZmF1bHRUaGVuT3B0T3V0KQogICAgIGNoZWNrU2V0dGluZ3NDb250cm9sbGVkQnlDYXB0aXZlUG9y dGFsTW9kZSh3ZWJWaWV3Mi5nZXQoKSwgU2hvdWxkQmVFbmFibGVkOjpZZXMpOwogICAgIEVYUEVD VF9FUShwaWQyLCBbd2ViVmlldzIgX3dlYlByb2Nlc3NJZGVudGlmaWVyXSk7CiB9CisKKyNlbmRp Zgo=